195274 2019-03-04 04:45:50 -0800 WebDriver: fix String not terminated with null caracter 2019-03-04 06:40:55 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 karl.leplat_ext webkit-unassigned bburg cgarcia commit-queue olivier.blin webkit-bug-importer zan oldest_to_newest 1512129 0 karl.leplat_ext 2019-03-04 04:45:50 -0800 WebDriver: fix String not terminated with null caracter This has been detected by an exception returned by the function evaluateJavaScriptFunction with the message : [native code]: JS ERROR SyntaxError: Unexpected keyword 'function'. Expected ')' to end a compound expression. Function has been initialized with a string that come from char array, not a null-terminated string. 1512132 1 363504 karl.leplat_ext 2019-03-04 05:22:04 -0800 Created attachment 363504 Patch 1512141 2 363504 commit-queue 2019-03-04 06:30:51 -0800 Comment on attachment 363504 Patch Clearing flags on attachment: 363504 Committed r242352: <https://trac.webkit.org/changeset/242352> 1512142 3 commit-queue 2019-03-04 06:30:53 -0800 All reviewed patches have been landed. Closing bug. 1512145 4 webkit-bug-importer 2019-03-04 06:40:55 -0800 <rdar://problem/48560927> 363504 2019-03-04 05:22:04 -0800 2019-03-04 06:30:51 -0800 Patch bug-195274-20190304142203.patch text/plain 6486 karl.leplat_ext U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IGEwM2I3NTQyYjZj YWI2YjZmYzY2MTg1Yzk1NmFmMTZkOWIwMzRkM2MuLjdhMjZiMmQxMjMyZmViMWU4NDAwMTNjZTZj ZDQ5OTc3ZGM4Mzc3OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMDMt MDQgIEthcmwgTGVwbGF0ICA8a2FybC5sZXBsYXRfZXh0QHNvZnRhdGhvbWUuY29tPgorCisgICAg ICAgIFdlYkRyaXZlcjogZml4IFN0cmluZyBub3QgdGVybWluYXRlZCB3aXRoIG51bGwgY2FyYWN0 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTI3 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg aGFzIGJlZW4gZGV0ZWN0ZWQgYnkgYW4gZXhjZXB0aW9uIHJldHVybmVkIGJ5IHRoZSBmdW5jdGlv bgorICAgICAgICBldmFsdWF0ZUphdmFTY3JpcHRGdW5jdGlvbiB3aXRoIHRoZSBtZXNzYWdlIDoK KyAgICAgICAgW25hdGl2ZSBjb2RlXTogSlMgRVJST1IgU3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQg a2V5d29yZCAnZnVuY3Rpb24nLiBFeHBlY3RlZCAnKScgdG8gZW5kIGEgY29tcG91bmQgZXhwcmVz c2lvbi4KKyAgICAgICAga2V5d29yZCAnZnVuY3Rpb24nIGhhcyBiZWVuIGluaXRpYWxpemVkIHdp dGggYSBzdHJpbmcgdGhhdCBjb21lIGZyb20gY2hhciBhcnJheSwgbm90IGEgbnVsbC10ZXJtaW5h dGVkIHN0cmluZy4KKworICAgICAgICAqIFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViRHJpdmVy OjpTZXNzaW9uOjpmdWxsc2NyZWVuV2luZG93KToKKyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lv bjo6ZmluZEVsZW1lbnRzKToKKyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lvbjo6aXNFbGVtZW50 U2VsZWN0ZWQpOgorICAgICAgICAoV2ViRHJpdmVyOjpTZXNzaW9uOjppc0VsZW1lbnREaXNwbGF5 ZWQpOgorICAgICAgICAoV2ViRHJpdmVyOjpTZXNzaW9uOjpnZXRFbGVtZW50QXR0cmlidXRlKToK KyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lvbjo6ZWxlbWVudENsZWFyKToKKwogMjAxOS0wMS0z MSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBzcGVjdWxhdGl2ZSBXUEUgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRy aXZlci9TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAKaW5kZXggMDcx MDcwZjA5NDE0MzBhZTg4ZGFkNjBmODg1ODA5OTUyNTBhMzExNS4uZGQ1MjI2N2MwNzg0MTIwMGIz MjkwN2ZkMjIxNjFhNjY0ZWQyYmE2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9TZXNz aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCkBAIC04MzksNyArODM5 LDcgQEAgdm9pZCBTZXNzaW9uOjpmdWxsc2NyZWVuV2luZG93KEZ1bmN0aW9uPHZvaWQgKENvbW1h bmRSZXN1bHQmJik+JiYgY29tcGxldGlvbkhhbmQKIAogICAgICAgICBSZWZQdHI8SlNPTjo6T2Jq ZWN0PiBwYXJhbWV0ZXJzID0gSlNPTjo6T2JqZWN0OjpjcmVhdGUoKTsKICAgICAgICAgcGFyYW1l dGVycy0+c2V0U3RyaW5nKCJicm93c2luZ0NvbnRleHRIYW5kbGUiX3MsIG1fdG9wbGV2ZWxCcm93 c2luZ0NvbnRleHQudmFsdWUoKSk7Ci0gICAgICAgIHBhcmFtZXRlcnMtPnNldFN0cmluZygiZnVu Y3Rpb24iX3MsIEVudGVyRnVsbHNjcmVlbkphdmFTY3JpcHQpOworICAgICAgICBwYXJhbWV0ZXJz LT5zZXRTdHJpbmcoImZ1bmN0aW9uIl9zLCBTdHJpbmcoRW50ZXJGdWxsc2NyZWVuSmF2YVNjcmlw dCwgc2l6ZW9mKEVudGVyRnVsbHNjcmVlbkphdmFTY3JpcHQpKSk7CiAgICAgICAgIHBhcmFtZXRl cnMtPnNldEFycmF5KCJhcmd1bWVudHMiX3MsIEpTT046OkFycmF5OjpjcmVhdGUoKSk7CiAgICAg ICAgIHBhcmFtZXRlcnMtPnNldEJvb2xlYW4oImV4cGVjdHNJbXBsaWNpdENhbGxiYWNrQXJndW1l bnQiX3MsIHRydWUpOwogICAgICAgICBtX2hvc3QtPnNlbmRDb21tYW5kVG9CYWNrZW5kKCJldmFs dWF0ZUphdmFTY3JpcHRGdW5jdGlvbiJfcywgV1RGTW92ZShwYXJhbWV0ZXJzKSwgW3RoaXMsIHBy b3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3Zl KGNvbXBsZXRpb25IYW5kbGVyKV0oU2Vzc2lvbkhvc3Q6OkNvbW1hbmRSZXNwb25zZSYmIHJlc3Bv bnNlKSBtdXRhYmxlIHsKQEAgLTEwMDIsNyArMTAwMiw3IEBAIHZvaWQgU2Vzc2lvbjo6ZmluZEVs ZW1lbnRzKGNvbnN0IFN0cmluZyYgc3RyYXRlZ3ksIGNvbnN0IFN0cmluZyYgc2VsZWN0b3IsIEZp bmRFCiAgICAgICAgIHBhcmFtZXRlcnMtPnNldFN0cmluZygiYnJvd3NpbmdDb250ZXh0SGFuZGxl Il9zLCBtX3RvcGxldmVsQnJvd3NpbmdDb250ZXh0LnZhbHVlKCkpOwogICAgICAgICBpZiAobV9j dXJyZW50QnJvd3NpbmdDb250ZXh0KQogICAgICAgICAgICAgcGFyYW1ldGVycy0+c2V0U3RyaW5n KCJmcmFtZUhhbmRsZSJfcywgbV9jdXJyZW50QnJvd3NpbmdDb250ZXh0LnZhbHVlKCkpOwotICAg ICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImZ1bmN0aW9uIl9zLCBGaW5kTm9kZXNKYXZhU2Ny aXB0KTsKKyAgICAgICAgcGFyYW1ldGVycy0+c2V0U3RyaW5nKCJmdW5jdGlvbiJfcywgU3RyaW5n KEZpbmROb2Rlc0phdmFTY3JpcHQsIHNpemVvZihGaW5kTm9kZXNKYXZhU2NyaXB0KSkpOwogICAg ICAgICBwYXJhbWV0ZXJzLT5zZXRBcnJheSgiYXJndW1lbnRzIl9zLCBXVEZNb3ZlKGFyZ3VtZW50 cykpOwogICAgICAgICBwYXJhbWV0ZXJzLT5zZXRCb29sZWFuKCJleHBlY3RzSW1wbGljaXRDYWxs YmFja0FyZ3VtZW50Il9zLCB0cnVlKTsKICAgICAgICAgLy8gSWYgdGhlcmUncyBhbiBpbXBsaWNp dCB3YWl0LCB1c2Ugb25lIHNlY29uZCBtb3JlIGFzIGNhbGxiYWNrIHRpbWVvdXQuCkBAIC0xMTE2 LDcgKzExMTYsNyBAQCB2b2lkIFNlc3Npb246OmlzRWxlbWVudFNlbGVjdGVkKGNvbnN0IFN0cmlu ZyYgZWxlbWVudElELCBGdW5jdGlvbjx2b2lkIChDb21tYW5kUgogICAgICAgICBwYXJhbWV0ZXJz LT5zZXRTdHJpbmcoImJyb3dzaW5nQ29udGV4dEhhbmRsZSJfcywgbV90b3BsZXZlbEJyb3dzaW5n Q29udGV4dC52YWx1ZSgpKTsKICAgICAgICAgaWYgKG1fY3VycmVudEJyb3dzaW5nQ29udGV4dCkK ICAgICAgICAgICAgIHBhcmFtZXRlcnMtPnNldFN0cmluZygiZnJhbWVIYW5kbGUiX3MsIG1fY3Vy cmVudEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKLSAgICAgICAgcGFyYW1ldGVycy0+c2V0U3Ry aW5nKCJmdW5jdGlvbiJfcywgRWxlbWVudEF0dHJpYnV0ZUphdmFTY3JpcHQpOworICAgICAgICBw YXJhbWV0ZXJzLT5zZXRTdHJpbmcoImZ1bmN0aW9uIl9zLCBTdHJpbmcoRWxlbWVudEF0dHJpYnV0 ZUphdmFTY3JpcHQsIHNpemVvZihFbGVtZW50QXR0cmlidXRlSmF2YVNjcmlwdCkpKTsKICAgICAg ICAgcGFyYW1ldGVycy0+c2V0QXJyYXkoImFyZ3VtZW50cyJfcywgV1RGTW92ZShhcmd1bWVudHMp KTsKICAgICAgICAgbV9ob3N0LT5zZW5kQ29tbWFuZFRvQmFja2VuZCgiZXZhbHVhdGVKYXZhU2Ny aXB0RnVuY3Rpb24iX3MsIFdURk1vdmUocGFyYW1ldGVycyksIFtwcm90ZWN0ZWRUaGlzID0gbWFr ZVJlZigqdGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxl cildKFNlc3Npb25Ib3N0OjpDb21tYW5kUmVzcG9uc2UmJiByZXNwb25zZSkgewogICAgICAgICAg ICAgaWYgKHJlc3BvbnNlLmlzRXJyb3IgfHwgIXJlc3BvbnNlLnJlc3BvbnNlT2JqZWN0KSB7CkBA IC0xMzE3LDcgKzEzMTcsNyBAQCB2b2lkIFNlc3Npb246OmlzRWxlbWVudERpc3BsYXllZChjb25z dCBTdHJpbmcmIGVsZW1lbnRJRCwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZAogICAgICAgICBwYXJh bWV0ZXJzLT5zZXRTdHJpbmcoImJyb3dzaW5nQ29udGV4dEhhbmRsZSJfcywgbV90b3BsZXZlbEJy b3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKICAgICAgICAgaWYgKG1fY3VycmVudEJyb3dzaW5nQ29u dGV4dCkKICAgICAgICAgICAgIHBhcmFtZXRlcnMtPnNldFN0cmluZygiZnJhbWVIYW5kbGUiX3Ms IG1fY3VycmVudEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKLSAgICAgICAgcGFyYW1ldGVycy0+ c2V0U3RyaW5nKCJmdW5jdGlvbiJfcywgRWxlbWVudERpc3BsYXllZEphdmFTY3JpcHQpOworICAg ICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImZ1bmN0aW9uIl9zLCBTdHJpbmcoRWxlbWVudERp c3BsYXllZEphdmFTY3JpcHQsIHNpemVvZihFbGVtZW50RGlzcGxheWVkSmF2YVNjcmlwdCkpKTsK ICAgICAgICAgcGFyYW1ldGVycy0+c2V0QXJyYXkoImFyZ3VtZW50cyJfcywgV1RGTW92ZShhcmd1 bWVudHMpKTsKICAgICAgICAgbV9ob3N0LT5zZW5kQ29tbWFuZFRvQmFja2VuZCgiZXZhbHVhdGVK YXZhU2NyaXB0RnVuY3Rpb24iX3MsIFdURk1vdmUocGFyYW1ldGVycyksIFtwcm90ZWN0ZWRUaGlz ID0gbWFrZVJlZigqdGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlcildKFNlc3Npb25Ib3N0OjpDb21tYW5kUmVzcG9uc2UmJiByZXNwb25zZSkgewogICAg ICAgICAgICAgaWYgKHJlc3BvbnNlLmlzRXJyb3IgfHwgIXJlc3BvbnNlLnJlc3BvbnNlT2JqZWN0 KSB7CkBAIC0xMzU5LDcgKzEzNTksNyBAQCB2b2lkIFNlc3Npb246OmdldEVsZW1lbnRBdHRyaWJ1 dGUoY29uc3QgU3RyaW5nJiBlbGVtZW50SUQsIGNvbnN0IFN0cmluZyYgYXR0cmlidQogICAgICAg ICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImJyb3dzaW5nQ29udGV4dEhhbmRsZSJfcywgbV90b3Bs ZXZlbEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKICAgICAgICAgaWYgKG1fY3VycmVudEJyb3dz aW5nQ29udGV4dCkKICAgICAgICAgICAgIHBhcmFtZXRlcnMtPnNldFN0cmluZygiZnJhbWVIYW5k bGUiX3MsIG1fY3VycmVudEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKLSAgICAgICAgcGFyYW1l dGVycy0+c2V0U3RyaW5nKCJmdW5jdGlvbiJfcywgRWxlbWVudEF0dHJpYnV0ZUphdmFTY3JpcHQp OworICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImZ1bmN0aW9uIl9zLCBTdHJpbmcoRWxl bWVudEF0dHJpYnV0ZUphdmFTY3JpcHQsIHNpemVvZihFbGVtZW50QXR0cmlidXRlSmF2YVNjcmlw dCkpKTsKICAgICAgICAgcGFyYW1ldGVycy0+c2V0QXJyYXkoImFyZ3VtZW50cyJfcywgV1RGTW92 ZShhcmd1bWVudHMpKTsKICAgICAgICAgbV9ob3N0LT5zZW5kQ29tbWFuZFRvQmFja2VuZCgiZXZh bHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24iX3MsIFdURk1vdmUocGFyYW1ldGVycyksIFtwcm90ZWN0 ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21w bGV0aW9uSGFuZGxlcildKFNlc3Npb25Ib3N0OjpDb21tYW5kUmVzcG9uc2UmJiByZXNwb25zZSkg ewogICAgICAgICAgICAgaWYgKHJlc3BvbnNlLmlzRXJyb3IgfHwgIXJlc3BvbnNlLnJlc3BvbnNl T2JqZWN0KSB7CkBAIC0xNTg1LDcgKzE1ODUsNyBAQCB2b2lkIFNlc3Npb246OmVsZW1lbnRDbGVh cihjb25zdCBTdHJpbmcmIGVsZW1lbnRJRCwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFJlc3VsdAog ICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImJyb3dzaW5nQ29udGV4dEhhbmRsZSJfcywg bV90b3BsZXZlbEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKICAgICAgICAgaWYgKG1fY3VycmVu dEJyb3dzaW5nQ29udGV4dCkKICAgICAgICAgICAgIHBhcmFtZXRlcnMtPnNldFN0cmluZygiZnJh bWVIYW5kbGUiX3MsIG1fY3VycmVudEJyb3dzaW5nQ29udGV4dC52YWx1ZSgpKTsKLSAgICAgICAg cGFyYW1ldGVycy0+c2V0U3RyaW5nKCJmdW5jdGlvbiJfcywgRm9ybUVsZW1lbnRDbGVhckphdmFT Y3JpcHQpOworICAgICAgICBwYXJhbWV0ZXJzLT5zZXRTdHJpbmcoImZ1bmN0aW9uIl9zLCBTdHJp bmcoRm9ybUVsZW1lbnRDbGVhckphdmFTY3JpcHQsIHNpemVvZihGb3JtRWxlbWVudENsZWFySmF2 YVNjcmlwdCkpKTsKICAgICAgICAgcGFyYW1ldGVycy0+c2V0QXJyYXkoImFyZ3VtZW50cyJfcywg V1RGTW92ZShhcmd1bWVudHMpKTsKICAgICAgICAgbV9ob3N0LT5zZW5kQ29tbWFuZFRvQmFja2Vu ZCgiZXZhbHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24iX3MsIFdURk1vdmUocGFyYW1ldGVycyksIFtw cm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92 ZShjb21wbGV0aW9uSGFuZGxlcildKFNlc3Npb25Ib3N0OjpDb21tYW5kUmVzcG9uc2UmJiByZXNw b25zZSkgewogICAgICAgICAgICAgaWYgKHJlc3BvbnNlLmlzRXJyb3IpIHsK