19527 2008-06-12 16:50:54 -0700 ASSERTION FAILED: containerA && containerB 2009-02-26 10:18:04 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 danceoffwithyourpantsoff ap ap oldest_to_newest 83137 0 danceoffwithyourpantsoff 2008-06-12 16:50:54 -0700 ASSERTION FAILED: containerA && containerB WebCore::Range::compareBoundaryPoints It looks like comparePoint specifically deals with the possibility that a range is detached and it's m_start.container is null. However, compareBoundaryPoints asserts that both are non-null, but returns different (-1 vs 1) if one of them is NULL. Maybe the ASSERT is just invalid? var ra = document.createRange(); ra.detach(); ra.comparePoint(document.createElement('b')); 83153 1 21671 ap 2008-06-12 21:52:10 -0700 Created attachment 21671 test case (will assert) 83154 2 ap 2008-06-12 21:53:11 -0700 Confirmed with r34513. 109862 3 27700 ap 2009-02-16 10:58:22 -0800 Created attachment 27700 proposed fix I think that the ASSERT is correct - it's the release-only code below it that's probably unneeded, but was added for extra safety. 111206 4 27700 darin 2009-02-26 09:46:04 -0800 Comment on attachment 27700 proposed fix Does this behavior match something in some specification, or is this a gray area? r=me 111210 5 ap 2009-02-26 10:02:00 -0800 These methods are Firefox extensions, without much documentation. 111212 6 ap 2009-02-26 10:18:04 -0800 Committed revision 41253. 21671 2008-06-12 21:52:10 -0700 2008-06-12 21:52:10 -0700 test case (will assert) 19527.html text/html 110 ap PHNjcmlwdD4KdmFyIHJhID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKcmEuZGV0YWNoKCk7CnJh LmNvbXBhcmVQb2ludChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdiJykpOwo8L3NjcmlwdD4= 27700 2009-02-16 10:58:22 -0800 2009-02-26 09:46:04 -0800 proposed fix ComparePoints.txt text/plain 7501 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTAxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDItMTYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUyNworICAgICAgICBB U1NFUlRJT04gRkFJTEVEOiBjb250YWluZXJBICYmIGNvbnRhaW5lckIKKworICAgICAgICBUZXN0 OiBmYXN0L2RvbS9SYW5nZS9idWctMTk1MjcuaHRtbAorCisgICAgICAgICogZG9tL1JhbmdlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJhbmdlOjppc1BvaW50SW5SYW5nZSk6CisgICAgICAgIChX ZWJDb3JlOjpSYW5nZTo6Y29tcGFyZVBvaW50KToKKyAgICAgICAgQnJpbmcgdGhlIGJlaGF2aW9y IGluIGxpbmUgd2l0aCBjdXJyZW50IEZpcmVmb3gsIG1ha2luZyBpdCBpbXBvc3NpYmxlIGZvciB0 aGVzZSBtZXRob2RzCisgICAgICAgIHRvIHBhc3MgYSBudWxsIGNvbnRhaW5lciB0byBjb21wYXJl Qm91bmRhcnlQb2ludHMoKS4KKwogMjAwOS0wMi0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgZHVwbGljYXRlIGNhcmV0V2lkdGggY29uc3RhbnRz IHRvIFJlbmRlck9iamVjdC5oCkluZGV4OiBXZWJDb3JlL2RvbS9SYW5nZS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9kb20vUmFuZ2UuY3BwCShyZXZpc2lvbiA0MTAxOCkKKysrIFdlYkNvcmUv ZG9tL1JhbmdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY0LDE3ICsyNjQsMTcgQEAgdm9pZCBS YW5nZTo6Y29sbGFwc2UoYm9vbCB0b1N0YXJ0LCBFeGNlcAogCiBib29sIFJhbmdlOjppc1BvaW50 SW5SYW5nZShOb2RlKiByZWZOb2RlLCBpbnQgb2Zmc2V0LCBFeGNlcHRpb25Db2RlJiBlYykKIHsK LSAgICBpZiAoIXJlZk5vZGUpIHsKLSAgICAgICAgZWMgPSBOT1RfRk9VTkRfRVJSOworICAgIGlm ICghbV9zdGFydC5jb250YWluZXIoKSkgeworICAgICAgICBlYyA9IElOVkFMSURfU1RBVEVfRVJS OwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgaWYgKCFtX3N0YXJ0LmNvbnRh aW5lcigpICYmIHJlZk5vZGUtPmF0dGFjaGVkKCkpIHsKLSAgICAgICAgZWMgPSBJTlZBTElEX1NU QVRFX0VSUjsKKyAgICBpZiAoIXJlZk5vZGUpIHsKKyAgICAgICAgZWMgPSBISUVSQVJDSFlfUkVR VUVTVF9FUlI7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAgICBpZiAobV9zdGFy dC5jb250YWluZXIoKSAmJiAhcmVmTm9kZS0+YXR0YWNoZWQoKSkgeworICAgIGlmICghcmVmTm9k ZS0+YXR0YWNoZWQoKSkgewogICAgICAgICAvLyBGaXJlZm94IGRvZXNuJ3QgdGhyb3cgYW4gZXhj ZXB0aW9uIGZvciB0aGlzIGNhc2U7IGl0IHJldHVybnMgZmFsc2UuCiAgICAgICAgIHJldHVybiBm YWxzZTsKICAgICB9CkBAIC0yOTksMjIgKzI5OSwxNyBAQCBzaG9ydCBSYW5nZTo6Y29tcGFyZVBv aW50KE5vZGUqIHJlZk5vZGUsCiAgICAgLy8gVGhpcyBtZXRob2QgcmV0dXJucyAtMSwgMCBvciAx IGRlcGVuZGluZyBvbiBpZiB0aGUgcG9pbnQgZGVzY3JpYmVkIGJ5IHRoZSAKICAgICAvLyByZWZO b2RlIG5vZGUgYW5kIGFuIG9mZnNldCB3aXRoaW4gdGhlIG5vZGUgaXMgYmVmb3JlLCBzYW1lIGFz LCBvciBhZnRlciB0aGUgcmFuZ2UgcmVzcGVjdGl2ZWx5LgogCi0gICAgaWYgKCFyZWZOb2RlKSB7 Ci0gICAgICAgIGVjID0gTk9UX0ZPVU5EX0VSUjsKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQot Ci0gICAgaWYgKCFtX3N0YXJ0LmNvbnRhaW5lcigpICYmIHJlZk5vZGUtPmF0dGFjaGVkKCkpIHsK KyAgICBpZiAoIW1fc3RhcnQuY29udGFpbmVyKCkpIHsKICAgICAgICAgZWMgPSBJTlZBTElEX1NU QVRFX0VSUjsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCi0gICAgaWYgKG1fc3RhcnQuY29u dGFpbmVyKCkgJiYgIXJlZk5vZGUtPmF0dGFjaGVkKCkpIHsKLSAgICAgICAgLy8gRmlyZWZveCBk b2Vzbid0IHRocm93IGFuIGV4Y2VwdGlvbiBmb3IgdGhpcyBjYXNlOyBpdCByZXR1cm5zIC0xLgot ICAgICAgICByZXR1cm4gLTE7CisgICAgaWYgKCFyZWZOb2RlKSB7CisgICAgICAgIGVjID0gSElF UkFSQ0hZX1JFUVVFU1RfRVJSOworICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgICBpZiAo cmVmTm9kZS0+ZG9jdW1lbnQoKSAhPSBtX293bmVyRG9jdW1lbnQpIHsKKyAgICBpZiAoIXJlZk5v ZGUtPmF0dGFjaGVkKCkgfHwgcmVmTm9kZS0+ZG9jdW1lbnQoKSAhPSBtX293bmVyRG9jdW1lbnQp IHsKICAgICAgICAgZWMgPSBXUk9OR19ET0NVTUVOVF9FUlI7CiAgICAgICAgIHJldHVybiAwOwog ICAgIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQxMDE5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDItMTYgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTUyNworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBjb250YWluZXJBICYmIGNvbnRhaW5l ckIKKworICAgICAgICAqIGZhc3QvZG9tL1JhbmdlL3JhbmdlLWNvbXBhcmVQb2ludC5odG1sOiBV cGRhdGVkIHRoZSB0ZXN0IGZvciBjdXJyZW50IEZpcmVmb3ggYmVoYXZpb3IKKyAgICAgICAgKGFz IG9mIDMuMSBhbmQgMy4yYTFwcmUpLgorCisgICAgICAgICogZmFzdC9kb20vUmFuZ2UvYnVnLTE5 NTI3LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vUmFuZ2UvYnVnLTE5 NTI3Lmh0bWw6IEFkZGVkLgorICAgICAgICBUZXN0IGEgbnVtYmVyIG9mIGFkZGl0aW9uYWwgZWRn ZSBjYXNlcy4KKwogMjAwOS0wMi0xMyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2RvbS9SYW5nZS9idWctMTk1MjctZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL2J1Zy0xOTUyNy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9SYW5nZS9idWctMTk1MjctZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1Rlc3QgUmFuZ2UuY29tcGFyZVBvaW50IGFuZCBS YW5nZS5pc1BvaW50SW5SYW5nZSBGaXJlZm94IGV4dGVuc2lvbnMuCisKK1BBU1MKClByb3BlcnR5 IGNoYW5nZXMgb246IExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL2J1Zy0xOTUyNy1leHBlY3Rl ZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFpbgpOYW1l OiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20v UmFuZ2UvYnVnLTE5NTI3Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20v UmFuZ2UvYnVnLTE5NTI3Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9SYW5nZS9idWctMTk1MjcuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2MSBAQAorPGJv ZHk+Cis8cD5UZXN0IFJhbmdlLmNvbXBhcmVQb2ludCBhbmQgUmFuZ2UuaXNQb2ludEluUmFuZ2Ug RmlyZWZveCBleHRlbnNpb25zLjwvcD4KKzxkaXYgaWQ9bG9nPjwvZGl2PgorPHNjcmlwdD4KK2lm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEFzVGV4dCgpOworCit2YXIgaGFkRXJyb3IgPSBmYWxzZTsKK2Z1bmN0aW9uIGxvZ0Vycm9y KG1lc3NhZ2UpCit7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZyIpLmlubmVySFRN TCArPSBtZXNzYWdlICsgIjxicj4iOworICAgIGhhZEVycm9yID0gdHJ1ZTsKK30KKworZnVuY3Rp b24gc2hvdWxkVGhyb3coZXhwciwgZXhjZXB0aW9uTmFtZSkKK3sKKyAgICB0cnkgeworICAgICAg ICBldmFsKGV4cHIpOworICAgICAgICBsb2dFcnJvcignPGNvZGU+JyArIGV4cHIgKyAnPC9jb2Rl PiBkaWRuXCd0IHJhaXNlIGFuIGV4Y2VwdGlvbicpOworICAgIH0gY2F0Y2ggKGV4KSB7CisgICAg ICAgIGlmIChleC5jb2RlICE9IGV4W2V4Y2VwdGlvbk5hbWVdKQorICAgICAgICAgICAgbG9nRXJy b3IoJzxjb2RlPicgKyBleHByICsnPC9jb2RlPiByYWlzZWQgYSB3cm9uZyBleGNlcHRpb246ICcg KyBleC5jb2RlICsgJyB2cy4gJyArIGV4W2V4Y2VwdGlvbk5hbWVdICsgJyAoJyArIGV4Y2VwdGlv bk5hbWUgKyAnKScpOworICAgIH0KK30KKworZnVuY3Rpb24gc2hvdWxkQmUoZXhwciwgZXhwZWN0 ZWQpCit7CisgICAgdHJ5IHsKKyAgICAgICAgdmFyIGFjdHVhbCA9IGV2YWwoZXhwcik7CisgICAg ICAgIGlmIChhY3R1YWwgIT0gZXhwZWN0ZWQpCisgICAgICAgICAgICBsb2dFcnJvcignPGNvZGU+ JyArIGV4cHIgKyAnPC9jb2RlPjogYWN0dWFsICcgKyBhY3R1YWwgKyAiLCBleHBlY3RlZCAiICsg ZXhwZWN0ZWQpOworICAgIH0gY2F0Y2ggKGV4KSB7CisgICAgICAgIGxvZ0Vycm9yKCc8Y29kZT4n ICsgZXhwciArJzwvY29kZT4gcmFpc2VkIGFuIGV4Y2VwdGlvbjogJyArIGV4KTsKKyAgICB9Cit9 CisKK3ZhciByYSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdlKCk7CityYS5zZWxlY3ROb2RlKGRvY3Vt ZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJwIilbMF0pOworCitzaG91bGRUaHJvdygicmEuY29t cGFyZVBvaW50KGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2InKSwgMCkiLCAiV1JPTkdfRE9DVU1F TlRfRVJSIik7CitzaG91bGRUaHJvdygicmEuY29tcGFyZVBvaW50KG51bGwsIDApIiwgIkhJRVJB UkNIWV9SRVFVRVNUX0VSUiIpOworc2hvdWxkQmUoInJhLmNvbXBhcmVQb2ludChkb2N1bWVudC5i b2R5LCAwKSIsIC0xKTsKK3Nob3VsZEJlKCJyYS5jb21wYXJlUG9pbnQoZG9jdW1lbnQuZG9jdW1l bnRFbGVtZW50LCAwKSIsIC0xKTsKK3Nob3VsZEJlKCJyYS5pc1BvaW50SW5SYW5nZShkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCdiJyksIDApIiwgZmFsc2UpOworc2hvdWxkQmUoInJhLmlzUG9pbnRJ blJhbmdlKGRvY3VtZW50LmRvY3VtZW50RWxlbWVudCwgMCkiLCBmYWxzZSk7CitzaG91bGRCZSgi cmEuaXNQb2ludEluUmFuZ2UoZG9jdW1lbnQuYm9keSwgMCkiLCBmYWxzZSk7CitzaG91bGRUaHJv dygicmEuaXNQb2ludEluUmFuZ2UobnVsbCwgMCkiLCAiSElFUkFSQ0hZX1JFUVVFU1RfRVJSIik7 CisKK3JhLmRldGFjaCgpOworCitzaG91bGRUaHJvdygicmEuY29tcGFyZVBvaW50KGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ2InKSwgMCkiLCAiSU5WQUxJRF9TVEFURV9FUlIiKTsKK3Nob3VsZFRo cm93KCJyYS5jb21wYXJlUG9pbnQoZG9jdW1lbnQuYm9keSwgMCkiLCAiSU5WQUxJRF9TVEFURV9F UlIiKTsKK3Nob3VsZFRocm93KCJyYS5jb21wYXJlUG9pbnQobnVsbCwgMCkiLCAiSU5WQUxJRF9T VEFURV9FUlIiKTsKK3Nob3VsZFRocm93KCJyYS5pc1BvaW50SW5SYW5nZShkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdiJyksIDApIiwgIklOVkFMSURfU1RBVEVfRVJSIik7CitzaG91bGRUaHJvdygi cmEuaXNQb2ludEluUmFuZ2UoZG9jdW1lbnQuYm9keSwgMCkiLCAiSU5WQUxJRF9TVEFURV9FUlIi KTsKK3Nob3VsZFRocm93KCJyYS5pc1BvaW50SW5SYW5nZShudWxsLCAwKSIsICJJTlZBTElEX1NU QVRFX0VSUiIpOworCitpZiAoIWhhZEVycm9yKQorICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJsb2ciKS5pbm5lckhUTUwgPSAiUEFTUyI7CisKKzwvc2NyaXB0PgoKUHJvcGVydHkgY2hhbmdl cyBvbjogTGF5b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2UvYnVnLTE5NTI3Lmh0bWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9odG1sCgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9kb20vUmFuZ2UvcmFuZ2UtY29tcGFyZVBvaW50Lmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2UvcmFuZ2UtY29tcGFyZVBvaW50Lmh0bWwJKHJldmlzaW9u IDQxMDE4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2UvcmFuZ2UtY29tcGFyZVBvaW50 Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTcxLDE0ICs3MSwxNSBAQCBmdW5jdGlvbiB0ZXN0KCkg CiAgICAgfQogICAgICAgICAKICAgICAvLyB0ZXN0IDEwIC0gYXR0YWNoZWQgcmFuZ2UsIGRldGFj aGVkIG5vZGUKLSAgICAvLyBmaXJlZm94IGRvZXMgbm90IHRocm93IGFuIGV4Y2VwdGlvbiBhbmQg cmV0dXJucyAtMSBmb3IgdGhpcyB0ZXN0Ci0gICAgZXhwZWN0ZWRSZXN1bHQgPSAtMTsKKyAgICAv LyBmaXJlZm94IHRocm93cyBhbiBleGNlcHRpb24KICAgICByYW5nZS5zZWxlY3ROb2RlKGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJhMSIpKTsKICAgICB2YXIgbm9kZSA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJiMSIpOwogICAgIG5vZGUucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChub2RlKTsK LSAgICByZXN1bHQgPSByYW5nZS5jb21wYXJlUG9pbnQobm9kZSwgMCk7Ci0gICAgaWYgKHJlc3Vs dCA9PSBleHBlY3RlZFJlc3VsdCkKKyAgICB0cnkgeworICAgICAgICByYW5nZS5jb21wYXJlUG9p bnQobm9kZSwgMCk7CisgICAgfSBjYXRjaCAoZSkgewogICAgICAgICBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgidGVzdDEwIikuaW5uZXJIVE1MID0gInRlc3QgMTAgcGFzc2VkIjsgCisgICAgfQog ICAgICAgICAKICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cg==