195251 2019-03-02 15:54:55 -0800 [GTK] No rule to make target 'JavaScriptCore-4.0.gir' 2020-02-15 07:15:51 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified NEW P2 Normal --- 1 berto webkit-unassigned bugs-noreply cedric.bellegarde don.olmstead dpa-webkit ht990332 mcatanzaro oldest_to_newest 1511870 0 berto 2019-03-02 15:54:55 -0800 This error happens if you try to build WebKitGTK with make -j1 (I'm using plain cmake, without ninja): make -f Source/WebKit/CMakeFiles/WebKit2WebExtension-4-gir.dir/build.make Source/WebKit/CMakeFiles/WebKit2WebExtension-4-gir.dir/build make[3]: Entering directory '/tmp/webkit2gtk-2.22.7/obj-x86_64-linux-gnu' make[3]: *** No rule to make target 'JavaScriptCore-4.0.gir', needed by 'WebKit2-4.0.gir'. Stop. make[3]: Leaving directory '/tmp/webkit2gtk-2.22.7/obj-x86_64-linux-gnu' make[2]: *** [CMakeFiles/Makefile2:1605: Source/WebKit/CMakeFiles/WebKit2WebExtension-4-gir.dir/all] Error 2 make[2]: Leaving directory '/tmp/webkit2gtk-2.22.7/obj-x86_64-linux-gnu' make[1]: *** [CMakeFiles/Makefile2:203: Source/CMakeFiles/gir.dir/rule] Error 2 make[1]: Leaving directory '/tmp/webkit2gtk-2.22.7/obj-x86_64-linux-gnu' make: *** [Makefile:215: gir] Error 2 There's indeed to no rule to generate JavaScriptCore-4.0.gir directly, but you can do 'make JavaScriptCore-4-gir', so I guess there's a wrong/missing rule on the CMake files? 1511879 1 363436 berto 2019-03-02 16:28:18 -0800 Created attachment 363436 Patch 1511880 2 363436 berto 2019-03-02 16:33:07 -0800 Comment on attachment 363436 Patch Sorry for the noise, this patch doesn't fix the build 1513962 3 berto 2019-03-08 03:04:28 -0800 This is maybe pure chance, but this reportedly doesn't happen when using cmake with ninja (although the failure with make was reproduced with 2.22.7 and the success with ninja with 2.23.92, so it can also be due to changes in the cmake files themselves). 1542337 4 dpa-webkit 2019-06-06 02:50:02 -0700 The workaround is to go in $(top_builddir)/Source/JavaScriptCore and type `make`. Then go back to $(top_builddir) and type there `make` to complete the build. This was a problem also with 2.24.1. I use cmake 3.13.2. Ninja might get it rigth, if the total order is by chance different. It looks to me that JavaScriptCore-4.0.gir is a side-product of building something different, e.g. JavaScriptCore, but it cannot be build on its own as target. I do not understand cmake to help with patches. Note, that JavaScriptCore-4.0 JavaScriptCore-4.0 and WebKit2WebExtension-4.0 gir and typelib are in $(top_builddir) and not in subdirectories. 1542339 5 berto 2019-06-06 03:01:04 -0700 (In reply to Дилян Палаузов from comment #4) > It looks to me that JavaScriptCore-4.0.gir is a side-product of > building something different That is correct, and that's why everything works most of the time. > e.g. JavaScriptCore, but it cannot be build on its own as target. There is the JavaScriptCore-4-gir target which creates that file, but I think there's a dependency missing (or with the wrong name) somewhere. With the patch on comment #1 I tried a quick fix by giving the target the same name as the file, but that did not fix the build. I haven't investigated it properly in order to find the exact solution and my knowledge of CMake is very basic. 1542400 6 mcatanzaro 2019-06-06 07:32:01 -0700 There's no spelling error. Source/JavaScriptCore/PlatformGTK.cmake creates ${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir and Source/WebKit/PlatformGTK.cmake depends on ${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir, which is identical. LGTM. 1542403 7 dpa-webkit 2019-06-06 07:43:20 -0700 Afrer `rm $(top_builddir)/JavaScriptCore-4.0.gir`, `make -C $(top_builddir)/JavaScriptCore-4.0.gir` fails with “make: *** No rule to make target 'JavaScriptCore-4.0.gir'. Stop.” 1542510 8 dpa-webkit 2019-06-06 12:03:42 -0700 `make JavaScriptCore-4-gir` does generate JavaScriptCore-4.0.gir. 1619414 9 cedric.bellegarde 2020-02-15 07:15:51 -0800 Happening here with last WebKitGTK release in a LXC container. 363436 2019-03-02 16:28:18 -0800 2019-03-02 16:33:07 -0800 Patch 195251.diff text/plain 1482 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmZWFlOTYxMWFkZC4uZWFk ZGZmNDZjMjIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxOS0wMy0wMiAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgJ0phdmFTY3JpcHRDb3JlLTQu MC5naXInCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTUyNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV c2UgdGhlIGV4YWN0IG5hbWUgb2YgdGhlIHRhcmdldCBmaWxlIGZvciB0aGUgYnVpbGQgcnVsZXMu CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwogMjAxOS0wMy0w MSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5D YWlyb10gRW5hYmxlIHNlcnZpY2Ugd29ya2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGZhNzNj ZWE3ZTRjLi5jYmZkYzc5MTgyZCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsu Y21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKQEAgLTQ0Myw5ICs0NDMs MTAgQEAgc2V0KFNIT1VMRF9JTlNUQUxMX0pTX1NIRUxMIE9OKQogIyBleHBvc2UgYSAnZ2lyJyB0 YXJnZXQgd2l0aCBhbGwgZ29iamVjdC1pbnRyb3NwZWN0aW9uIGZpbGVzLgogbWFjcm8oQUREX1RZ UEVMSUIgdHlwZWxpYikKICAgICBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCi0gICAgICAgIGdl dF9maWxlbmFtZV9jb21wb25lbnQodGFyZ2V0X25hbWUgJHt0eXBlbGlifSBOQU1FX1dFKQotICAg ICAgICBhZGRfY3VzdG9tX3RhcmdldCgke3RhcmdldF9uYW1lfS1naXIgQUxMIERFUEVORFMgJHt0 eXBlbGlifSkKLSAgICAgICAgbGlzdChBUFBFTkQgR09iamVjdEludHJvc3BlY3Rpb25UYXJnZXRz ICR7dGFyZ2V0X25hbWV9LWdpcikKKyAgICAgICAgZ2V0X2ZpbGVuYW1lX2NvbXBvbmVudChmaWxl X25hbWUgJHt0eXBlbGlifSBOQU1FKQorICAgICAgICBzdHJpbmcoUkVHRVggUkVQTEFDRSAiXFwu dHlwZWxpYiIgIi5naXIiIHRhcmdldF9uYW1lICR7ZmlsZV9uYW1lfSkKKyAgICAgICAgYWRkX2N1 c3RvbV90YXJnZXQoJHt0YXJnZXRfbmFtZX0gQUxMIERFUEVORFMgJHt0eXBlbGlifSkKKyAgICAg ICAgbGlzdChBUFBFTkQgR09iamVjdEludHJvc3BlY3Rpb25UYXJnZXRzICR7dGFyZ2V0X25hbWV9 KQogICAgICAgICBzZXQoR09iamVjdEludHJvc3BlY3Rpb25UYXJnZXRzICR7R09iamVjdEludHJv c3BlY3Rpb25UYXJnZXRzfSBQQVJFTlRfU0NPUEUpCiAgICAgZW5kaWYgKCkKIGVuZG1hY3JvKCkK