195243 2019-03-02 08:17:31 -0800 Improve some comments 2021-07-06 09:55:34 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 darin darin cehec76493 commit-queue dbates mositoc884 webkit-bug-importer xogahi8850 oldest_to_newest 1511805 0 darin 2019-03-02 08:17:31 -0800 Improve some comments 1511806 1 363421 darin 2019-03-02 08:19:10 -0800 Created attachment 363421 Patch 1511818 2 363421 commit-queue 2019-03-02 09:33:26 -0800 Comment on attachment 363421 Patch Clearing flags on attachment: 363421 Committed r242311: <https://trac.webkit.org/changeset/242311> 1511819 3 commit-queue 2019-03-02 09:33:27 -0800 All reviewed patches have been landed. Closing bug. 1511821 4 webkit-bug-importer 2019-03-02 09:40:46 -0800 <rdar://problem/48536996> 363421 2019-03-02 08:19:10 -0800 2019-03-02 09:33:26 -0800 Patch bug-195243-20190302081909.patch text/plain 5688 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRjMTRjYjVmNTczOWQ1 YjkyOWZmMjRiMDYwNjgxNjRjNWI2ODNkNy4uNjY0OGQ5N2FlZGE2YTkxOTgxNTJkMTJhNjIzYTJm ODFlMjk4MDIxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAzLTAyICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBJbXByb3ZlIHNvbWUgY29tbWVu dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTI0 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW06CisgICAg ICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIF9hZGRBY2Nlc3NpYmlsaXR5T2Jq ZWN0OnRvVGV4dE1hcmtlckFycmF5Ol0pOgorICAgICAgICBGaXggYSB0eXBvIGluIGEgY29tbWVu dC4KKworICAgICAgICAqIGRvbS9SYWRpb0J1dHRvbkdyb3Vwcy5jcHA6IEZpeCBhIHR5cG8gaW4g YSBjb21tZW50LgorICAgICAgICAoV2ViQ29yZTo6UmFkaW9CdXR0b25Hcm91cHM6OmNoZWNrZWRC dXR0b25Gb3JHcm91cCBjb25zdCk6IFVzZSBudWxscHRyIGluc3RlYWQgb2YgMC4KKworICAgICAg ICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5w dXRFbGVtZW50Ojp+SFRNTElucHV0RWxlbWVudCk6IEltcHJvdmVkIGEgY29tbWVudCwgYnV0IHNh ZGx5IG1hZGUKKyAgICAgICAgaXQgYSBiaXQgbG9uZ2VyLiBVc2UgbnVsbHB0ciBpbnN0ZWFkIG9m IDAuCisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpkaWRNb3ZlVG9OZXdEb2N1 bWVudCk6IEFkZGVkIGEgY29tbWVudC4KKwogMjAxOS0wMy0wMSAgRGFyaW4gQWRsZXIgIDxkYXJp bkBhcHBsZS5jb20+CiAKICAgICAgICAgRmluaXNoIHJlbW92aW5nIFN0cmluZzo6Zm9ybWF0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmls aXR5T2JqZWN0V3JhcHBlcklPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9z L1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCmluZGV4IDIyMDlmZjc2ZjcyYTI4 NGMyMjMzNjgxMGRjMmFhM2Y0OTMwNDk3M2UuLjEyMDMxY2RlM2Y4ODEyZjgyZmY4OTA5MmEyZGEx ZDJiMjJjYTc5NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9z L1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCkBA IC0yMDc2LDcgKzIwNzYsNyBAQCAtIChCT09MKV9hZGRBY2Nlc3NpYmlsaXR5T2JqZWN0OihBY2Nl c3NpYmlsaXR5T2JqZWN0KilheE9iamVjdCB0b1RleHRNYXJrZXJBcnJheQogICAgIGlmIChbYXJy YXkgY29udGFpbnNPYmplY3Q6d3JhcHBlcl0pCiAgICAgICAgIHJldHVybiBZRVM7CiAgICAgCi0g ICAgLy8gRXhwbGljaXR5IHNldCB0aGF0IHRoaXMgaXMgbm93IGFuIGVsZW1lbnQgKGluIGNhc2Ug b3RoZXIgbG9naWMgdHJpZXMgdG8gb3ZlcnJpZGUpLgorICAgIC8vIEV4cGxpY2l0bHkgc2V0IHRo YXQgdGhpcyBpcyBub3cgYW4gZWxlbWVudCAoaW4gY2FzZSBvdGhlciBsb2dpYyB0cmllcyB0byBv dmVycmlkZSkuCiAgICAgW3dyYXBwZXIgc2V0VmFsdWU6QFlFUyBmb3JLZXk6QCJpc0FjY2Vzc2li aWxpdHlFbGVtZW50Il07ICAgIAogICAgIFthcnJheSBhZGRPYmplY3Q6d3JhcHBlcl07CiAgICAg cmV0dXJuIFlFUzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9SYWRpb0J1dHRvbkdy b3Vwcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vUmFkaW9CdXR0b25Hcm91cHMuY3BwCmluZGV4 IDY3OWViZTI2ZTU2MzBkZmI1MTg4NjY4NTY0OGI2NzRjN2Q5YzNiNDUuLjJmMzA1ZWY2ODFkMjBi NDhkYTU3MTViZWIyODVlMjI3NjA0NDk2ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9SYWRpb0J1dHRvbkdyb3Vwcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1JhZGlvQnV0 dG9uR3JvdXBzLmNwcApAQCAtMTg2LDExICsxODYsOSBAQCBib29sIFJhZGlvQnV0dG9uR3JvdXA6 OmNvbnRhaW5zKEhUTUxJbnB1dEVsZW1lbnQmIGJ1dHRvbikgY29uc3QKIAogLy8gLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog Ci0vLyBFeHBsaWNpdHkgZGVmaW5lIGVtcHR5IGNvbnN0cnVjdG9yIGFuZCBkZXN0cnVjdG9yIGlu IG9yZGVyIHRvIHByZXZlbnQgdGhlCi0vLyBjb21waWxlciBmcm9tIGdlbmVyYXRpbmcgdGhlbSBh cyBpbmxpbmVzLiBTbyB3ZSBkb24ndCBuZWVkIHRvIHRvIGRlZmluZQotLy8gUmFkaW9CdXR0b25H cm91cCBpbiB0aGUgaGVhZGVyLgorLy8gRXhwbGljaXRseSBkZWZpbmUgZGVmYXVsdCBjb25zdHJ1 Y3RvciBhbmQgZGVzdHJ1Y3RvciBoZXJlIG91dHNpZGUgdGhlIGhlYWRlcgorLy8gc28gd2UgY2Fu IGNvbXBpbGUgdGhlIGhlYWRlciB3aXRob3V0IGluY2x1ZGluZyB0aGUgZGVmaW5pdGlvbiBvZiBS YWRpb0J1dHRvbkdyb3VwLgogUmFkaW9CdXR0b25Hcm91cHM6OlJhZGlvQnV0dG9uR3JvdXBzKCkg PSBkZWZhdWx0OwotCiBSYWRpb0J1dHRvbkdyb3Vwczo6flJhZGlvQnV0dG9uR3JvdXBzKCkgPSBk ZWZhdWx0OwogCiB2b2lkIFJhZGlvQnV0dG9uR3JvdXBzOjphZGRCdXR0b24oSFRNTElucHV0RWxl bWVudCYgZWxlbWVudCkKQEAgLTI1NCw3ICsyNTIsNyBAQCB2b2lkIFJhZGlvQnV0dG9uR3JvdXBz OjpyZXF1aXJlZFN0YXRlQ2hhbmdlZChIVE1MSW5wdXRFbGVtZW50JiBlbGVtZW50KQogSFRNTElu cHV0RWxlbWVudCogUmFkaW9CdXR0b25Hcm91cHM6OmNoZWNrZWRCdXR0b25Gb3JHcm91cChjb25z dCBBdG9taWNTdHJpbmcmIG5hbWUpIGNvbnN0CiB7CiAgICAgaWYgKCFtX25hbWVUb0dyb3VwTWFw KQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgbV9uYW1l VG9Hcm91cE1hcC0+Y2hlY2tDb25zaXN0ZW5jeSgpOwogICAgIFJhZGlvQnV0dG9uR3JvdXAqIGdy b3VwID0gbV9uYW1lVG9Hcm91cE1hcC0+Z2V0KG5hbWUuaW1wbCgpKTsKICAgICByZXR1cm4gZ3Jv dXAgPyBncm91cC0+Y2hlY2tlZEJ1dHRvbigpIDogbnVsbHB0cjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGNhZmQyZGQyNjllMzEzYjQ2NmYwYThiODc4ZDNm YTRlMmMzYWYwZjkuLmFlOWE5Y2RhMmNkOTgyNjE3NjYyYjdjMTBmZDM2MGE5NDc5M2NhMjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtMTY1LDExICsxNjUs MTUgQEAgSFRNTElucHV0RWxlbWVudDo6fkhUTUxJbnB1dEVsZW1lbnQoKQogCiAgICAgLy8gTmVl ZCB0byByZW1vdmUgZm9ybSBhc3NvY2lhdGlvbiB3aGlsZSB0aGlzIGlzIHN0aWxsIGFuIEhUTUxJ bnB1dEVsZW1lbnQKICAgICAvLyBzbyB0aGF0IHZpcnR1YWwgZnVuY3Rpb25zIGFyZSBjYWxsZWQg Y29ycmVjdGx5LgotICAgIHNldEZvcm0oMCk7Ci0gICAgLy8gc2V0Rm9ybSgwKSBtYXkgcmVnaXN0 ZXIgdGhpcyB0byBhIGRvY3VtZW50LWxldmVsIHJhZGlvIGJ1dHRvbiBncm91cC4KLSAgICAvLyBX ZSBzaG91bGQgdW5yZWdpc3RlciBpdCB0byBhdm9pZCBhY2Nlc3NpbmcgYSBkZWxldGVkIG9iamVj dC4KKyAgICBzZXRGb3JtKG51bGxwdHIpOworCisgICAgLy8gVGhpcyBpcyBuZWVkZWQgZm9yIGEg cmFkaW8gYnV0dG9uIHRoYXQgd2FzIG5vdCBpbiBhIGZvcm0sIGFuZCBhbHNvIGZvcgorICAgIC8v IGEgcmFkaW8gYnV0dG9uIHRoYXQgd2FzIGluIGEgZm9ybS4gVGhlIGNhbGwgdG8gc2V0Rm9ybShu dWxscHRyKSBhYm92ZQorICAgIC8vIGFjdHVhbGx5IGFkZHMgdGhlIGJ1dHRvbiB0byB0aGUgZG9j dW1lbnQgZ3JvdXBzIGluIHRoZSBsYXR0ZXIgY2FzZS4KKyAgICAvLyBUaGF0IGlzIGluZWxlZ2Fu dCwgYnV0IGhhcm1sZXNzIHNpbmNlIHdlIHJlbW92ZSBpdCBoZXJlLgogICAgIGlmIChpc1JhZGlv QnV0dG9uKCkpCiAgICAgICAgIGRvY3VtZW50KCkuZm9ybUNvbnRyb2xsZXIoKS5yYWRpb0J1dHRv bkdyb3VwcygpLnJlbW92ZUJ1dHRvbigqdGhpcyk7CisKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRT KQogICAgIGlmIChtX2hhc1RvdWNoRXZlbnRIYW5kbGVyKQogICAgICAgICBkb2N1bWVudCgpLmRp ZFJlbW92ZUV2ZW50VGFyZ2V0Tm9kZSgqdGhpcyk7CkBAIC0xNTYzLDggKzE1NjcsMTIgQEAgdm9p ZCBIVE1MSW5wdXRFbGVtZW50OjpkaWRNb3ZlVG9OZXdEb2N1bWVudChEb2N1bWVudCYgb2xkRG9j dW1lbnQsIERvY3VtZW50JiBuZXcKICAgICAgICAgb2xkRG9jdW1lbnQudW5yZWdpc3RlckZvckRv Y3VtZW50U3VzcGVuc2lvbkNhbGxiYWNrcygqdGhpcyk7CiAgICAgICAgIG5ld0RvY3VtZW50LnJl Z2lzdGVyRm9yRG9jdW1lbnRTdXNwZW5zaW9uQ2FsbGJhY2tzKCp0aGlzKTsKICAgICB9CisKKyAg ICAvLyBXZSBjYWxsIHRoaXMgZXZlbiBmb3IgcmFkaW8gYnV0dG9ucyBpbiBmb3JtczsgaXQncyBo YXJtbGVzcyBiZWNhdXNlIHRoZQorICAgIC8vIHJlbW92ZUJ1dHRvbiBmdW5jdGlvbiBpcyB3cml0 dGVuIHRvIGJlIHNhZmUgZm9yIGJ1dHRvbnMgbm90IGluIGFueSBncm91cC4KICAgICBpZiAoaXNS YWRpb0J1dHRvbigpKQogICAgICAgICBvbGREb2N1bWVudC5mb3JtQ29udHJvbGxlcigpLnJhZGlv QnV0dG9uR3JvdXBzKCkucmVtb3ZlQnV0dG9uKCp0aGlzKTsKKwogI2lmIEVOQUJMRShUT1VDSF9F VkVOVFMpCiAgICAgaWYgKG1faGFzVG91Y2hFdmVudEhhbmRsZXIpIHsKICAgICAgICAgb2xkRG9j dW1lbnQuZGlkUmVtb3ZlRXZlbnRUYXJnZXROb2RlKCp0aGlzKTsKQEAgLTE4OTIsMTIgKzE5MDAs MTIgQEAgVmVjdG9yPEhUTUxJbnB1dEVsZW1lbnQqPiBIVE1MSW5wdXRFbGVtZW50OjpyYWRpb0J1 dHRvbkdyb3VwKCkgY29uc3QKICAgICAgICAgcmV0dXJuIHsgfTsKICAgICByZXR1cm4gYnV0dG9u cy0+Z3JvdXBNZW1iZXJzKCp0aGlzKTsKIH0KLSAgICAKKwogSFRNTElucHV0RWxlbWVudCogSFRN TElucHV0RWxlbWVudDo6Y2hlY2tlZFJhZGlvQnV0dG9uRm9yR3JvdXAoKSBjb25zdAogewogICAg IGlmIChSYWRpb0J1dHRvbkdyb3VwcyogYnV0dG9ucyA9IHJhZGlvQnV0dG9uR3JvdXBzKCkpCiAg ICAgICAgIHJldHVybiBidXR0b25zLT5jaGVja2VkQnV0dG9uRm9yR3JvdXAobmFtZSgpKTsKLSAg ICByZXR1cm4gMDsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogUmFkaW9CdXR0b25Hcm91cHMq IEhUTUxJbnB1dEVsZW1lbnQ6OnJhZGlvQnV0dG9uR3JvdXBzKCkgY29uc3QK