195239 2019-03-01 20:28:00 -0800 Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event 2019-03-04 12:24:55 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1511752 0 joepeck 2019-03-01 20:28:00 -0800 Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event I'd suggest if after load tickling the dead timeout so we would stop within 2s. 1511868 1 363435 hi 2019-03-02 15:47:17 -0800 Created attachment 363435 Patch 1512053 2 363486 hi 2019-03-03 21:53:12 -0800 Created attachment 363486 Patch 1512271 3 363486 joepeck 2019-03-04 11:57:51 -0800 Comment on attachment 363486 Patch r=me, Nice! 1512294 4 363486 commit-queue 2019-03-04 12:23:54 -0800 Comment on attachment 363486 Patch Clearing flags on attachment: 363486 Committed r242370: <https://trac.webkit.org/changeset/242370> 1512295 5 commit-queue 2019-03-04 12:23:56 -0800 All reviewed patches have been landed. Closing bug. 1512296 6 webkit-bug-importer 2019-03-04 12:24:55 -0800 <rdar://problem/48572456> 363435 2019-03-02 15:47:17 -0800 2019-03-03 21:53:12 -0800 Patch bug-195239-20190302154717.patch text/plain 1888 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk0YzVmZWI1ZGY3MTVjMWFhOWIwNGUxYzc2MTM3 NjI4ZGYyNzBiNjMuLjIzYzQ5MzMzMjQzYmIyNTU3NjQ4ZWY5YTQxMjU2OWJlYmNiODE3NzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTAyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBU b2dnbGluZyBUaW1lbGluZSAiU3RvcCB3aGVuIHBhZ2UgbG9hZHMiIHRvIG9uIHNob3VsZCBzdG9w IChpbW1lZGlhdGVseSBvciBzb29uKSBhbnkgYWN0aXZlIHJlY29yZGluZyBpZiBhbHJlYWR5IHBh c3QgdGhlIGxvYWQgZXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NTIzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanM6 CisgICAgICAgIChXSS5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBlLl9oYW5kbGVUaW1lbGluZXNB dXRvU3RvcFNldHRpbmdDaGFuZ2VkKToKKwogMjAxOS0wMy0wMiAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRGVidWdnZXI6IERPTSwg VVJMLCBhbmQgRXZlbnQgYnJlYWtwb2ludHMgZG9uJ3QgZ3JleSBvdXQgd2hlbiBhbGwgYnJlYWtw b2ludHMgYXJlIGRpc2FibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKaW5k ZXggOTBjY2ZjOWEwZGZjYTFmZWYxMzQwYWJhMzc0ZTRiYzZjYjhmNDBmNS4uNGFmZDBlMDg1Yjky MmQ3MDk4MDE4OWY1NDEwZGRiMjc0YmE1ODhmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5l TWFuYWdlci5qcwpAQCAtOTU2LDkgKzk1NiwxMyBAQCBXSS5UaW1lbGluZU1hbmFnZXIgPSBjbGFz cyBUaW1lbGluZU1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgaWYgKCF0aGlzLl9p c0NhcHR1cmluZykKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAoV0kuc2V0dGlu Z3MudGltZWxpbmVzQXV0b1N0b3AudmFsdWUpCi0gICAgICAgICAgICB0aGlzLl9yZXNldEF1dG9S ZWNvcmRpbmdNYXhUaW1lVGltZW91dCgpOwotICAgICAgICBlbHNlCisgICAgICAgIGlmIChXSS5z ZXR0aW5ncy50aW1lbGluZXNBdXRvU3RvcC52YWx1ZSkgeworICAgICAgICAgICAgaWYgKCFpc05h TihXSS5uZXR3b3JrTWFuYWdlci5tYWluRnJhbWUubG9hZEV2ZW50VGltZXN0YW1wKSkKKyAgICAg ICAgICAgICAgICB0aGlzLl9zdG9wQXV0b1JlY29yZGluZ1Nvb24oKTsKKyAgICAgICAgICAgIGVs c2UKKyAgICAgICAgICAgICAgICB0aGlzLl9yZXNldEF1dG9SZWNvcmRpbmdNYXhUaW1lVGltZW91 dCgpOworICAgICAgICAgICAgdGhpcy5fcmVzZXRBdXRvUmVjb3JkaW5nRGVhZFRpbWVUaW1lb3V0 KCk7CisgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgdGhpcy5yZWxheEF1dG9TdG9wKCk7CiAg ICAgfQogCg== 363486 2019-03-03 21:53:12 -0800 2019-03-04 12:23:54 -0800 Patch bug-195239-20190302154717.patch text/plain 1908 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk0YzVmZWI1ZGY3MTVjMWFhOWIwNGUxYzc2MTM3 NjI4ZGYyNzBiNjMuLjIzYzQ5MzMzMjQzYmIyNTU3NjQ4ZWY5YTQxMjU2OWJlYmNiODE3NzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAzLTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBU b2dnbGluZyBUaW1lbGluZSAiU3RvcCB3aGVuIHBhZ2UgbG9hZHMiIHRvIG9uIHNob3VsZCBzdG9w IChpbW1lZGlhdGVseSBvciBzb29uKSBhbnkgYWN0aXZlIHJlY29yZGluZyBpZiBhbHJlYWR5IHBh c3QgdGhlIGxvYWQgZXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NTIzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanM6 CisgICAgICAgIChXSS5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBlLl9oYW5kbGVUaW1lbGluZXNB dXRvU3RvcFNldHRpbmdDaGFuZ2VkKToKKwogMjAxOS0wMy0wMiAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVW5leHBlY3RlZGx5IGZy ZXF1ZW50IGZsYXNoaW5nIG9mIERPTSBub2RlIGF0dHJpYnV0ZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdl ci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1Rp bWVsaW5lTWFuYWdlci5qcwppbmRleCA5MGNjZmM5YTBkZmNhMWZlZjEzNDBhYmEzNzRlNGJjNmNi OGY0MGY1Li40YWZkMGUwODViOTIyZDcwOTgwMTg5ZjU0MTBkZGIyNzRiYTU4OGYwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1l bGluZU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzCkBAIC05NTYsOSArOTU2LDEzIEBAIFdJLlRp bWVsaW5lTWFuYWdlciA9IGNsYXNzIFRpbWVsaW5lTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAog ICAgICAgICBpZiAoIXRoaXMuX2lzQ2FwdHVyaW5nKQogICAgICAgICAgICAgcmV0dXJuOwogCi0g ICAgICAgIGlmIChXSS5zZXR0aW5ncy50aW1lbGluZXNBdXRvU3RvcC52YWx1ZSkKLSAgICAgICAg ICAgIHRoaXMuX3Jlc2V0QXV0b1JlY29yZGluZ01heFRpbWVUaW1lb3V0KCk7Ci0gICAgICAgIGVs c2UKKyAgICAgICAgaWYgKFdJLnNldHRpbmdzLnRpbWVsaW5lc0F1dG9TdG9wLnZhbHVlKSB7Cisg ICAgICAgICAgICBpZiAodGhpcy5fbWFpblJlc291cmNlRm9yQXV0b0NhcHR1cmluZyAmJiAhaXNO YU4odGhpcy5fbWFpblJlc291cmNlRm9yQXV0b0NhcHR1cmluZy5wYXJlbnRGcmFtZS5sb2FkRXZl bnRUaW1lc3RhbXApKQorICAgICAgICAgICAgICAgIHRoaXMuX3N0b3BBdXRvUmVjb3JkaW5nU29v bigpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHRoaXMuX3Jlc2V0QXV0b1Jl Y29yZGluZ01heFRpbWVUaW1lb3V0KCk7CisgICAgICAgICAgICB0aGlzLl9yZXNldEF1dG9SZWNv cmRpbmdEZWFkVGltZVRpbWVvdXQoKTsKKyAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICB0aGlz LnJlbGF4QXV0b1N0b3AoKTsKICAgICB9CiAK