195235 2019-03-01 16:57:35 -0800 [JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX 2019-03-01 17:06:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1511692 0 ysuzuki 2019-03-01 16:57:35 -0800 [JSC] Fix FTL build on ARM32_64 by adding stubs for JSRopeString::offsetOfXXX 1511694 1 363390 ysuzuki 2019-03-01 16:58:23 -0800 Created attachment 363390 Patch 1511695 2 363390 saam 2019-03-01 17:00:20 -0800 Comment on attachment 363390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:567 > + static ptrdiff_t offsetOfFlags() { return 0; } > + static ptrdiff_t offsetOfFiber1Lower() { return 0; } > + static ptrdiff_t offsetOfFiber1Upper() { return 0; } > + static ptrdiff_t offsetOfFiber2Lower() { return 0; } > + static ptrdiff_t offsetOfFiber2Upper() { return 0; } please ASSERT_NOT_REACHED or similar. 1511696 3 363390 ysuzuki 2019-03-01 17:01:04 -0800 Comment on attachment 363390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:567 >> + static ptrdiff_t offsetOfFiber2Upper() { return 0; } > > please ASSERT_NOT_REACHED or similar. Nice! Added. 1511697 4 363390 mark.lam 2019-03-01 17:01:49 -0800 Comment on attachment 363390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review > Source/JavaScriptCore/runtime/JSString.h:560 > + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, /stroing/storing/ 1511698 5 363390 ysuzuki 2019-03-01 17:04:47 -0800 Comment on attachment 363390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363390&action=review >> Source/JavaScriptCore/runtime/JSString.h:560 >> + // FIXME: This is an temporary workaround to make JSC built on ARM64_32. Once we start calculating bits before stroing them to JSRopeString, > > /stroing/storing/ Oops, nice catch. Fixed. 1511699 6 ysuzuki 2019-03-01 17:05:36 -0800 Committed r242299: <https://trac.webkit.org/changeset/242299> 1511700 7 webkit-bug-importer 2019-03-01 17:06:25 -0800 <rdar://problem/48528954> 363390 2019-03-01 16:58:23 -0800 2019-03-01 17:00:20 -0800 Patch bug-195235-20190301165822.patch text/plain 2921 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 Y2Y3MTk3ZWNhMGM1YjI4NDI0YjgzYWRkYmM3OGM1ZGExNzcyYTc3Li4xYjYwOWI1OGZiMWI2NzY5 ZDkwNGI5YTUyNDI0MjM3MTE3ZjFkMzQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0wMy0wMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEZpeCBGVEwgYnVpbGQgb24gQVJNMzJfNjQgYnkgYWRkaW5nIHN0 dWJzIGZvciBKU1JvcGVTdHJpbmc6Om9mZnNldE9mWFhYCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUyMzUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgd29ya2Fyb3VuZCB1bnRpbCBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MjM0IGlzIGRvbmUuCisKKyAg ICAgICAgKiBydW50aW1lL0pTU3RyaW5nLmg6CisKIDIwMTktMDMtMDEgIFl1c3VrZSBTdXp1a2kg IDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBVc2UgcnVudGltZSBjYWxscyBm b3IgREZHIE1ha2VSb3BlIGlmICFDUFUoQUREUkVTUzY0KQpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTU3RyaW5nLmgKaW5kZXggMWEwNDBjNmMyNzA2YjlhZmY0ZDc3NTBlNGM3YzljOGI4 OTg0ZDE1My4uYTcwZjdhZGI0Zjc2MTUxNGM2MzAyYjk2YTI0YTRkYzg4Mjc2MDI1ZSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNTdHJpbmcuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oCkBAIC01NDksMTMgKzU0OSwyMiBA QCBjbGFzcyBKU1JvcGVTdHJpbmcgZmluYWwgOiBwdWJsaWMgSlNTdHJpbmcgewogCiBwdWJsaWM6 CiAgICAgc3RhdGljIHB0cmRpZmZfdCBvZmZzZXRPZkxlbmd0aCgpIHsgcmV0dXJuIE9CSkVDVF9P RkZTRVRPRihKU1JvcGVTdHJpbmcsIG1fY29tcGFjdEZpYmVycykgKyBDb21wYWN0RmliZXJzOjpv ZmZzZXRPZkxlbmd0aCgpOyB9IC8vIDMyYnl0ZSB3aWR0aC4KKyAgICBzdGF0aWMgcHRyZGlmZl90 IG9mZnNldE9mRmliZXIwKCkgeyByZXR1cm4gb2Zmc2V0T2ZWYWx1ZSgpOyB9CiAjaWYgQ1BVKEFE RFJFU1M2NCkKICAgICBzdGF0aWMgcHRyZGlmZl90IG9mZnNldE9mRmxhZ3MoKSB7IHJldHVybiBv ZmZzZXRPZlZhbHVlKCkgKyBzaXplb2YodWludDE2X3QpICogMzsgfSAvLyAxNmJ5dGUgd2lkdGgu Ci0gICAgc3RhdGljIHB0cmRpZmZfdCBvZmZzZXRPZkZpYmVyMCgpIHsgcmV0dXJuIG9mZnNldE9m VmFsdWUoKTsgfQogICAgIHN0YXRpYyBwdHJkaWZmX3Qgb2Zmc2V0T2ZGaWJlcjFMb3dlcigpIHsg cmV0dXJuIE9CSkVDVF9PRkZTRVRPRihKU1JvcGVTdHJpbmcsIG1fY29tcGFjdEZpYmVycykgKyBD b21wYWN0RmliZXJzOjpvZmZzZXRPZkZpYmVyMUxvd2VyKCk7IH0gLy8gMzJieXRlIHdpZHRoLgog ICAgIHN0YXRpYyBwdHJkaWZmX3Qgb2Zmc2V0T2ZGaWJlcjFVcHBlcigpIHsgcmV0dXJuIE9CSkVD VF9PRkZTRVRPRihKU1JvcGVTdHJpbmcsIG1fY29tcGFjdEZpYmVycykgKyBDb21wYWN0RmliZXJz OjpvZmZzZXRPZkZpYmVyMVVwcGVyKCk7IH0gLy8gMTZieXRlIHdpZHRoLgogICAgIHN0YXRpYyBw dHJkaWZmX3Qgb2Zmc2V0T2ZGaWJlcjJMb3dlcigpIHsgcmV0dXJuIE9CSkVDVF9PRkZTRVRPRihK U1JvcGVTdHJpbmcsIG1fY29tcGFjdEZpYmVycykgKyBDb21wYWN0RmliZXJzOjpvZmZzZXRPZkZp YmVyMkxvd2VyKCk7IH0gLy8gMzJieXRlIHdpZHRoLgogICAgIHN0YXRpYyBwdHJkaWZmX3Qgb2Zm c2V0T2ZGaWJlcjJVcHBlcigpIHsgcmV0dXJuIE9CSkVDVF9PRkZTRVRPRihKU1JvcGVTdHJpbmcs IG1fY29tcGFjdEZpYmVycykgKyBDb21wYWN0RmliZXJzOjpvZmZzZXRPZkZpYmVyMlVwcGVyKCk7 IH0gLy8gMTZieXRlIHdpZHRoLgorI2VsaWYgVVNFKEpTVkFMVUU2NCkKKyAgICAvLyBGSVhNRTog VGhpcyBpcyBhbiB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCB0byBtYWtlIEpTQyBidWlsdCBvbiBBUk02 NF8zMi4gT25jZSB3ZSBzdGFydCBjYWxjdWxhdGluZyBiaXRzIGJlZm9yZSBzdHJvaW5nIHRoZW0g dG8gSlNSb3BlU3RyaW5nLAorICAgIC8vIHdlIGRvIG5vdCBuZWVkIHRvIGhhdmUgc3VjaCBhIGRl dGFpbGVkIGluZm9ybWF0aW9uIGFzIGFuIG9mZnNldC4gQWZ0ZXIgdGhhdCwgd2hhdCB3ZSBvbmx5 IG5lZWQgaXMgb2Zmc2V0T2ZGaWJlcjAsIG9mZnNldE9mRmliZXIxLCBhbmQgb2Zmc2V0T2ZGaWJl cjIuCisgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTIz NAorICAgIHN0YXRpYyBwdHJkaWZmX3Qgb2Zmc2V0T2ZGbGFncygpIHsgcmV0dXJuIDA7IH0KKyAg ICBzdGF0aWMgcHRyZGlmZl90IG9mZnNldE9mRmliZXIxTG93ZXIoKSB7IHJldHVybiAwOyB9Cisg ICAgc3RhdGljIHB0cmRpZmZfdCBvZmZzZXRPZkZpYmVyMVVwcGVyKCkgeyByZXR1cm4gMDsgfQor ICAgIHN0YXRpYyBwdHJkaWZmX3Qgb2Zmc2V0T2ZGaWJlcjJMb3dlcigpIHsgcmV0dXJuIDA7IH0K KyAgICBzdGF0aWMgcHRyZGlmZl90IG9mZnNldE9mRmliZXIyVXBwZXIoKSB7IHJldHVybiAwOyB9 CiAjZW5kaWYKIAogICAgIHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgc19tYXhJbnRlcm5hbFJv cGVMZW5ndGggPSAzOwo=