195230 2019-03-01 14:47:07 -0800 Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled 2019-03-01 16:30:46 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue rniwa webkit-bug-importer oldest_to_newest 1511625 0 cdumez 2019-03-01 14:47:07 -0800 Disable NetworkStateNotifier::singleton()'s isMainThread() assertion when the WebThread is enabled to address crashes on iOS WK1. 1511626 1 cdumez 2019-03-01 14:47:25 -0800 <rdar://problem/47925359> 1511627 2 363378 cdumez 2019-03-01 14:48:52 -0800 Created attachment 363378 Patch 1511631 3 363378 rniwa 2019-03-01 14:59:30 -0800 Comment on attachment 363378 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363378&action=review > Source/WebCore/platform/network/NetworkStateNotifier.cpp:41 > +#if PLATFORM(IOS_FAMILY) Why not #if USE(WEB_THREAD)? 1511659 4 363386 cdumez 2019-03-01 15:53:14 -0800 Created attachment 363386 Patch 1511681 5 363386 commit-queue 2019-03-01 16:30:44 -0800 Comment on attachment 363386 Patch Clearing flags on attachment: 363386 Committed r242295: <https://trac.webkit.org/changeset/242295> 1511682 6 commit-queue 2019-03-01 16:30:46 -0800 All reviewed patches have been landed. Closing bug. 363378 2019-03-01 14:48:52 -0800 2019-03-01 15:53:13 -0800 Patch bug-195230-20190301144851.patch text/plain 1946 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI1ODk4YmNjN2YxMjE0 Zjc0YTMyZDU5MWZmMmFhY2E1ZDZhYmIzOS4uNDI2NjQ5ZGM5ZTY3ZDQ4MjlkNThiMzBjOGYyMDY3 ODExZGQwYWU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBOZXR3b3JrU3Rh dGVOb3RpZmllcjo6c2luZ2xldG9uKCkncyBpc01haW5UaHJlYWQoKSBhc3NlcnRpb24gd2hlbiB0 aGUgV2ViVGhyZWFkIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NTIzMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc5MjUzNTk+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlzYWJs ZSBOZXR3b3JrU3RhdGVOb3RpZmllcjo6c2luZ2xldG9uKCkncyBpc01haW5UaHJlYWQoKSBhc3Nl cnRpb24gd2hlbiB0aGUgV2ViVGhyZWFkIGlzIGVuYWJsZWQKKyAgICAgICAgdG8gYWRkcmVzcyBj cmFzaGVzIG9uIGlPUyBXSzEuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtT dGF0ZU5vdGlmaWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNob3VsZFN1cHByZXNzVGhyZWFk U2FmZXR5Q2hlY2spOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya1N0YXRlTm90aWZpZXI6OnNp bmdsZXRvbik6CisKIDIwMTktMDItMjggIEp1c3RpbiBGYW4gIDxqdXN0aW5fZmFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbV2ViIEdQVV0gRW5hYmxlIFdlYiBHUFUgb25seSBvbiA2NC1iaXQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90 aWZpZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVO b3RpZmllci5jcHAKaW5kZXggODIyZThiMDZlZDQyNDgyYjYxNmVlZWUwYzIyNWRmNWQ0Zjc0Yzlj Yi4uYTg0MzcxM2QwNGI5NmViOGM0YTM0NzBlZTlhMjA3ZmM4ZGY2MzU1YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmll ci5jcHAKQEAgLTI4LDEzICsyOCwyNiBAQAogCiAjaW5jbHVkZSA8d3RmL05ldmVyRGVzdHJveWVk Lmg+CiAKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZKQorI2luY2x1ZGUgIldlYkNvcmVUaHJlYWQu aCIKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBjb25zdCBTZWNvbmRz IHVwZGF0ZVN0YXRlU29vbkludGVydmFsIHsgMl9zIH07CiAKK3N0YXRpYyBib29sIHNob3VsZFN1 cHByZXNzVGhyZWFkU2FmZXR5Q2hlY2soKQoreworI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisg ICAgcmV0dXJuIFdlYlRocmVhZElzRW5hYmxlZCgpOworI2Vsc2UKKyAgICByZXR1cm4gZmFsc2U7 CisjZW5kaWYKK30KKwogTmV0d29ya1N0YXRlTm90aWZpZXImIE5ldHdvcmtTdGF0ZU5vdGlmaWVy OjpzaW5nbGV0b24oKQogewotICAgIFJFTEVBU0VfQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKyAg ICBSRUxFQVNFX0FTU0VSVChzaG91bGRTdXBwcmVzc1RocmVhZFNhZmV0eUNoZWNrKCkgfHwgaXNN YWluVGhyZWFkKCkpOwogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxOZXR3b3JrU3RhdGVOb3Rp Zmllcj4gbmV0d29ya1N0YXRlTm90aWZpZXI7CiAgICAgcmV0dXJuIG5ldHdvcmtTdGF0ZU5vdGlm aWVyOwogfQo= 363386 2019-03-01 15:53:14 -0800 2019-03-01 16:30:44 -0800 Patch bug-195230-20190301155310.patch text/plain 1977 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY1MGNjZGI5ZTI0MWZj OWQ5MTcxOTc2MDkwMjY1ZjU2MGFhYzZmMi4uZTk3YzEyNjk3MTRmMjNjYWIzZWY1YzJjOWQxYjE2 ZTE0NmQzZWNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBOZXR3b3JrU3Rh dGVOb3RpZmllcjo6c2luZ2xldG9uKCkncyBpc01haW5UaHJlYWQoKSBhc3NlcnRpb24gd2hlbiB0 aGUgV2ViVGhyZWFkIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NTIzMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc5MjUzNTk+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIERpc2FibGUg TmV0d29ya1N0YXRlTm90aWZpZXI6OnNpbmdsZXRvbigpJ3MgaXNNYWluVGhyZWFkKCkgYXNzZXJ0 aW9uIHdoZW4gdGhlIFdlYlRocmVhZCBpcyBlbmFibGVkCisgICAgICAgIHRvIGFkZHJlc3MgY3Jh c2hlcyBvbiBpT1MgV0sxLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3Rh dGVOb3RpZmllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzaG91bGRTdXBwcmVzc1RocmVhZFNh ZmV0eUNoZWNrKToKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtTdGF0ZU5vdGlmaWVyOjpzaW5n bGV0b24pOgorCiAyMDE5LTAzLTAxICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNlcnZlcl0gQ2hlY2sgZm9yIHBlbmRpbmcgc3R5bGUg cmVjYWxjcyBhdCB0aGUgZW5kIG9mIGVhY2ggdGltZXIgcnVuLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVyLmNwcAppbmRl eCA4MjJlOGIwNmVkNDI0ODJiNjE2ZWVlZTBjMjI1ZGY1ZDRmNzRjOWNiLi5hY2NmOTQ0MWMzYzY2 YWI5MjU5OWIzNTg3YjFiOTk3YjFlMDNkZDg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVyLmNwcApAQCAtMjgsMTMg KzI4LDI2IEBACiAKICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KIAorI2lmIFVTRShX RUJfVEhSRUFEKQorI2luY2x1ZGUgIldlYkNvcmVUaHJlYWQuaCIKKyNlbmRpZgorCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBjb25zdCBTZWNvbmRzIHVwZGF0ZVN0YXRlU29vbkludGVy dmFsIHsgMl9zIH07CiAKK3N0YXRpYyBib29sIHNob3VsZFN1cHByZXNzVGhyZWFkU2FmZXR5Q2hl Y2soKQoreworI2lmIFVTRShXRUJfVEhSRUFEKQorICAgIHJldHVybiBXZWJUaHJlYWRJc0VuYWJs ZWQoKTsKKyNlbHNlCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCit9CisKIE5ldHdvcmtTdGF0 ZU5vdGlmaWVyJiBOZXR3b3JrU3RhdGVOb3RpZmllcjo6c2luZ2xldG9uKCkKIHsKLSAgICBSRUxF QVNFX0FTU0VSVChpc01haW5UaHJlYWQoKSk7CisgICAgUkVMRUFTRV9BU1NFUlQoc2hvdWxkU3Vw cHJlc3NUaHJlYWRTYWZldHlDaGVjaygpIHx8IGlzTWFpblRocmVhZCgpKTsKICAgICBzdGF0aWMg TmV2ZXJEZXN0cm95ZWQ8TmV0d29ya1N0YXRlTm90aWZpZXI+IG5ldHdvcmtTdGF0ZU5vdGlmaWVy OwogICAgIHJldHVybiBuZXR3b3JrU3RhdGVOb3RpZmllcjsKIH0K