195215 2019-03-01 09:45:09 -0800 Improper use of PLATFORM(TVOS) in PAL 2019-03-04 11:58:55 -0800 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz ap conrad_shultz darin ews-watchlist webkit-bug-importer oldest_to_newest 1511432 0 conrad_shultz 2019-03-01 09:45:09 -0800 There are a couple stray uses of PLATFORM(TVOS) in PAL. The correct usage is PLATFORM(APPLETV). 1511433 1 conrad_shultz 2019-03-01 09:45:23 -0800 <rdar://problem/48512402> 1511435 2 363339 conrad_shultz 2019-03-01 09:52:14 -0800 Created attachment 363339 Patch 1511436 3 conrad_shultz 2019-03-01 09:53:37 -0800 Style checker will fail due to existing issues, but I don't think we should address those as part of this change. 1511437 4 ews-watchlist 2019-03-01 09:54:51 -0800 Attachment 363339 did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:28: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32: Incorrect OS version check. VERSION_MIN_REQUIRED values never include a minor version. You may be looking for a combination of VERSION_MIN_REQUIRED for target OS version check and VERSION_MAX_ALLOWED for SDK check. [build/version_check] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:34: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1511549 5 ap 2019-03-01 12:48:21 -0800 You probably don't have to, but this is a good opportunity to improve things. 1512231 6 conrad_shultz 2019-03-04 10:44:16 -0800 (In reply to Alexey Proskuryakov from comment #5) > You probably don't have to, but this is a good opportunity to improve things. I'd like to do these in separate commits, in the unlikely event that addressing the style issues introduces unexpected problems. 1512273 7 conrad_shultz 2019-03-04 11:58:55 -0800 Committed r242368: <https://trac.webkit.org/changeset/242368> 363339 2019-03-01 09:52:14 -0800 2019-03-03 00:18:40 -0800 Patch bug-195215-20190301095209.patch text/plain 3573 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBlODdhYzg5 MTc0YjY0MzRkMWEzZDAxODJmZmY4Mjg0ZmEzZjk5MTZkLi5hZTkzNDllMzM5NmUxZTI3YmUxMjA4 M2NkZTg5ODNiZTFmYWNiNmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAxOS0wMy0wMSAgQ29ucmFkIFNodWx0eiAgPGNvbnJhZF9zaHVsdHpAYXBwbGUuY29tPgorCisg ICAgICAgIEltcHJvcGVyIHVzZSBvZiBQTEFURk9STShUVk9TKSBpbiBQQUwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTIxNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBhIGNvdXBsZSBz dHJheSB1c2VzIG9mIFBMQVRGT1JNKFRWT1MpIGluIFBBTC4gVGhlIGNvcnJlY3QgdXNhZ2UgaXMK KyAgICAgICAgUExBVEZPUk0oQVBQTEVUVikuCisKKyAgICAgICAgKiBwYWwvc3BpL2NvY29hL05T S2V5ZWRBcmNoaXZlclNQSS5oOgorICAgICAgICAqIHBhbC9zcGkvY29jb2EvTlNQcm9ncmVzc1NQ SS5oOgorCiAyMDE5LTAzLTAxICBKdXN0aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dlYiBHUFVdIDMyLWJpdCBidWlsZHMgYnJva2VuIGJ5IGF0dGVtcHQgdG8gZGlz YWJsZSBXZWJHUFUgb24gMzItYml0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFs L3NwaS9jb2NvYS9OU0tleWVkQXJjaGl2ZXJTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwv c3BpL2NvY29hL05TS2V5ZWRBcmNoaXZlclNQSS5oCmluZGV4IDVhMjVmMWJkOWYzMjNkNTU5NzRj YTcyM2ZhYjY0ZjBiNDQxYmQwZWIuLmRkM2IwZDhmNDY0ZTAxMDkwMGFiOTM0YjY5ZTAwMjhjYzcw ZWFmZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NvY29hL05TS2V5 ZWRBcmNoaXZlclNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NvY29hL05T S2V5ZWRBcmNoaXZlclNQSS5oCkBAIC0yOSw5ICsyOSw5IEBACiAjaW1wb3J0IDx3dGYvQXNzZXJ0 aW9ucy5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCi0jZGVmaW5lIFVTRV9TRUNVUkVf QVJDSElWRVJfQVBJICgoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUFYX0FM TE9XRUQgPj0gMTAxMzAyICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAx MzAwKSB8fCAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTEwMjAwKSB8fCAoUExBVEZPUk0oV0FUQ0hPUykgJiYgX19XQVRDSF9PU19W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSA0MDIwMCkgfHwgKFBMQVRGT1JNKFRWT1MpICYmIF9fVFZf T1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTEwMjAwKSkKKyNkZWZpbmUgVVNFX1NFQ1VSRV9B UkNISVZFUl9BUEkgKChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxM T1dFRCA+PSAxMDEzMDIgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEz MDApIHx8IChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMTAyMDApIHx8IChQTEFURk9STShXQVRDSE9TKSAmJiBfX1dBVENIX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDQwMjAwKSB8fCAoUExBVEZPUk0oQVBQTEVUVikgJiYgX19U Vl9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAyMDApKQogCi0jZGVmaW5lIFVTRV9TRUNV UkVfQVJDSElWRVJfRk9SX0FUVFJJQlVURURfU1RSSU5HICgoUExBVEZPUk0oTUFDKSAmJiBfX01B Q19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gMTAxMzAyICYmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAwKSB8fCAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19J UEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKSB8fCAoUExBVEZPUk0oV0FU Q0hPUykgJiYgX19XQVRDSF9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA2MDAwMCkgfHwgKFBM QVRGT1JNKFRWT1MpICYmIF9fVFZfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwMDAwKSkK KyNkZWZpbmUgVVNFX1NFQ1VSRV9BUkNISVZFUl9GT1JfQVRUUklCVVRFRF9TVFJJTkcgKChQTEFU Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMDEzMDIgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDApIHx8IChQTEFURk9STShJ T1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAwMDAp IHx8IChQTEFURk9STShXQVRDSE9TKSAmJiBfX1dBVENIX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDYwMDAwKSB8fCAoUExBVEZPUk0oQVBQTEVUVikgJiYgX19UVl9PU19WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMzAwMDApKQogCiAjaWYgVVNFKFNFQ1VSRV9BUkNISVZFUl9BUEkpCiAjaWYg VVNFKEFQUExFX0lOVEVSTkFMX1NESykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9w YWwvc3BpL2NvY29hL05TUHJvZ3Jlc3NTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3Bp L2NvY29hL05TUHJvZ3Jlc3NTUEkuaAppbmRleCA3OTM3MGExNjUxYmZiNjRlYzBjMjA3MGU5ZmU3 YjRhMGFmYmFkMjUyLi5lMDdkMDYxNTRkMDllMTc0MjI3ODlmMDdiN2QyODQ5MDVmZjA3NjA3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jb2NvYS9OU1Byb2dyZXNzU1BJ LmgKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvTlNQcm9ncmVzc1NQSS5o CkBAIC0yNSw3ICsyNSw3IEBACiAKICNwcmFnbWEgb25jZQogCi0jZGVmaW5lIFVTRV9OU1BST0dS RVNTX1BVQkxJU0hJTkdfU1BJICgoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhPTkVfT1Nf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMzAwMDApIHx8IChQTEFURk9STShXQVRDSE9TKSAmJiBf X1dBVENIX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgNjAwMDApIHx8IChQTEFURk9STShUVk9T KSAmJiBfX1RWX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTMwMDAwKSkKKyNkZWZpbmUgVVNF X05TUFJPR1JFU1NfUFVCTElTSElOR19TUEkgKChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQ SE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEzMDAwMCkgfHwgKFBMQVRGT1JNKFdBVENI T1MpICYmIF9fV0FUQ0hfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCA2MDAwMCkgfHwgKFBMQVRG T1JNKEFQUExFVFYpICYmIF9fVFZfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMzAwMDApKQog CiAjaWYgVVNFKE5TUFJPR1JFU1NfUFVCTElTSElOR19TUEkpCiAK