195209 2019-03-01 07:23:09 -0800 Remove unused WebPageProxy::m_navigationID 2019-03-02 08:30:44 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue darin mcatanzaro webkit-bug-importer oldest_to_newest 1511396 0 mcatanzaro 2019-03-01 07:23:09 -0800 WebPageProxy::m_navigationID is never assigned to and is only used once by mistake in a debug LOG(). It must be a refactoring mistake. 1511397 1 363329 mcatanzaro 2019-03-01 07:24:48 -0800 Created attachment 363329 Patch 1511807 2 363329 commit-queue 2019-03-02 08:28:52 -0800 Comment on attachment 363329 Patch Clearing flags on attachment: 363329 Committed r242310: <https://trac.webkit.org/changeset/242310> 1511808 3 commit-queue 2019-03-02 08:28:53 -0800 All reviewed patches have been landed. Closing bug. 1511809 4 webkit-bug-importer 2019-03-02 08:30:44 -0800 <rdar://problem/48536697> 363329 2019-03-01 07:24:48 -0800 2019-03-02 08:28:52 -0800 Patch bug-195209-20190301092447.patch text/plain 2784 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlmZmFhNDkxNGE3N2IzYjhj OWE2NmE4ZWZjMDMyZWViZmRlMzg3NmMuLmIxNjlmZDFlMmY1ZGRlZmY4ODY0OGIxNDkxYTNiNTc5 OGE1YmNhMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDMtMDEgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVz ZWQgV2ViUGFnZVByb3h5OjptX25hdmlnYXRpb25JRAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViUGFnZVByb3h5OjptX25hdmlnYXRpb25JRCBpcyBu ZXZlciBhc3NpZ25lZCB0byBhbmQgaXMgb25seSB1c2VkIG9uY2UgYnkgbWlzdGFrZSBpbiBhCisg ICAgICAgIGRlYnVnIExPRygpLiBJdCBtdXN0IGJlIGEgcmVmYWN0b3JpbmcgbWlzdGFrZS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlUHJveHk6OmRpZENvbW1pdExvYWRGb3JGcmFtZSk6CisgICAgICAgICogVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oOgorCiAyMDE5LTAyLTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgSFRUUFNVcGdyYWRlTGlzdC5kYiBkYXRhYmFzZSBzaG91bGQgYmUg b3BlbmVkIGluIHJlYWRvbmx5IG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwCmluZGV4IDg3MGMxN2UxYzQ4OGI2YWFiNWM1OGY0MjAwMDVhOTMyZThiOWExZmUuLjg5 ZmM1NWZhNmQ4ZWM2MjZlZDUxNGExMjhkNTk5NGUwODlmNDgyNTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNDA0NSw3ICs0MDQ1LDcgQEAgdm9pZCBXZWJQ YWdlUHJveHk6OmNsZWFyTG9hZERlcGVuZGVudENhbGxiYWNrcygpCiAKIHZvaWQgV2ViUGFnZVBy b3h5OjpkaWRDb21taXRMb2FkRm9yRnJhbWUodWludDY0X3QgZnJhbWVJRCwgdWludDY0X3QgbmF2 aWdhdGlvbklELCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBib29sIGZyYW1lSGFzQ3VzdG9tQ29u dGVudFByb3ZpZGVyLCB1aW50MzJfdCBvcGFxdWVGcmFtZUxvYWRUeXBlLCBjb25zdCBXZWJDb3Jl OjpDZXJ0aWZpY2F0ZUluZm8mIGNlcnRpZmljYXRlSW5mbywgYm9vbCBjb250YWluc1BsdWdpbkRv Y3VtZW50LCBPcHRpb25hbDxIYXNJbnNlY3VyZUNvbnRlbnQ+IGhhc0luc2VjdXJlQ29udGVudCwg Y29uc3QgVXNlckRhdGEmIHVzZXJEYXRhKQogewotICAgIExPRyhMb2FkaW5nLCAiKExvYWRpbmcp IFdlYlBhZ2VQcm94eSAlIiBQUkl1NjQgIiBkaWRDb21taXRMb2FkRm9yRnJhbWUgaW4gbmF2aWdh dGlvbiAlIiBQUkl1NjQsIG1fcGFnZUlELCBtX25hdmlnYXRpb25JRCk7CisgICAgTE9HKExvYWRp bmcsICIoTG9hZGluZykgV2ViUGFnZVByb3h5ICUiIFBSSXU2NCAiIGRpZENvbW1pdExvYWRGb3JG cmFtZSBpbiBuYXZpZ2F0aW9uICUiIFBSSXU2NCwgbV9wYWdlSUQsIG5hdmlnYXRpb25JRCk7CiAg ICAgTE9HKEJhY2tGb3J3YXJkLCAiKEJhY2svRm9yd2FyZCkgQWZ0ZXIgbG9hZCBjb21taXQsIGJh Y2svZm9yd2FyZCBsaXN0IGlzIG5vdzolcyIsIG1fYmFja0ZvcndhcmRMaXN0LT5sb2dnaW5nU3Ry aW5nKCkpOwogICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoTG9hZGluZywgImRpZENvbW1pdExv YWRGb3JGcmFtZTogd2ViUElEID0gJWksIHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0g JSIgUFJJdTY0LCBtX3Byb2Nlc3MtPnByb2Nlc3NJZGVudGlmaWVyKCksIG1fcGFnZUlELCBmcmFt ZUlEKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAppbmRleCAyYTUzOWY1 NTRkNjExZGRjN2UyNjkyZGVlZWM1NzNhYmI1MWUyODU2Li5lMmYyYWY1ZWM4NjQ4N2M3NzY1ZWJh MjE5Yzk2ZDNhODRkZDM1YTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku aApAQCAtMjMxMiw3ICsyMzEyLDYgQEAgcHJpdmF0ZToKICAgICBXZWJDb3JlOjpTY3JvbGxQaW5u aW5nQmVoYXZpb3IgbV9zY3JvbGxQaW5uaW5nQmVoYXZpb3IgeyBXZWJDb3JlOjpEb05vdFBpbiB9 OwogICAgIE9wdGlvbmFsPFdlYkNvcmU6OlNjcm9sbGJhck92ZXJsYXlTdHlsZT4gbV9zY3JvbGxi YXJPdmVybGF5U3R5bGU7CiAKLSAgICB1aW50NjRfdCBtX25hdmlnYXRpb25JRCB7IDAgfTsKICAg ICBBY3Rpdml0eVN0YXRlQ2hhbmdlSUQgbV9jdXJyZW50QWN0aXZpdHlTdGF0ZUNoYW5nZUlEIHsg QWN0aXZpdHlTdGF0ZUNoYW5nZUFzeW5jaHJvbm91cyB9OwogCiAgICAgV2ViUHJlZmVyZW5jZXNT dG9yZTo6VmFsdWVNYXAgbV9jb25maWd1cmF0aW9uUHJlZmVyZW5jZVZhbHVlczsK