195188 2019-02-28 15:17:23 -0800 Use-after-move in RenderCombineText::combineTextIfNeeded() 2019-02-28 15:42:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino jonlee simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1511149 0 mmaxfield 2019-02-28 15:17:23 -0800 Use-after-move in RenderCombineText::combineTextIfNeeded() 1511152 1 363266 mmaxfield 2019-02-28 15:20:22 -0800 Created attachment 363266 Patch 1511154 2 zalan 2019-02-28 15:24:21 -0800 great to have a WTFMove in a loop 1511157 3 mmaxfield 2019-02-28 15:26:01 -0800 <rdar://problem/48488423> 1511164 4 363266 commit-queue 2019-02-28 15:42:28 -0800 Comment on attachment 363266 Patch Clearing flags on attachment: 363266 Committed r242237: <https://trac.webkit.org/changeset/242237> 1511165 5 commit-queue 2019-02-28 15:42:30 -0800 All reviewed patches have been landed. Closing bug. 363266 2019-02-28 15:20:22 -0800 2019-02-28 15:42:28 -0800 Patch bug-195188-20190228152021.patch text/plain 6377 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjcxOWRlODM2NWE1NjE1 YmM1MDNjZGMyMGNmNDA0ZmRlN2M5NmQ3OC4uMThmNDg1OWNlMDdiZDBiNGM5YTM0MjY0NWEyZGY1 MDYxMDMzMTYxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE5LTAyLTI4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlLWFmdGVy LW1vdmUgaW4gUmVuZGVyQ29tYmluZVRleHQ6OmNvbWJpbmVUZXh0SWZOZWVkZWQoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MTg4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjI0MTI4OCB1bmNvdmVy ZWQgYW4gZXhpc3RpbmcgcHJvYmxlbSB3aXRoIG91ciB0ZXh0LWNvbWJpbmUgY29kZS4gcjI0MjIw NCBhbGxldmlhdGVkIHRoZQorICAgICAgICBzeW1wdG9tLCBidXQgdGhpcyBwYXRjaCBmaXhlcyB0 aGUgc291cmNlIG9mIHRoZSBwcm9ibGVtIChhbmQgcmV2ZXJ0cyByMjQyMjA0KS4KKworICAgICAg ICBUaGUgY29kZSBpbiBSZW5kZXJDb21iaW5lVGV4dDo6Y29tYmluZVRleHRJZk5lZWRlZCgpIGhh cyBhIGJpdCB0aGF04oCZcyBsaWtlOgorCisgICAgICAgIEZvbnREZXNjcmlwdGlvbiBiZXN0Rml0 RGVzY3JpcHRpb247CisgICAgICAgIHdoaWxlICguLi4pIHsKKyAgICAgICAgICAgIEZvbnRDYXNj YWRlIGNvbXByZXNzZWRGb250KFdURk1vdmUoYmVzdEZpdERlc2NyaXB0aW9uKSwgLi4uKTsKKyAg ICAgICAgICAgIC4uLgorICAgICAgICB9CisKKyAgICAgICAgQ2xlYXJseSB0aGlzIGlzIHdyb25n LgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC90ZXh0LWNvbWJpbmUtY3Jhc2gtMi5odG1sCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250RGVzY3JpcHRpb25Db2NvYS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGb250RGVzY3JpcHRpb246OnBsYXRmb3JtUmVzb2x2ZUdl bmVyaWNGYW1pbHkpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJDb21iaW5lVGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJDb21iaW5lVGV4dDo6Y29tYmluZVRleHRJZk5lZWRl ZCk6CisKIDIwMTktMDItMjggIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAog ICAgICAgICBFbmFibGUgdGhlIFBvaW50ZXIgRXZlbnRzIHJ1bnRpbWUgZmxhZyBieSBkZWZhdWx0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250 RGVzY3JpcHRpb25Db2NvYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j b2NvYS9Gb250RGVzY3JpcHRpb25Db2NvYS5jcHAKaW5kZXggNTcyZGYzOWRhNDg5NDk0MjE0MGI3 NGIxNDFmZDI2YzcyNzQwYzUwYi4uOGI5YzQzNDhkNDc0MzM1OGNlZjBiNjU4YTQyZjU4ZmEyZTZj OTc2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2Ev Rm9udERlc2NyaXB0aW9uQ29jb2EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NvY29hL0ZvbnREZXNjcmlwdGlvbkNvY29hLmNwcApAQCAtMTY1LDcgKzE2NSw4IEBA IHN0YXRpYyB2b2lkIGxhbmd1YWdlQ2hhbmdlZCh2b2lkKikKIAogQXRvbWljU3RyaW5nIEZvbnRE ZXNjcmlwdGlvbjo6cGxhdGZvcm1SZXNvbHZlR2VuZXJpY0ZhbWlseShVU2NyaXB0Q29kZSBzY3Jp cHQsIGNvbnN0IEF0b21pY1N0cmluZyYgbG9jYWxlLCBjb25zdCBBdG9taWNTdHJpbmcmIGZhbWls eU5hbWUpCiB7Ci0gICAgaWYgKGxvY2FsZS5pc051bGwoKSB8fCBzY3JpcHQgPT0gVVNDUklQVF9D T01NT04pCisgICAgQVNTRVJUKChsb2NhbGUuaXNOdWxsKCkgJiYgc2NyaXB0ID09IFVTQ1JJUFRf Q09NTU9OKSB8fCAhbG9jYWxlLmlzTnVsbCgpKTsKKyAgICBpZiAoc2NyaXB0ID09IFVTQ1JJUFRf Q09NTU9OKQogICAgICAgICByZXR1cm4gbnVsbEF0b20oKTsKIAogICAgIHN0YXRpYyBzdGQ6Om9u Y2VfZmxhZyBvbmNlRmxhZzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJDb21iaW5lVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ29t YmluZVRleHQuY3BwCmluZGV4IDE1ZjE2MTkxNjhlNzYyNzAyODgwNjc4NTZjZTg2ZjFjMjEyZjRl YTIuLjViMWEyODc0MjVkMDY5MzM3YzA5Zjg1MjkyNzJkMTg0ODRmMTRhNDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJDb21iaW5lVGV4dC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckNvbWJpbmVUZXh0LmNwcApAQCAtMTc0LDcgKzE3 NCw3IEBAIHZvaWQgUmVuZGVyQ29tYmluZVRleHQ6OmNvbWJpbmVUZXh0SWZOZWVkZWQoKQogICAg ICAgICAgICAgYmVzdEZpdERlc2NyaXB0aW9uLnNldENvbXB1dGVkU2l6ZShjb21wdXRlZFNpemUp OwogICAgICAgICAgICAgc2hvdWxkVXBkYXRlRm9udCA9IG1fY29tYmluZUZvbnRTdHlsZS0+c2V0 Rm9udERlc2NyaXB0aW9uKEZvbnRDYXNjYWRlRGVzY3JpcHRpb24geyBiZXN0Rml0RGVzY3JpcHRp b24gfSk7CiAgICAgICAgIAotICAgICAgICAgICAgRm9udENhc2NhZGUgY29tcHJlc3NlZEZvbnQo V1RGTW92ZShiZXN0Rml0RGVzY3JpcHRpb24pLCBzdHlsZSgpLmZvbnRDYXNjYWRlKCkubGV0dGVy U3BhY2luZygpLCBzdHlsZSgpLmZvbnRDYXNjYWRlKCkud29yZFNwYWNpbmcoKSk7CisgICAgICAg ICAgICBGb250Q2FzY2FkZSBjb21wcmVzc2VkRm9udChGb250Q2FzY2FkZURlc2NyaXB0aW9uKGJl c3RGaXREZXNjcmlwdGlvbiksIHN0eWxlKCkuZm9udENhc2NhZGUoKS5sZXR0ZXJTcGFjaW5nKCks IHN0eWxlKCkuZm9udENhc2NhZGUoKS53b3JkU3BhY2luZygpKTsKICAgICAgICAgICAgIGNvbXBy ZXNzZWRGb250LnVwZGF0ZShmb250U2VsZWN0b3IpOwogICAgICAgICAgICAgCiAgICAgICAgICAg ICBnbHlwaE92ZXJmbG93LmxlZnQgPSBnbHlwaE92ZXJmbG93LnRvcCA9IGdseXBoT3ZlcmZsb3cu cmlnaHQgPSBnbHlwaE92ZXJmbG93LmJvdHRvbSA9IDA7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzgxYzk4NTQyNWRiZTUw NWI4OTc3NTMzMjgyMzkzOTFhZGYwOWY5Ni4uNWI5MDU1YzQ5YzIyZWViZThiYjU5YTc5ODg5YTQ4 MmNmNTZiYTlmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTI4ICBNeWxlcyBDLiBN YXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlLWFmdGVyLW1vdmUg aW4gUmVuZGVyQ29tYmluZVRleHQ6OmNvbWJpbmVUZXh0SWZOZWVkZWQoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MTg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvdGV4dC1jb21i aW5lLWNyYXNoLTItZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC90ZXh0L3Rl eHQtY29tYmluZS1jcmFzaC0yLmh0bWw6IEFkZGVkLgorCiAyMDE5LTAyLTI4ICBEZXZpbiBSb3Vz c28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjQwNjQ0KTog TGF5b3V0IFRlc3QgaW5zcGVjdG9yL3BhZ2Uvb3ZlcnJpZGVTZXR0aW5nLUlDRUNhbmRpZGF0ZUZp bHRlcmluZ0VuYWJsZWQuaHRtbCBpcyBhIGZsYWt5IHRpbWVvdXQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvdGV4dC90ZXh0LWNvbWJpbmUtY3Jhc2gtMi1leHBlY3RlZC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC90ZXh0L3RleHQtY29tYmluZS1jcmFzaC0yLWV4cGVjdGVkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNTkzNmQ3ZThmZTJlMjBiYjNmMGRjZTRlMGRlZjk2MjM0YWYwMDQ5NwotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC90ZXh0LWNvbWJpbmUtY3Jhc2gtMi1l eHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMzMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWwgbGFu Zz0iamEiPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8L2hlYWQ+Cis8Ym9keT4K K1RoaXMgdGVzdCBwYXNzZXMgaWYgdGhlcmUgaXMgbm8gY3Jhc2guCis8cCB4bWxucz0iaHR0cDov L3d3dy53My5vcmcvMTk5OS94aHRtbCIgc3R5bGU9Ii13ZWJraXQtZm9udC1zbW9vdGhpbmc6IHN1 YnBpeGVsLWFudGlhbGlhc2VkOworLXdlYmtpdC1oeXBoZW5hdGUtbGltaXQtYWZ0ZXI6IDM7Cist d2Via2l0LWh5cGhlbmF0ZS1saW1pdC1iZWZvcmU6IDM7Cistd2Via2l0LWh5cGhlbmF0ZS1saW1p dC1saW5lczogMjsKKy13ZWJraXQtaHlwaGVuczogYXV0bzsKKy13ZWJraXQtbGluZS1ib3gtY29u dGFpbjogYmxvY2sgaW5saW5lIHJlcGxhY2VkOworLXdlYmtpdC1sb2NhbGU6IGphOworZGlzcGxh eTogYmxvY2s7Citmb250LWZhbWlseTogc2VyaWY7Citmb250LXNpemU6IDIyLjM5OTk5OTYxODUz MDI3M3B4OworaGVpZ2h0OiA2MzZweDsKK2xpbmUtYnJlYWs6IHN0cmljdDsKK21hcmdpbi1ib3R0 b206IDBweDsKK21hcmdpbi1sZWZ0OiAwcHg7CittYXJnaW4tcmlnaHQ6IDBweDsKK21hcmdpbi10 b3A6IDBweDsKK29ycGhhbnM6IDI7Cit0ZXh0LWFsaWduOiBzdGFydDsKK3RleHQtaW5kZW50OiAy Mi4zOTk5OTk2MTg1MzAyNzNweDsKK3RleHQtcmVuZGVyaW5nOiBhdXRvOword2lkb3dzOiAyOwor d2lkdGg6IDMzcHg7Cit3b3JkLXdyYXA6IGJyZWFrLXdvcmQ7Cit3cml0aW5nLW1vZGU6IHZlcnRp Y2FsLXJsOyI+5Zub5qGB5paH5a2XPHNwYW4gY2xhc3M9InRjeSIgc3R5bGU9Ii1lcHViLXRleHQt Y29tYmluZTogICBob3Jpem9udGFsOyI+QUJDRDwvc3Bhbj48L3A+Cis8L2JvZHk+Cis8L2h0bWw+ CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQvdGV4dC1jb21iaW5lLWNyYXNoLTIu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC90ZXh0LWNvbWJpbmUtY3Jhc2gtMi5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjU5MzZkN2U4ZmUyZTIwYmIzZjBkY2U0ZTBkZWY5NjIzNGFmMDA0OTcKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvdGV4dC1jb21iaW5lLWNyYXNoLTIu aHRtbApAQCAtMCwwICsxLDMzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sIGxhbmc9ImphIj4K KzxoZWFkPgorPG1ldGEgY2hhcnNldD0idXRmLTgiPgorPC9oZWFkPgorPGJvZHk+CitUaGlzIHRl c3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoLgorPHAgeG1sbnM9Imh0dHA6Ly93d3cudzMu b3JnLzE5OTkveGh0bWwiIHN0eWxlPSItd2Via2l0LWZvbnQtc21vb3RoaW5nOiBzdWJwaXhlbC1h bnRpYWxpYXNlZDsKKy13ZWJraXQtaHlwaGVuYXRlLWxpbWl0LWFmdGVyOiAzOworLXdlYmtpdC1o eXBoZW5hdGUtbGltaXQtYmVmb3JlOiAzOworLXdlYmtpdC1oeXBoZW5hdGUtbGltaXQtbGluZXM6 IDI7Cistd2Via2l0LWh5cGhlbnM6IGF1dG87Cistd2Via2l0LWxpbmUtYm94LWNvbnRhaW46IGJs b2NrIGlubGluZSByZXBsYWNlZDsKKy13ZWJraXQtbG9jYWxlOiBqYTsKK2Rpc3BsYXk6IGJsb2Nr OworZm9udC1mYW1pbHk6IHNlcmlmOworZm9udC1zaXplOiAyMi4zOTk5OTk2MTg1MzAyNzNweDsK K2hlaWdodDogNjM2cHg7CitsaW5lLWJyZWFrOiBzdHJpY3Q7CittYXJnaW4tYm90dG9tOiAwcHg7 CittYXJnaW4tbGVmdDogMHB4OworbWFyZ2luLXJpZ2h0OiAwcHg7CittYXJnaW4tdG9wOiAwcHg7 CitvcnBoYW5zOiAyOwordGV4dC1hbGlnbjogc3RhcnQ7Cit0ZXh0LWluZGVudDogMjIuMzk5OTk5 NjE4NTMwMjczcHg7Cit0ZXh0LXJlbmRlcmluZzogYXV0bzsKK3dpZG93czogMjsKK3dpZHRoOiAz M3B4Oword29yZC13cmFwOiBicmVhay13b3JkOword3JpdGluZy1tb2RlOiB2ZXJ0aWNhbC1ybDsi PuWbm+ahgeaWh+WtlzxzcGFuIGNsYXNzPSJ0Y3kiIHN0eWxlPSItZXB1Yi10ZXh0LWNvbWJpbmU6 ICAgaG9yaXpvbnRhbDsiPkFCQ0Q8L3NwYW4+PC9wPgorPC9ib2R5PgorPC9odG1sPgo=