195187 2019-02-28 15:07:52 -0800 Change CheckedArithmetic to not use std::enable_if_t. 2019-06-20 21:17:30 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199099 InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo dbates ews-watchlist fujii ggaren keith_miller webkit-bug-importer oldest_to_newest 1511145 0 mark.lam 2019-02-28 15:07:52 -0800 Because C++11 does not like std::enable_if_t and there's a need to use this file with C++11. 1511146 1 mark.lam 2019-02-28 15:09:27 -0800 <rdar://problem/48464665> 1511153 2 363267 mark.lam 2019-02-28 15:22:32 -0800 Created attachment 363267 proposed patch. 1511155 3 363267 keith_miller 2019-02-28 15:24:28 -0800 Comment on attachment 363267 proposed patch. r=me 1511159 4 mark.lam 2019-02-28 15:33:30 -0800 Thanks for the review. Landed in r242235: <http://trac.webkit.org/r242235>. 363267 2019-02-28 15:22:32 -0800 2019-02-28 15:24:28 -0800 proposed patch. bug-195187.patch text/plain 2856 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDIyMzMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTI4ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgQ2hlY2tlZEFyaXRobWV0aWMgdG8gbm90IHVz ZSBzdGQ6OmVuYWJsZV9pZl90LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk1MTg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODQ2NDY2NT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCZWNhdXNlIEMr KzExIGRvZXMgbm90IGxpa2Ugc3RkOjplbmFibGVfaWZfdCBhbmQgdGhlcmUncyBhIG5lZWQgdG8g dXNlIHRoaXMgZmlsZSB3aXRoIEMrKzExLgorCisgICAgICAgICogd3RmL0NoZWNrZWRBcml0aG1l dGljLmg6CisKIDIwMTktMDItMjcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgUm9sbCBvdXQgcjI0MjAxNDsgaXQgY2F1c2VkIGNyYXNoZXMgaW4gY29t cG9zaXRpbmcgbG9nZ2luZyAod2Via2l0Lm9yZy9iLzE5NTE0MSkKSW5kZXg6IFNvdXJjZS9XVEYv d3RmL0NoZWNrZWRBcml0aG1ldGljLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQ2hl Y2tlZEFyaXRobWV0aWMuaAkocmV2aXNpb24gMjQyMjI0KQorKysgU291cmNlL1dURi93dGYvQ2hl Y2tlZEFyaXRobWV0aWMuaAkod29ya2luZyBjb3B5KQpAQCAtNTQxLDcgKzU0MSw3IEBAIHRlbXBs YXRlIDx0eXBlbmFtZSBSZXN1bHRUeXBlPiBzdHJ1Y3QgQXIKICAgICB9CiB9OwogCi10ZW1wbGF0 ZSA8Y2xhc3MgT3ZlcmZsb3dIYW5kbGVyLCB0eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8IXN0 ZDo6aXNfc2NhbGFyPE92ZXJmbG93SGFuZGxlcj46OnZhbHVlPj4KK3RlbXBsYXRlIDxjbGFzcyBP dmVyZmxvd0hhbmRsZXIsIHR5cGVuYW1lID0gdHlwZW5hbWUgc3RkOjplbmFibGVfaWY8IXN0ZDo6 aXNfc2NhbGFyPE92ZXJmbG93SGFuZGxlcj46OnZhbHVlPjo6dHlwZT4KIGlubGluZSBjb25zdGV4 cHIgYm9vbCBvYnNlcnZlc092ZXJmbG93KCkgeyByZXR1cm4gdHJ1ZTsgfQogCiB0ZW1wbGF0ZSA8 PgpAQCAtNTUzLDcgKzU1Myw3IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0 eXBlbmEKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotdGVtcGxhdGUgPGNsYXNzIE92ZXJmbG93SGFu ZGxlciwgdHlwZW5hbWUgVSwgdHlwZW5hbWUgViwgdHlwZW5hbWUgUiwgdHlwZW5hbWUgPSBzdGQ6 OmVuYWJsZV9pZl90PCFzdGQ6OmlzX3NjYWxhcjxPdmVyZmxvd0hhbmRsZXI+Ojp2YWx1ZT4+Cit0 ZW1wbGF0ZSA8Y2xhc3MgT3ZlcmZsb3dIYW5kbGVyLCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0 eXBlbmFtZSBSLCB0eXBlbmFtZSA9IHR5cGVuYW1lIHN0ZDo6ZW5hYmxlX2lmPCFzdGQ6OmlzX3Nj YWxhcjxPdmVyZmxvd0hhbmRsZXI+Ojp2YWx1ZT46OnR5cGU+CiBzdGF0aWMgaW5saW5lIGJvb2wg c2FmZUFkZChVIGxocywgViByaHMsIFImIHJlc3VsdCkKIHsKICAgICBpZiAob2JzZXJ2ZXNPdmVy ZmxvdzxPdmVyZmxvd0hhbmRsZXI+KCkpCkBAIC01NjcsNyArNTY3LDcgQEAgdGVtcGxhdGUgPHR5 cGVuYW1lIFUsIHR5cGVuYW1lIFYsIHR5cGVuYQogICAgIHJldHVybiBBcml0aG1ldGljT3BlcmF0 aW9uczxVLCBWLCBSPjo6c3ViKGxocywgcmhzLCByZXN1bHQpOwogfQogCi10ZW1wbGF0ZSA8Y2xh c3MgT3ZlcmZsb3dIYW5kbGVyLCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0eXBlbmFtZSBSLCB0 eXBlbmFtZSA9IHN0ZDo6ZW5hYmxlX2lmX3Q8IXN0ZDo6aXNfc2NhbGFyPE92ZXJmbG93SGFuZGxl cj46OnZhbHVlPj4KK3RlbXBsYXRlIDxjbGFzcyBPdmVyZmxvd0hhbmRsZXIsIHR5cGVuYW1lIFUs IHR5cGVuYW1lIFYsIHR5cGVuYW1lIFIsIHR5cGVuYW1lID0gdHlwZW5hbWUgc3RkOjplbmFibGVf aWY8IXN0ZDo6aXNfc2NhbGFyPE92ZXJmbG93SGFuZGxlcj46OnZhbHVlPjo6dHlwZT4KIHN0YXRp YyBpbmxpbmUgYm9vbCBzYWZlU3ViKFUgbGhzLCBWIHJocywgUiYgcmVzdWx0KQogewogICAgIGlm IChvYnNlcnZlc092ZXJmbG93PE92ZXJmbG93SGFuZGxlcj4oKSkKQEAgLTU4MSw3ICs1ODEsNyBA QCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVSwgdHlwZW5hbWUgViwgdHlwZW5hCiAgICAgcmV0dXJuIEFy aXRobWV0aWNPcGVyYXRpb25zPFUsIFYsIFI+OjptdWx0aXBseShsaHMsIHJocywgcmVzdWx0KTsK IH0KIAotdGVtcGxhdGUgPGNsYXNzIE92ZXJmbG93SGFuZGxlciwgdHlwZW5hbWUgVSwgdHlwZW5h bWUgViwgdHlwZW5hbWUgUiwgdHlwZW5hbWUgPSBzdGQ6OmVuYWJsZV9pZl90PCFzdGQ6OmlzX3Nj YWxhcjxPdmVyZmxvd0hhbmRsZXI+Ojp2YWx1ZT4+Cit0ZW1wbGF0ZSA8Y2xhc3MgT3ZlcmZsb3dI YW5kbGVyLCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0eXBlbmFtZSBSLCB0eXBlbmFtZSA9IHR5 cGVuYW1lIHN0ZDo6ZW5hYmxlX2lmPCFzdGQ6OmlzX3NjYWxhcjxPdmVyZmxvd0hhbmRsZXI+Ojp2 YWx1ZT46OnR5cGU+CiBzdGF0aWMgaW5saW5lIGJvb2wgc2FmZU11bHRpcGx5KFUgbGhzLCBWIHJo cywgUiYgcmVzdWx0KQogewogICAgIGlmIChvYnNlcnZlc092ZXJmbG93PE92ZXJmbG93SGFuZGxl cj4oKSkK