195185 2019-02-28 14:17:15 -0800 [ContentChangeObserver] Make observed state reset explicit. 2019-02-28 14:29:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1511110 0 zalan 2019-02-28 14:17:15 -0800 ssia 1511112 1 webkit-bug-importer 2019-02-28 14:17:45 -0800 <rdar://problem/48488342> 1511118 2 363260 zalan 2019-02-28 14:21:55 -0800 Created attachment 363260 Patch 1511119 3 363260 simon.fraser 2019-02-28 14:24:39 -0800 Comment on attachment 363260 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363260&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:252 > // Force reset the content change flag when the last observed content modifier is removed. We should not be in indeterminate state anymore. in an indeterminate state 1511122 4 zalan 2019-02-28 14:29:57 -0800 Committed r242227: <https://trac.webkit.org/changeset/242227> 363260 2019-02-28 14:21:55 -0800 2019-02-28 14:24:39 -0800 Patch bug-195185-20190228142154.patch text/plain 3105 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNhZjY4ZDY0ZmViZDJj YTQ5OWY2ZGVkMmI4ZTcxNjU5NGEwMWJhMi4uN2FhMmY4YTJhOTExYWI3ZmYzMDU5MGJmZTM3M2Zm MTRkNDdiNjZjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAyLTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNl cnZlcl0gTWFrZSBvYnNlcnZlZCBzdGF0ZSByZXNldCBleHBsaWNpdC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTE4NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDg0ODgzNDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIHNldE9ic2VydmVkQ29udGVudENoYW5nZSBvbmx5IGZvciBzZXR0aW5n IHRoZSBvYnNlcnZlZCBjaGFuZ2Ugd2hpbGUgb2JzZXJ2aW5nLgorCisgICAgICAgICogcGFnZS9p b3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRD aGFuZ2VPYnNlcnZlcjo6c3RhcnRPYnNlcnZpbmdDb250ZW50Q2hhbmdlcyk6CisgICAgICAgIChX ZWJDb3JlOjpDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OnJlc2V0T2JzZXJ2ZWRDb250ZW50Q2hhbmdl KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRDaGFuZ2VPYnNlcnZlcjo6cmVtb3ZlT2JzZXJ2 ZWRET01UaW1lcik6CisgICAgICAgICogcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmg6 CisKIDIwMTktMDItMjggIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDIyMTAuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmNwcAppbmRleCA0NmY4NmY4 YWU1OGNmOTFjZGFhMTNjNzdkMGYxNjU0Yjk4YzJmMDQ2Li4yYTZjMjEzNWZmZjVkYjU1MWJhYzM3 NWMyMDkxODRhOTU2NjIwZTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9D b250ZW50Q2hhbmdlT2JzZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0Nv bnRlbnRDaGFuZ2VPYnNlcnZlci5jcHAKQEAgLTE1MCw3ICsxNTAsNyBAQCB2b2lkIENvbnRlbnRD aGFuZ2VPYnNlcnZlcjo6d2lsbERldGFjaFBhZ2UoKQogdm9pZCBDb250ZW50Q2hhbmdlT2JzZXJ2 ZXI6OnN0YXJ0T2JzZXJ2aW5nQ29udGVudENoYW5nZXMoKQogewogICAgIHN0YXJ0T2JzZXJ2aW5n RE9NVGltZXJTY2hlZHVsaW5nKCk7Ci0gICAgc2V0T2JzZXJ2ZWRDb250ZW50Q2hhbmdlKFdLQ29u dGVudE5vQ2hhbmdlKTsKKyAgICByZXNldE9ic2VydmVkQ29udGVudENoYW5nZSgpOwogICAgIG1f b2JzZXJ2aW5nQ29udGVudENoYW5nZXMgPSB0cnVlOwogfQogCkBAIC0yMjEsNiArMjIxLDExIEBA IHZvaWQgQ29udGVudENoYW5nZU9ic2VydmVyOjpjbGVhck9ic2VydmVkRE9NVGltZXJzKCkKICAg ICBtX0RPTVRpbWVyTGlzdC5jbGVhcigpOwogfQogCit2b2lkIENvbnRlbnRDaGFuZ2VPYnNlcnZl cjo6cmVzZXRPYnNlcnZlZENvbnRlbnRDaGFuZ2UoKQoreworICAgIFdLU2V0T2JzZXJ2ZWRDb250 ZW50Q2hhbmdlKFdLQ29udGVudE5vQ2hhbmdlKTsKK30KKwogdm9pZCBDb250ZW50Q2hhbmdlT2Jz ZXJ2ZXI6OnNldE9ic2VydmVkQ29udGVudENoYW5nZShXS0NvbnRlbnRDaGFuZ2UgY2hhbmdlKQog ewogICAgIGlmIChvYnNlcnZlZENvbnRlbnRDaGFuZ2UoKSA9PSBXS0NvbnRlbnRWaXNpYmlsaXR5 Q2hhbmdlKQpAQCAtMjQ2LDcgKzI1MSw3IEBAIHZvaWQgQ29udGVudENoYW5nZU9ic2VydmVyOjpy ZW1vdmVPYnNlcnZlZERPTVRpbWVyKGNvbnN0IERPTVRpbWVyJiB0aW1lcikKICAgICBtX0RPTVRp bWVyTGlzdC5yZW1vdmUoJnRpbWVyKTsKICAgICAvLyBGb3JjZSByZXNldCB0aGUgY29udGVudCBj aGFuZ2UgZmxhZyB3aGVuIHRoZSBsYXN0IG9ic2VydmVkIGNvbnRlbnQgbW9kaWZpZXIgaXMgcmVt b3ZlZC4gV2Ugc2hvdWxkIG5vdCBiZSBpbiBpbmRldGVybWluYXRlIHN0YXRlIGFueW1vcmUuCiAg ICAgaWYgKCFjb3VudE9mT2JzZXJ2ZWRET01UaW1lcnMoKSAmJiBvYnNlcnZlZENvbnRlbnRDaGFu Z2UoKSA9PSBXS0NvbnRlbnRJbmRldGVybWluYXRlQ2hhbmdlKQotICAgICAgICBzZXRPYnNlcnZl ZENvbnRlbnRDaGFuZ2UoV0tDb250ZW50Tm9DaGFuZ2UpOworICAgICAgICByZXNldE9ic2VydmVk Q29udGVudENoYW5nZSgpOwogfQogCiBzdGF0aWMgVmlzaWJpbGl0eSBlbGVtZW50SW1wbGljaXRW aXNpYmlsaXR5KGNvbnN0IEVsZW1lbnQmIGVsZW1lbnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5oCmluZGV4IGQ2Nzk1ZGY2OWQ3MzYyY2UzNjcw ZjcyNTFjY2M1MjI4NmM0ZWNkZjcuLmZjODdkODNiMzVmYjlhODYxM2ExZjI5M2JiYmZjMDNmZDMw OWJjOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VP YnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNl cnZlci5oCkBAIC04Nyw2ICs4Nyw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBpc09ic2VydmluZ1N0 eWxlUmVjYWxjU2NoZWR1bGluZygpOwogCiAgICAgdm9pZCBzZXRPYnNlcnZlZENvbnRlbnRDaGFu Z2UoV0tDb250ZW50Q2hhbmdlKTsKKyAgICB2b2lkIHJlc2V0T2JzZXJ2ZWRDb250ZW50Q2hhbmdl KCk7CiAKICAgICB1bnNpZ25lZCBjb3VudE9mT2JzZXJ2ZWRET01UaW1lcnMoKTsKICAgICB2b2lk IGNsZWFyT2JzZXJ2ZWRET01UaW1lcnMoKTsK