195181 2019-02-28 12:29:41 -0800 cloop.rb shift mask should depend on the word size being shifted. 2019-07-17 05:58:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller mitya57 msaboff ryanhaddad saam webkit-bug-importer ysuzuki oldest_to_newest 1511057 0 mark.lam 2019-02-28 12:29:41 -0800 Previously, we're always masking the shift amount with 0x1f. This only works for 32-bit words. For 64-bit words, the mask should be 0x3f. For intptr_t shifts, the mask depends on sizeof(uintptr_t). 1511058 1 webkit-bug-importer 2019-02-28 12:30:06 -0800 <rdar://problem/48484164> 1511060 2 363250 mark.lam 2019-02-28 12:35:11 -0800 Created attachment 363250 proposed patch. 1511070 3 363250 ysuzuki 2019-02-28 12:45:10 -0800 Comment on attachment 363250 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=363250&action=review r=me > Source/JavaScriptCore/offlineasm/cloop.rb:429 > + shiftMask = "((sizeof(uintptr_t) == 8) ? 0x3f : 0x1f)" if type == :int || type == :uint Discussed with Mark. The type ":int" and ":uint" actually means "intptr_t" and "uintptr_t". Then this is correct. It is nice if we have either of 1. Add a comment about it here now, and rename ":int" => ":intPtr" or something like that in a subsequent patch. 2. Rename them in this patch too. 1511073 4 mark.lam 2019-02-28 12:49:35 -0800 Thanks for the review. I added the FIXME. Landed in r242215: <http://trac.webkit.org/r242215>. 1511075 5 mark.lam 2019-02-28 12:51:16 -0800 *** Bug 195175 has been marked as a duplicate of this bug. *** 1553497 6 berto 2019-07-17 05:58:56 -0700 *** Bug 199684 has been marked as a duplicate of this bug. *** 363250 2019-02-28 12:35:11 -0800 2019-02-28 12:45:10 -0800 proposed patch. bug-195181.patch text/plain 2110 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQyMjEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTAyLTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBj bG9vcC5yYiBzaGlmdCBtYXNrIHNob3VsZCBkZXBlbmQgb24gdGhlIHdvcmQgc2l6ZSBiZWluZyBz aGlmdGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk1MTgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODQ4NDE2ND4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5LCB3ZSdyZSBhbHdh eXMgbWFza2luZyB0aGUgc2hpZnQgYW1vdW50IHdpdGggMHgxZi4gIFRoaXMgaXMgb25seSBjb3Jy ZWN0CisgICAgICAgIGZvciAzMi1iaXQgd29yZHMuICBGb3IgNjQtYml0IHdvcmRzLCB0aGUgbWFz ayBzaG91bGQgYmUgMHgzZi4gIEZvciBwb2ludGVyIHNpemVkCisgICAgICAgIHNoaWZ0cywgdGhl IG1hc2sgZGVwZW5kcyBvbiBzaXplb2YodWludHB0cl90KS4KKworICAgICAgICAqIG9mZmxpbmVh c20vY2xvb3AucmI6CisKIDIwMTktMDItMjggIEp1c3RpbiBGYW4gIDxqdXN0aW5fZmFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbV2ViIEdQVV0gRW5hYmxlIFdlYiBHUFUgb25seSBvbiA2NC1iaXQK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiCShyZXZpc2lv biAyNDIyMDEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgko d29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChDKSAyMDEyLTIwMTgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTItMjAx OSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKQEAgLTQyNiw3ICs0MjYsMTAgQEAgZGVmIGNsb29wRW1pdFNoaWZ0T3BlcmF0aW9uKG9w ZXJhbmRzLCB0eQogICAgICAgICB0cnVuY2F0aW9uSGVhZGVyID0gIiIKICAgICAgICAgdHJ1bmNh dGlvbkZvb3RlciA9ICIiCiAgICAgZW5kCi0gICAgJGFzbS5wdXRjICIje2RzdC5jbExWYWx1ZSh0 eXBlKX0gPSAje3RydW5jYXRpb25IZWFkZXJ9I3tvcGVyYW5kc1sxXS5jbFZhbHVlKHR5cGUpfSAj e29wZXJhdG9yfSAoI3tvcGVyYW5kc1swXS5jbFZhbHVlKDppbnQpfSAmIDB4MWYpI3t0cnVuY2F0 aW9uRm9vdGVyfTsiCisgICAgc2hpZnRNYXNrID0gIigoc2l6ZW9mKHVpbnRwdHJfdCkgPT0gOCkg PyAweDNmIDogMHgxZikiIGlmIHR5cGUgPT0gOmludCB8fCB0eXBlID09IDp1aW50CisgICAgc2hp ZnRNYXNrID0gIjB4M2YiIGlmIHR5cGUgPT0gOmludDY0IHx8IHR5cGUgPT0gOnVpbnQ2NAorICAg IHNoaWZ0TWFzayA9ICIweDFmIiBpZiB0eXBlID09IDppbnQzMiB8fCB0eXBlID09IDp1aW50MzIK KyAgICAkYXNtLnB1dGMgIiN7ZHN0LmNsTFZhbHVlKHR5cGUpfSA9ICN7dHJ1bmNhdGlvbkhlYWRl cn0je29wZXJhbmRzWzFdLmNsVmFsdWUodHlwZSl9ICN7b3BlcmF0b3J9ICgje29wZXJhbmRzWzBd LmNsVmFsdWUoOmludCl9ICYgI3tzaGlmdE1hc2t9KSN7dHJ1bmNhdGlvbkZvb3Rlcn07IgogZW5k CiAKIGRlZiBjbG9vcEVtaXRVbmFyeU9wZXJhdGlvbihvcGVyYW5kcywgdHlwZSwgb3BlcmF0b3Ip Cg==