195160 2019-02-28 05:55:23 -0800 Several PasteImage API tests are flaky 2019-02-28 12:53:18 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain wenson_hsieh aakash_jain ap bdakin commit-queue lforschler rniwa thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1510909 0 aakash_jain 2019-02-28 05:55:23 -0800 TestWebKitAPI.PasteImage.PastePNGFile seems flaky. In https://ews-build.webkit-uat.org/#/builders/19/builds/1307, the test Passed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it failed. 1510921 1 wenson_hsieh 2019-02-28 07:29:11 -0800 Unlike PasteImage.PasteTIFFImage, this one is timing out. It looks like this one might be racy, since it inserts the image and then registers a "load" event handler. If the image fires a load event /before/ the handler is registered, we'll end up waiting forever for image load. Seems like this should probably use -waitForMessage:afterEvaluatingScript: instead, which first registers the handler and then evaluates script. 1510933 2 wenson_hsieh 2019-02-28 08:53:22 -0800 *** Bug 195157 has been marked as a duplicate of this bug. *** 1510934 3 363224 wenson_hsieh 2019-02-28 08:53:57 -0800 Created attachment 363224 Patch 1511076 4 363224 commit-queue 2019-02-28 12:52:54 -0800 Comment on attachment 363224 Patch Clearing flags on attachment: 363224 Committed r242216: <https://trac.webkit.org/changeset/242216> 1511077 5 commit-queue 2019-02-28 12:52:56 -0800 All reviewed patches have been landed. Closing bug. 1511079 6 webkit-bug-importer 2019-02-28 12:53:18 -0800 <rdar://problem/48484916> 363224 2019-02-28 08:53:57 -0800 2019-02-28 12:52:54 -0800 Patch bug-195160-20190228085356.patch text/plain 5438 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMDExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGZiYjgyZTNkNzE0ZDhhMDM1Y2VlZGUwZjJiYjU3ODc1 YWJhZjNiNy4uZmE2NGZiZjI4ZmIwNjZmNGZiOTJjNmU4YzIzNThkM2U0ODU5MmM3MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTAyLTI4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFNldmVyYWwgUGFzdGVJbWFnZSBBUEkgdGVzdHMgYXJlIGZsYWt5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUxNjAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIG9mIHRoZXNlIHRl c3RzLCBzdWNoIGFzIFBhc3RlVElGRkltYWdlLCBkb24ndCB3YWl0IGZvciB0aGUgaW5zZXJ0ZWQg aW1hZ2UgZWxlbWVudCB0byBmaW5pc2ggbG9hZGluZyBiZWZvcmUKKyAgICAgICAgcXVlcnlpbmcg dGhlIGltYWdlIGVsZW1lbnQncyBzaXplOyBhIGZldyBvdGhlciB0ZXN0cywgc3VjaCBhcyBQYXN0 ZVBOR0ZpbGUsIGFyZSByYWN5IHNpbmNlIHRoZXkgbWF5IGJlZ2luCisgICAgICAgIGxpc3Rlbmlu ZyBmb3IgYSAibG9hZCIgZXZlbnQgYWZ0ZXIgaW1hZ2UgbG9hZCBpcyBhbHJlYWR5IGNvbXBsZXRl LgorCisgICAgICAgIFRvIGFkZHJlc3MgdGhpcywgbWFrZSB0aGVzZSB0ZXN0cyBmaXJzdCByZWdp c3RlciBhICJsb2FkIiBldmVudCBoYW5kbGVyLCB0aGVuIHJ1biBzY3JpcHQgdG8gaW5zZXJ0IGFu IGltYWdlCisgICAgICAgIGVsZW1lbnQgaW50byB0aGUgZG9jdW1lbnQsIGFuZCBmaW5hbGx5IHdh aXQgdW50aWwgdGhlIGxvYWQgZXZlbnQgaXMgb2JzZXJ2ZWQgYmVmb3JlIGNoZWNraW5nIGltYWdl IHNpemUuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Bhc3Rl SW1hZ2UubW06CisKIDIwMTktMDItMjMgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIG5ldyBtYWMgdGFyZ2V0IG51bWJlcnMKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUGFzdGVJbWFnZS5tbSBiL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUGFzdGVJbWFnZS5tbQppbmRleCA2 M2M3NTViZGNjMmM1YTE1OGI2ZDMyZjMzYzMzZGMzODA3MDZhNzk4Li5lMTAyYTZhZDZjMmEwZjdj NGRjMjI4YWI5NmRjYThhMzM0NGI4M2M5IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL1Bhc3RlSW1hZ2UubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRDb2NvYS9QYXN0ZUltYWdlLm1tCkBAIC0xNjAsOCArMTYwLDcgQEAgVEVT VChQYXN0ZUltYWdlLCBQYXN0ZUdJRkZpbGUpCiAgICAgRVhQRUNUX1dLX1NUUkVRKCJzdW5zZXQt aW4tY3VwZXJ0aW5vLTQwMHB4LmdpZiIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHQ6QCJmaWxlLm5hbWUiXSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCIiLCBbd2ViVmlldyBz dHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9yLnRleHRDb250ZW50Il0pOwogCi0g ICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImluc2VydEZpbGVBc0lt YWdlKGZpbGUpIl07Ci0gICAgW3dlYlZpZXcgd2FpdEZvck1lc3NhZ2U6QCJsb2FkZWQiXTsKKyAg ICBbd2ViVmlldyB3YWl0Rm9yTWVzc2FnZTpAImxvYWRlZCIgYWZ0ZXJFdmFsdWF0aW5nU2NyaXB0 OkAiaW5zZXJ0RmlsZUFzSW1hZ2UoZmlsZSkiXTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoImJsb2I6 IiwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAInVybCA9IG5ldyBVUkwo aW1hZ2VFbGVtZW50LnNyYyk7IHVybC5wcm90b2NvbCJdKTsKICAgICBFWFBFQ1RfV0tfU1RSRVEo IjQwMCIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJpbWFnZUVsZW1l bnQud2lkdGgiXSk7CiB9CkBAIC0xODIsOCArMTgxLDcgQEAgVEVTVChQYXN0ZUltYWdlLCBQYXN0 ZUpQRUdGaWxlKQogICAgIEVYUEVDVF9XS19TVFJFUSgic3Vuc2V0LWluLWN1cGVydGluby02MDBw eC5qcGciLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZmlsZS5uYW1l Il0pOwogICAgIEVYUEVDVF9XS19TVFJFUSgiIiwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5n SmF2YVNjcmlwdDpAImVkaXRvci50ZXh0Q29udGVudCJdKTsKIAotICAgIFt3ZWJWaWV3IHN0cmlu Z0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJpbnNlcnRGaWxlQXNJbWFnZShmaWxlKSJdOwotICAg IFt3ZWJWaWV3IHdhaXRGb3JNZXNzYWdlOkAibG9hZGVkIl07CisgICAgW3dlYlZpZXcgd2FpdEZv ck1lc3NhZ2U6QCJsb2FkZWQiIGFmdGVyRXZhbHVhdGluZ1NjcmlwdDpAImluc2VydEZpbGVBc0lt YWdlKGZpbGUpIl07CiAgICAgRVhQRUNUX1dLX1NUUkVRKCJibG9iOiIsIFt3ZWJWaWV3IHN0cmlu Z0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJ1cmwgPSBuZXcgVVJMKGltYWdlRWxlbWVudC5zcmMp OyB1cmwucHJvdG9jb2wiXSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCI2MDAiLCBbd2ViVmlldyBz dHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiaW1hZ2VFbGVtZW50LndpZHRoIl0pOwogfQpA QCAtMjA0LDggKzIwMiw3IEBAIFRFU1QoUGFzdGVJbWFnZSwgUGFzdGVQTkdGaWxlKQogICAgIEVY UEVDVF9XS19TVFJFUSgic3Vuc2V0LWluLWN1cGVydGluby0yMDBweC5wbmciLCBbd2ViVmlldyBz dHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZmlsZS5uYW1lIl0pOwogICAgIEVYUEVDVF9X S19TVFJFUSgiIiwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImVkaXRv ci50ZXh0Q29udGVudCJdKTsKIAotICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHQ6QCJpbnNlcnRGaWxlQXNJbWFnZShmaWxlKSJdOwotICAgIFt3ZWJWaWV3IHdhaXRGb3JN ZXNzYWdlOkAibG9hZGVkIl07CisgICAgW3dlYlZpZXcgd2FpdEZvck1lc3NhZ2U6QCJsb2FkZWQi IGFmdGVyRXZhbHVhdGluZ1NjcmlwdDpAImluc2VydEZpbGVBc0ltYWdlKGZpbGUpIl07CiAgICAg RVhQRUNUX1dLX1NUUkVRKCJibG9iOiIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHQ6QCJ1cmwgPSBuZXcgVVJMKGltYWdlRWxlbWVudC5zcmMpOyB1cmwucHJvdG9jb2wiXSk7 CiAgICAgRVhQRUNUX1dLX1NUUkVRKCIyMDAiLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdK YXZhU2NyaXB0OkAiaW1hZ2VFbGVtZW50LndpZHRoIl0pOwogfQpAQCAtMjI2LDggKzIyMyw3IEBA IFRFU1QoUGFzdGVJbWFnZSwgUGFzdGVUSUZGRmlsZSkKICAgICBFWFBFQ1RfV0tfU1RSRVEoInN1 bnNldC1pbi1jdXBlcnRpbm8tMTAwcHgudGlmZiIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGlu Z0phdmFTY3JpcHQ6QCJmaWxlLm5hbWUiXSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCIiLCBbd2Vi VmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9yLnRleHRDb250ZW50Il0p OwogCi0gICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImluc2VydEZp bGVBc0ltYWdlKGZpbGUpIl07Ci0gICAgW3dlYlZpZXcgd2FpdEZvck1lc3NhZ2U6QCJsb2FkZWQi XTsKKyAgICBbd2ViVmlldyB3YWl0Rm9yTWVzc2FnZTpAImxvYWRlZCIgYWZ0ZXJFdmFsdWF0aW5n U2NyaXB0OkAiaW5zZXJ0RmlsZUFzSW1hZ2UoZmlsZSkiXTsKICAgICBFWFBFQ1RfV0tfU1RSRVEo ImJsb2I6IiwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAInVybCA9IG5l dyBVUkwoaW1hZ2VFbGVtZW50LnNyYyk7IHVybC5wcm90b2NvbCJdKTsKICAgICBFWFBFQ1RfV0tf U1RSRVEoIjEwMCIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJpbWFn ZUVsZW1lbnQud2lkdGgiXSk7CiB9CkBAIC0yNDgsNyArMjQ0LDcgQEAgVEVTVChQYXN0ZUltYWdl LCBQYXN0ZUxlZ2FjeVRJRkZJbWFnZSkKICAgICBFWFBFQ1RfV0tfU1RSRVEoImltYWdlL3BuZyIs IFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJmaWxlID0gZGF0YVRyYW5z ZmVyLmZpbGVzWzBdOyBmaWxlLnR5cGUiXSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCJpbWFnZS5w bmciLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZmlsZS5uYW1lIl0p OwogCi0gICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImluc2VydEZp bGVBc0ltYWdlKGZpbGUpIl07CisgICAgW3dlYlZpZXcgd2FpdEZvck1lc3NhZ2U6QCJsb2FkZWQi IGFmdGVyRXZhbHVhdGluZ1NjcmlwdDpAImluc2VydEZpbGVBc0ltYWdlKGZpbGUpIl07CiAgICAg RVhQRUNUX1dLX1NUUkVRKCJibG9iOiIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHQ6QCJ1cmwgPSBuZXcgVVJMKGltYWdlRWxlbWVudC5zcmMpOyB1cmwucHJvdG9jb2wiXSk7 CiAgICAgRVhQRUNUX1dLX1NUUkVRKCIxMDAiLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdK YXZhU2NyaXB0OkAiaW1hZ2VFbGVtZW50LndpZHRoIl0pOwogfQpAQCAtMjcwLDcgKzI2Niw3IEBA IFRFU1QoUGFzdGVJbWFnZSwgUGFzdGVUSUZGSW1hZ2UpCiAgICAgRVhQRUNUX1dLX1NUUkVRKCJp bWFnZS5wbmciLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAicG5nSXRl bS5maWxlLm5hbWUiXSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCJ0cnVlIiwgW3dlYlZpZXcgc3Ry aW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRhdGFUcmFuc2Zlci5maWxlcy5pbmNsdWRlcyhw bmdJdGVtLmZpbGUpLnRvU3RyaW5nKCkiXSk7CiAKLSAgICBbd2ViVmlldyBzdHJpbmdCeUV2YWx1 YXRpbmdKYXZhU2NyaXB0OkAiaW5zZXJ0RmlsZUFzSW1hZ2UocG5nSXRlbS5maWxlKSJdOworICAg IFt3ZWJWaWV3IHdhaXRGb3JNZXNzYWdlOkAibG9hZGVkIiBhZnRlckV2YWx1YXRpbmdTY3JpcHQ6 QCJpbnNlcnRGaWxlQXNJbWFnZShwbmdJdGVtLmZpbGUpIl07CiAgICAgRVhQRUNUX1dLX1NUUkVR KCJibG9iOiIsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJ1cmwgPSBu ZXcgVVJMKGltYWdlRWxlbWVudC5zcmMpOyB1cmwucHJvdG9jb2wiXSk7CiAgICAgRVhQRUNUX1dL X1NUUkVRKCIxMDAiLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiaW1h Z2VFbGVtZW50LndpZHRoIl0pOwogfQo=