195147 2019-02-27 23:02:56 -0800 Web Inspector: Cleanup some Chart code 2019-02-28 00:08:24 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1510823 0 joepeck 2019-02-27 23:02:56 -0800 Cleanup some Chart code Small fixes seen while looking over the code. 1510825 1 363194 joepeck 2019-02-27 23:04:06 -0800 Created attachment 363194 [PATCH] Proposed Fix 1510830 2 363194 mattbaker 2019-02-27 23:41:30 -0800 Comment on attachment 363194 [PATCH] Proposed Fix rs=me 1510832 3 363194 commit-queue 2019-02-28 00:07:21 -0800 Comment on attachment 363194 [PATCH] Proposed Fix Clearing flags on attachment: 363194 Committed r242195: <https://trac.webkit.org/changeset/242195> 1510833 4 commit-queue 2019-02-28 00:07:22 -0800 All reviewed patches have been landed. Closing bug. 1510834 5 webkit-bug-importer 2019-02-28 00:08:24 -0800 <rdar://problem/48465895> 363194 2019-02-27 23:04:06 -0800 2019-02-28 00:07:21 -0800 [PATCH] Proposed Fix charts-1.patch text/plain 2422 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkwMzEyOTMxN2RhLi4xMDgzZDAzNjU1YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDItMjcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBDbGVhbnVwIHNvbWUgQ2hhcnQgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1JhbmdlQ2hhcnQuanM6Cisg ICAgICAgIChXSS5SYW5nZUNoYXJ0LnByb3RvdHlwZS5sYXlvdXQpOgorICAgICAgICAoV0kuUmFu Z2VDaGFydCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TdGFja2VkQ29sdW1uQ2hh cnQuanM6CisgICAgICAgIChXSS5TdGFja2VkQ29sdW1uQ2hhcnQucHJvdG90eXBlLmxheW91dCk6 CisgICAgICAgIChXSS5TdGFja2VkQ29sdW1uQ2hhcnQpOgorCiAyMDE5LTAyLTI3ICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog Vmlldy5yZW1vdmVTdWJ2aWV3IG5vdCByZW1vdmluZyB0aGUgZWxlbWVudCBwcm9wZXJseSB3aGVu IG5vdCBwYXJlbnRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmFuZ2VDaGFydC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1JhbmdlQ2hhcnQuanMKaW5kZXggYmM4N2JkMzI3ZmYuLjc1ODViOGMwODI2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9S YW5nZUNoYXJ0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1JhbmdlQ2hhcnQuanMKQEAgLTk4LDExICs5OCwxMSBAQCBXSS5SYW5nZUNoYXJ0ID0gY2xh c3MgUmFuZ2VDaGFydCBleHRlbmRzIFdJLlZpZXcKIAogICAgICAgICB0aGlzLl9zdmdFbGVtZW50 LnJlbW92ZUNoaWxkcmVuKCk7CiAKLSAgICAgICAgbGV0IGggPSAwOworICAgICAgICBsZXQgaGVp Z2h0ID0gdGhpcy5zaXplLmhlaWdodDsKICAgICAgICAgZm9yIChsZXQge3gsIHdpZHRoLCBjbGFz c05hbWV9IG9mIHRoaXMuX3JhbmdlcykgewogICAgICAgICAgICAgbGV0IHJlY3QgPSB0aGlzLl9z dmdFbGVtZW50LmFwcGVuZENoaWxkKGNyZWF0ZVNWR0VsZW1lbnQoInJlY3QiKSk7CiAgICAgICAg ICAgICByZWN0LnNldEF0dHJpYnV0ZSgid2lkdGgiLCB3aWR0aCk7Ci0gICAgICAgICAgICByZWN0 LnNldEF0dHJpYnV0ZSgiaGVpZ2h0IiwgdGhpcy5zaXplLmhlaWdodCk7CisgICAgICAgICAgICBy ZWN0LnNldEF0dHJpYnV0ZSgiaGVpZ2h0IiwgaGVpZ2h0KTsKICAgICAgICAgICAgIHJlY3Quc2V0 QXR0cmlidXRlKCJ0cmFuc2Zvcm0iLCBgdHJhbnNsYXRlKCR7eH0sIDApYCk7CiAgICAgICAgICAg ICByZWN0LmNsYXNzTGlzdC5hZGQoY2xhc3NOYW1lKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RhY2tlZENvbHVtbkNo YXJ0LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RhY2tl ZENvbHVtbkNoYXJ0LmpzCmluZGV4IDI1MGI4YTZkNjEyLi4zYThlZGIxODViYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RhY2tlZENvbHVt bkNoYXJ0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1N0YWNrZWRDb2x1bW5DaGFydC5qcwpAQCAtMTA4LDcgKzEwOCw2IEBAIFdJLlN0YWNrZWRDb2x1 bW5DaGFydCA9IGNsYXNzIFN0YWNrZWRDb2x1bW5DaGFydCBleHRlbmRzIFdJLlZpZXcKICAgICAg ICAgdGhpcy5fc3ZnRWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwogCiAgICAgICAgIGZvciAobGV0 IHt4LCB0b3RhbEhlaWdodCwgd2lkdGgsIGhlaWdodHN9IG9mIHRoaXMuX2NvbHVtbnMpIHsKLSAg ICAgICAgICAgIGxldCBzZWN0aW9uSW5kZXggPSAwOwogICAgICAgICAgICAgZm9yIChsZXQgaSA9 IGhlaWdodHMubGVuZ3RoIC0gMTsgaSA+PSAwOyAtLWkpIHsKICAgICAgICAgICAgICAgICBsZXQg aGVpZ2h0ID0gaGVpZ2h0c1tpXTsKICAgICAgICAgICAgICAgICAvLyBOZXh0IHJlY3Qgd2lsbCBi ZSBpZGVudGljYWwsIHNraXAgdGhpcyBvbmUuCg==