195146 2019-02-27 22:57:37 -0800 Web Inspector: View.removeSubview not removing the element properly when not parented 2019-02-28 16:49:33 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1510821 0 joepeck 2019-02-27 22:57:37 -0800 View.removeSubview not removing the element properly when not parented I addressed a review comment incompletely... I updated the assertion appropriately but not the code. 1510822 1 363193 joepeck 2019-02-27 22:58:43 -0800 Created attachment 363193 [PATCH] Proposed Fix Would only be possible right now debugging Worker Threads in CPU Timeline View. 1. Reload maps.google.com a few times with CPU timeline view 1510856 2 363193 mattbaker 2019-02-28 00:30:08 -0800 Comment on attachment 363193 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=363193&action=review > Source/WebInspectorUI/ChangeLog:10 > + Since the element may not be a direct child, just use Element.prototype.remove. Nice fix! I think we should add an assertion around View.js:110, before we try to insert the child view's DOM element: console.assert(!view.element.parentNode || this._element.contains(view.element.parentNode), "Subview DOM element must be a descendant of the parent view element."); This can balance the assertion at the top of View.removeSubview. 1510859 3 363193 mattbaker 2019-02-28 00:35:11 -0800 Comment on attachment 363193 [PATCH] Proposed Fix r=me We should add a test to LayoutTests/inspector/view/basics.html: suite.addTestCase({ name: "View.removeSubview.IndirectDescendant", test() { let parent = new WI.View; let middleElement = parent.element.appendChild(document.createElement("div")); let child = new WI.View; middleElement.appendChild(child.element); parent.addSubview(child); parent.removeSubview(child); InspectorTest.expectFalse(child.element.parentNode, "Removed view should not be in the DOM."); return true; } }); 1511180 4 joepeck 2019-02-28 16:20:11 -0800 Great suggestions, taking both! 1511201 5 joepeck 2019-02-28 16:48:39 -0800 https://trac.webkit.org/r242241 1511205 6 webkit-bug-importer 2019-02-28 16:49:33 -0800 <rdar://problem/48494372> 363193 2019-02-27 22:58:43 -0800 2019-02-28 16:20:03 -0800 [PATCH] Proposed Fix view-1.patch text/plain 1297 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY2YzE1Yjg3NjdiLi45MDMxMjkzMTdkYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDItMjcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBWaWV3LnJlbW92ZVN1YnZpZXcgbm90IHJlbW92aW5nIHRoZSBlbGVtZW50IHByb3Blcmx5IHdo ZW4gbm90IHBhcmVudGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTUxNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVmlldy5qczoKKyAgICAgICAgKFdJLlZpZXcu cHJvdG90eXBlLnJlbW92ZVN1YnZpZXcpOgorICAgICAgICBTaW5jZSB0aGUgZWxlbWVudCBtYXkg bm90IGJlIGEgZGlyZWN0IGNoaWxkLCBqdXN0IHVzZSBFbGVtZW50LnByb3RvdHlwZS5yZW1vdmUu CisKIDIwMTktMDItMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgYSBuZXcgU2Nhbm5lciBUaW1lbGluZU1hcmtlciB0 byBzaG93IHVwIHdoZW4gbW91c2luZyBvdmVyIFRpbWVsaW5lVmlldyBncmFwaHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1ZpZXcuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzCmluZGV4IDRm MjU5MWYzYjg4Li5kNTcxMGI5MmZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzCkBAIC0xMjYsNyArMTI2LDcgQEAgV0kuVmlldyA9 IGNsYXNzIFZpZXcgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMu X3N1YnZpZXdzLnNwbGljZShpbmRleCwgMSk7Ci0gICAgICAgIHRoaXMuX2VsZW1lbnQucmVtb3Zl Q2hpbGQodmlldy5lbGVtZW50KTsKKyAgICAgICAgdmlldy5lbGVtZW50LnJlbW92ZSgpOwogCiAg ICAgICAgIHZpZXcuX2RpZE1vdmVUb1BhcmVudChudWxsKTsKICAgICB9Cg==