195134 2019-02-27 17:20:50 -0800 [GTK] New CPU profiler tests failing 2020-10-08 00:54:43 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya dpino bburg bugs-noreply cgarcia darin dpino ews-watchlist hi joepeck magomez oldest_to_newest 1510726 0 aboya 2019-02-27 17:20:50 -0800 inspector/cpu-profiler/threads.html inspector/cpu-profiler/tracking.html Introduced in r241739. --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/cpu-profiler/threads-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/inspector/cpu-profiler/threads-actual.txt @@ -10,13 +10,10 @@ PASS: Event should have a timestamp. PASS: Event should have a usage. PASS: usage should be greater than or equal to zero. -PASS: Event should have threads. -PASS: Every thread has between 0 and 100 usage. -PASS: Event should have 1 main thread. -PASS: Event should have 2 worker threads. -PASS: Event should have other worker threads. -PASS: Worker 1 usage should be greater than zero. -PASS: Worker 2 usage should be greater than zero. -PASS: Total usage should be greater than or equal to the sum of both worker threads. -CPUProfiler.trackingComplete +FAIL: Event should have threads. + Expected: truthy + Actual: false +!! EXCEPTION: undefined is not an object (evaluating 'messageObject.params.event.threads') +Stack Trace: #0: (anonymous) (unknown) +#1: promiseReactionJob [native code] 1532257 1 magomez 2019-05-02 06:38:49 -0700 inspector/cpu-profiler/tracking.html is passing since r244478. 1695110 2 410627 dpino 2020-10-06 05:43:41 -0700 Created attachment 410627 Patch 1695111 3 dpino 2020-10-06 05:45:43 -0700 inspector/cpu-profiler/threads.html is a flaky failure. It has been passing since r266388, but it fails occasionally. For instance: Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r267958%20(16233)/inspector/cpu-profiler/threads-diff.txt --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/inspector/cpu-profiler/threads-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/inspector/cpu-profiler/threads-actual.txt @@ -17,6 +17,8 @@ PASS: Event should have other worker threads. PASS: Worker 1 usage should be greater than zero. PASS: Worker 2 usage should be greater than zero. -PASS: Total usage should be greater than or equal to the sum of both worker threads. +FAIL: Total usage should be greater than or equal to the sum of both worker threads. + Expected: greater than or equal to 198.53888702392578 + Actual: 198.53887939453125 CPUProfiler.trackingComplete The difference is minimal. I pushed a patch to round the decimal part to 4 digits only. 1695194 4 410627 joepeck 2020-10-06 10:03:54 -0700 Comment on attachment 410627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410627&action=review > LayoutTests/inspector/cpu-profiler/threads.html:52 > + let totalUsage = Float(messageObject.params.event.usage.toFixed(4)); Err, no such thing as `Float()` in JavaScript? > ! EXCEPTION: Can't find variable: Float > 21Stack Trace: #0: (anonymous) (unknown) > 22#1: promiseReactionJob [native code] Would this work? let totalUsage = messageObject.params.event.usage.toFixed(4); let workersUsage = (workers[0].usage + workers[1].usage).toFixed(4); 1695477 5 410736 dpino 2020-10-07 01:32:52 -0700 Created attachment 410736 Patch 1695816 6 ews-feeder 2020-10-08 00:54:42 -0700 Committed r268174: <https://trac.webkit.org/changeset/268174> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410736. 410627 2020-10-06 05:43:41 -0700 2020-10-07 01:32:47 -0700 Patch bug-195134-20201006144339.patch text/plain 2095 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MDQ1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTQ3MmFjM2E1Y2MyM2RmMDVhNDBk OTA3MjYxYTFhNjI0Y2RmZjljYi4uMWY4MGI2NTI0ZmIxMGI3MjE1NmFiMzlmYTRiZTAwNjFjNDZk OTE0YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTEwLTA2ICBEaWVnbyBQaW5vIEdhcmNp YSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaW5zcGVjdG9y L2NwdS1wcm9maWxlci90aHJlYWRzLmh0bWwsIHVzZSBvbmx5IDQgZGVjaW1hbCBkaWdpdHMgdG8g Y29tcGFyZSB0b3RhbCBhbmQgd29ya2VycyB1c2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY3B1LXByb2ZpbGVyL3RocmVhZHMu aHRtbDoKKwogMjAyMC0xMC0wNiAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcuIFJlbW92ZSB0ZXN0 cyBwYXNzaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NwdS1wcm9maWxl ci90aHJlYWRzLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY3B1LXByb2ZpbGVyL3RocmVh ZHMuaHRtbAppbmRleCA2YzVlZWQ1NGJlMzY1YjI1ZWUxNmZmMGJjNDcxMTBiNmVkZThjZTM5Li5i MmNhMDUyMjk0ZGZiNDA5OTg2NmY3ZTgxZmIzMjQ4MzhhNDQxZmUxIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvY3B1LXByb2ZpbGVyL3RocmVhZHMuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvY3B1LXByb2ZpbGVyL3RocmVhZHMuaHRtbApAQCAtNDgsNyArNDgsMTAg QEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICAgICAgUHJvdG9jb2xUZXN0LmV4cGVjdFRo YXQob3RoZXJzLmxlbmd0aCA+IDAsICJFdmVudCBzaG91bGQgaGF2ZSBvdGhlciB3b3JrZXIgdGhy ZWFkcy4iKTsKICAgICAgICAgICAgICAgICBQcm90b2NvbFRlc3QuZXhwZWN0R3JlYXRlclRoYW4o d29ya2Vyc1swXS51c2FnZSwgMCwgIldvcmtlciAxIHVzYWdlIHNob3VsZCBiZSBncmVhdGVyIHRo YW4gemVyby4iKTsKICAgICAgICAgICAgICAgICBQcm90b2NvbFRlc3QuZXhwZWN0R3JlYXRlclRo YW4od29ya2Vyc1sxXS51c2FnZSwgMCwgIldvcmtlciAyIHVzYWdlIHNob3VsZCBiZSBncmVhdGVy IHRoYW4gemVyby4iKTsKLSAgICAgICAgICAgICAgICBQcm90b2NvbFRlc3QuZXhwZWN0R3JlYXRl clRoYW5PckVxdWFsKG1lc3NhZ2VPYmplY3QucGFyYW1zLmV2ZW50LnVzYWdlLCB3b3JrZXJzWzBd LnVzYWdlICsgd29ya2Vyc1sxXS51c2FnZSwgIlRvdGFsIHVzYWdlIHNob3VsZCBiZSBncmVhdGVy IHRoYW4gb3IgZXF1YWwgdG8gdGhlIHN1bSBvZiBib3RoIHdvcmtlciB0aHJlYWRzLiIpOworICAg ICAgICAgICAgICAgIC8vIFJvdW5kIHRvIDQgZGVjaW1hbCBkaWdpdHMuCisgICAgICAgICAgICAg ICAgbGV0IHRvdGFsVXNhZ2UgPSBGbG9hdChtZXNzYWdlT2JqZWN0LnBhcmFtcy5ldmVudC51c2Fn ZS50b0ZpeGVkKDQpKTsKKyAgICAgICAgICAgICAgICBsZXQgd29ya2Vyc1VzYWdlID0gRmxvYXQo KHdvcmtlcnNbMF0udXNhZ2UgKyB3b3JrZXJzWzFdLnVzYWdlKS50b0ZpeGVkKDQpKTsKKyAgICAg ICAgICAgICAgICBQcm90b2NvbFRlc3QuZXhwZWN0R3JlYXRlclRoYW5PckVxdWFsKHRvdGFsVXNh Z2UsIHdvcmtlcnNVc2FnZSwgIlRvdGFsIHVzYWdlIHNob3VsZCBiZSBncmVhdGVyIHRoYW4gb3Ig ZXF1YWwgdG8gdGhlIHN1bSBvZiBib3RoIHdvcmtlciB0aHJlYWRzLiIpOwogCiAgICAgICAgICAg ICAgICAgSW5zcGVjdG9yUHJvdG9jb2wuc2VuZENvbW1hbmQoIkNQVVByb2ZpbGVyLnN0b3BUcmFj a2luZyIsIHt9KTsKICAgICAgICAgICAgIH0pLmNhdGNoKHJlamVjdCk7Cg== 410736 2020-10-07 01:32:52 -0700 2020-10-08 00:54:42 -0700 Patch bug-195134-20201007103250.patch text/plain 2107 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4MTE4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGM2NTE2NWUyNWMwNmNkNDU1ZjVi OTc4OWM1OTkwMDhhYWU2MjFkNy4uYzNhOTQ1NWRkYmUyMGM0OThkZDU0NzI5MTRkY2I4MDdmYTE0 Y2ZhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTEwLTA3ICBEaWVnbyBQaW5vIEdhcmNp YSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaW5zcGVjdG9y L2NwdS1wcm9maWxlci90aHJlYWRzLmh0bWwsIHVzZSBvbmx5IDQgZGVjaW1hbCBkaWdpdHMgdG8g Y29tcGFyZSB0b3RhbCBhbmQgd29ya2VycyB1c2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY3B1LXByb2ZpbGVyL3RocmVhZHMu aHRtbDoKKwogMjAyMC0xMC0wNiAgQW5kcmVzIEdvbnphbGV6ICA8YW5kcmVzZ18yMkBhcHBsZS5j b20+CiAKICAgICAgICAgUHJlc2lkZW50aWFsIEV4ZWN1dGl2ZSBPcmRlciBwYWdlcyBub3QgYWNj ZXNzaWJsZSB3aXRoIFNhZmFyaS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9j cHUtcHJvZmlsZXIvdGhyZWFkcy5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NwdS1wcm9m aWxlci90aHJlYWRzLmh0bWwKaW5kZXggNmM1ZWVkNTRiZTM2NWIyNWVlMTZmZjBiYzQ3MTEwYjZl ZGU4Y2UzOS4uMzY1ZDA3NDBlZjZkOGFkMWE5YTlkYzJhMjg4YTM3ZDg0NWRiMGQzNSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NwdS1wcm9maWxlci90aHJlYWRzLmh0bWwKKysr IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NwdS1wcm9maWxlci90aHJlYWRzLmh0bWwKQEAgLTQ4 LDcgKzQ4LDEwIEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgICAgIFByb3RvY29sVGVz dC5leHBlY3RUaGF0KG90aGVycy5sZW5ndGggPiAwLCAiRXZlbnQgc2hvdWxkIGhhdmUgb3RoZXIg d29ya2VyIHRocmVhZHMuIik7CiAgICAgICAgICAgICAgICAgUHJvdG9jb2xUZXN0LmV4cGVjdEdy ZWF0ZXJUaGFuKHdvcmtlcnNbMF0udXNhZ2UsIDAsICJXb3JrZXIgMSB1c2FnZSBzaG91bGQgYmUg Z3JlYXRlciB0aGFuIHplcm8uIik7CiAgICAgICAgICAgICAgICAgUHJvdG9jb2xUZXN0LmV4cGVj dEdyZWF0ZXJUaGFuKHdvcmtlcnNbMV0udXNhZ2UsIDAsICJXb3JrZXIgMiB1c2FnZSBzaG91bGQg YmUgZ3JlYXRlciB0aGFuIHplcm8uIik7Ci0gICAgICAgICAgICAgICAgUHJvdG9jb2xUZXN0LmV4 cGVjdEdyZWF0ZXJUaGFuT3JFcXVhbChtZXNzYWdlT2JqZWN0LnBhcmFtcy5ldmVudC51c2FnZSwg d29ya2Vyc1swXS51c2FnZSArIHdvcmtlcnNbMV0udXNhZ2UsICJUb3RhbCB1c2FnZSBzaG91bGQg YmUgZ3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvIHRoZSBzdW0gb2YgYm90aCB3b3JrZXIgdGhyZWFk cy4iKTsKKyAgICAgICAgICAgICAgICAvLyBSb3VuZCB0byA0IGRlY2ltYWwgZGlnaXRzLgorICAg ICAgICAgICAgICAgIGxldCB0b3RhbFVzYWdlID0gTnVtYmVyKG1lc3NhZ2VPYmplY3QucGFyYW1z LmV2ZW50LnVzYWdlLnRvRml4ZWQoNCkpOworICAgICAgICAgICAgICAgIGxldCB3b3JrZXJzVXNh Z2UgPSBOdW1iZXIoKHdvcmtlcnNbMF0udXNhZ2UgKyB3b3JrZXJzWzFdLnVzYWdlKS50b0ZpeGVk KDQpKTsKKyAgICAgICAgICAgICAgICBQcm90b2NvbFRlc3QuZXhwZWN0R3JlYXRlclRoYW5PckVx dWFsKHRvdGFsVXNhZ2UsIHdvcmtlcnNVc2FnZSwgIlRvdGFsIHVzYWdlIHNob3VsZCBiZSBncmVh dGVyIHRoYW4gb3IgZXF1YWwgdG8gdGhlIHN1bSBvZiBib3RoIHdvcmtlciB0aHJlYWRzLiIpOwog CiAgICAgICAgICAgICAgICAgSW5zcGVjdG9yUHJvdG9jb2wuc2VuZENvbW1hbmQoIkNQVVByb2Zp bGVyLnN0b3BUcmFja2luZyIsIHt9KTsKICAgICAgICAgICAgIH0pLmNhdGNoKHJlamVjdCk7Cg==