195126 2019-02-27 15:59:33 -0800 Universal links from Google search results pages don't open the app 2019-03-01 10:34:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson achristensen cdumez commit-queue dbates ews-watchlist ggaren japhet ryanhaddad tsavell youennf oldest_to_newest 1510669 0 beidson 2019-02-27 15:59:33 -0800 Universal links from Google search results pages don't open the app They do some fancy iframe tricks. We have a good relaxation to fix it. 1510670 1 beidson 2019-02-27 15:59:44 -0800 <rdar://problem/46887179> 1510671 2 363150 beidson 2019-02-27 16:06:38 -0800 Created attachment 363150 Patch 1510675 3 ews-watchlist 2019-02-27 16:09:27 -0800 Attachment 363150 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:257: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:261: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:263: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:265: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:273: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1510683 4 363150 ggaren 2019-02-27 16:23:53 -0800 Comment on attachment 363150 Patch r=me 1510700 5 363150 commit-queue 2019-02-27 16:50:36 -0800 Comment on attachment 363150 Patch Clearing flags on attachment: 363150 Committed r242181: <https://trac.webkit.org/changeset/242181> 1510701 6 commit-queue 2019-02-27 16:50:38 -0800 All reviewed patches have been landed. Closing bug. 1511097 7 tsavell 2019-02-28 13:26:12 -0800 It looks like the changes in https://trac.webkit.org/changeset/242181/webkit caused 3 test crashes on Mac Debug: fast/xmlhttprequest/xmlhttprequest-no-file-access.html fast/files/file-reader-file-url.html security/cannot-read-self-from-file.html Crash: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r242199%20(1759)/fast/files/file-reader-immediate-abort-stderr.txt History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=security%2Fcannot-read-self-from-file.html%20fast%2Fxmlhttprequest%2Fxmlhttprequest-no-file-access.html%20fast%2Ffiles%2Ffile-reader-file-url.html 1511099 8 ggaren 2019-02-28 13:27:01 -0800 ASSERTION FAILED: result == (origin1.toString() == origin2.toString()) ./page/SecurityOrigin.cpp(498) : bool WebCore::originsMatch(const WebCore::SecurityOrigin &, const WebCore::SecurityOrigin &) 1 0x368180a99 WTFCrash 2 0x3560ea8db WTFCrashWithInfo(int, char const*, char const*, int) 3 0x359069c05 WebCore::originsMatch(WebCore::SecurityOrigin const&, WebCore::SecurityOrigin const&) 4 0x358d706be WebCore::DocumentLoader::shouldOpenExternalURLsPolicyToPropagate() const 5 0x358db5666 WebCore::HistoryController::saveDocumentState() 1511181 9 ryanhaddad 2019-02-28 16:20:20 -0800 It appears that mac-debug EWS saw this before the change was landed, but it didn't get a chance to verify results: https://webkit-queues.webkit.org/results/11309974 Since these are consistent crashes affecting EWS, we should roll this out if it cannot be fixed quickly. 1511212 10 beidson 2019-02-28 17:02:25 -0800 I'm sure this'll be easy to resolve but I will not be able to do so today. 1511213 11 beidson 2019-02-28 17:03:56 -0800 Actually let me see if I can in the next 10 minutes. Hang on. 1511216 12 beidson 2019-02-28 17:11:26 -0800 Have to build for desktop from scratch. Will check on it when I get home and try to resolve this tonight. 1511219 13 beidson 2019-02-28 17:12:23 -0800 (In reply to Ryan Haddad from comment #9) > It appears that mac-debug EWS saw this before the change was landed, but it > didn't get a chance to verify results: > https://webkit-queues.webkit.org/results/11309974 I've been an advocate for a cq+ that waits for EWS clearance to actually land for quite awhile now, and I sometimes forget it doesn't already do it. =/ 1511225 14 beidson 2019-02-28 17:30:41 -0800 Bogus assertion. They are both file:// origins, one with universal access and the other without. The one without toStrings() to "null" The one with toStrings() to "file" Removing the ASSERT until somebody explains to me why it's important (it was added in https://trac.webkit.org/changeset/207871/webkit with no explanation as to why) 1511226 15 beidson 2019-02-28 17:32:46 -0800 Reopening to attach new patch. 1511227 16 363281 beidson 2019-02-28 17:32:47 -0800 Created attachment 363281 Patch 1511238 17 363281 commit-queue 2019-02-28 18:10:28 -0800 Comment on attachment 363281 Patch Clearing flags on attachment: 363281 Committed r242249: <https://trac.webkit.org/changeset/242249> 1511239 18 commit-queue 2019-02-28 18:10:30 -0800 All reviewed patches have been landed. Closing bug. 1511266 19 youennf 2019-02-28 19:34:18 -0800 > Removing the ASSERT until somebody explains to me why it's important (it was > added in https://trac.webkit.org/changeset/207871/webkit with no explanation > as to why) https://trac.webkit.org/changeset/207871/webkit is adding the helper routine based on a previous version which was doing string matching. The ASSERT makes sure that both versions are equivalent. String matching is useful as this is what origins end up being serialized to, for instance in HTTP headers for CORS. In this particular case, universal access makes things like CORS a no-problem so this is fine to ignore. I see value in tracking the differences between the two comparisons and making sure any difference is ok. I would tend to beef up the ASSERT instead of removing it. 1511273 20 ggaren 2019-02-28 20:19:09 -0800 > I would tend to beef up the ASSERT instead of removing it. What would you recommend here? Retain the ASSERT but exclude file:// origins with universal access? 1511405 21 beidson 2019-03-01 08:45:49 -0800 (In reply to youenn fablet from comment #19) > > Removing the ASSERT until somebody explains to me why it's important (it was > > added in https://trac.webkit.org/changeset/207871/webkit with no explanation > > as to why) > > https://trac.webkit.org/changeset/207871/webkit is adding the helper routine > based on a previous version which was doing string matching. > The ASSERT makes sure that both versions are equivalent. As is evidenced by the impact this patch had on the tests, the two versions are *not* equivalent. If they are supposed to be equivalent then the original patch seems wrong. > I see value in tracking the differences between the two comparisons and > making sure any difference is ok. > I would tend to beef up the ASSERT instead of removing it. I'm fine with restoring an ASSERT that is correct, but am unclear on what that ASSERT would look like. (See my comment above!) 1511452 22 youennf 2019-03-01 10:34:22 -0800 I filed bug 195216 to follow up on the ASSERT issue. 363150 2019-02-27 16:06:38 -0800 2019-02-28 17:32:45 -0800 Patch bug-195126-20190227160638.patch text/plain 8925 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTYyZDg0ZTgyYmVmMDQz ZWRjZDczODY4ZjMyM2RkMDk5NzgyOTNlNy4uNGVhNDA5NTZlZGQxNDM5YTYwZDY4OTM5MDY1OTc3 MGZjZTQxOTZiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTI3ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBVbml2ZXJzYWwgbGlua3Mg ZnJvbSBHb29nbGUgc2VhcmNoIHJlc3VsdHMgcGFnZXMgZG9uJ3Qgb3BlbiB0aGUgYXBwLgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNDY4ODcxNzk+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBuZXcgQVBJIHRlc3RzLgorCisgICAgICAgICog bG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9h ZGVyOjpzaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5VG9Qcm9wYWdhdGUgY29uc3QpOiBQcm9w YWdhdGUgdGhlIGV4dGVybmFsIFVSTCBwb2xpY3kgZnJvbQorICAgICAgICAgIGFuIGlmcmFtZSBp ZiBpdCBpcyBmcm9tIHRoZSBzYW1lIHNlY3VyaXR5IG9yaWdpbiBhcyB0aGUgbWFpbiBmcmFtZS4K KwogMjAxOS0wMi0yNyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtDb250ZW50Q2hhbmdlT2JzZXJ2ZXJdIE1vdmUgc3R5bGUgcmVjYWxjIGhhbmRsaW5nIGZyb20g Z2xvYmFsIHRvIENvbnRlbnRDaGFuZ2VPYnNlcnZlciBjbGFzcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggZjk2M2M1ZDhiZWNlMGY0NGY4ZDFkOTI2OTgyYzk3 ZjFhOWRmOTk3OS4uYjBmOTRhNTA4OWE1ZTQzNDI4NDJkNmMyYTRkYzY4NmY5ZTAwZDFkMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCkBAIC0yMDc2LDEwICsyMDc2 LDE4IEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OnNldFRyaWdnZXJpbmdBY3Rpb24oTmF2aWdhdGlv bkFjdGlvbiYmIGFjdGlvbikKIAogU2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeSBEb2N1bWVu dExvYWRlcjo6c2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeVRvUHJvcGFnYXRlKCkgY29uc3QK IHsKLSAgICBpZiAoIW1fZnJhbWUgfHwgIW1fZnJhbWUtPmlzTWFpbkZyYW1lKCkpCisgICAgaWYg KCFtX2ZyYW1lKQogICAgICAgICByZXR1cm4gU2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeTo6 U2hvdWxkTm90QWxsb3c7CiAKLSAgICByZXR1cm4gbV9zaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9s aWN5OworICAgIGlmIChtX2ZyYW1lLT5pc01haW5GcmFtZSgpKQorICAgICAgICByZXR1cm4gbV9z aG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OworCisgICAgaWYgKGF1dG8qIGN1cnJlbnREb2N1 bWVudCA9IGRvY3VtZW50KCkpIHsKKyAgICAgICAgaWYgKG9yaWdpbnNNYXRjaChjdXJyZW50RG9j dW1lbnQtPnNlY3VyaXR5T3JpZ2luKCksIGN1cnJlbnREb2N1bWVudC0+dG9wT3JpZ2luKCkpKQor ICAgICAgICAgICAgcmV0dXJuIG1fc2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeTsKKyAgICB9 CisKKyAgICByZXR1cm4gU2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeTo6U2hvdWxkTm90QWxs b3c7CiB9CiAKIHZvaWQgRG9jdW1lbnRMb2FkZXI6OmJlY29tZU1haW5SZXNvdXJjZUNsaWVudCgp CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmY4 NGQ2YmEzNjc1ODkxZDZlMTcxNTcyN2U1MjI4ZWQ2Zjk3OGEyOC4uOWNjNzU1ZTdkY2E3ODcyNmY0 ZmEzNWQ3OGExMWVlZDM0MWJhNzQ2OCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTI3ICBCcmFkeSBFaWRz b24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBVbml2ZXJzYWwgbGlua3MgZnJvbSBH b29nbGUgc2VhcmNoIHJlc3VsdHMgcGFnZXMgZG9uJ3Qgb3BlbiB0aGUgYXBwLgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDY4ODcxNzk+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk1MTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Nob3VsZE9wZW5F eHRlcm5hbFVSTHNJbk5ld1dpbmRvd0FjdGlvbnMubW06CisgICAgICAgICogVGVzdFdlYktpdEFQ SS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRlLmg6CisgICAgICAgICogVGVzdFdlYktpdEFQ SS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRlLm1tOgorICAgICAgICAoLVtUZXN0TmF2aWdh dGlvbkRlbGVnYXRlIHdlYlZpZXc6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjpkZWNp c2lvbkhhbmRsZXI6XSk6CisKIDIwMTktMDItMTMgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBh cHBsZS5jb20+CiAKICAgICAgICAgSGlnaCBTaWVycmEgRGVidWcgSlNDIHRlc3QgcXVldWUgc2hv dWxkIHVzZSBmYXN0ZXIgaGFyZHdhcmUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvU2hvdWxkT3BlbkV4dGVybmFsVVJMc0luTmV3V2luZG93QWN0aW9u cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2hvdWxkT3BlbkV4 dGVybmFsVVJMc0luTmV3V2luZG93QWN0aW9ucy5tbQppbmRleCBhMTI2M2U3NjA4ZTdhNWNlMGQ5 OTVhMDA4MmM1MDU2NTEyYTc0NzFiLi5hYTAwMTBlYzU3NTE2ZTQ4MThjNGUzZDY0NThkMDViOWFj Y2Y0YWRmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1Nob3VsZE9wZW5FeHRlcm5hbFVSTHNJbk5ld1dpbmRvd0FjdGlvbnMubW0KKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TaG91bGRPcGVuRXh0ZXJuYWxVUkxzSW5O ZXdXaW5kb3dBY3Rpb25zLm1tCkBAIC0yOCw2ICsyOCw4IEBACiAjaWYgUExBVEZPUk0oTUFDKQog CiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxpdGllcy5oIgorI2ltcG9ydCAiVGVzdE5hdmlnYXRpb25E ZWxlZ2F0ZS5oIgorI2ltcG9ydCAiVGVzdFVSTFNjaGVtZUhhbmRsZXIuaCIKICNpbXBvcnQgPFdl YktpdC9XS05hdmlnYXRpb25BY3Rpb25Qcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tXZWJW aWV3UHJpdmF0ZS5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgpAQCAtMjUwLDYgKzI1Miw4 MiBAQCBURVNUKFdlYktpdCwgUmVzdG9yZVNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3lBZnRl ckNyYXNoKQogICAgIEFTU0VSVF9GQUxTRShbYWN0aW9uIF9zaG91bGRPcGVuQXBwTGlua3NdKTsK IH07CiAKKworCitzdGF0aWMgY29uc3QgY2hhciogaWZyYW1lQnl0ZXMgPSBSInNjaGVtZXJlc291 cmNlKAorPHNjcmlwdD4KK3RvcC5sb2NhdGlvbi5ocmVmID0gImV4dGVybmFsU2NoZW1lOi8vc29t ZW90aGVyaG9zdC9mb28iOworPC9zY3JpcHQ+Cispc2NoZW1lcmVzb3VyY2UiOworCitzdGF0aWMg Y29uc3QgY2hhciogbWFpbkZyYW1lQnl0ZXMgPSBSInNjaGVtZXJlc291cmNlKAorPHNjcmlwdD4K K2Z1bmN0aW9uIGNsaWNrZWQoKSB7CisgICAgdmFyIGlmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoJ2lmcmFtZScpOworICAgIGlmcmFtZS5zcmMgPSAiY3VzdG9tOi8vZmlyc3Rob3N0L2lm cmFtZS5odG1sIjsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcmFtZSk7Cit9Cis8 L3NjcmlwdD4KKworPGEgc3R5bGU9ImRpc3BsYXk6IGJsb2NrOyBoZWlnaHQ6IDEwMCUiIG9uY2xp Y2s9ImNsaWNrZWQoKTsiPkNsaWNrIHRvIHN0YXJ0IGlmcmFtZSBkYW5jZTwvYT4KKylzY2hlbWVy ZXNvdXJjZSI7CisKK1RFU1QoV2ViS2l0LCBJRnJhbWVXaXRoU2FtZU9yaWdpbkFzTWFpbkZyYW1l UHJvcGFnYXRlcykKK3sKKyAgICBhdXRvIHNjaGVtZUhhbmRsZXIgPSBhZG9wdE5TKFtbVGVzdFVS TFNjaGVtZUhhbmRsZXIgYWxsb2NdIGluaXRdKTsKKyAgICBhdXRvIGNvbmZpZ3VyYXRpb24gPSBh ZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0pOworICAgIFtjb25m aWd1cmF0aW9uIHNldFVSTFNjaGVtZUhhbmRsZXI6c2NoZW1lSGFuZGxlci5nZXQoKSBmb3JVUkxT Y2hlbWU6QCJjdXN0b20iXTsKKworICAgIFtzY2hlbWVIYW5kbGVyIHNldFN0YXJ0VVJMU2NoZW1l VGFza0hhbmRsZXI6XihXS1dlYlZpZXcgKiwgaWQ8V0tVUkxTY2hlbWVUYXNrPiB0YXNrKSB7Cisg ICAgICAgIE5TVVJMICpyZXF1ZXN0VVJMID0gW3Rhc2sgcmVxdWVzdF0uVVJMOworICAgICAgICAK KyAgICAgICAgTlNTdHJpbmcgKnJlc3BvbnNlVGV4dCA9IG5pbDsKKyAgICAgICAgaWYgKFtbdGFz ayByZXF1ZXN0XS5VUkwuYWJzb2x1dGVTdHJpbmcgY29udGFpbnNTdHJpbmc6QCJpZnJhbWUuaHRt bCJdKQorICAgICAgICAgICAgcmVzcG9uc2VUZXh0ID0gW05TU3RyaW5nIHN0cmluZ1dpdGhVVEY4 U3RyaW5nOmlmcmFtZUJ5dGVzXTsKKyAgICAgICAgZWxzZSBpZiAoW1t0YXNrIHJlcXVlc3RdLlVS TC5hYnNvbHV0ZVN0cmluZyBjb250YWluc1N0cmluZzpAIm1haW5mcmFtZS5odG1sIl0pCisgICAg ICAgICAgICByZXNwb25zZVRleHQgPSBbTlNTdHJpbmcgc3RyaW5nV2l0aFVURjhTdHJpbmc6bWFp bkZyYW1lQnl0ZXNdOworCisgICAgICAgIGF1dG8gcmVzcG9uc2UgPSBhZG9wdE5TKFtbTlNVUkxS ZXNwb25zZSBhbGxvY10gaW5pdFdpdGhVUkw6cmVxdWVzdFVSTCBNSU1FVHlwZTpAInRleHQvaHRt bCIgZXhwZWN0ZWRDb250ZW50TGVuZ3RoOltyZXNwb25zZVRleHQgbGVuZ3RoXSB0ZXh0RW5jb2Rp bmdOYW1lOm5pbF0pOworICAgICAgICBbdGFzayBkaWRSZWNlaXZlUmVzcG9uc2U6cmVzcG9uc2Uu Z2V0KCldOworICAgICAgICBbdGFzayBkaWRSZWNlaXZlRGF0YTpbcmVzcG9uc2VUZXh0IGRhdGFV c2luZ0VuY29kaW5nOk5TVVRGOFN0cmluZ0VuY29kaW5nXV07CisgICAgICAgIFt0YXNrIGRpZEZp bmlzaF07CisgICAgfV07CisKKyAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3 IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApIGNvbmZpZ3Vy YXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOworICAgIGF1dG8gbmF2aWdhdGlvbkRlbGVnYXRl ID0gYWRvcHROUyhbW1Rlc3ROYXZpZ2F0aW9uRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICBb d2ViVmlldyBzZXROYXZpZ2F0aW9uRGVsZWdhdGU6bmF2aWdhdGlvbkRlbGVnYXRlLmdldCgpXTsK KworICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6 W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJjdXN0b206Ly9maXJzdGhvc3QvbWFpbmZyYW1lLmh0bWwi XV1dOworICAgIFtuYXZpZ2F0aW9uRGVsZWdhdGUgd2FpdEZvckRpZEZpbmlzaE5hdmlnYXRpb25d OworICAgIAorICAgIC8vIEluc3RhbGwgdGhlIGRlY2lkZVBvbGljeUxpc3RlbmVyCisgICAgc3Rh dGljIGJvb2wgb3BlbkFwcExpbmtzOworICAgIHN0YXRpYyBib29sIGV4dGVybmFsU2NoZW1lczsK KyAgICBzdGF0aWMgYm9vbCBmaW5pc2hlZCA9IGZhbHNlOworICAgIG5hdmlnYXRpb25EZWxlZ2F0 ZS5nZXQoKS5kZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uID0gXihXS05hdmlnYXRpb25B Y3Rpb24gKmFjdGlvbiwgdm9pZCAoXmRlY2lzaW9uSGFuZGxlcikoV0tOYXZpZ2F0aW9uQWN0aW9u UG9saWN5KSkgeworICAgICAgICBpZiAoIWFjdGlvbi50YXJnZXRGcmFtZS5tYWluRnJhbWUpIHsK KyAgICAgICAgICAgIGRlY2lzaW9uSGFuZGxlcihXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3lBbGxv dyk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBvcGVuQXBwTGlu a3MgPSBbYWN0aW9uIF9zaG91bGRPcGVuQXBwTGlua3NdOworICAgICAgICBleHRlcm5hbFNjaGVt ZXMgPSBbYWN0aW9uIF9zaG91bGRPcGVuRXh0ZXJuYWxTY2hlbWVzXTsKKyAgICAgICAgCisgICAg ICAgIGRlY2lzaW9uSGFuZGxlcihXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3lDYW5jZWwpOworICAg ICAgICBmaW5pc2hlZCA9IHRydWU7CisgICAgfTsKKyAgICAKKyAgICAvLyBDbGljayB0aGUgbGlu aworICAgIE5TUG9pbnQgY2xpY2tQb2ludCA9IE5TTWFrZVBvaW50KDEwMCwgMTAwKTsKKyAgICBb W3dlYlZpZXcgaGl0VGVzdDpjbGlja1BvaW50XSBtb3VzZURvd246W05TRXZlbnQgbW91c2VFdmVu dFdpdGhUeXBlOk5TRXZlbnRUeXBlTGVmdE1vdXNlRG93biBsb2NhdGlvbjpjbGlja1BvaW50IG1v ZGlmaWVyRmxhZ3M6MCB0aW1lc3RhbXA6MCB3aW5kb3dOdW1iZXI6W3dlYlZpZXcuZ2V0KCkud2lu ZG93IHdpbmRvd051bWJlcl0gY29udGV4dDpuaWwgZXZlbnROdW1iZXI6MCBjbGlja0NvdW50OjEg cHJlc3N1cmU6MV1dOworICAgIFtbd2ViVmlldyBoaXRUZXN0OmNsaWNrUG9pbnRdIG1vdXNlVXA6 W05TRXZlbnQgbW91c2VFdmVudFdpdGhUeXBlOk5TRXZlbnRUeXBlTGVmdE1vdXNlVXAgbG9jYXRp b246Y2xpY2tQb2ludCBtb2RpZmllckZsYWdzOjAgdGltZXN0YW1wOjAgd2luZG93TnVtYmVyOlt3 ZWJWaWV3LmdldCgpLndpbmRvdyB3aW5kb3dOdW1iZXJdIGNvbnRleHQ6bmlsIGV2ZW50TnVtYmVy OjAgY2xpY2tDb3VudDoxIHByZXNzdXJlOjFdXTsKKworICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6 OnJ1bigmZmluaXNoZWQpOworICAgIAorICAgIEFTU0VSVF9UUlVFKG9wZW5BcHBMaW5rcyk7Cisg ICAgQVNTRVJUX1RSVUUoZXh0ZXJuYWxTY2hlbWVzKTsKK307CisKICNlbmRpZgogCiAjZW5kaWYK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29jb2EvVGVzdE5hdmlnYXRpb25EZWxl Z2F0ZS5oIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRl LmgKaW5kZXggMTZhMGJjZWFkZWU5ZTkxMjMzN2JlMmU3NTcwMDY5NjQ1N2YxMzZmNS4uZmY3ODVm NmI4YjNmYzQ4YzBmYTVmNGZlMWIyMjBiZGQ1Y2QxMDFmNCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRlLmgKKysrIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRlLmgKQEAgLTMyLDYgKzMyLDcg QEAKIAogQGludGVyZmFjZSBUZXN0TmF2aWdhdGlvbkRlbGVnYXRlIDogTlNPYmplY3QgPFdLTmF2 aWdhdGlvbkRlbGVnYXRlPgogCitAcHJvcGVydHkgKG5vbmF0b21pYywgY29weSkgdm9pZCAoXmRl Y2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24pKFdLTmF2aWdhdGlvbkFjdGlvbiAqLCB2b2lk ICheKShXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3kpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBj b3B5KSB2b2lkICheZGlkRmFpbFByb3Zpc2lvbmFsTmF2aWdhdGlvbikoV0tXZWJWaWV3ICosIFdL TmF2aWdhdGlvbiAqLCBOU0Vycm9yICopOwogQHByb3BlcnR5IChub25hdG9taWMsIGNvcHkpIHZv aWQgKF5kaWRTdGFydFByb3Zpc2lvbmFsTmF2aWdhdGlvbikoV0tXZWJWaWV3ICosIFdLTmF2aWdh dGlvbiAqKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSB2b2lkICheZGlkRmluaXNoTmF2 aWdhdGlvbikoV0tXZWJWaWV3ICosIFdLTmF2aWdhdGlvbiAqKTsKZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvY29jb2EvVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5tbSBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvY29jb2EvVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5tbQppbmRleCBlY2QzNTUx ZjUyNDhkYzRiNmUxYTYxM2E5NDI3MWJkYWZhY2Y3ZGUxLi5iNDliNzNkMDUwMmM3MmEwMGQ2M2Y4 ZGRhODFhYzU2ZDlmY2IwOTkxIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL2NvY29h L1Rlc3ROYXZpZ2F0aW9uRGVsZWdhdGUubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9jb2Nv YS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRlLm1tCkBAIC0zMyw2ICszMywxNCBAQAogCiBAaW1wbGVt ZW50YXRpb24gVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZQogCistICh2b2lkKXdlYlZpZXc6KFdLV2Vi VmlldyAqKXdlYlZpZXcgZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjooV0tOYXZpZ2F0 aW9uQWN0aW9uICopbmF2aWdhdGlvbkFjdGlvbiBkZWNpc2lvbkhhbmRsZXI6KHZvaWQgKF4pKFdL TmF2aWdhdGlvbkFjdGlvblBvbGljeSkpZGVjaXNpb25IYW5kbGVyCit7CisgICAgaWYgKF9kZWNp ZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKQorICAgICAgICBfZGVjaWRlUG9saWN5Rm9yTmF2 aWdhdGlvbkFjdGlvbihuYXZpZ2F0aW9uQWN0aW9uLCBkZWNpc2lvbkhhbmRsZXIpOworICAgIGVs c2UKKyAgICAgICAgZGVjaXNpb25IYW5kbGVyKFdLTmF2aWdhdGlvbkFjdGlvblBvbGljeUFsbG93 KTsKK30KKwogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZFN0YXJ0UHJv dmlzaW9uYWxOYXZpZ2F0aW9uOihXS05hdmlnYXRpb24gKiluYXZpZ2F0aW9uCiB7CiAgICAgaWYg KF9kaWRTdGFydFByb3Zpc2lvbmFsTmF2aWdhdGlvbikK 363281 2019-02-28 17:32:47 -0800 2019-02-28 18:10:28 -0800 Patch bug-195126-20190228173246.patch text/plain 1456 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmU3OGEyYmYyZDE3ZmMz MmEzNWM5OWI0NTBlNTRiMDZkYjE4NzU0MS4uNGU0NDI0MDcyMGNlY2IxMzkzY2NjMjEyYzkxZjg5 ZjhjODNkNDE3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAyLTI4ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBGb2xsb3d1cCB0bzoKKyAg ICAgICAgVW5pdmVyc2FsIGxpbmtzIGZyb20gR29vZ2xlIHNlYXJjaCByZXN1bHRzIHBhZ2VzIGRv bid0IG9wZW4gdGhlIGFwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk1MTI2CisKKyAgICAgICAgVW5yZXZpZXdlZC4KKworICAgICAgICAqIHBhZ2Uv U2VjdXJpdHlPcmlnaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6b3JpZ2luc01hdGNoKTogUmVt b3ZlIGEgYm9ndXMgYXNzZXJ0aW9uIChyZWFzb25pbmcgaW4gYnVnemlsbGEpCisKIDIwMTktMDIt MjggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBV c2UtYWZ0ZXItbW92ZSBpbiBSZW5kZXJDb21iaW5lVGV4dDo6Y29tYmluZVRleHRJZk5lZWRlZCgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCmluZGV4IDNhZDkyMWNjNTRkZTFm ZWZlM2QxNTcxZjIyZTI1MzIxMmE4ZGUyMGIuLjgwOWU1NDc1ZWM1ZGU1ODE1MjRkOTE4NjQzNDMx NTk4MTU2ZTFhZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmln aW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwCkBAIC00 OTQsOSArNDk0LDcgQEAgYm9vbCBvcmlnaW5zTWF0Y2goY29uc3QgU2VjdXJpdHlPcmlnaW4mIG9y aWdpbjEsIGNvbnN0IFNlY3VyaXR5T3JpZ2luJiBvcmlnaW4yKQogICAgIGlmICgmb3JpZ2luMSA9 PSAmb3JpZ2luMikKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBib29sIHJlc3VsdCA9IGFy ZU9yaWdpbnNNYXRjaGluZyhvcmlnaW4xLCBvcmlnaW4yKTsKLSAgICBBU1NFUlQocmVzdWx0ID09 IChvcmlnaW4xLnRvU3RyaW5nKCkgPT0gb3JpZ2luMi50b1N0cmluZygpKSk7Ci0gICAgcmV0dXJu IHJlc3VsdDsKKyAgICByZXR1cm4gYXJlT3JpZ2luc01hdGNoaW5nKG9yaWdpbjEsIG9yaWdpbjIp OwogfQogCiBib29sIG9yaWdpbnNNYXRjaChjb25zdCBTZWN1cml0eU9yaWdpbiogb3JpZ2luMSwg Y29uc3QgU2VjdXJpdHlPcmlnaW4qIG9yaWdpbjIpCg==