19512 2008-06-12 00:39:04 -0700 Unquoted $ORIGDIR in autogen.sh 2013-09-11 02:53:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Trivial --- 1 julien.sanchez berto berto cgarcia julien.sanchez pnormand oldest_to_newest 83085 0 julien.sanchez 2008-06-12 00:39:04 -0700 $ORIGDIR must be quoted to build inside a directory with space 927683 1 211288 berto 2013-09-11 01:24:50 -0700 Created attachment 211288 Patch I'm not sure why anyone would want to build inside a directory with this kind of names, but configure will anyway make a proper safety check. 927692 2 211288 cgarcia 2013-09-11 02:12:51 -0700 Comment on attachment 211288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211288&action=review > autogen.sh:11 > -rm -f $top_srcdir/autom4te.cache > +rm -rf autom4te.cache Is this related to this bug? or can it be fixed in a different commit? 927693 3 berto 2013-09-11 02:26:23 -0700 Not directly related, I was just trying to sanitize autogen.sh a bit. Not sure if the autom4te thing deserves its own patch, but I can also file a separate bug, of course. 927696 4 cgarcia 2013-09-11 02:33:50 -0700 (In reply to comment #3) > Not directly related, I was just trying to sanitize autogen.sh a bit. > > Not sure if the autom4te thing deserves its own patch, but I can also file a separate bug, of course. Yes, please, even if it's one line patch it's a different fix 927699 5 211291 berto 2013-09-11 02:42:20 -0700 Created attachment 211291 Patch So be it 927701 6 berto 2013-09-11 02:53:26 -0700 Committed r155515: <http://trac.webkit.org/changeset/155515> 211288 2013-09-11 01:24:50 -0700 2013-09-11 02:42:20 -0700 Patch 19512.diff text/plain 1358 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyYTE1ZWI0Li5kMWJkNjQ4 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTMtMDktMTEgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAgICAg ICBVbnF1b3RlZCAkT1JJR0RJUiBpbiBhdXRvZ2VuLnNoCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFF1b3RlIGFsbCBkaXJlY3RvcnkgbmFtZXMgYW5kIGZp eCByZW1vdmFsIG9mIGF1dG9tNHRlLmNhY2hlLgorCisgICAgICAgICogYXV0b2dlbi5zaDoKKwog MjAxMy0wOS0xMCAgTWFyY2VsbyBNb3JhaXMgIDxtLm1vcmFpc0BzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbRUZMXSBXZWJJbnNwZWN0b3I6IE1vdmUgdG8gbmV3IHdlYmluc3BlY3RvcgpkaWZmIC0t Z2l0IGEvYXV0b2dlbi5zaCBiL2F1dG9nZW4uc2gKaW5kZXggMTJjNmE0Yy4uOTEwOWJmZCAxMDA3 NTUKLS0tIGEvYXV0b2dlbi5zaAorKysgYi9hdXRvZ2VuLnNoCkBAIC0yLDEzICsyLDEzIEBACiAK ICMgQWxsb3cgaW52b2NhdGlvbiBmcm9tIGEgc2VwYXJhdGUgYnVpbGQgZGlyZWN0b3J5OyBpbiB0 aGF0IGNhc2UsIHdlIGNoYW5nZQogIyB0byB0aGUgc291cmNlIGRpcmVjdG9yeSB0byBydW4gdGhl IGF1dG8qLCB0aGVuIGNoYW5nZSBiYWNrIGJlZm9yZSBydW5uaW5nIGNvbmZpZ3VyZQotc3JjZGly PWBkaXJuYW1lICQwYAorc3JjZGlyPWBkaXJuYW1lICIkMCJgCiB0ZXN0IC16ICIkc3JjZGlyIiAm JiBzcmNkaXI9LgogCiBPUklHRElSPWBwd2RgCi1jZCAkc3JjZGlyCitjZCAiJHNyY2RpciIgfHwg ZXhpdCAxCiAKLXJtIC1mICR0b3Bfc3JjZGlyL2F1dG9tNHRlLmNhY2hlCitybSAtcmYgYXV0b200 dGUuY2FjaGUKIAogdG91Y2ggUkVBRE1FIElOU1RBTEwKIApAQCAtMTgsOSArMTgsOSBAQCBpZiB0 ZXN0IC16IGB3aGljaCBhdXRvcmVjb25mYDsgdGhlbgogZmkKIGF1dG9yZWNvbmYgLS12ZXJib3Nl IC0taW5zdGFsbCAtSSBTb3VyY2UvYXV0b3Rvb2xzICRBQ0xPQ0FMX0ZMQUdTfHwgZXhpdCAkPwog Ci1jZCAkT1JJR0RJUiB8fCBleGl0IDEKK2NkICIkT1JJR0RJUiIgfHwgZXhpdCAxCiAKIGlmIHRl c3QgLXogIiROT0NPTkZJR1VSRSI7IHRoZW4KLSAgICAkc3JjZGlyL2NvbmZpZ3VyZSAkQVVUT0dF Tl9DT05GSUdVUkVfQVJHUyAiJEAiIHx8IGV4aXQgJD8KKyAgICAiJHNyY2RpciIvY29uZmlndXJl ICRBVVRPR0VOX0NPTkZJR1VSRV9BUkdTICIkQCIgfHwgZXhpdCAkPwogZmkKIAo= 211291 2013-09-11 02:42:20 -0700 2013-09-11 02:43:45 -0700 Patch 19512.diff text/plain 1431 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyYTE1ZWI0Li5iODQ0NDRk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTMtMDktMTEgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAgICAg ICBVbnF1b3RlZCAkT1JJR0RJUiBpbiBhdXRvZ2VuLnNoCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFF1b3RlIGFsbCBkaXJlY3RvcnkgbmFtZXMuIFRoaXMg ZG9lc24ndCBtZWFuIHRoYXQgYWxsIHBvc3NpYmxlCisgICAgICAgIGRpcmVjdG9yeSBuYW1lcyBh cmUgc2FmZSBmb3IgYnVpbGRpbmcgd2Via2l0LCBidXQgdGhlIGNvbmZpZ3VyZQorICAgICAgICBz Y3JpcHQgYWxyZWFkeSBydW5zIGEgc2FuaXR5IGNoZWNrLgorCisgICAgICAgICogYXV0b2dlbi5z aDoKKwogMjAxMy0wOS0xMCAgTWFyY2VsbyBNb3JhaXMgIDxtLm1vcmFpc0BzYW1zdW5nLmNvbT4K IAogICAgICAgICBbRUZMXSBXZWJJbnNwZWN0b3I6IE1vdmUgdG8gbmV3IHdlYmluc3BlY3Rvcgpk aWZmIC0tZ2l0IGEvYXV0b2dlbi5zaCBiL2F1dG9nZW4uc2gKaW5kZXggMTJjNmE0Yy4uYzY2ODhk NCAxMDA3NTUKLS0tIGEvYXV0b2dlbi5zaAorKysgYi9hdXRvZ2VuLnNoCkBAIC0yLDExICsyLDEx IEBACiAKICMgQWxsb3cgaW52b2NhdGlvbiBmcm9tIGEgc2VwYXJhdGUgYnVpbGQgZGlyZWN0b3J5 OyBpbiB0aGF0IGNhc2UsIHdlIGNoYW5nZQogIyB0byB0aGUgc291cmNlIGRpcmVjdG9yeSB0byBy dW4gdGhlIGF1dG8qLCB0aGVuIGNoYW5nZSBiYWNrIGJlZm9yZSBydW5uaW5nIGNvbmZpZ3VyZQot c3JjZGlyPWBkaXJuYW1lICQwYAorc3JjZGlyPWBkaXJuYW1lICIkMCJgCiB0ZXN0IC16ICIkc3Jj ZGlyIiAmJiBzcmNkaXI9LgogCiBPUklHRElSPWBwd2RgCi1jZCAkc3JjZGlyCitjZCAiJHNyY2Rp ciIgfHwgZXhpdCAxCiAKIHJtIC1mICR0b3Bfc3JjZGlyL2F1dG9tNHRlLmNhY2hlCiAKQEAgLTE4 LDkgKzE4LDkgQEAgaWYgdGVzdCAteiBgd2hpY2ggYXV0b3JlY29uZmA7IHRoZW4KIGZpCiBhdXRv cmVjb25mIC0tdmVyYm9zZSAtLWluc3RhbGwgLUkgU291cmNlL2F1dG90b29scyAkQUNMT0NBTF9G TEFHU3x8IGV4aXQgJD8KIAotY2QgJE9SSUdESVIgfHwgZXhpdCAxCitjZCAiJE9SSUdESVIiIHx8 IGV4aXQgMQogCiBpZiB0ZXN0IC16ICIkTk9DT05GSUdVUkUiOyB0aGVuCi0gICAgJHNyY2Rpci9j b25maWd1cmUgJEFVVE9HRU5fQ09ORklHVVJFX0FSR1MgIiRAIiB8fCBleGl0ICQ/CisgICAgIiRz cmNkaXIiL2NvbmZpZ3VyZSAkQVVUT0dFTl9DT05GSUdVUkVfQVJHUyAiJEAiIHx8IGV4aXQgJD8K IGZpCiAK