195113 2019-02-27 11:35:03 -0800 Web Inspector: popover colors don't change when transitioning to/from dark mode 2019-02-27 13:45:21 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker timothy webkit-bug-importer oldest_to_newest 1510528 0 hi 2019-02-27 11:35:03 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. find some CSS color in the Styles sidebar of the Elements tab 3. click the color swatch 4. go to System Preferences > General and change the appearance to Dark => the popover still has a light background 1510529 1 webkit-bug-importer 2019-02-27 11:35:40 -0800 <rdar://problem/48444188> 1510541 2 363111 hi 2019-02-27 11:50:37 -0800 Created attachment 363111 Patch 1510552 3 363111 commit-queue 2019-02-27 12:13:21 -0800 Comment on attachment 363111 Patch Clearing flags on attachment: 363111 Committed r242144: <https://trac.webkit.org/changeset/242144> 1510553 4 commit-queue 2019-02-27 12:13:22 -0800 All reviewed patches have been landed. Closing bug. 1510594 5 363111 mattbaker 2019-02-27 13:45:21 -0800 Comment on attachment 363111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363111&action=review > Source/WebInspectorUI/UserInterface/Views/Popover.js:587 > + this._prefersDarkColorSchemeMediaQueryList = window.matchMedia("(prefers-color-scheme: dark)"); Cool! 363111 2019-02-27 11:50:37 -0800 2019-02-27 12:13:21 -0800 Patch bug-195113-20190227115037.patch text/plain 2165 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyYzUwNDVhNDFiM2VkYzE4MGEyN2JiMmM3ZDE1 MWI0OGY5MjFiZGEuLjA1MDA5YjE5ODcxZTdhZDUzMDcwNDQ0Mzc0MzBlMGMwNTU1M2MzOWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTI3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBw b3BvdmVyIGNvbG9ycyBkb24ndCBjaGFuZ2Ugd2hlbiB0cmFuc2l0aW9uaW5nIHRvL2Zyb20gZGFy ayBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTUxMTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4NDQ0MTg4PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Q b3BvdmVyLmpzOgorICAgICAgICAoV0kuUG9wb3Zlci5wcm90b3R5cGUuZGlzbWlzcyk6CisgICAg ICAgIChXSS5Qb3BvdmVyLnByb3RvdHlwZS5fYWRkTGlzdGVuZXJzSWZOZWVkZWQpOgorCiAyMDE5 LTAyLTI2ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBVc2Ugc3lzdGVtIGFjY2VudCBjb2xvciB0aHJvdWdob3V0IFVJCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qb3BvdmVyLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUG9wb3Zlci5qcwpp bmRleCAyNjE4ZjFiNjZhMzM1MDc1N2Q2Nzc4MDIxZGM3YTdlOWM4NmQ4OTk4Li5iODQ1ZTViMjcx ZTg3MzU5NTVlODczNDRiZTBlNDExYjJlOTMwZmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qb3BvdmVyLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1BvcG92ZXIuanMKQEAgLTE1Niw2ICsxNTYs OCBAQCBXSS5Qb3BvdmVyID0gY2xhc3MgUG9wb3ZlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAg ICB3aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigicmVzaXplIiwgdGhpcywgdHJ1ZSk7CiAgICAg ICAgIHdpbmRvdy5yZW1vdmVFdmVudExpc3RlbmVyKCJrZXlwcmVzcyIsIHRoaXMsIHRydWUpOwog CisgICAgICAgIHRoaXMuX3ByZWZlcnNEYXJrQ29sb3JTY2hlbWVNZWRpYVF1ZXJ5TGlzdC5yZW1v dmVMaXN0ZW5lcih0aGlzLl9ib3VuZFVwZGF0ZSk7CisKICAgICAgICAgV0kucXVpY2tDb25zb2xl LmtleWJvYXJkU2hvcnRjdXREaXNhYmxlZCA9IGZhbHNlOwogCiAgICAgICAgIHRoaXMuX2VsZW1l bnQuY2xhc3NMaXN0LmFkZChXSS5Qb3BvdmVyLkZhZGVPdXRDbGFzc05hbWUpOwpAQCAtNTc4LDYg KzU4MCwxMyBAQCBXSS5Qb3BvdmVyID0gY2xhc3MgUG9wb3ZlciBleHRlbmRzIFdJLk9iamVjdAog ICAgICAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInJlc2l6ZSIsIHRoaXMsIHRydWUp OwogICAgICAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImtleXByZXNzIiwgdGhpcywg dHJ1ZSk7CiAKKyAgICAgICAgICAgIGlmICghdGhpcy5fYm91bmRVcGRhdGUpCisgICAgICAgICAg ICAgICAgdGhpcy5fYm91bmRVcGRhdGUgPSB0aGlzLl91cGRhdGUuYmluZCh0aGlzKTsKKworICAg ICAgICAgICAgaWYgKCF0aGlzLl9wcmVmZXJzRGFya0NvbG9yU2NoZW1lTWVkaWFRdWVyeUxpc3Qp CisgICAgICAgICAgICAgICAgdGhpcy5fcHJlZmVyc0RhcmtDb2xvclNjaGVtZU1lZGlhUXVlcnlM aXN0ID0gd2luZG93Lm1hdGNoTWVkaWEoIihwcmVmZXJzLWNvbG9yLXNjaGVtZTogZGFyaykiKTsK KyAgICAgICAgICAgIHRoaXMuX3ByZWZlcnNEYXJrQ29sb3JTY2hlbWVNZWRpYVF1ZXJ5TGlzdC5h ZGRMaXN0ZW5lcih0aGlzLl9ib3VuZFVwZGF0ZSk7CisKICAgICAgICAgICAgIFdJLnF1aWNrQ29u c29sZS5rZXlib2FyZFNob3J0Y3V0RGlzYWJsZWQgPSB0cnVlOwogICAgICAgICB9CiAgICAgfQo=