195101 2019-02-27 09:34:28 -0800 Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled 2025-11-05 00:11:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 301972 1 cdumez cdumez achristensen beidson commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1510458 0 cdumez 2019-02-27 09:34:28 -0800 Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled. 1510459 1 cdumez 2019-02-27 09:34:42 -0800 <rdar://problem/48423023> 1510468 2 363097 cdumez 2019-02-27 09:55:18 -0800 Created attachment 363097 Patch 1510486 3 363097 ggaren 2019-02-27 10:30:15 -0800 Comment on attachment 363097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363097&action=review r=me with one change > Source/WebCore/page/DOMWindow.cpp:1894 > + if (!isSameSecurityOriginAsMainFrame() || !isSecureContext()) > + return; Can you add a test for needsSiteSpecificQuirks here, so that website developers can disable the quirk when testing a fix? 1510487 4 363097 cdumez 2019-02-27 10:31:06 -0800 Comment on attachment 363097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363097&action=review > Source/WebCore/ChangeLog:13 > + Unfortunately, document()->settings().needsSiteSpecificQuirks() is false on iOS so I could not See this line in the change log. 1510488 5 ggaren 2019-02-27 10:34:23 -0800 Sad face. 1510511 6 363097 commit-queue 2019-02-27 11:03:27 -0800 Comment on attachment 363097 Patch Clearing flags on attachment: 363097 Committed r242138: <https://trac.webkit.org/changeset/242138> 1510512 7 commit-queue 2019-02-27 11:03:29 -0800 All reviewed patches have been landed. Closing bug. 363097 2019-02-27 09:55:18 -0800 2019-02-27 11:03:27 -0800 Patch bug-195101-20190227095517.patch text/plain 3743 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMwYTRlMDQxM2I0YjQ5 MTMwZTM2YWZlYWZhYTk2NDlmZTY0ZTM3OC4uYTdjYTAyZWY1MjBiYjQ5OWRlNTk0OTJmY2ZmNmUy OWI1NGE2ZGU5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTAyLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVW5hYmxlIHRvIGxvZyBpbnRv IGNoYXNlLmNvbSBvbiBpUGFkIHdoZW4gRGV2aWNlTW90aW9uRXZlbnQgQVBJIGlzIGRpc2FibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUxMDEK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4NDIzMDIzPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzaXRlLXNwZWNpZmljIHF1aXJrIGZvciBj aGFzZS5jb20gb24gaU9TIHdoZXJlIHdlIGZpcmUgYSBkdW1teSBEZXZpY2VNb3Rpb25FdmVudCBp ZiB0aGUgcGFnZQorICAgICAgICB0cmllcyB0byByZWdpc3RlciBhICJkZXZpY2Vtb3Rpb24iIGV2 ZW50IGxpc3RlbmVyIGFuZCBmYWlscyBiZWNhdXNlIHRoZSBBUEkgaXMgZGlzYWJsZWQuIFRoaXMg aXMKKyAgICAgICAgbmVlZGVkIHRvIHVuYmxvY2sgdGhlIHNpdGUgYW5kIHByb2NlZWQgd2l0aCB0 aGUgbG9naW4gZmxvdy4KKworICAgICAgICBVbmZvcnR1bmF0ZWx5LCBkb2N1bWVudCgpLT5zZXR0 aW5ncygpLm5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKCkgaXMgZmFsc2Ugb24gaU9TIHNvIEkgY291 bGQgbm90CisgICAgICAgIGd1YXJkIHRoZSBxdWlyayBiZWhpbmQgdGhpcyBmbGFnLgorCisgICAg ICAgICogcGFnZS9ET01XaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93Ojph ZGRFdmVudExpc3RlbmVyKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6ZmFpbGVkVG9S ZWdpc3RlckRldmljZU1vdGlvbkV2ZW50TGlzdGVuZXIpOgorICAgICAgICAqIHBhZ2UvRE9NV2lu ZG93Lmg6CisKIDIwMTktMDItMjYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIGNvbmRpdGlvbmFsIGNvbXBpbGUgZ3VhcmQgZm9yIEluc2Vy dEludG9UZXh0Tm9kZUNvbW1hbmQ6OmRvUmVhcHBseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3Bw CmluZGV4IGZhNzVhYzU0ZWFkNTE3OGU3MGJkMGQ3OTUwYzMxMDUxNGU0MDczM2MuLmE5MTE2ZDJl OTY4NTk2ZmZlNWI3MmY2MjE3NzNlMzNiYmRhMTcyNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRv dy5jcHAKQEAgLTQ3LDYgKzQ3LDggQEAKICNpbmNsdWRlICJET01VUkwuaCIKICNpbmNsdWRlICJE T01XaW5kb3dFeHRlbnNpb24uaCIKICNpbmNsdWRlICJEZXZpY2VNb3Rpb25Db250cm9sbGVyLmgi CisjaW5jbHVkZSAiRGV2aWNlTW90aW9uRGF0YS5oIgorI2luY2x1ZGUgIkRldmljZU1vdGlvbkV2 ZW50LmgiCiAjaW5jbHVkZSAiRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyLmgiCiAjaW5jbHVk ZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJEb2N1bWVudExvYWRlci5oIgpAQCAtMTg3NiwxMiAr MTg3OCwzNiBAQCBib29sIERPTVdpbmRvdzo6YWRkRXZlbnRMaXN0ZW5lcihjb25zdCBBdG9taWNT dHJpbmcmIGV2ZW50VHlwZSwgUmVmPEV2ZW50TGlzdGVuZQogICAgICAgICAgICAgfQogICAgICAg ICB9CiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICB9CisgICAgfSBlbHNlIGlm IChldmVudFR5cGUgPT0gZXZlbnROYW1lcygpLmRldmljZW1vdGlvbkV2ZW50KQorICAgICAgICBm YWlsZWRUb1JlZ2lzdGVyRGV2aWNlTW90aW9uRXZlbnRMaXN0ZW5lcigpOwogI2VuZGlmIC8vIEVO QUJMRShERVZJQ0VfT1JJRU5UQVRJT04pCiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorI2lmIEVO QUJMRShERVZJQ0VfT1JJRU5UQVRJT04pCisKK3ZvaWQgRE9NV2luZG93OjpmYWlsZWRUb1JlZ2lz dGVyRGV2aWNlTW90aW9uRXZlbnRMaXN0ZW5lcigpCit7CisjaWYgUExBVEZPUk0oSU9TX0ZBTUlM WSkKKyAgICBpZiAoIWlzU2FtZVNlY3VyaXR5T3JpZ2luQXNNYWluRnJhbWUoKSB8fCAhaXNTZWN1 cmVDb250ZXh0KCkpCisgICAgICAgIHJldHVybjsKKworICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEg cXVpcmsgZm9yIGNoYXNlLmNvbSBvbiBpUGFkICg8cmRhcjovL3Byb2JsZW0vNDg0MjMwMjM+KS4K KyAgICBpZiAodG9SZWdpc3RyYWJsZURvbWFpbihkb2N1bWVudCgpLT51cmwoKSkgPT0gImNoYXNl LmNvbSIpIHsKKyAgICAgICAgLy8gRmlyZSBhIGZha2UgRGV2aWNlTW90aW9uRXZlbnQgd2l0aCBh Y2NlbGVyYXRpb24gZGF0YSB0byB1bmJsb2NrIHRoZSBzaXRlJ3MgbG9naW4gZmxvdy4KKyAgICAg ICAgZG9jdW1lbnQoKS0+cG9zdFRhc2soW10oYXV0byYgY29udGV4dCkgeworICAgICAgICAgICAg aWYgKGF1dG8qIHdpbmRvdyA9IGRvd25jYXN0PERvY3VtZW50Pihjb250ZXh0KS5kb21XaW5kb3co KSkgeworICAgICAgICAgICAgICAgIGF1dG8gYWNjZWxlcmF0aW9uID0gRGV2aWNlTW90aW9uRGF0 YTo6QWNjZWxlcmF0aW9uOjpjcmVhdGUoKTsKKyAgICAgICAgICAgICAgICB3aW5kb3ctPmRpc3Bh dGNoRXZlbnQoRGV2aWNlTW90aW9uRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkuZGV2aWNlbW90 aW9uRXZlbnQsIERldmljZU1vdGlvbkRhdGE6OmNyZWF0ZShhY2NlbGVyYXRpb24uY29weVJlZigp LCBhY2NlbGVyYXRpb24uY29weVJlZigpLCBEZXZpY2VNb3Rpb25EYXRhOjpSb3RhdGlvblJhdGU6 OmNyZWF0ZSgpLCBXVEY6Om51bGxvcHQpLnB0cigpKSk7CisgICAgICAgICAgICB9CisgICAgICAg IH0pOworICAgIH0KKyNlbmRpZiAvLyBQTEFURk9STShJT1NfRkFNSUxZKQorfQorCisjZW5kaWYg Ly8gRU5BQkxFKERFVklDRV9PUklFTlRBVElPTikKKwogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkp CiAKIHZvaWQgRE9NV2luZG93OjppbmNyZW1lbnRTY3JvbGxFdmVudExpc3RlbmVyc0NvdW50KCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmggYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5oCmluZGV4IDhhOWM4MGEwYjFlMTUyZmU0NzVkY2Q4NGZhNGE1 YzBkYjgwMTZjNmQuLmJiYmZhOTU4NzJlNGEzM2U3MzQyNTI4MWU0YWNjYjRmNzA1OWIxYzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9ET01XaW5kb3cuaApAQCAtMzUzLDYgKzM1MywxMCBAQCBwcml2YXRlOgogCiAg ICAgdm9pZCByZXNldERPTVdpbmRvd1Byb3BlcnRpZXMoKTsKIAorI2lmIEVOQUJMRShERVZJQ0Vf T1JJRU5UQVRJT04pCisgICAgdm9pZCBmYWlsZWRUb1JlZ2lzdGVyRGV2aWNlTW90aW9uRXZlbnRM aXN0ZW5lcigpOworI2VuZGlmCisKICAgICBib29sIGlzU2FtZVNlY3VyaXR5T3JpZ2luQXNNYWlu RnJhbWUoKSBjb25zdDsKIAogI2lmIEVOQUJMRShHQU1FUEFEKQo=