19510 2008-06-11 22:38:04 -0700 CodeBlock::needsFullScopeChain not always set for global code 2008-06-22 17:59:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich webkit-unassigned ggaren mjs oliver oldest_to_newest 83082 0 zwarich 2008-06-11 22:38:04 -0700 If a unit of global code doesn't define any functions, the associated CodeBlock does not have needsFullScopeChain set. Since we use this to test for copying local variables to temporaries when necessary, it leads to incorrect behaviour. I will post a test case in the next post. 83083 1 21653 zwarich 2008-06-11 22:39:06 -0700 Created attachment 21653 Test case 83093 2 21657 zwarich 2008-06-12 01:57:59 -0700 Created attachment 21657 Patch to fix symptoms Here is a patch that fixes the symptoms, but we should still try to more clearly define the meaning of needsFullScopeChain. 83094 3 21657 mjs 2008-06-12 01:59:26 -0700 Comment on attachment 21657 Patch to fix symptoms r=me 83095 4 zwarich 2008-06-12 02:05:35 -0700 Landed in r34510. 21653 2008-06-11 22:39:06 -0700 2008-06-11 22:39:23 -0700 Test case test.html text/html 180 zwarich PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBmKCkKewogICAgYSA9IDEwMDsKICAgIHJl dHVybiAxOwp9Cjwvc2NyaXB0Pgo8c2NyaXB0Pgp2YXIgYSA9IDE7CmEgKz0gZigpOwphbGVydChh ID09IDIgPyAiUEFTUyIgOiAiRkFJTCIpOwo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KPC9ib2R5 Pgo8L2h0bWw+ 21657 2008-06-12 01:57:59 -0700 2008-06-12 01:59:26 -0700 Patch to fix symptoms multiglobal.diff text/plain 5842 zwarich SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM0NTA4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDYtMTIgIENhbWVyb24g WndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE5NTEwOiBDb2RlQmxvY2s6Om5lZWRzRnVs bFNjb3BlQ2hhaW4gbm90IGFsd2F5cyBzZXQgZm9yIGdsb2JhbCBjb2RlCisgICAgICAgIDxodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MTA+CisKKyAgICAgICAgVGhp cyBmaXhlcyB0aGUgc3ltcHRvbXMgYnkgdXNpbmcgQ29kZUdlbmVyYXRvcjo6bV9jb2RlVHlwZSB0 byBkZXRlcm1pbmUKKyAgICAgICAgd2hlbiB0byB1c2UgdGVtcG9yYXJpZXMgaW5zdGVhZCBvZiBD b2RlQmxvY2s6Om5lZWRzRnVsbFNjb3BlQ2hhaW4sIGJ1dAorICAgICAgICBpdCBkb2VzIG5vdCBm aXggdGhlIHByb2JsZW0gaXRzZWxmLgorCisgICAgICAgICogVk0vQ29kZUdlbmVyYXRvci5oOgor ICAgICAgICAoS0pTOjpDb2RlR2VuZXJhdG9yOjpsZWZ0SGFuZFNpZGVOZWVkc0NvcHkpOgorCiAy MDA4LTA2LTExICBDYW1lcm9uIFp3YXJpY2ggIDxjd3p3YXJpY2hAdXdhdGVybG9vLmNhPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL1ZNL0NvZGVH ZW5lcmF0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9WTS9Db2RlR2VuZXJhdG9y LmgJKHJldmlzaW9uIDM0NTA4KQorKysgSmF2YVNjcmlwdENvcmUvVk0vQ29kZUdlbmVyYXRvci5o CSh3b3JraW5nIGNvcHkpCkBAIC0xNzMsNyArMTczLDcgQEAgbmFtZXNwYWNlIEtKUyB7CiAKICAg ICAgICAgQUxXQVlTX0lOTElORSBib29sIGxlZnRIYW5kU2lkZU5lZWRzQ29weShib29sIHJpZ2h0 SGFzQXNzaWdubWVudHMpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHJldHVybiBtX2NvZGVCbG9j ay0+bmVlZHNGdWxsU2NvcGVDaGFpbiB8fCByaWdodEhhc0Fzc2lnbm1lbnRzOworICAgICAgICAg ICAgcmV0dXJuIG1fY29kZVR5cGUgIT0gRnVuY3Rpb25Db2RlIHx8IG1fY29kZUJsb2NrLT5uZWVk c0Z1bGxTY29wZUNoYWluIHx8IHJpZ2h0SGFzQXNzaWdubWVudHM7CiAgICAgICAgIH0KIAogICAg ICAgICBBTFdBWVNfSU5MSU5FIFBhc3NSZWZQdHI8UmVnaXN0ZXJJRD4gZW1pdE5vZGVGb3JMZWZ0 SGFuZFNpZGUoRXhwcmVzc2lvbk5vZGUqIG4sIGJvb2wgcmlnaHRIYXNBc3NpZ25tZW50cykKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDM0NTA4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDYtMTIgIENhbWVyb24gWndhcmljaCAgPGN3 endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdHMgZm9yOgorCisgICAgICAgIEJ1ZyAxOTUxMDogQ29kZUJsb2Nr OjpuZWVkc0Z1bGxTY29wZUNoYWluIG5vdCBhbHdheXMgc2V0IGZvciBnbG9iYWwgY29kZQorICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTEwPgorCisg ICAgICAgICogZmFzdC9qcy9jb2RlZ2VuLXRlbXBvcmFyaWVzLW11bHRpcGxlLWdsb2JhbC1ibG9j a3MtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL2NvZGVnZW4tdGVtcG9y YXJpZXMtbXVsdGlwbGUtZ2xvYmFsLWJsb2Nrcy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2pzL3Jlc291cmNlcy9jb2RlZ2VuLXRlbXBvcmFyaWVzLW11bHRpcGxlLWdsb2JhbC1ibG9ja3Mt MS5qczogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9yZXNvdXJjZXMvY29kZWdlbi10ZW1wb3Jh cmllcy1tdWx0aXBsZS1nbG9iYWwtYmxvY2tzLTIuanM6IEFkZGVkLgorCiAyMDA4LTA2LTExICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 ZSBIeWF0dC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvY29kZWdlbi10ZW1wb3Jhcmllcy1t dWx0aXBsZS1nbG9iYWwtYmxvY2tzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2pzL2NvZGVnZW4tdGVtcG9yYXJpZXMtbXVsdGlwbGUtZ2xvYmFsLWJsb2Nrcy1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2NvZGVnZW4t dGVtcG9yYXJpZXMtbXVsdGlwbGUtZ2xvYmFsLWJsb2Nrcy1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMTcgQEAKK1Rlc3RzIHdoZXRoZXIgYnl0ZWNvZGUgY29kZWdlbiBwcm9w ZXJseSBoYW5kbGVzIHRlbXBvcmFyaWVzIGFjcm9zcyBtdWx0aXBsZSBnbG9iYWwgYmxvY2tzLgor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB2MSBpcyAyCitQQVNTIG8yLmEg aXMgMgorUEFTUyBvMy5hIGlzIDIKK1BBU1MgcjQgaXMgMQorUEFTUyBvNS5hIGlzIDIKK1BBU1Mg bzYuYSBpcyAyCitQQVNTIG83LmEgaXMgMgorUEFTUyBvOC5hIGlzIDIKK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2pzL2NvZGVnZW4tdGVtcG9yYXJpZXMtbXVsdGlwbGUtZ2xvYmFsLWJsb2Nrcy5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvY29kZWdlbi10ZW1wb3Jhcmllcy1tdWx0 aXBsZS1nbG9iYWwtYmxvY2tzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2pzL2NvZGVnZW4tdGVtcG9yYXJpZXMtbXVsdGlwbGUtZ2xvYmFsLWJsb2Nrcy5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYv L0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBo cmVmPSJyZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9InJlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNj cmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0icmVz b3VyY2VzL2NvZGVnZW4tdGVtcG9yYXJpZXMtbXVsdGlwbGUtZ2xvYmFsLWJsb2Nrcy0xLmpzIj48 L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvY29kZWdlbi10ZW1wb3Jhcmllcy1tdWx0 aXBsZS1nbG9iYWwtYmxvY2tzLTIuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvY29kZWdlbi10ZW1wb3Jhcmllcy1tdWx0aXBsZS1n bG9iYWwtYmxvY2tzLTEuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNv dXJjZXMvY29kZWdlbi10ZW1wb3Jhcmllcy1tdWx0aXBsZS1nbG9iYWwtYmxvY2tzLTEuanMJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9jb2RlZ2VuLXRlbXBv cmFyaWVzLW11bHRpcGxlLWdsb2JhbC1ibG9ja3MtMS5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw0NyBAQAorZnVuY3Rpb24gYXNzaWduMSgpCit7CisgICAgdjEgPSAwOworICAgIHJldHVybiAx OworfQorCitmdW5jdGlvbiBhc3NpZ24yKCkKK3sKKyAgICB2MiA9IHsgYTogMCB9OworICAgIHJl dHVybiAyOworfQorCitmdW5jdGlvbiBhc3NpZ24zKCkKK3sKKyAgICB2MyA9IHsgYTogMCB9Owor ICAgIHJldHVybiAxOworfQorCitmdW5jdGlvbiBhc3NpZ240KCkKK3sKKyAgICB2NCA9IHsgYTog MCB9OworICAgIHJldHVybiAiYSI7Cit9CisKK2Z1bmN0aW9uIGFzc2lnbjUoKQoreworICAgIHY1 ID0geyBhOiAwIH07CisgICAgcmV0dXJuICJhIjsKK30KKworZnVuY3Rpb24gYXNzaWduNigpCit7 CisgICAgdjYgPSB7IGE6IDAgfTsKKyAgICByZXR1cm4gMjsKK30KKworZnVuY3Rpb24gYXNzaWdu NygpCit7CisgICAgdjcgPSB7IGE6IDAgfTsKKyAgICByZXR1cm4gImEiOworfQorCitmdW5jdGlv biBhc3NpZ244KCkKK3sKKyAgICB2OCA9IHsgYTogMCB9OworICAgIHJldHVybiAxOworfQpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvY29kZWdlbi10ZW1wb3Jhcmllcy1tdWx0 aXBsZS1nbG9iYWwtYmxvY2tzLTIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9q cy9yZXNvdXJjZXMvY29kZWdlbi10ZW1wb3Jhcmllcy1tdWx0aXBsZS1nbG9iYWwtYmxvY2tzLTIu anMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9jb2RlZ2Vu LXRlbXBvcmFyaWVzLW11bHRpcGxlLWdsb2JhbC1ibG9ja3MtMi5qcwkocmV2aXNpb24gMCkKQEAg LTAsMCArMSw0MyBAQAorZGVzY3JpcHRpb24oCisnVGVzdHMgd2hldGhlciBieXRlY29kZSBjb2Rl Z2VuIHByb3Blcmx5IGhhbmRsZXMgdGVtcG9yYXJpZXMgYWNyb3NzIG11bHRpcGxlIGdsb2JhbCBi bG9ja3MuJworKTsKKwordmFyIHYxID0gMTsKK3YxICs9IGFzc2lnbjEoKTsKK3Nob3VsZEJlKCJ2 MSIsICIyIik7CisKK3ZhciBvMiA9IHsgYTogMSB9OwordmFyIHYyID0gbzI7Cit2Mi5hID0gYXNz aWduMigpOworc2hvdWxkQmUoIm8yLmEiLCAiMiIpOworCit2YXIgbzMgPSB7IGE6IDEgfTsKK3Zh ciB2MyA9IG8zOwordjMuYSArPSBhc3NpZ24zKCk7CitzaG91bGRCZSgibzMuYSIsICIyIik7CisK K3ZhciB2NCA9IHsgYTogMSB9OwordmFyIHI0ID0gdjRbYXNzaWduNCgpXTsKK3Nob3VsZEJlKCJy NCIsICIxIik7CisKK3ZhciBvNSA9IHsgYTogMSB9OwordmFyIHY1ID0gbzU7Cit2NVthc3NpZ241 KCldID0gMjsKK3Nob3VsZEJlKCJvNS5hIiwgIjIiKTsKKwordmFyIG82ID0geyBhOiAxIH07Cit2 YXIgdjYgPSBvNjsKK3Y2WyJhIl0gPSBhc3NpZ242KCk7CitzaG91bGRCZSgibzYuYSIsICIyIik7 CisKK3ZhciBvNyA9IHsgYTogMSB9OwordmFyIHY3ID0gbzc7Cit2N1thc3NpZ243KCldICs9IDE7 CitzaG91bGRCZSgibzcuYSIsICIyIik7CisKK3ZhciBvOCA9IHsgYTogMSB9OwordmFyIHY4ID0g bzg7Cit2OFsiYSJdICs9IGFzc2lnbjgoKTsKK3Nob3VsZEJlKCJvOC5hIiwgIjIiKTsKKwordmFy IHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==