195081 2019-02-26 17:24:34 -0800 Web Inspector: Debugger: don't enable breakpoints when source location changes 2019-03-02 12:32:18 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1510288 0 hi 2019-02-26 17:24:34 -0800 # STEPS TO REPRODUCE: 1. inspect any page with a minified script 2. pretty print the script 3. set a breakpoint on any line 4. disable breakpoints 5. close Web Inspector 6. open Web Inspector => breakpoints start out disabled, but become enabled once the script becomes pretty printed 1510293 1 webkit-bug-importer 2019-02-26 17:30:02 -0800 <rdar://problem/48422701> 1510294 2 363044 hi 2019-02-26 17:30:12 -0800 Created attachment 363044 Patch 1510295 3 363045 hi 2019-02-26 17:30:32 -0800 Created attachment 363045 Patch 1511798 4 363045 joepeck 2019-03-02 01:52:06 -0800 Comment on attachment 363045 Patch r=me Wow, good find! 1511838 5 363045 commit-queue 2019-03-02 12:32:17 -0800 Comment on attachment 363045 Patch Clearing flags on attachment: 363045 Committed r242314: <https://trac.webkit.org/changeset/242314> 1511839 6 commit-queue 2019-03-02 12:32:18 -0800 All reviewed patches have been landed. Closing bug. 363044 2019-02-26 17:30:12 -0800 2019-02-26 17:30:31 -0800 Patch bug-195081-20190226173011.patch text/plain 2598 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYwMDY0Y2MxOGNiZDI5MGMwZThiNDQ3MGM0MTky Yzc1ODE0OTZkMDIuLjYzOTFkOWQ3YWFiMDM3YTliMGNmOGU4ZjZjNGFhMGIzYzdkY2M4NzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAyLTI2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE ZWJ1Z2dlcjogZG9uJ3QgZW5hYmxlIGJyZWFrcG9pbnRzIHdoZW4gc291cmNlIGxvY2F0aW9uIGNo YW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NTA4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanM6CisgICAgICAgIChX SS5EZWJ1Z2dlck1hbmFnZXIucHJvdG90eXBlLl9icmVha3BvaW50RGlzcGxheUxvY2F0aW9uRGlk Q2hhbmdlKToKKyAgICAgICAgKFdJLkRlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUuX2JyZWFrcG9p bnRFZGl0YWJsZVByb3BlcnR5RGlkQ2hhbmdlKToKKwogMjAxOS0wMi0yNiAgRGV2aW4gUm91c3Nv ICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2VhcmNoOiBu byByZXN1bHRzIHdoZW4gb3BlbmluZyB0byBTZWFyY2ggdGFiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1 Z2dlck1hbmFnZXIuanMKaW5kZXggOTNmZmVkNzkwNGEwZjEwNDRkNjAzZWY2Y2Q0OTM3YWVmZDkz N2Q5ZS4uNmMxNmJhOWM3NzVkNzA3OTY5YjZmZGFhMWUwNGRhNTlmNmI4NTU3OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdn ZXJNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcwpAQCAtMTAzNCwxNSArMTAzNCwxNCBAQCBXSS5E ZWJ1Z2dlck1hbmFnZXIgPSBjbGFzcyBEZWJ1Z2dlck1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QK ICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAvLyBSZW1vdmUgdGhlIGJyZWFrcG9pbnQg d2l0aCBpdHMgb2xkIGlkLgotICAgICAgICB0aGlzLl9yZW1vdmVCcmVha3BvaW50KGJyZWFrcG9p bnQsIGJyZWFrcG9pbnRSZW1vdmVkLmJpbmQodGhpcykpOwotCi0gICAgICAgIGZ1bmN0aW9uIGJy ZWFrcG9pbnRSZW1vdmVkKCkKLSAgICAgICAgeworICAgICAgICB0aGlzLl9yZW1vdmVCcmVha3Bv aW50KGJyZWFrcG9pbnQsICgpID0+IHsKICAgICAgICAgICAgIC8vIEFkZCB0aGUgYnJlYWtwb2lu dCBhdCBpdHMgbmV3IGxpbmVOdW1iZXIgYW5kIGdldCBhIG5ldyBpZC4KKyAgICAgICAgICAgIHRo aXMuX3Jlc3RvcmluZ0JyZWFrcG9pbnRzID0gdHJ1ZTsKICAgICAgICAgICAgIHRoaXMuX3NldEJy ZWFrcG9pbnQoYnJlYWtwb2ludCk7CisgICAgICAgICAgICB0aGlzLl9yZXN0b3JpbmdCcmVha3Bv aW50cyA9IGZhbHNlOwogCiAgICAgICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVy cyhXSS5EZWJ1Z2dlck1hbmFnZXIuRXZlbnQuQnJlYWtwb2ludE1vdmVkLCB7YnJlYWtwb2ludH0p OwotICAgICAgICB9CisgICAgICAgIH0pOwogICAgIH0KIAogICAgIF9icmVha3BvaW50RGlzYWJs ZWRTdGF0ZURpZENoYW5nZShldmVudCkKQEAgLTEwOTgsMTMgKzEwOTcsMTIgQEAgV0kuRGVidWdn ZXJNYW5hZ2VyID0gY2xhc3MgRGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAg ICAgICAgICByZXR1cm47CiAKICAgICAgICAgLy8gUmVtb3ZlIHRoZSBicmVha3BvaW50IHdpdGgg aXRzIG9sZCBpZC4KLSAgICAgICAgdGhpcy5fcmVtb3ZlQnJlYWtwb2ludChicmVha3BvaW50LCBi cmVha3BvaW50UmVtb3ZlZC5iaW5kKHRoaXMpKTsKLQotICAgICAgICBmdW5jdGlvbiBicmVha3Bv aW50UmVtb3ZlZCgpCi0gICAgICAgIHsKKyAgICAgICAgdGhpcy5fcmVtb3ZlQnJlYWtwb2ludChi cmVha3BvaW50LCAoKSA9PiB7CiAgICAgICAgICAgICAvLyBBZGQgdGhlIGJyZWFrcG9pbnQgd2l0 aCBpdHMgbmV3IHByb3BlcnRpZXMgYW5kIGdldCBhIG5ldyBpZC4KKyAgICAgICAgICAgIHRoaXMu X3Jlc3RvcmluZ0JyZWFrcG9pbnRzID0gdHJ1ZTsKICAgICAgICAgICAgIHRoaXMuX3NldEJyZWFr cG9pbnQoYnJlYWtwb2ludCk7Ci0gICAgICAgIH0KKyAgICAgICAgICAgIHRoaXMuX3Jlc3Rvcmlu Z0JyZWFrcG9pbnRzID0gZmFsc2U7CisgICAgICAgIH0pOwogICAgIH0KIAogICAgIF9oYW5kbGVC cmVha3BvaW50QWN0aW9uc0RpZENoYW5nZShldmVudCkK 363045 2019-02-26 17:30:32 -0800 2019-03-02 12:32:17 -0800 Patch bug-195081-20190226173031.patch text/plain 2633 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYwMDY0Y2MxOGNiZDI5MGMwZThiNDQ3MGM0MTky Yzc1ODE0OTZkMDIuLjNkYWFmZGM1ODE5YjNjOGIxYzM0ZTg3NmRjZDgzZjJhYmE5YzQxZTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTI2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE ZWJ1Z2dlcjogZG9uJ3QgZW5hYmxlIGJyZWFrcG9pbnRzIHdoZW4gc291cmNlIGxvY2F0aW9uIGNo YW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NTA4MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDg0MjI3MDE+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0RlYnVnZ2VyTWFuYWdlci5qczoKKyAgICAgICAgKFdJLkRlYnVnZ2VyTWFuYWdlci5wcm90 b3R5cGUuX2JyZWFrcG9pbnREaXNwbGF5TG9jYXRpb25EaWRDaGFuZ2UpOgorICAgICAgICAoV0ku RGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZS5fYnJlYWtwb2ludEVkaXRhYmxlUHJvcGVydHlEaWRD aGFuZ2UpOgorCiAyMDE5LTAyLTI2ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTZWFyY2g6IG5vIHJlc3VsdHMgd2hlbiBvcGVuaW5n IHRvIFNlYXJjaCB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcwppbmRleCA5 M2ZmZWQ3OTA0YTBmMTA0NGQ2MDNlZjZjZDQ5MzdhZWZkOTM3ZDllLi42YzE2YmE5Yzc3NWQ3MDc5 NjliNmZkYWExZTA0ZGE1OWY2Yjg1NTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5h Z2VyLmpzCkBAIC0xMDM0LDE1ICsxMDM0LDE0IEBAIFdJLkRlYnVnZ2VyTWFuYWdlciA9IGNsYXNz IERlYnVnZ2VyTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgcmV0dXJuOwog CiAgICAgICAgIC8vIFJlbW92ZSB0aGUgYnJlYWtwb2ludCB3aXRoIGl0cyBvbGQgaWQuCi0gICAg ICAgIHRoaXMuX3JlbW92ZUJyZWFrcG9pbnQoYnJlYWtwb2ludCwgYnJlYWtwb2ludFJlbW92ZWQu YmluZCh0aGlzKSk7Ci0KLSAgICAgICAgZnVuY3Rpb24gYnJlYWtwb2ludFJlbW92ZWQoKQotICAg ICAgICB7CisgICAgICAgIHRoaXMuX3JlbW92ZUJyZWFrcG9pbnQoYnJlYWtwb2ludCwgKCkgPT4g ewogICAgICAgICAgICAgLy8gQWRkIHRoZSBicmVha3BvaW50IGF0IGl0cyBuZXcgbGluZU51bWJl ciBhbmQgZ2V0IGEgbmV3IGlkLgorICAgICAgICAgICAgdGhpcy5fcmVzdG9yaW5nQnJlYWtwb2lu dHMgPSB0cnVlOwogICAgICAgICAgICAgdGhpcy5fc2V0QnJlYWtwb2ludChicmVha3BvaW50KTsK KyAgICAgICAgICAgIHRoaXMuX3Jlc3RvcmluZ0JyZWFrcG9pbnRzID0gZmFsc2U7CiAKICAgICAg ICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLkRlYnVnZ2VyTWFuYWdlci5F dmVudC5CcmVha3BvaW50TW92ZWQsIHticmVha3BvaW50fSk7Ci0gICAgICAgIH0KKyAgICAgICAg fSk7CiAgICAgfQogCiAgICAgX2JyZWFrcG9pbnREaXNhYmxlZFN0YXRlRGlkQ2hhbmdlKGV2ZW50 KQpAQCAtMTA5OCwxMyArMTA5NywxMiBAQCBXSS5EZWJ1Z2dlck1hbmFnZXIgPSBjbGFzcyBEZWJ1 Z2dlck1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAgICAgICAgICAgIHJldHVybjsKIAogICAg ICAgICAvLyBSZW1vdmUgdGhlIGJyZWFrcG9pbnQgd2l0aCBpdHMgb2xkIGlkLgotICAgICAgICB0 aGlzLl9yZW1vdmVCcmVha3BvaW50KGJyZWFrcG9pbnQsIGJyZWFrcG9pbnRSZW1vdmVkLmJpbmQo dGhpcykpOwotCi0gICAgICAgIGZ1bmN0aW9uIGJyZWFrcG9pbnRSZW1vdmVkKCkKLSAgICAgICAg eworICAgICAgICB0aGlzLl9yZW1vdmVCcmVha3BvaW50KGJyZWFrcG9pbnQsICgpID0+IHsKICAg ICAgICAgICAgIC8vIEFkZCB0aGUgYnJlYWtwb2ludCB3aXRoIGl0cyBuZXcgcHJvcGVydGllcyBh bmQgZ2V0IGEgbmV3IGlkLgorICAgICAgICAgICAgdGhpcy5fcmVzdG9yaW5nQnJlYWtwb2ludHMg PSB0cnVlOwogICAgICAgICAgICAgdGhpcy5fc2V0QnJlYWtwb2ludChicmVha3BvaW50KTsKLSAg ICAgICAgfQorICAgICAgICAgICAgdGhpcy5fcmVzdG9yaW5nQnJlYWtwb2ludHMgPSBmYWxzZTsK KyAgICAgICAgfSk7CiAgICAgfQogCiAgICAgX2hhbmRsZUJyZWFrcG9pbnRBY3Rpb25zRGlkQ2hh bmdlKGV2ZW50KQo=