195067 2019-02-26 13:17:23 -0800 Remove conditional compile guard for InsertIntoTextNodeCommand::doReapply 2019-02-26 17:13:57 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin bfulgham commit-queue rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1510165 0 wenson_hsieh 2019-02-26 13:17:23 -0800 <rdar://problem/44812080> 1510166 1 wenson_hsieh 2019-02-26 13:17:36 -0800 This appears to be unnecessarily special-cased. 1510209 2 363024 wenson_hsieh 2019-02-26 14:49:17 -0800 Created attachment 363024 Patch 1510280 3 363024 commit-queue 2019-02-26 17:13:56 -0800 Comment on attachment 363024 Patch Clearing flags on attachment: 363024 Committed r242117: <https://trac.webkit.org/changeset/242117> 1510281 4 commit-queue 2019-02-26 17:13:57 -0800 All reviewed patches have been landed. Closing bug. 363024 2019-02-26 14:49:17 -0800 2019-02-26 17:13:56 -0800 Patch bug-195067-20190226144916.patch text/plain 5875 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBmZDc2MzlkYWFmNGEz MzM0NWRjOTBmZjI1NmE0YjQ3OGQwNjM5OC4uNTg0NDk4NmZiNDAwMTg1YzE4Njg1YTZjMzRmYjQ3 ZTFmY2EwNTg1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTAyLTI2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBjb25k aXRpb25hbCBjb21waWxlIGd1YXJkIGZvciBJbnNlcnRJbnRvVGV4dE5vZGVDb21tYW5kOjpkb1Jl YXBwbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NTA2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDQ4MTIwODA+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpT1Mtc3BlY2lmaWMgb3ZlcnJp ZGUgd2FzIGludHJvZHVjZWQgdG8gZml4IDxyZGFyOi8vcHJvYmxlbS83MTE0NDI1PiwgaW4gd2hp Y2ggdGhlIGxhc3QgdHlwZWQgY2hhcmFjdGVyCisgICAgICAgIHdvdWxkIGJlIHJldmVhbGVkIHdo ZW4gcmVkb2luZyB0ZXh0IGlucHV0IG9uIGlPUyBpbnNpZGUgYSBwYXNzd29yZCBmaWVsZC4gVGhl IGFzc29jaWF0ZWQgY2hhbmdlIGZpeGVkIHRoaXMgYnVnCisgICAgICAgIGJ5IG92ZXJyaWRpbmcg ZG9SZWFwcGx5IG9uIGlPUyB0byBvbmx5IGluc2VydCB0ZXh0IChpbnN0ZWFkIG9mIGFkZGl0aW9u YWxseSBoYW5kbGluZyBwYXNzd29yZCBlY2hvKTsgaG93ZXZlciwgaXQKKyAgICAgICAgcmVhbGx5 IG1ha2VzIHNlbnNlIHRvIHNraXAgcGFzc3dvcmQgZWNobyB3aGVuIHJlZG9pbmcgb24gYWxsIHBs YXRmb3Jtcywgc28gd2UgY2FuIGp1c3QgcmVtb3ZlIHRoZSBwbGF0Zm9ybS0KKyAgICAgICAgc3Bl Y2lmaWMgZ3VhcmRzIGFyb3VuZCB0aGlzIGxvZ2ljLgorCisgICAgICAgIERvaW5nIHRoaXMgYWxs b3dzIHVzIHRvIGFkZCB0aGUgYGhhc0VkaXRhYmxlU3R5bGUoKWAgY2hlY2sgb24gaU9TIHdoZW4g cmVkb2luZyB0ZXh0IGluc2VydGlvbiwgd2hpY2ggcmVzdWx0cyBpbgorICAgICAgICBhIHZlcnkg c3VidGxlIGJlaGF2aW9yIGNoYW5nZSBjb3ZlcmVkIGJ5IHRoZSBuZXcgbGF5b3V0IHRlc3QgYmVs b3cuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy91bmRvL3JlZG8tdGV4dC1pbnNlcnRpb24taW4t bm9uLWVkaXRhYmxlLW5vZGUuaHRtbAorCisgICAgICAgICogZWRpdGluZy9JbnNlcnRJbnRvVGV4 dE5vZGVDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc2VydEludG9UZXh0Tm9kZUNv bW1hbmQ6OmRvUmVhcHBseSk6CisgICAgICAgICogZWRpdGluZy9JbnNlcnRJbnRvVGV4dE5vZGVD b21tYW5kLmg6CisKIDIwMTktMDItMjYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgW2lPU10gUHJvZ3JhbW1hdGljIHBhc3RlIGFjY2VzcyBzaG91bGQg YmUgZ3JhbnRlZCB3aGVuIGNvcHlpbmcgYW5kIHBhc3Rpbmcgd2l0aGluIHRoZSBzYW1lIG9yaWdp bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNlcnRJbnRvVGV4dE5vZGVD b21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0SW50b1RleHROb2RlQ29t bWFuZC5jcHAKaW5kZXggYmE1ZDI4ZWQ4YzZlNDcyNDYzNTljZmM4MmU0YmMyY2VjMjE4YjE1Mi4u NzMwNzZkZTFiNzliOWYwOWZmOWYzMTI3YTgzZTViMDgzZDU3ODU5MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9JbnNlcnRJbnRvVGV4dE5vZGVDb21tYW5kLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luc2VydEludG9UZXh0Tm9kZUNvbW1hbmQuY3BwCkBAIC02 NSwxOCArNjUsMTQgQEAgdm9pZCBJbnNlcnRJbnRvVGV4dE5vZGVDb21tYW5kOjpkb0FwcGx5KCkK ICAgICBtX25vZGUtPmluc2VydERhdGEobV9vZmZzZXQsIG1fdGV4dCk7CiB9CiAKLSNpZiBQTEFU Rk9STShJT1NfRkFNSUxZKQotCi0vLyBGSVhNRTogV2h5IHdvdWxkIHJlYXBwbHkgYmUgaU9TLXNw ZWNpZmljPwogdm9pZCBJbnNlcnRJbnRvVGV4dE5vZGVDb21tYW5kOjpkb1JlYXBwbHkoKQogewot ICAgIC8vIEZJWE1FOiBTaG91bGRuJ3QgdGhpcyBoYXZlIGEgaGFzRWRpdGFibGVTdHlsZSBjaGVj az8KKyAgICBpZiAoIW1fbm9kZS0+aGFzRWRpdGFibGVTdHlsZSgpKQorICAgICAgICByZXR1cm47 CiAKICAgICBtX25vZGUtPmluc2VydERhdGEobV9vZmZzZXQsIG1fdGV4dCk7CiB9CiAKLSNlbmRp ZgotICAgIAogdm9pZCBJbnNlcnRJbnRvVGV4dE5vZGVDb21tYW5kOjpkb1VuYXBwbHkoKQogewog ICAgIGlmICghbV9ub2RlLT5oYXNFZGl0YWJsZVN0eWxlKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0luc2VydEludG9UZXh0Tm9kZUNvbW1hbmQuaCBiL1NvdXJjZS9XZWJD b3JlL2VkaXRpbmcvSW5zZXJ0SW50b1RleHROb2RlQ29tbWFuZC5oCmluZGV4IGE1NGMxNzJmMDNm YjBkMTJlZGU5MmY3ZmNmNTdiMGNiZDhiOTZjZmUuLjIzNmRkNmY1MjgwODcyMTU5N2M3ZjFkNGVj YzQwZjg1MWNjOThhOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0 SW50b1RleHROb2RlQ29tbWFuZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5zZXJ0 SW50b1RleHROb2RlQ29tbWFuZC5oCkBAIC00Niw5ICs0Niw3IEBAIHByb3RlY3RlZDoKIHByaXZh dGU6CiAgICAgdm9pZCBkb0FwcGx5KCkgb3ZlcnJpZGU7CiAgICAgdm9pZCBkb1VuYXBwbHkoKSBv dmVycmlkZTsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogICAgIHZvaWQgZG9SZWFwcGx5KCkg b3ZlcnJpZGU7Ci0jZW5kaWYKICAgICAKICNpZm5kZWYgTkRFQlVHCiAgICAgdm9pZCBnZXROb2Rl c0luQ29tbWFuZChIYXNoU2V0PE5vZGUqPiYpIG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDRkNTliNDE4MjM3 MzZjZGQ4ZWFiOWEyYmYyOTk4NDBjYTA3NzViMDIuLjc3NDNjOTRhZDk2NmY5MGM0MDA3YjE2NGM2 OTFkMTkzNjQ5M2FlZmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOS0wMi0yNiAgV2Vuc29u IEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgY29uZGl0 aW9uYWwgY29tcGlsZSBndWFyZCBmb3IgSW5zZXJ0SW50b1RleHROb2RlQ29tbWFuZDo6ZG9SZWFw cGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUw NjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0ODEyMDgwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5ldyBsYXlvdXQgdGVzdCB0byB2 ZXJpZnkgdGhhdCByZWRvaW5nIHRleHQgaW5zZXJ0aW9uIGluIGEgbm9uLWVkaXRhYmxlIGVsZW1l bnQgKHdoaWNoIHdhcyBwcmV2aW91c2x5CisgICAgICAgIGVkaXRhYmxlKSBkb2VzIG5vdCBtdXRh dGUgdGhlIHRleHQgbm9kZXMgYWZmZWN0ZWQgYnkgZWRpdGluZy4gVGhpcyB0ZXN0IGNhc2UgY3Vy cmVudGx5IGZhaWxzIG9uIGlPUywgc2luY2Ugd2UKKyAgICAgICAgdGFrZSBhIHNlcGFyYXRlIGNv ZGVwYXRoIHdoZW4gcmVkb2luZyB0aGF0IGRvZXMgbm90IGNvbnRhaW4gdGhpcyBhZGRpdGlvbmFs IGNoZWNrLgorCisgICAgICAgICogZWRpdGluZy91bmRvL3JlZG8tdGV4dC1pbnNlcnRpb24taW4t bm9uLWVkaXRhYmxlLW5vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5n L3VuZG8vcmVkby10ZXh0LWluc2VydGlvbi1pbi1ub24tZWRpdGFibGUtbm9kZS5odG1sOiBBZGRl ZC4KKwogMjAxOS0wMi0yNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBQcm9ncmFtbWF0aWMgcGFzdGUgYWNjZXNzIHNob3VsZCBiZSBncmFu dGVkIHdoZW4gY29weWluZyBhbmQgcGFzdGluZyB3aXRoaW4gdGhlIHNhbWUgb3JpZ2luCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3VuZG8vcmVkby10ZXh0LWluc2VydGlvbi1pbi1u b24tZWRpdGFibGUtbm9kZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3VuZG8v cmVkby10ZXh0LWluc2VydGlvbi1pbi1ub24tZWRpdGFibGUtbm9kZS1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNDUxOWY1OTU4Y2U2ZDg1YmQyODg5YjRjMjNlOWFiMDVmOTBkMWNlZQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvdW5kby9yZWRvLXRleHQtaW5zZXJ0aW9u LWluLW5vbi1lZGl0YWJsZS1ub2RlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitUaGlz IHRlc3QgdmVyaWZpZXMgdGhhdCByZWRvaW5nIHRleHQgaW5zZXJ0aW9uIGluIGEgbm9uLWVkaXRh YmxlIGVsZW1lbnQgaXMgYSBuby1vcC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2Vy aWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisK K1BBU1MgdGV4dE5vZGUuZGF0YSBpcyAiSGVsbG8iCitQQVNTIHRleHROb2RlLmRhdGEgaXMgIiIK K1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3VuZG8vcmVkby10ZXh0LWluc2VydGlvbi1pbi1u b24tZWRpdGFibGUtbm9kZS5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy91bmRvL3JlZG8tdGV4 dC1pbnNlcnRpb24taW4tbm9uLWVkaXRhYmxlLW5vZGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xNDg4NjI2 ZGQ2OWE4NDlmNzczMDFiOTcyNmM4Zjk3MWU2MzI3M2MzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZWRpdGluZy91bmRvL3JlZG8tdGV4dC1pbnNlcnRpb24taW4tbm9uLWVkaXRhYmxl LW5vZGUuaHRtbApAQCAtMCwwICsxLDIzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhl YWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+Cis8ZGl2IGlkPSJlZGl0b3IiIGNvbnRlbnRlZGl0YWJsZT48L2Rpdj4K KzwvYm9keT4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQg cmVkb2luZyB0ZXh0IGluc2VydGlvbiBpbiBhIG5vbi1lZGl0YWJsZSBlbGVtZW50IGlzIGEgbm8t b3AuIik7CitlZGl0b3IuZm9jdXMoKTsKKworZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydFRl eHQiLCB0cnVlLCAiSGVsbG8iKTsKK2NvbnN0IHRleHROb2RlID0gZWRpdG9yLmZpcnN0Q2hpbGQ7 CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoInRleHROb2RlLmRhdGEiLCAiSGVsbG8iKTsKKworZG9j dW1lbnQuZXhlY0NvbW1hbmQoIlVuZG8iKTsKK2VkaXRvci5zZXRBdHRyaWJ1dGUoImNvbnRlbnRl ZGl0YWJsZSIsICJmYWxzZSIpOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoIlJlZG8iKTsKKworc2hv dWxkQmVFcXVhbFRvU3RyaW5nKCJ0ZXh0Tm9kZS5kYXRhIiwgIiIpOworPC9zY3JpcHQ+Cis8L2h0 bWw+Cg==