195062 2019-02-26 12:03:39 -0800 [ContentChangeObserver] Move style recalc schedule observation logic to ContentChangeObserver 2019-02-26 13:01:32 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham cdumez dbates esprehn+autocc ews-watchlist kangil.han simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1510131 0 zalan 2019-02-26 12:03:39 -0800 ssia 1510132 1 webkit-bug-importer 2019-02-26 12:04:44 -0800 <rdar://problem/48409258> 1510135 2 363003 zalan 2019-02-26 12:12:42 -0800 Created attachment 363003 Patch 1510141 3 363003 thorton 2019-02-26 12:34:02 -0800 Comment on attachment 363003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363003&action=review > Source/WebCore/page/ios/ContentChangeObserver.mm:55 > + LOG_WITH_STREAM(ContentObservation, stream << "didInstallDOMTimer: registed this timer: (" << &timer << ") and observe when it fires."); REGISTED 1510153 4 zalan 2019-02-26 13:01:32 -0800 Committed r242102: <https://trac.webkit.org/changeset/242102> 363003 2019-02-26 12:12:42 -0800 2019-02-26 12:34:02 -0800 Patch bug-195062-20190226121241.patch text/plain 6938 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTA4YmMwYmY1MWM0ODhh ZDdkOWRhNTlkZmQxNTZlZjVkY2ViZTIwZS4uZmI1MWRjNjZjNGU3N2Q0OGFlZDZkNjlhYjU4NTE2 NjJkZTZlMTk5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTAyLTI2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNl cnZlcl0gTW92ZSBzdHlsZSByZWNhbGMgc2NoZWR1bGUgb2JzZXJ2YXRpb24gbG9naWMgdG8gQ29u dGVudENoYW5nZU9ic2VydmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTUwNjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4NDA5MjU4PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsc28gcmVuYW1l IHJlZ2lzdGVyRE9NVGltZXJGb3JDb250ZW50T2JzZXJ2YXRpb25JZk5lZWRlZCB0byBiZSBjb25z aXN0ZW50IHdpdGggdGhlIGRpZCogbmFtaW5nIHN0eWxlLgorCisgICAgICAgICogZG9tL0RvY3Vt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzY2hlZHVsZVN0eWxlUmVjYWxj KToKKyAgICAgICAgKiBwYWdlL0RPTVRpbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVRp bWVyOjppbnN0YWxsKToKKyAgICAgICAgKiBwYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIu aDoKKyAgICAgICAgKiBwYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIubW06CisgICAgICAg IChXZWJDb3JlOjpDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OmRpZEluc3RhbGxET01UaW1lcik6Cisg ICAgICAgIChXZWJDb3JlOjpDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OmRpZFNjaGVkdWxlU3R5bGVS ZWNhbGMpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudENoYW5nZU9ic2VydmVyOjpyZWdpc3Rl ckRPTVRpbWVyRm9yQ29udGVudE9ic2VydmF0aW9uSWZOZWVkZWQpOiBEZWxldGVkLgorCiAyMDE5 LTAyLTI2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvbnRl bnRDaGFuZ2VPYnNlcnZlcl0gU2ltcGxpZnkgY29udGVudCBvYnNlcnZhdGlvbiBBUEkgYnkgcmVt b3ZpbmcgZXhwbGljaXQgRE9NVGltZXIgb2JzZXJ2YXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cAppbmRleCA5ZjllZGQzZDMzZWJlNTk4ZGVmZDhiZGRkZjMxYzliNjYwZWJiOWY1Li41ZDMyMDcw MTI3MGFiYWUzOTI2OWQ1OTU4MDQ3OGIwNjY0MWI1YTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAKQEAgLTE4MDksMTcgKzE4MDksNiBAQCB2b2lkIERvY3VtZW50OjpzY2hlZHVsZVN0eWxlUmVj YWxjKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQVNTRVJUKGNoaWxkTmVlZHNTdHlsZVJlY2Fs YygpIHx8IG1fbmVlZHNGdWxsU3R5bGVSZWJ1aWxkKTsKLQotI2lmIFBMQVRGT1JNKElPU19GQU1J TFkpCi0gICAgaWYgKGF1dG8qIHBhZ2UgPSB0aGlzLT5wYWdlKCkpIHsKLSAgICAgICAgYXV0byYg Y29udGVudENoYW5nZU9ic2VydmVyID0gcGFnZS0+Y29udGVudENoYW5nZU9ic2VydmVyKCk7Ci0g ICAgICAgIGlmIChjb250ZW50Q2hhbmdlT2JzZXJ2ZXIuaXNPYnNlcnZpbmdTdHlsZVJlY2FsY1Nj aGVkdWxpbmcoKSkgewotICAgICAgICAgICAgTE9HX1dJVEhfU1RSRUFNKENvbnRlbnRPYnNlcnZh dGlvbiwgc3RyZWFtIDw8ICJEb2N1bWVudCgiIDw8IHRoaXMgPDwgIik6OnNjaGVkdWxlU3R5bGVS ZWNhbGM6IHJlZ2lzdGVyIHRoaXMgc3R5bGUgcmVjYWxjIHNjaGVkdWxlIGFuZCBvYnNlcnZlIHdo ZW4gaXQgZmlyZXMuIik7Ci0gICAgICAgICAgICBjb250ZW50Q2hhbmdlT2JzZXJ2ZXIuc2V0T2Jz ZXJ2ZWRDb250ZW50Q2hhbmdlKFdLQ29udGVudEluZGV0ZXJtaW5hdGVDaGFuZ2UpOwotICAgICAg ICB9Ci0gICAgfQotI2VuZGlmCi0KICAgICBhdXRvIHNob3VsZFRocm90dGxlU3R5bGVSZWNhbGMg PSBbJl0gewogICAgICAgICBpZiAoIXZpZXcoKSB8fCAhdmlldygpLT5pc1Zpc3VhbGx5Tm9uRW1w dHkoKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTE4MzIsNiArMTgyMSwxMCBAQCB2 b2lkIERvY3VtZW50OjpzY2hlZHVsZVN0eWxlUmVjYWxjKCkKICAgICAgICAgcmV0dXJuOwogCiAg ICAgbV9zdHlsZVJlY2FsY1RpbWVyLnN0YXJ0T25lU2hvdCgwX3MpOworI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpCisgICAgaWYgKGF1dG8qIHBhZ2UgPSB0aGlzLT5wYWdlKCkpCisgICAgICAgIHBh Z2UtPmNvbnRlbnRDaGFuZ2VPYnNlcnZlcigpLmRpZFNjaGVkdWxlU3R5bGVSZWNhbGMoKTsKKyNl bmRpZgogCiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRTY2hlZHVsZVN0eWxlUmVj YWxjdWxhdGlvbigqdGhpcyk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RP TVRpbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NVGltZXIuY3BwCmluZGV4IDU1NTg5 MGZlMTFmM2FmNjgyM2YxNTU5OTEzMTFjN2RlOTE5NTQ4YmQuLjYwMWE0N2M1OGVkNWE2NWEwOTNk OGMzYTNiMWRhNWZjZjZkZmRkNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9N VGltZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NVGltZXIuY3BwCkBAIC0yMjMs NyArMjIzLDcgQEAgaW50IERPTVRpbWVyOjppbnN0YWxsKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQm IGNvbnRleHQsIHN0ZDo6dW5pcXVlX3B0cjxTY2hlZHVsZWQKICAgICAgICAgbmVzdGVkVGltZXJz LT5hZGQodGltZXItPm1fdGltZW91dElkLCAqdGltZXIpOwogI2lmIFBMQVRGT1JNKElPU19GQU1J TFkpCiAgICAgaWYgKGlzPERvY3VtZW50Pihjb250ZXh0KSkKLSAgICAgICAgZG93bmNhc3Q8RG9j dW1lbnQ+KGNvbnRleHQpLnBhZ2UoKS0+Y29udGVudENoYW5nZU9ic2VydmVyKCkucmVnaXN0ZXJE T01UaW1lckZvckNvbnRlbnRPYnNlcnZhdGlvbklmTmVlZGVkKCp0aW1lciwgdGltZW91dCwgc2lu Z2xlU2hvdCk7CisgICAgICAgIGRvd25jYXN0PERvY3VtZW50Pihjb250ZXh0KS5wYWdlKCktPmNv bnRlbnRDaGFuZ2VPYnNlcnZlcigpLmRpZEluc3RhbGxET01UaW1lcigqdGltZXIsIHRpbWVvdXQs IHNpbmdsZVNob3QpOwogI2VuZGlmCiAgICAgcmV0dXJuIHRpbWVyLT5tX3RpbWVvdXRJZDsKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZl ci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmgKaW5k ZXggNmVhMWY0MDQwYTQwMGZjY2M3YjcxNTRkMmJmN2FkNThhOGRhOTMzNy4uZTlkYzlkMDMyMTk2 YWFlMDJhMGY1YjIyZTQ3ODBkYzZjOTA0MWExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLmgKQEAgLTM4LDIzICszOCwxOCBAQCBjbGFzcyBD b250ZW50Q2hhbmdlT2JzZXJ2ZXIgewogcHVibGljOgogICAgIENvbnRlbnRDaGFuZ2VPYnNlcnZl cihQYWdlJik7CiAKLSAgICB2b2lkIHJlZ2lzdGVyRE9NVGltZXJGb3JDb250ZW50T2JzZXJ2YXRp b25JZk5lZWRlZChjb25zdCBET01UaW1lciYsIFNlY29uZHMgdGltZW91dCwgYm9vbCBzaW5nbGVT aG90KTsKKyAgICB2b2lkIGRpZEluc3RhbGxET01UaW1lcihjb25zdCBET01UaW1lciYsIFNlY29u ZHMgdGltZW91dCwgYm9vbCBzaW5nbGVTaG90KTsKICAgICB2b2lkIHJlbW92ZURPTVRpbWVyKGNv bnN0IERPTVRpbWVyJik7CiAgICAgdm9pZCBzdGFydE9ic2VydmluZ0RPTVRpbWVyRXhlY3V0ZShj b25zdCBET01UaW1lciYpOwogICAgIHZvaWQgc3RvcE9ic2VydmluZ0RPTVRpbWVyRXhlY3V0ZShj b25zdCBET01UaW1lciYpOwogCisgICAgdm9pZCBkaWRTY2hlZHVsZVN0eWxlUmVjYWxjKCk7CiAg ICAgdm9pZCBzdGFydE9ic2VydmluZ1N0eWxlUmVzb2x2ZSgpOwogICAgIHZvaWQgc3RvcE9ic2Vy dmluZ1N0eWxlUmVzb2x2ZSgpOwogCiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzdGFydE9ic2Vy dmluZ0NvbnRlbnRDaGFuZ2VzKCk7CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzdG9wT2JzZXJ2 aW5nQ29udGVudENoYW5nZXMoKTsKIAotICAgIGJvb2wgaXNPYnNlcnZpbmdTdHlsZVJlY2FsY1Nj aGVkdWxpbmcoKTsKLQotICAgIHZvaWQgc2V0U2hvdWxkT2JzZXJ2ZU5leHRTdHlsZVJlY2FsYyhi b29sKTsKLSAgICBib29sIHNob3VsZE9ic2VydmVOZXh0U3R5bGVSZWNhbGMoKTsKLQotICAgIHZv aWQgc2V0T2JzZXJ2ZWRDb250ZW50Q2hhbmdlKFdLQ29udGVudENoYW5nZSk7CiAgICAgV0VCQ09S RV9FWFBPUlQgV0tDb250ZW50Q2hhbmdlIG9ic2VydmVkQ29udGVudENoYW5nZSgpOwogCiAgICAg V0VCQ09SRV9FWFBPUlQgdW5zaWduZWQgY291bnRPZk9ic2VydmVkRE9NVGltZXJzKCk7CkBAIC04 NSw3ICs4MCwxMyBAQCBwcml2YXRlOgogICAgIHZvaWQgc3RhcnRPYnNlcnZpbmdTdHlsZVJlY2Fs Y1NjaGVkdWxpbmcoKTsKICAgICB2b2lkIHN0b3BPYnNlcnZpbmdTdHlsZVJlY2FsY1NjaGVkdWxp bmcoKTsKIAorICAgIHZvaWQgc2V0U2hvdWxkT2JzZXJ2ZU5leHRTdHlsZVJlY2FsYyhib29sKTsK KyAgICBib29sIHNob3VsZE9ic2VydmVOZXh0U3R5bGVSZWNhbGMoKTsKKwogICAgIGJvb2wgaXNP YnNlcnZpbmdDb250ZW50Q2hhbmdlcygpOworICAgIGJvb2wgaXNPYnNlcnZpbmdTdHlsZVJlY2Fs Y1NjaGVkdWxpbmcoKTsKKworICAgIHZvaWQgc2V0T2JzZXJ2ZWRDb250ZW50Q2hhbmdlKFdLQ29u dGVudENoYW5nZSk7CiAKICAgICBQYWdlJiBtX3BhZ2U7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLm1tIGIvU291cmNlL1dlYkNv cmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9ic2VydmVyLm1tCmluZGV4IGQyYWUzMDczNzc0NjIz YWJmOTJiYjU5NDVhYjA4MWNlMDdjZTM4MTkuLmFmYTE4YzhmMWIzNjM5NjdiMjdkN2QxMTlhYTcz ZjlmNTc3NDc2NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0NvbnRlbnRD aGFuZ2VPYnNlcnZlci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hh bmdlT2JzZXJ2ZXIubW0KQEAgLTQwLDcgKzQwLDcgQEAgQ29udGVudENoYW5nZU9ic2VydmVyOjpD b250ZW50Q2hhbmdlT2JzZXJ2ZXIoUGFnZSYgcGFnZSkKIHsKIH0KIAotdm9pZCBDb250ZW50Q2hh bmdlT2JzZXJ2ZXI6OnJlZ2lzdGVyRE9NVGltZXJGb3JDb250ZW50T2JzZXJ2YXRpb25JZk5lZWRl ZChjb25zdCBET01UaW1lciYgdGltZXIsIFNlY29uZHMgdGltZW91dCwgYm9vbCBzaW5nbGVTaG90 KQordm9pZCBDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OmRpZEluc3RhbGxET01UaW1lcihjb25zdCBE T01UaW1lciYgdGltZXIsIFNlY29uZHMgdGltZW91dCwgYm9vbCBzaW5nbGVTaG90KQogewogICAg IGlmICghbV9wYWdlLm1haW5GcmFtZSgpLmRvY3VtZW50KCkpCiAgICAgICAgIHJldHVybjsKQEAg LTUyLDcgKzUyLDcgQEAgdm9pZCBDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OnJlZ2lzdGVyRE9NVGlt ZXJGb3JDb250ZW50T2JzZXJ2YXRpb25JZk5lZWRlZChjb25zdAogICAgICAgICByZXR1cm47CiAg ICAgc2V0T2JzZXJ2ZWRDb250ZW50Q2hhbmdlKFdLQ29udGVudEluZGV0ZXJtaW5hdGVDaGFuZ2Up OwogICAgIGFkZE9ic2VydmVkRE9NVGltZXIodGltZXIpOwotICAgIExPR19XSVRIX1NUUkVBTShD b250ZW50T2JzZXJ2YXRpb24sIHN0cmVhbSA8PCAicmVnaXN0ZXJET01UaW1lckZvckNvbnRlbnRP YnNlcnZhdGlvbklmTmVlZGVkOiByZWdpc3RlZCB0aGlzIHRpbWVyOiAoIiA8PCAmdGltZXIgPDwg IikgYW5kIG9ic2VydmUgd2hlbiBpdCBmaXJlcy4iKTsKKyAgICBMT0dfV0lUSF9TVFJFQU0oQ29u dGVudE9ic2VydmF0aW9uLCBzdHJlYW0gPDwgImRpZEluc3RhbGxET01UaW1lcjogcmVnaXN0ZWQg dGhpcyB0aW1lcjogKCIgPDwgJnRpbWVyIDw8ICIpIGFuZCBvYnNlcnZlIHdoZW4gaXQgZmlyZXMu Iik7CiB9CiAKIHZvaWQgQ29udGVudENoYW5nZU9ic2VydmVyOjpzdGFydE9ic2VydmluZ0RPTVRp bWVyRXhlY3V0ZShjb25zdCBET01UaW1lciYgdGltZXIpCkBAIC04Niw2ICs4NiwxNCBAQCB2b2lk IENvbnRlbnRDaGFuZ2VPYnNlcnZlcjo6c3RvcE9ic2VydmluZ0RPTVRpbWVyRXhlY3V0ZShjb25z dCBET01UaW1lciYgdGltZXIpCiAgICAgfQogfQogCit2b2lkIENvbnRlbnRDaGFuZ2VPYnNlcnZl cjo6ZGlkU2NoZWR1bGVTdHlsZVJlY2FsYygpCit7CisgICAgaWYgKCFpc09ic2VydmluZ1N0eWxl UmVjYWxjU2NoZWR1bGluZygpKQorICAgICAgICByZXR1cm47CisgICAgTE9HKENvbnRlbnRPYnNl cnZhdGlvbiwgImRpZFNjaGVkdWxlU3R5bGVSZWNhbGM6IHJlZ2lzdGVyIHRoaXMgc3R5bGUgcmVj YWxjIHNjaGVkdWxlIGFuZCBvYnNlcnZlIHdoZW4gaXQgZmlyZXMuIik7CisgICAgc2V0T2JzZXJ2 ZWRDb250ZW50Q2hhbmdlKFdLQ29udGVudEluZGV0ZXJtaW5hdGVDaGFuZ2UpOworfQorCiB2b2lk IENvbnRlbnRDaGFuZ2VPYnNlcnZlcjo6c3RhcnRPYnNlcnZpbmdTdHlsZVJlc29sdmUoKQogewog ICAgIGlmICghc2hvdWxkT2JzZXJ2ZU5leHRTdHlsZVJlY2FsYygpKQo=