195060 2019-02-26 11:42:08 -0800 Web Inspector: Canvas: enabling auto-capture if the frame count is empty triggers an assertion 2019-02-28 13:07:06 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1510114 0 hi 2019-02-26 11:42:08 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Canvas tab 3. delete all text inside the auto-capture frame count <input> (make sure the checkbox is unchecked) 4. click the checkbox => the <input> is empty and has the placeholder "null" 1510120 1 362999 hi 2019-02-26 11:47:16 -0800 Created attachment 362999 Patch 1510121 2 webkit-bug-importer 2019-02-26 11:47:34 -0800 <rdar://problem/48408669> 1511066 3 362999 mattbaker 2019-02-28 12:41:17 -0800 Comment on attachment 362999 Patch r=me, nice refactor. It makes much more sense to check this._recordingAutoCaptureFrameCountInputElementValue separately from setting the frame count and updating the label. 1511085 4 362999 commit-queue 2019-02-28 13:07:05 -0800 Comment on attachment 362999 Patch Clearing flags on attachment: 362999 Committed r242217: <https://trac.webkit.org/changeset/242217> 1511086 5 commit-queue 2019-02-28 13:07:06 -0800 All reviewed patches have been landed. Closing bug. 362999 2019-02-26 11:47:16 -0800 2019-02-28 13:07:05 -0800 Patch bug-195060-20190226114716.patch text/plain 3457 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRlNGExMDNkNDExNjg4MDY0ZjhjZWYxOGNlZWJk ZjQ1NjhjZDY1ZDkuLjkxMGIyYzIwODk5ZTU5NTVkNDdhZjIwNTQ2M2YyODBmZGUzZGY1YjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTI2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IGVuYWJsaW5nIGF1dG8tY2FwdHVyZSBpZiB0aGUgZnJhbWUgY291bnQgaXMgZW1wdHkg dHJpZ2dlcnMgYW4gYXNzZXJ0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTUwNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzT3ZlcnZpZXdDb250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcucHJvdG90eXBl Ll9zZXRSZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnQpOgorICAgICAgICAoV0kuQ2FudmFz T3ZlcnZpZXdDb250ZW50Vmlldy5wcm90b3R5cGUuX3VwZGF0ZVJlY29yZGluZ0F1dG9DYXB0dXJl Q2hlY2tib3hMYWJlbCk6CisgICAgICAgIChXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LnBy b3RvdHlwZS5faGFuZGxlUmVjb3JkaW5nQXV0b0NhcHR1cmVDaGVja2VkRGlkQ2hhbmdlKToKKwog MjAxOS0wMi0yNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogbmF2aWdhdGlvbiBzaWRlYmFyIHNheXMgIk5vIFNlYXJjaCBSZXN1bHRz IiB3aGVuIGEgc2xvdyBzZWFyY2ggaXMgaW4gcHJvZ3Jlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZp ZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNP dmVydmlld0NvbnRlbnRWaWV3LmpzCmluZGV4IDI0MmZkMTM3YjQzNWE3NWE1MTE2NDBiMmJhZDdi NGYzZjM1NWE1OGIuLjkyODNkMjZjNTY1NTNlZDY1ZmRhMGJlMjhmYjQ1Zjk1MmQ1MjEyMmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZh c092ZXJ2aWV3Q29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ2FudmFzT3ZlcnZpZXdDb250ZW50Vmlldy5qcwpAQCAtMTg5LDkgKzE4 OSw2IEBAIFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcgPSBjbGFzcyBDYW52YXNPdmVydmll d0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29sbGVjCiAKICAgICBfc2V0UmVjb3JkaW5nQXV0b0Nh cHR1cmVGcmFtZUNvdW50KGZyYW1lQ291bnQpCiAgICAgewotICAgICAgICBpZiAoaXNOYU4oZnJh bWVDb3VudCkpCi0gICAgICAgICAgICBmcmFtZUNvdW50ID0gdGhpcy5fcmVjb3JkaW5nQXV0b0Nh cHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50VmFsdWU7Ci0KICAgICAgICAgY29uc29sZS5hc3Nl cnQoIWlzTmFOKGZyYW1lQ291bnQpICYmIGZyYW1lQ291bnQgPj0gMCk7CiAKICAgICAgICAgaWYg KHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlTmF2aWdhdGlvbkl0ZW0uY2hlY2tlZCkKQEAgLTIw NCwyMiArMjAxLDE3IEBAIFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcgPSBjbGFzcyBDYW52 YXNPdmVydmlld0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29sbGVjCiAKICAgICBfdXBkYXRlUmVj b3JkaW5nQXV0b0NhcHR1cmVDaGVja2JveExhYmVsKGZyYW1lQ291bnQpCiAgICAgewotICAgICAg ICBpZiAoaXNOYU4oZnJhbWVDb3VudCkpCi0gICAgICAgICAgICBmcmFtZUNvdW50ID0gdGhpcy5f cmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50VmFsdWU7Ci0KLSAgICAg ICAgbGV0IGxhYmVsID0gZnJhbWVDb3VudCA9PT0gMSA/IFdJLlVJU3RyaW5nKCJSZWNvcmQgZmly c3QgJXMgZnJhbWUiKSA6IFdJLlVJU3RyaW5nKCJSZWNvcmQgZmlyc3QgJXMgZnJhbWVzIik7Ci0K ICAgICAgICAgbGV0IGFjdGl2ZSA9IGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQgPT09IHRoaXMuX3Jl Y29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVudDsKICAgICAgICAgbGV0IHNl bGVjdGlvblN0YXJ0ID0gdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRF bGVtZW50LnNlbGVjdGlvblN0YXJ0OwogICAgICAgICBsZXQgc2VsZWN0aW9uRW5kID0gdGhpcy5f cmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50LnNlbGVjdGlvbkVuZDsK ICAgICAgICAgbGV0IGRpcmVjdGlvbiA9IHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVD b3VudElucHV0RWxlbWVudC5kaXJlY3Rpb247CiAKKyAgICAgICAgbGV0IGxhYmVsID0gZnJhbWVD b3VudCA9PT0gMSA/IFdJLlVJU3RyaW5nKCJSZWNvcmQgZmlyc3QgJXMgZnJhbWUiKSA6IFdJLlVJ U3RyaW5nKCJSZWNvcmQgZmlyc3QgJXMgZnJhbWVzIik7CiAgICAgICAgIGxldCBmcmFnbWVudCA9 IGRvY3VtZW50LmNyZWF0ZURvY3VtZW50RnJhZ21lbnQoKTsKICAgICAgICAgU3RyaW5nLmZvcm1h dChsYWJlbCwgW3RoaXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVu dF0sIFN0cmluZy5zdGFuZGFyZEZvcm1hdHRlcnMsIGZyYWdtZW50LCAoYSwgYikgPT4gewogICAg ICAgICAgICAgYS5hcHBlbmQoYik7CiAgICAgICAgICAgICByZXR1cm4gYTsKICAgICAgICAgfSk7 Ci0KICAgICAgICAgdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVOYXZpZ2F0aW9uSXRlbS5sYWJl bCA9IGZyYWdtZW50OwogCiAgICAgICAgIGlmIChhY3RpdmUpIHsKQEAgLTI3Niw3ICsyNjgsNyBA QCBXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3ID0gY2xhc3MgQ2FudmFzT3ZlcnZpZXdDb250 ZW50VmlldyBleHRlbmRzIFdJLkNvbGxlYwogCiAgICAgX2hhbmRsZVJlY29yZGluZ0F1dG9DYXB0 dXJlQ2hlY2tlZERpZENoYW5nZShldmVudCkKICAgICB7Ci0gICAgICAgIHRoaXMuX3NldFJlY29y ZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudCgpOworICAgICAgICB0aGlzLl9zZXRSZWNvcmRpbmdB dXRvQ2FwdHVyZUZyYW1lQ291bnQodGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50 SW5wdXRFbGVtZW50VmFsdWUgfHwgMCk7CiAgICAgfQogCiAgICAgX2hhbmRsZUNhbnZhc1JlY29y ZGluZ0F1dG9DYXB0dXJlRW5hYmxlZENoYW5nZWQoZXZlbnQpCg==