195051 2019-02-26 08:35:26 -0800 Create WebPageProxy::m_userMediaPermissionRequestManager only when needed 2019-02-26 11:47:45 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195028 InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1510040 0 youennf 2019-02-26 08:35:26 -0800 Create WebPageProxy::m_userMediaPermissionRequestManager only when needed. This is better for efficiency and will reduce the risk of creating them at an unexpected time. 1510041 1 webkit-bug-importer 2019-02-26 08:36:07 -0800 <rdar://problem/48401331> 1510043 2 362988 youennf 2019-02-26 08:44:57 -0800 Created attachment 362988 Patch 1510122 3 362988 commit-queue 2019-02-26 11:47:44 -0800 Comment on attachment 362988 Patch Clearing flags on attachment: 362988 Committed r242097: <https://trac.webkit.org/changeset/242097> 1510123 4 commit-queue 2019-02-26 11:47:45 -0800 All reviewed patches have been landed. Closing bug. 362988 2019-02-26 08:44:57 -0800 2019-02-26 11:47:44 -0800 Patch bug-195051-20190226084457.patch text/plain 3746 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxOTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmNmEwOTgzZTc1ZTIwMDBl MDRlYzkwY2JjMTcwNzY0NzFlNzIxZDYuLmRkZWE4NWQ2MWJhOTE4NzY3YTE3NDZiM2JlZTRiNTQ3 YzQ3ZDBjZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMDItMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENyZWF0ZSBXZWJQYWdlUHJveHk6 Om1fdXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyIG9ubHkgd2hlbiBuZWVkZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTA1MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlZm9yZSB0aGUg cGF0Y2gsIFdlYlBhZ2VQcm94eTo6bV91c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIg d2FzIGNyZWF0ZWQKKyAgICAgICAgaW4gc29tZSBtZXRob2RzIHRvIHJlc2V0IGl0cyBzdGF0ZSB3 aGVuIG1haW4gZG9jdW1lbnQgaXMgY2hhbmdpbmcsIHZpZXcgaXMgYmVjb21pbmcgdmlzaWJsZS4u LgorICAgICAgICBUaGlzIGNvZGUgaXMgdW5uZWNlc3NhcnkgaWYgdGhlIHBhZ2UgZGlkIG5vdCBj cmVhdGUgaXQgYWxyZWFkeSB1c2luZyBKUyBBUElzIHN1Y2ggYXMgZ2V0VXNlck1lZGlhL2VudW1l cmF0ZURldmljZXMvb25kZXZpY2VjaGFuZ2UuCisgICAgICAgIFRoaXMgcGF0Y2ggc2tpcHMgcHJv Y2Vzc2luZyBpbiB0aGUgb3RoZXIgY2FzZXMgaWYgV2ViUGFnZVByb3h5OjptX3VzZXJNZWRpYVBl cm1pc3Npb25SZXF1ZXN0TWFuYWdlciBpcyBudWxsLgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y2xvc2UpOiBO byBuZWVkIHRvIG51bGxpZnkgaXQgc2luY2UgaXQgd2lsbCBiZSBkb25lIGluIHJlc2V0U3RhdGUg c2hvcnRseSBhZnRlci4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRDaGFuZ2VN YWluRG9jdW1lbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnZpZXdJc0JlY29t aW5nVmlzaWJsZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y2xlYXJVc2VyTWVk aWFTdGF0ZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6dXBkYXRlUGxheWluZ01l ZGlhRGlkQ2hhbmdlKTogbV91c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIgc2hvdWxk IG5vdCBiZSBudWxsIGhlcmUKKyAgICAgICAgc2luY2UgdGhlcmUgaXMgb3Igd2FzIHNvbWUgY2Fw dHVyaW5nIGRvbmUgZm9yIHRoZSBwYWdlLgorCiAyMDE5LTAyLTI1ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJQYWdlUHJveHkgc2hvdWxkIG51bGxpZnkg bV91c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIgYWZ0ZXIgcmVzZXR0aW5nIHRoZSBt ZWRpYSBzdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXgg ZWQ4NzA4OTM3ZTdlYTc0MTBmZTExMmVkZDZjZjM3NTA1ODhlZjQxNC4uOWZmZjE4NDNjYWNkNTQ0 MTljNmY3MWI1MDVlZDkxNGNmYzA1OTBlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCkBAIC05NzAsMTAgKzk3MCw2IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpjbG9z ZSgpCiAKICAgICBtX2lzQ2xvc2VkID0gdHJ1ZTsKIAotI2lmIEVOQUJMRShNRURJQV9TVFJFQU0p Ci0gICAgbV91c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIgPSBudWxscHRyOwotI2Vu ZGlmCi0KICAgICByZXBvcnRQYWdlTG9hZFJlc3VsdChSZXNvdXJjZUVycm9yIHsgUmVzb3VyY2VF cnJvcjo6VHlwZTo6Q2FuY2VsbGF0aW9uIH0pOwogCiAgICAgaWYgKG1fYWN0aXZlUG9wdXBNZW51 KQpAQCAtNDI3Niw3ICs0MjcyLDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZFNhbWVEb2N1bWVu dE5hdmlnYXRpb25Gb3JGcmFtZSh1aW50NjRfdCBmcmFtZUlELCB1aW50NjRfdAogdm9pZCBXZWJQ YWdlUHJveHk6OmRpZENoYW5nZU1haW5Eb2N1bWVudCh1aW50NjRfdCBmcmFtZUlEKQogewogI2lm IEVOQUJMRShNRURJQV9TVFJFQU0pCi0gICAgdXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5h Z2VyKCkucmVzZXRBY2Nlc3MoZnJhbWVJRCk7CisgICAgaWYgKG1fdXNlck1lZGlhUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyKQorICAgICAgICBtX3VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFu YWdlci0+cmVzZXRBY2Nlc3MoZnJhbWVJRCk7CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShmcmFt ZUlEKTsKICNlbmRpZgpAQCAtNDI4NSw3ICs0MjgyLDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRp ZENoYW5nZU1haW5Eb2N1bWVudCh1aW50NjRfdCBmcmFtZUlEKQogdm9pZCBXZWJQYWdlUHJveHk6 OnZpZXdJc0JlY29taW5nVmlzaWJsZSgpCiB7CiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKLSAg ICB1c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIoKS52aWV3SXNCZWNvbWluZ1Zpc2li bGUoKTsKKyAgICBpZiAobV91c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIpCisgICAg ICAgIG1fdXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLT52aWV3SXNCZWNvbWluZ1Zp c2libGUoKTsKICNlbmRpZgogfQogCkBAIC03MDY3LDcgKzcwNjUsOCBAQCB2b2lkIFdlYlBhZ2VQ cm94eTo6YmVnaW5Nb25pdG9yaW5nQ2FwdHVyZURldmljZXMoKQogdm9pZCBXZWJQYWdlUHJveHk6 OmNsZWFyVXNlck1lZGlhU3RhdGUoKQogewogI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCi0gICAg dXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKCkuY2xlYXJDYWNoZWRTdGF0ZSgpOwor ICAgIGlmIChtX3VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcikKKyAgICAgICAgbV91 c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXItPmNsZWFyQ2FjaGVkU3RhdGUoKTsKICNl bmRpZgogfQogCkBAIC03ODAyLDcgKzc4MDEsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6dXBkYXRl UGxheWluZ01lZGlhRGlkQ2hhbmdlKE1lZGlhUHJvZHVjZXI6Ok1lZGlhU3RhdGVGbGFncyBuZQog I2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAgICAgaWYgKG9sZE1lZGlhQ2FwdHVyZVN0YXRlICE9 IG5ld01lZGlhQ2FwdHVyZVN0YXRlKSB7CiAgICAgICAgIG1fdWlDbGllbnQtPm1lZGlhQ2FwdHVy ZVN0YXRlRGlkQ2hhbmdlKG1fbWVkaWFTdGF0ZSk7Ci0gICAgICAgIHVzZXJNZWRpYVBlcm1pc3Np b25SZXF1ZXN0TWFuYWdlcigpLmNhcHR1cmVTdGF0ZUNoYW5nZWQob2xkTWVkaWFDYXB0dXJlU3Rh dGUsIG5ld01lZGlhQ2FwdHVyZVN0YXRlKTsKKyAgICAgICAgbV91c2VyTWVkaWFQZXJtaXNzaW9u UmVxdWVzdE1hbmFnZXItPmNhcHR1cmVTdGF0ZUNoYW5nZWQob2xkTWVkaWFDYXB0dXJlU3RhdGUs IG5ld01lZGlhQ2FwdHVyZVN0YXRlKTsKICAgICB9CiAjZW5kaWYKIAo=