195047 2019-02-26 07:01:37 -0800 [ews-app] Update method to save build to handle builder_display_name 2019-02-28 04:30:37 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194961 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dean_johnson dewei_zhu ews-watchlist jbedard kocsen_chung lforschler slewis webkit-bug-importer oldest_to_newest 1510019 0 aakash_jain 2019-02-26 07:01:37 -0800 After https://bugs.webkit.org/show_bug.cgi?id=194961, ews-app's build table also include builder_name and builder_display_name. We should update the corresponding methods to save build accordingly. 1510020 1 362983 aakash_jain 2019-02-26 07:08:01 -0800 Created attachment 362983 Proposed patch 1510021 2 aakash_jain 2019-02-26 07:09:58 -0800 Tested on a local instance. 1510022 3 ews-watchlist 2019-02-26 07:10:56 -0800 Attachment 362983 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/build.py:63: [Build.save_build] Instance of 'Build' has no 'save' member [pylint/E1101] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1510059 4 jbedard 2019-02-26 10:13:18 -0800 This almost feels like this should have been contained in <https://bugs.webkit.org/show_bug.cgi?id=194961>, any reason to separate them? 1510164 5 aakash_jain 2019-02-26 13:17:22 -0800 > any reason to separate them? I have been making smaller patches to make them easier to review. Previous reviewers found it easier to review multiple smaller patches as compared to a large patch. 1510635 6 362983 dewei_zhu 2019-02-27 15:19:08 -0800 Comment on attachment 362983 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=362983&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/results.py:81 > + 'number', 'result', 'state_string', 'started_at', 'complete_at'], Nit: we need a consistent indentation. Usually 4 spaces. 1510895 7 aakash_jain 2019-02-28 04:29:14 -0800 Committed r242198: <https://trac.webkit.org/changeset/242198> 1510896 8 webkit-bug-importer 2019-02-28 04:30:37 -0800 <rdar://problem/48470453> 362983 2019-02-26 07:08:01 -0800 2019-02-27 15:19:08 -0800 Proposed patch builder-display-name-save.patch text/plain 4666 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MjA4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAyLTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gVXBkYXRlIG1ldGhvZCB0byBzYXZlIGJ1aWxkIHRvIGhh bmRsZSBidWlsZGVyX2Rpc3BsYXlfbmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMv YnVpbGQucHk6IFVwZGF0ZWQgdG8gaGFuZGxlIGJ1aWxkZXJfbmFtZSBhbmQgYnVpbGRlcl9kaXNw bGF5X25hbWUuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mv cmVzdWx0cy5weTogRGl0dG8uCisKIDIwMTktMDItMjYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y bWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEFkZCBBUEkgZm9yIHdlYnZpZXcgYmFj a2dyb3VuZCBjb2xvciBjb25maWd1cmF0aW9uCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5CShyZXZpc2lvbiAyNDIwODMp CisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGQucHkJ KHdvcmtpbmcgY29weSkKQEAgLTUwLDIyICs1MCwyMiBAQCBjbGFzcyBCdWlsZChtb2RlbHMuTW9k ZWwpOgogICAgICAgICByZXR1cm4gc3RyKHNlbGYuYnVpbGRfaWQpCiAKICAgICBAY2xhc3NtZXRo b2QKLSAgICBkZWYgc2F2ZV9idWlsZChjbHMsIHBhdGNoX2lkLCBidWlsZF9pZCwgYnVpbGRlcl9p ZCwgbnVtYmVyLCByZXN1bHQsIHN0YXRlX3N0cmluZywgc3RhcnRlZF9hdCwgY29tcGxldGVfYXQ9 Tm9uZSk6CisgICAgZGVmIHNhdmVfYnVpbGQoY2xzLCBwYXRjaF9pZCwgYnVpbGRfaWQsIGJ1aWxk ZXJfaWQsIGJ1aWxkZXJfbmFtZSwgYnVpbGRlcl9kaXNwbGF5X25hbWUsIG51bWJlciwgcmVzdWx0 LCBzdGF0ZV9zdHJpbmcsIHN0YXJ0ZWRfYXQsIGNvbXBsZXRlX2F0PU5vbmUpOgogICAgICAgICBp ZiBub3QgQnVpbGQuaXNfdmFsaWRfcmVzdWx0KHBhdGNoX2lkLCBidWlsZF9pZCwgYnVpbGRlcl9p ZCwgbnVtYmVyLCByZXN1bHQsIHN0YXRlX3N0cmluZywgc3RhcnRlZF9hdCwgY29tcGxldGVfYXQp OgogICAgICAgICAgICAgcmV0dXJuIEVSUl9VTkVYUEVDVEVECiAKICAgICAgICAgYnVpbGQgPSBC dWlsZC5nZXRfZXhpc3RpbmdfYnVpbGQoYnVpbGRfaWQpCiAgICAgICAgIGlmIGJ1aWxkOgogICAg ICAgICAgICAgIyBJZiB0aGUgYnVpbGQgZGF0YSBpcyBhbHJlYWR5IHByZXNlbnQgaW4gZGF0YWJh c2UsIHVwZGF0ZSBpdCwgZS5nLjogYnVpbGQgY29tcGxldGUgZXZlbnQuCi0gICAgICAgICAgICBy ZXR1cm4gQnVpbGQudXBkYXRlX2J1aWxkKGJ1aWxkLCBwYXRjaF9pZCwgYnVpbGRfaWQsIGJ1aWxk ZXJfaWQsIG51bWJlciwgcmVzdWx0LCBzdGF0ZV9zdHJpbmcsIHN0YXJ0ZWRfYXQsIGNvbXBsZXRl X2F0KQorICAgICAgICAgICAgcmV0dXJuIEJ1aWxkLnVwZGF0ZV9idWlsZChidWlsZCwgcGF0Y2hf aWQsIGJ1aWxkX2lkLCBidWlsZGVyX2lkLCBidWlsZGVyX25hbWUsIGJ1aWxkZXJfZGlzcGxheV9u YW1lLCBudW1iZXIsIHJlc3VsdCwgc3RhdGVfc3RyaW5nLCBzdGFydGVkX2F0LCBjb21wbGV0ZV9h dCkKIAogICAgICAgICAjIFNhdmUgdGhlIG5ldyBidWlsZCBkYXRhLCBlLmcuOiBidWlsZCBzdGFy dCBldmVudC4KLSAgICAgICAgQnVpbGQocGF0Y2hfaWQsIGJ1aWxkX2lkLCBidWlsZGVyX2lkLCBu dW1iZXIsIHJlc3VsdCwgc3RhdGVfc3RyaW5nLCBzdGFydGVkX2F0LCBjb21wbGV0ZV9hdCkuc2F2 ZSgpCisgICAgICAgIEJ1aWxkKHBhdGNoX2lkLCBidWlsZF9pZCwgYnVpbGRlcl9pZCwgYnVpbGRl cl9uYW1lLCBidWlsZGVyX2Rpc3BsYXlfbmFtZSwgbnVtYmVyLCByZXN1bHQsIHN0YXRlX3N0cmlu Zywgc3RhcnRlZF9hdCwgY29tcGxldGVfYXQpLnNhdmUoKQogICAgICAgICBfbG9nLmluZm8oJ1Nh dmVkIGJ1aWxkIHt9IGluIGRhdGFiYXNlIGZvciBwYXRjaF9pZDoge30nLmZvcm1hdChidWlsZF9p ZCwgcGF0Y2hfaWQpKQogICAgICAgICByZXR1cm4gU1VDQ0VTUwogCiAgICAgQGNsYXNzbWV0aG9k Ci0gICAgZGVmIHVwZGF0ZV9idWlsZChjbHMsIGJ1aWxkLCBwYXRjaF9pZCwgYnVpbGRfaWQsIGJ1 aWxkZXJfaWQsIG51bWJlciwgcmVzdWx0LCBzdGF0ZV9zdHJpbmcsIHN0YXJ0ZWRfYXQsIGNvbXBs ZXRlX2F0KToKKyAgICBkZWYgdXBkYXRlX2J1aWxkKGNscywgYnVpbGQsIHBhdGNoX2lkLCBidWls ZF9pZCwgYnVpbGRlcl9pZCwgYnVpbGRlcl9uYW1lLCBidWlsZGVyX2Rpc3BsYXlfbmFtZSwgbnVt YmVyLCByZXN1bHQsIHN0YXRlX3N0cmluZywgc3RhcnRlZF9hdCwgY29tcGxldGVfYXQpOgogICAg ICAgICBpZiBidWlsZC5wYXRjaF9pZCAhPSBwYXRjaF9pZDoKICAgICAgICAgICAgIF9sb2cuZXJy b3IoJ3BhdGNoX2lkIHt9IGRvZXMgbm90IG1hdGNoIHdpdGggcGF0Y2hfaWQge30uIElnbm9yaW5n IG5ldyBkYXRhLicuZm9ybWF0KGJ1aWxkLnBhdGNoX2lkLCBwYXRjaF9pZCkpCiAgICAgICAgICAg ICByZXR1cm4gRVJSX1VORVhQRUNURUQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL3ZpZXdzL3Jlc3VsdHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3MvcmVzdWx0cy5weQkocmV2aXNpb24gMjQyMDgzKQor KysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3MvcmVzdWx0cy5weQko d29ya2luZyBjb3B5KQpAQCAtNTksNyArNTksOCBAQCBjbGFzcyBSZXN1bHRzKFZpZXcpOgogICAg ICAgICBpZiBub3QgcGF0Y2hfaWQgb3IgcGF0Y2hfaWQgPCAxOgogICAgICAgICAgICAgcmV0dXJu IEh0dHBSZXNwb25zZSgiSW52YWxpZCBwYXRjaCBpZDoge30uIi5mb3JtYXQocGF0Y2hfaWQpKQog Ci0gICAgICAgIEJ1aWxkLnNhdmVfYnVpbGQocGF0Y2hfaWQ9aW50KHBhdGNoX2lkKSwgYnVpbGRf aWQ9ZGF0YVsnYnVpbGRfaWQnXSwgYnVpbGRlcl9pZD1kYXRhWydidWlsZGVyX2lkJ10sIG51bWJl cj1kYXRhWydudW1iZXInXSwgcmVzdWx0PWRhdGFbJ3Jlc3VsdCddLAorICAgICAgICBCdWlsZC5z YXZlX2J1aWxkKHBhdGNoX2lkPWludChwYXRjaF9pZCksIGJ1aWxkX2lkPWRhdGFbJ2J1aWxkX2lk J10sIGJ1aWxkZXJfaWQ9ZGF0YVsnYnVpbGRlcl9pZCddLCBidWlsZGVyX25hbWU9ZGF0YVsnYnVp bGRlcl9uYW1lJ10sCisgICAgICAgICAgICAgICAgICAgYnVpbGRlcl9kaXNwbGF5X25hbWU9ZGF0 YVsnYnVpbGRlcl9kaXNwbGF5X25hbWUnXSwgbnVtYmVyPWRhdGFbJ251bWJlciddLCByZXN1bHQ9 ZGF0YVsncmVzdWx0J10sCiAgICAgICAgICAgICAgICAgICAgc3RhdGVfc3RyaW5nPWRhdGFbJ3N0 YXRlX3N0cmluZyddLCBzdGFydGVkX2F0PWRhdGFbJ3N0YXJ0ZWRfYXQnXSwgY29tcGxldGVfYXQ9 ZGF0YVsnY29tcGxldGVfYXQnXSkKICAgICAgICAgcmV0dXJuIEh0dHBSZXNwb25zZSgiU2F2ZWQg ZGF0YSBmb3IgcGF0Y2g6IHt9LlxuIi5mb3JtYXQocGF0Y2hfaWQpKQogCkBAIC03Niw3ICs3Nyw4 IEBAIGNsYXNzIFJlc3VsdHMoVmlldyk6CiAgICAgICAgICAgICBfbG9nLmVycm9yKCJJbnZhbGlk IGRhdGEgdHlwZToge30iLmZvcm1hdChkYXRhWyd0eXBlJ10pKQogICAgICAgICAgICAgcmV0dXJu IEZhbHNlCiAKLSAgICAgICAgcmVxdWlyZWRfa2V5cyA9IHt1J2V3cy1idWlsZCc6IFsncGF0Y2hf aWQnLCAnYnVpbGRfaWQnLCAnYnVpbGRlcl9pZCcsICdudW1iZXInLCAncmVzdWx0JywgJ3N0YXRl X3N0cmluZycsICdzdGFydGVkX2F0JywgJ2NvbXBsZXRlX2F0J10sCisgICAgICAgIHJlcXVpcmVk X2tleXMgPSB7dSdld3MtYnVpbGQnOiBbJ3BhdGNoX2lkJywgJ2J1aWxkX2lkJywgJ2J1aWxkZXJf aWQnLCAnYnVpbGRlcl9uYW1lJywgJ2J1aWxkZXJfZGlzcGxheV9uYW1lJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ251bWJlcicsICdyZXN1bHQnLCAnc3Rh dGVfc3RyaW5nJywgJ3N0YXJ0ZWRfYXQnLCAnY29tcGxldGVfYXQnXSwKICAgICAgICAgICAgICAg ICAgICAgICAgICB1J2V3cy1zdGVwJzogWydzdGVwX2lkJywgJ2J1aWxkX2lkJywgJ3Jlc3VsdCcs ICdzdGF0ZV9zdHJpbmcnLCAnc3RhcnRlZF9hdCcsICdjb21wbGV0ZV9hdCddfQogCiAgICAgICAg IGZvciBrZXkgaW4gcmVxdWlyZWRfa2V5cy5nZXQoZGF0YS5nZXQoJ3R5cGUnKSk6Cg==