195045 2019-02-26 06:41:57 -0800 [ews-build] Buildbot should include builder_display_name in the build events 2019-02-27 18:51:36 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194961 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dean_johnson dewei_zhu ews-watchlist jbedard kocsen_chung lforschler slewis webkit-bug-importer oldest_to_newest 1510013 0 aakash_jain 2019-02-26 06:41:57 -0800 After https://bugs.webkit.org/show_bug.cgi?id=194961, ews-app's build table also include builder_display_name. So, buildbot should include builder_display_name in the build event data (e.g.: build-start/end events) it send to ews-app. 1510016 1 362981 aakash_jain 2019-02-26 06:48:22 -0800 Created attachment 362981 Proposed patch 1510018 2 ews-watchlist 2019-02-26 06:50:43 -0800 Attachment 362981 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/events.py:112: [Events.buildStarted] Instance of 'Events' has no 'master' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/events.py:139: [Events.buildFinished] Instance of 'Events' has no 'master' member [pylint/E1101] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1510060 3 jbedard 2019-02-26 10:13:25 -0800 This almost feels like this should have been contained in <https://bugs.webkit.org/show_bug.cgi?id=194961>, any reason to separate them? 1510078 4 aakash_jain 2019-02-26 10:38:09 -0800 > any reason to separate them? I have been making smaller patches to make them easier to review. Previous reviewers found it easier to review multiple smaller patches as compared to a large patch. 1510744 5 362981 commit-queue 2019-02-27 17:47:09 -0800 Comment on attachment 362981 Proposed patch Clearing flags on attachment: 362981 Committed r242185: <https://trac.webkit.org/changeset/242185> 1510745 6 commit-queue 2019-02-27 17:47:10 -0800 All reviewed patches have been landed. Closing bug. 1510770 7 webkit-bug-importer 2019-02-27 18:51:36 -0800 <rdar://problem/48460180> 362981 2019-02-26 06:48:22 -0800 2019-02-27 17:47:09 -0800 Proposed patch add-builder-display-name-events.patch text/plain 2805 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MjA4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTAyLTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBCdWlsZGJvdCBzaG91bGQgaW5jbHVkZSBidWlsZGVy X2Rpc3BsYXlfbmFtZSBpbiB0aGUgYnVpbGQgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUwNDUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9l dmVudHMucHk6CisgICAgICAgIChFdmVudHMuYnVpbGRTdGFydGVkKTogSW5jbHVkZWQgYnVpbGRl cl9kaXNwbGF5X25hbWUgaW4gZXZlbnQgZGF0YS4gQWxzbyByZW5hbWVkCisgICAgICAgIGJ1aWxk ZXJuYW1lIHRvIGJ1aWxkZXJfbmFtZSB0byBiZSBjb25zaXN0ZW50IGluIG5hbWluZyBzdHlsZS4K KyAgICAgICAgKEV2ZW50cy5idWlsZEZpbmlzaGVkKTogRGl0dG8uCisKIDIwMTktMDItMjYgIFBo aWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEFk ZCBBUEkgZm9yIHdlYnZpZXcgYmFja2dyb3VuZCBjb2xvciBjb25maWd1cmF0aW9uCkluZGV4OiBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZXZlbnRzLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9ldmVudHMucHkJKHJldmlzaW9uIDI0 MjA4MykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9ldmVudHMucHkJKHdv cmtpbmcgY29weSkKQEAgLTEwOSw2ICsxMDksOSBAQCBjbGFzcyBFdmVudHMoc2VydmljZS5CdWls ZGJvdFNlcnZpY2UpOgogICAgICAgICBpZiBub3QgYnVpbGQuZ2V0KCdwcm9wZXJ0aWVzJyk6CiAg ICAgICAgICAgICBidWlsZFsncHJvcGVydGllcyddID0geWllbGQgc2VsZi5tYXN0ZXIuZGIuYnVp bGRzLmdldEJ1aWxkUHJvcGVydGllcyhidWlsZC5nZXQoJ2J1aWxkaWQnKSkKIAorICAgICAgICBi dWlsZGVyID0geWllbGQgc2VsZi5tYXN0ZXIuZGIuYnVpbGRlcnMuZ2V0QnVpbGRlcihidWlsZC5n ZXQoJ2J1aWxkZXJpZCcpKQorICAgICAgICBidWlsZGVyX2Rpc3BsYXlfbmFtZSA9IGJ1aWxkZXIu Z2V0KCdkZXNjcmlwdGlvbicpCisKICAgICAgICAgZGF0YSA9IHsKICAgICAgICAgICAgICJ0eXBl Ijogc2VsZi50eXBlX3ByZWZpeCArICJidWlsZCIsCiAgICAgICAgICAgICAic3RhdHVzIjogInN0 YXJ0ZWQiLApAQCAtMTIwLDcgKzEyMyw4IEBAIGNsYXNzIEV2ZW50cyhzZXJ2aWNlLkJ1aWxkYm90 U2VydmljZSk6CiAgICAgICAgICAgICAic3RhcnRlZF9hdCI6IGJ1aWxkLmdldCgnc3RhcnRlZF9h dCcpLAogICAgICAgICAgICAgImNvbXBsZXRlX2F0IjogYnVpbGQuZ2V0KCdjb21wbGV0ZV9hdCcp LAogICAgICAgICAgICAgInN0YXRlX3N0cmluZyI6IGJ1aWxkLmdldCgnc3RhdGVfc3RyaW5nJyks Ci0gICAgICAgICAgICAiYnVpbGRlcm5hbWUiOiBzZWxmLmdldEJ1aWxkZXJOYW1lKGJ1aWxkKSwK KyAgICAgICAgICAgICJidWlsZGVyX25hbWUiOiBzZWxmLmdldEJ1aWxkZXJOYW1lKGJ1aWxkKSwK KyAgICAgICAgICAgICJidWlsZGVyX2Rpc3BsYXlfbmFtZSI6IGJ1aWxkZXJfZGlzcGxheV9uYW1l LAogICAgICAgICB9CiAKICAgICAgICAgc2VsZi5zZW5kRGF0YShkYXRhKQpAQCAtMTMyLDYgKzEz Niw5IEBAIGNsYXNzIEV2ZW50cyhzZXJ2aWNlLkJ1aWxkYm90U2VydmljZSk6CiAgICAgICAgIGlm IG5vdCBidWlsZC5nZXQoJ3N0ZXBzJyk6CiAgICAgICAgICAgICBidWlsZFsnc3RlcHMnXSA9IHlp ZWxkIHNlbGYubWFzdGVyLmRiLnN0ZXBzLmdldFN0ZXBzKGJ1aWxkLmdldCgnYnVpbGRpZCcpKQog CisgICAgICAgIGJ1aWxkZXIgPSB5aWVsZCBzZWxmLm1hc3Rlci5kYi5idWlsZGVycy5nZXRCdWls ZGVyKGJ1aWxkLmdldCgnYnVpbGRlcmlkJykpCisgICAgICAgIGJ1aWxkZXJfZGlzcGxheV9uYW1l ID0gYnVpbGRlci5nZXQoJ2Rlc2NyaXB0aW9uJykKKwogICAgICAgICBkYXRhID0gewogICAgICAg ICAgICAgInR5cGUiOiBzZWxmLnR5cGVfcHJlZml4ICsgImJ1aWxkIiwKICAgICAgICAgICAgICJz dGF0dXMiOiAiZmluaXNoZWQiLApAQCAtMTQzLDcgKzE1MCw4IEBAIGNsYXNzIEV2ZW50cyhzZXJ2 aWNlLkJ1aWxkYm90U2VydmljZSk6CiAgICAgICAgICAgICAic3RhcnRlZF9hdCI6IGJ1aWxkLmdl dCgnc3RhcnRlZF9hdCcpLAogICAgICAgICAgICAgImNvbXBsZXRlX2F0IjogYnVpbGQuZ2V0KCdj b21wbGV0ZV9hdCcpLAogICAgICAgICAgICAgInN0YXRlX3N0cmluZyI6IGJ1aWxkLmdldCgnc3Rh dGVfc3RyaW5nJyksCi0gICAgICAgICAgICAiYnVpbGRlcm5hbWUiOiBzZWxmLmdldEJ1aWxkZXJO YW1lKGJ1aWxkKSwKKyAgICAgICAgICAgICJidWlsZGVyX25hbWUiOiBzZWxmLmdldEJ1aWxkZXJO YW1lKGJ1aWxkKSwKKyAgICAgICAgICAgICJidWlsZGVyX2Rpc3BsYXlfbmFtZSI6IGJ1aWxkZXJf ZGlzcGxheV9uYW1lLAogICAgICAgICAgICAgInN0ZXBzIjogYnVpbGQuZ2V0KCdzdGVwcycpLAog ICAgICAgICB9CiAK