195023 2019-02-25 16:10:54 -0800 [ContentChangeObserver] Simplify content observation API by removing explicit DOMTimer observation. 2019-02-26 10:37:23 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1509823 0 zalan 2019-02-25 16:10:54 -0800 startObservingContentChanges should imply DOMTimer observation as well. 1509824 1 webkit-bug-importer 2019-02-25 16:11:31 -0800 <rdar://problem/48381885> 1509839 2 362942 zalan 2019-02-25 16:26:30 -0800 Created attachment 362942 Patch 1510077 3 zalan 2019-02-26 10:37:23 -0800 Committed r242094: <https://trac.webkit.org/changeset/242094> 362942 2019-02-25 16:26:30 -0800 2019-02-26 10:13:23 -0800 Patch bug-195023-20190225162629.patch text/plain 5951 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDJkMGJhYzQ0YzBiYzc2 Njk4NGI5YjI3YjdmMTllZDQ2MGQ2M2E5OS4uN2IzMGQ3OTBjMDU2YmNmYTBiODE2MGRmZjUxZmM0 MDUzNmFkZmYzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAyLTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNl cnZlcl0gU2ltcGxpZnkgY29udGVudCBvYnNlcnZhdGlvbiBBUEkgYnkgcmVtb3ZpbmcgZXhwbGlj aXQgRE9NVGltZXIgb2JzZXJ2YXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTUwMjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4MzgxODg1 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHRo ZSBmdXR1cmUgd2UgbWlnaHQgZGVjaWRlIHRoYXQgY2VydGFpbiBhY3Rpdml0aWVzIGRvbid0IHJl cXVpcmUgRE9NVGltZXIgb2JzZXJ2YXRpb24sIGJ1dCB0aGF0IHNob3VsZAorICAgICAgICBiZSBp bnRlcm5hbCB0byBDb250ZW50Q2hhbmdlT2JzZXJ2ZXIuCisKKyAgICAgICAgKiBwYWdlL2lvcy9D b250ZW50Q2hhbmdlT2JzZXJ2ZXIuaDoKKyAgICAgICAgKiBwYWdlL2lvcy9Db250ZW50Q2hhbmdl T2JzZXJ2ZXIubW06CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6OnN0 YXJ0T2JzZXJ2aW5nQ29udGVudENoYW5nZXMpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudENo YW5nZU9ic2VydmVyOjpzdG9wT2JzZXJ2aW5nQ29udGVudENoYW5nZXMpOgorICAgICAgICAqIHBh Z2UvaW9zL0V2ZW50SGFuZGxlcklPUy5tbToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxl cjo6bW91c2VNb3ZlZCk6CisKIDIwMTktMDItMjUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbQ29udGVudENoYW5nZU9ic2VydmVyXSBNb3ZlIG9ic2VydmluZyBs b2dpYyBmcm9tIERPTVdpbmRvdzo6Y2xlYXJUaW1lb3V0IHRvIENvbnRlbnRDaGFuZ2VPYnNlcnZl cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZwppbmRleCAzOTgxOTU1YjFjNmQ4NzZhYTcxZWZiNGJjYzU2N2IyYjhiZTE4MjIyLi5m MTc3ZGI1YWI2OGNjY2QxNTg1YWVmZmEwODQ4M2Q2OWJhZWY5NzNlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAyLTI1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisK KyAgICAgICAgW0NvbnRlbnRDaGFuZ2VPYnNlcnZlcl0gU2ltcGxpZnkgY29udGVudCBvYnNlcnZh dGlvbiBBUEkgYnkgcmVtb3ZpbmcgZXhwbGljaXQgRE9NVGltZXIgb2JzZXJ2YXRpb24uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUwMjMKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQ4MzgxODg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9T Lm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpoYW5kbGVTeW50aGV0aWNDbGljayk6CisK IDIwMTktMDItMjUgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgW2lPU10gQWRqdXN0IGluaXRpYWwgc2NhbGUgem9vbWluZyBoZXVyaXN0aWNzIHdoZW4g Y2hhbmdpbmcgdmlldyBzY2FsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3Mv Q29udGVudENoYW5nZU9ic2VydmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50 Q2hhbmdlT2JzZXJ2ZXIuaAppbmRleCA2ZmJlMDc1YjVmZWJjNDQwNzIxYzk2ZTE3YzhlNDIxYjdi MjcyMDk0Li45NTk0N2U1ZjU4NWZkMzgxMzBhOTRmOTBkYTExNjI4ZTMwNmM3YjI0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdlT2JzZXJ2ZXIuaApAQCAtNDcs OSArNDcsNiBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzdG9wT2JzZXJ2aW5n Q29udGVudENoYW5nZXMoKTsKICAgICBib29sIGlzT2JzZXJ2aW5nQ29udGVudENoYW5nZXMoKTsK IAotICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc3RhcnRPYnNlcnZpbmdET01UaW1lclNjaGVkdWxp bmcoKTsKLSAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHN0b3BPYnNlcnZpbmdET01UaW1lclNjaGVk dWxpbmcoKTsKLQogICAgIGJvb2wgaXNPYnNlcnZpbmdTdHlsZVJlY2FsY1NjaGVkdWxpbmcoKTsK IAogICAgIHZvaWQgc2V0U2hvdWxkT2JzZXJ2ZU5leHRTdHlsZVJlY2FsYyhib29sKTsKQEAgLTYy LDYgKzU5LDkgQEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgY2xlYXJPYnNlcnZl ZERPTVRpbWVycygpOwogCiBwcml2YXRlOgorICAgIHZvaWQgc3RhcnRPYnNlcnZpbmdET01UaW1l clNjaGVkdWxpbmcoKTsKKyAgICB2b2lkIHN0b3BPYnNlcnZpbmdET01UaW1lclNjaGVkdWxpbmco KTsKKwogICAgIHZvaWQgYWRkT2JzZXJ2ZWRET01UaW1lcihjb25zdCBET01UaW1lciYpOwogICAg IGJvb2wgaXNPYnNlcnZpbmdET01UaW1lclNjaGVkdWxpbmcoKTsKICAgICB2b2lkIHJlbW92ZU9i c2VydmVkRE9NVGltZXIoY29uc3QgRE9NVGltZXImKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvaW9zL0NvbnRlbnRDaGFuZ2VPYnNlcnZlci5tbQppbmRleCAzNzVlYmNhYzRlMjk2YzJmMjAx MmFjNTcyNWY5YTJlNjgzYTU3MjBiLi5mN2E0OTM3MTQ5ZmU1NWYwZTg2MGJlYTQzMTYyYjBhYzBh ZjQ1ZDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9Db250ZW50Q2hhbmdl T2JzZXJ2ZXIubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvQ29udGVudENoYW5nZU9i c2VydmVyLm1tCkBAIC05OSwxMSArOTksMTMgQEAgdm9pZCBDb250ZW50Q2hhbmdlT2JzZXJ2ZXI6 OnJlbW92ZURPTVRpbWVyKGNvbnN0IERPTVRpbWVyJiB0aW1lcikKIAogdm9pZCBDb250ZW50Q2hh bmdlT2JzZXJ2ZXI6OnN0YXJ0T2JzZXJ2aW5nQ29udGVudENoYW5nZXMoKQogeworICAgIHN0YXJ0 T2JzZXJ2aW5nRE9NVGltZXJTY2hlZHVsaW5nKCk7CiAgICAgV0tTdGFydE9ic2VydmluZ0NvbnRl bnRDaGFuZ2VzKCk7CiB9CiAKIHZvaWQgQ29udGVudENoYW5nZU9ic2VydmVyOjpzdG9wT2JzZXJ2 aW5nQ29udGVudENoYW5nZXMoKQogeworICAgIHN0b3BPYnNlcnZpbmdET01UaW1lclNjaGVkdWxp bmcoKTsKICAgICBXS1N0b3BPYnNlcnZpbmdDb250ZW50Q2hhbmdlcygpOwogfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lvcy9FdmVudEhhbmRsZXJJT1MubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL2lvcy9FdmVudEhhbmRsZXJJT1MubW0KaW5kZXggYjhjOGNlZmUzMzg4ZjU2 ZjVkMjg2NDRhMGJhYzdjODEzNGZkYjkwMC4uZGU5ODljZTg4NGVjMGNkNDlkZTQ5MGJmMjkzYWE5 Zjg0NzU2OTZiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvRXZlbnRIYW5k bGVySU9TLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0V2ZW50SGFuZGxlcklPUy5t bQpAQCAtNDk3LDE0ICs0OTcsMTIgQEAgdm9pZCBFdmVudEhhbmRsZXI6Om1vdXNlTW92ZWQoV2Vi RXZlbnQgKmV2ZW50KQogCiAgICAgYXV0byYgY29udGVudENoYW5nZU9ic2VydmVyID0gZG9jdW1l bnQucGFnZSgpLT5jb250ZW50Q2hhbmdlT2JzZXJ2ZXIoKTsKICAgICBjb250ZW50Q2hhbmdlT2Jz ZXJ2ZXIuc3RhcnRPYnNlcnZpbmdDb250ZW50Q2hhbmdlcygpOwotICAgIGNvbnRlbnRDaGFuZ2VP YnNlcnZlci5zdGFydE9ic2VydmluZ0RPTVRpbWVyU2NoZWR1bGluZygpOwogCiAgICAgQ3VycmVu dEV2ZW50U2NvcGUgc2NvcGUoZXZlbnQpOwogICAgIGV2ZW50Lndhc0hhbmRsZWQgPSBtb3VzZU1v dmVkKGN1cnJlbnRQbGF0Zm9ybU1vdXNlRXZlbnQoKSk7CiAKICAgICAvLyBSdW4gc3R5bGUgcmVj YWxjIHRvIGJlIGFibGUgdG8gY2FwdHVyZSBjb250ZW50IGNoYW5nZXMgYXMgdGhlIHJlc3VsdCBv ZiB0aGUgbW91c2UgbW92ZSBldmVudC4KICAgICBkb2N1bWVudC51cGRhdGVTdHlsZUlmTmVlZGVk KCk7Ci0gICAgY29udGVudENoYW5nZU9ic2VydmVyLnN0b3BPYnNlcnZpbmdET01UaW1lclNjaGVk dWxpbmcoKTsKICAgICBjb250ZW50Q2hhbmdlT2JzZXJ2ZXIuc3RvcE9ic2VydmluZ0NvbnRlbnRD aGFuZ2VzKCk7CiAKICAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCBlNjVl ZmYzYmMyNDA2YTEzZjljNGI1MDg3MWZjYTIxNzdkN2E3NjkwLi45MjFhYTU4MDQ4MDRmNmQ2NDA1 NDk4OWVhMzFjMjVmYTYxM2FmNWRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtNTQzLDcgKzU0Myw2IEBAIHZvaWQgV2Vi UGFnZTo6aGFuZGxlU3ludGhldGljQ2xpY2soTm9kZSogbm9kZVJlc3BvbmRpbmdUb0NsaWNrLCBj b25zdCBXZWJDb3JlOjpGCiAKICAgICBMT0dfV0lUSF9TVFJFQU0oQ29udGVudE9ic2VydmF0aW9u LCBzdHJlYW0gPDwgImhhbmRsZVN5bnRoZXRpY0NsaWNrOiBub2RlKCIgPDwgbm9kZVJlc3BvbmRp bmdUb0NsaWNrIDw8ICIpICIgPDwgbG9jYXRpb24pOwogICAgIGNvbnRlbnRDaGFuZ2VPYnNlcnZl ci5zdGFydE9ic2VydmluZ0NvbnRlbnRDaGFuZ2VzKCk7Ci0gICAgY29udGVudENoYW5nZU9ic2Vy dmVyLnN0YXJ0T2JzZXJ2aW5nRE9NVGltZXJTY2hlZHVsaW5nKCk7CiAKICAgICAvLyBGSVhNRTog UGFzcyBjYXBzIGxvY2sgc3RhdGUuCiAgICAgYm9vbCBzaGlmdEtleSA9IG1vZGlmaWVycy5jb250 YWlucyhXZWJFdmVudDo6TW9kaWZpZXI6OlNoaWZ0S2V5KTsKQEAgLTU1Myw3ICs1NTIsNiBAQCB2 b2lkIFdlYlBhZ2U6OmhhbmRsZVN5bnRoZXRpY0NsaWNrKE5vZGUqIG5vZGVSZXNwb25kaW5nVG9D bGljaywgY29uc3QgV2ViQ29yZTo6RgogICAgIG1haW5mcmFtZS5ldmVudEhhbmRsZXIoKS5tb3Vz ZU1vdmVkKFBsYXRmb3JtTW91c2VFdmVudChyb3VuZGVkQWRqdXN0ZWRQb2ludCwgcm91bmRlZEFk anVzdGVkUG9pbnQsIE5vQnV0dG9uLCBQbGF0Zm9ybUV2ZW50OjpNb3VzZU1vdmVkLCAwLCBzaGlm dEtleSwgY3RybEtleSwgYWx0S2V5LCBtZXRhS2V5LCBXYWxsVGltZTo6bm93KCksIFdlYkNvcmU6 OkZvcmNlQXRDbGljaywgV2ViQ29yZTo6Tm9UYXApKTsKICAgICBtYWluZnJhbWUuZG9jdW1lbnQo KS0+dXBkYXRlU3R5bGVJZk5lZWRlZCgpOwogCi0gICAgY29udGVudENoYW5nZU9ic2VydmVyLnN0 b3BPYnNlcnZpbmdET01UaW1lclNjaGVkdWxpbmcoKTsKICAgICBjb250ZW50Q2hhbmdlT2JzZXJ2 ZXIuc3RvcE9ic2VydmluZ0NvbnRlbnRDaGFuZ2VzKCk7CiAKICAgICBtX3BlbmRpbmdTeW50aGV0 aWNDbGlja05vZGUgPSBudWxscHRyOwo=