195004 2019-02-25 07:29:51 -0800 -Wformat error in SharedBuffer::tryCreateArrayBuffer 2019-03-03 08:45:45 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue darin mcatanzaro oldest_to_newest 1509626 0 mcatanzaro 2019-02-25 07:29:51 -0800 Looking over a 32-bit build log from Debian, to check for potential issues with 32-bit build: /<<PKGBUILDDIR>>/Source/WebCore/PAL/pal/FileSizeFormatter.cpp: In function 'WTF::String fileSizeDescription(uint64_t)': /<<PKGBUILDDIR>>/Source/WebCore/PAL/pal/FileSizeFormatter.cpp:36:31: warning: format '%tu' expects argument of type 'unsigned ptrdiff_t', but argument 2 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=] return String::format("%tu bytes", size); ^~~~~~~~~~~ ~~~~ In file included from /<<PKGBUILDDIR>>/obj-i686-linux-gnu/DerivedSources/WebCore/unified-sources/UnifiedSource291.cpp:1: /<<PKGBUILDDIR>>/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp: In function 'WTF::String WebCore::formatByteNumber(size_t)': /<<PKGBUILDDIR>>/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp:59:27: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'size_t' {aka 'unsigned int'} [-Wformat=] return String::format("%lu", number); ^~~~~ ~~~~~~ In file included from /<<PKGBUILDDIR>>/obj-i686-linux-gnu/DerivedSources/WebCore/unified-sources/UnifiedSource300.cpp:5: /<<PKGBUILDDIR>>/Source/WebCore/platform/SharedBuffer.cpp: In member function 'WTF::RefPtr<JSC::ArrayBuffer> WebCore::SharedBuffer::tryCreateArrayBuffer() const': /<<PKGBUILDDIR>>/Source/WebCore/platform/SharedBuffer.cpp:124:22: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat=] WTFLogAlways("SharedBuffer::tryCreateArrayBuffer Unable to create buffer. Requested size was %zu x %lu\n", size(), sizeof(char)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1509627 1 mcatanzaro 2019-02-25 07:30:51 -0800 (In reply to Michael Catanzaro from comment #0) > Looking over a 32-bit build log from Debian, to check for potential issues > with 32-bit build: > > /<<PKGBUILDDIR>>/Source/WebCore/PAL/pal/FileSizeFormatter.cpp: In function > 'WTF::String fileSizeDescription(uint64_t)': > /<<PKGBUILDDIR>>/Source/WebCore/PAL/pal/FileSizeFormatter.cpp:36:31: > warning: format '%tu' expects argument of type 'unsigned ptrdiff_t', but > argument 2 has type 'uint64_t' {aka 'long long unsigned int'} [-Wformat=] > return String::format("%tu bytes", size); > ^~~~~~~~~~~ ~~~~ This one's already fixed (probably by Darin). 1509628 2 mcatanzaro 2019-02-25 07:31:57 -0800 (In reply to Michael Catanzaro from comment #0) > In file included from > /<<PKGBUILDDIR>>/obj-i686-linux-gnu/DerivedSources/WebCore/unified-sources/ > UnifiedSource291.cpp:1: > /<<PKGBUILDDIR>>/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp: In > function 'WTF::String WebCore::formatByteNumber(size_t)': > /<<PKGBUILDDIR>>/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp:59: > 27: warning: format '%lu' expects argument of type 'long unsigned int', but > argument 2 has type 'size_t' {aka 'unsigned int'} [-Wformat=] > return String::format("%lu", number); > ^~~~~ ~~~~~~ Ditto 1509630 3 362903 mcatanzaro 2019-02-25 07:43:14 -0800 Created attachment 362903 Patch 1511920 4 362903 darin 2019-03-03 00:31:08 -0800 Comment on attachment 362903 Patch This seems fine. if we did need to log the result of sizeof there are three traditional fixes: 1) add a type cast to some known type 2) put in a local variable or constant of a known type 3) stringify the constant into the literal directly rather than using printf formatting to insert it 1511938 5 362903 commit-queue 2019-03-03 08:45:43 -0800 Comment on attachment 362903 Patch Clearing flags on attachment: 362903 Committed r242327: <https://trac.webkit.org/changeset/242327> 1511939 6 commit-queue 2019-03-03 08:45:45 -0800 All reviewed patches have been landed. Closing bug. 362903 2019-02-25 07:43:14 -0800 2019-03-03 08:45:43 -0800 Patch bug-195004-20190225094313.patch text/plain 2119 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQwM2Y3MDgzNmZkNTlm YThiNGQ3NDc3ZDA0MTNhOTY3ODU1NDhhNC4uYTRmMWQwODdkNGM1MTY0M2U0OWJlMzgyNmI2YzVl YmNkMDM3YmQxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAyLTI1ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV2Zvcm1h dCBlcnJvciBpbiBTaGFyZWRCdWZmZXI6OnRyeUNyZWF0ZUFycmF5QnVmZmVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUwMDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZWVtcyBDKysgaGFzIG5vIGZv cm1hdCBzcGVjaWZpZXIgYXBwcm9wcmlhdGUgZm9yIHByaW50aW5nIHRoZSByZXN1bHQgb2Ygc2l6 ZW9mLiBXZSBzaG91bGQKKyAgICAgICAganVzdCBub3QgdHJ5IHRvIHByaW50IGl0LiBBbnl3YXks IHRoYXQncyBlYXN5IGluIHRoaXMgY2FzZSwgYmVjYXVzZSBzaXplb2YoY2hhcikgaXMKKyAgICAg ICAgZ3VhcmFudGVlZCB0byBiZSAxLiBUaGlzIGNvZGUgd2FzIGFuIGF0dGVtcHQgdG8gYmUgcGVk YW50aWMgdG8gYWNjb3VudCBmb3IgbXl0aGljYWwgc3lzdGVtcworICAgICAgICB3aXRoIGNoYXIg bGFyZ2VyIHRoYW4gb25lIGJ5dGUsIGJ1dCBwZXJoYXBzIGl0IGRpZG4ndCByZWFsaXplIHNpemVv ZiBhbHdheXMgcmV0dXJucworICAgICAgICBtdWx0aXBsZXMgb2YgY2hhciBhbmQgc28gc2l6ZW9m KGNoYXIpIGlzIGFsd2F5cyBvbmUgZXZlbiBvbiBzdWNoIG15dGhpY2FsIHN5c3RlbXMuCisKKyAg ICAgICAgTm90ZSB0aGUgc2l6ZW9mKGNoYXIpIHVzZSB0d28gbGluZXMgdXAgaXMgbGVmdCBzaW5j ZSBpdCdzIG5vdCBjbGVhciB0aGF0IHN3aXRjaGluZyBpdCB0byAxCisgICAgICAgIHdvdWxkIGFj dHVhbGx5IGJlIG1vcmUgcmVhZGFibGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TaGFyZWRCdWZm ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkQnVmZmVyOjp0cnlDcmVhdGVBcnJheUJ1 ZmZlciBjb25zdCk6CisKIDIwMTktMDItMjAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIEluY29ycmVjdCB1c2Ugb2YgU3RyaW5nOjpmb2xkQ2FzZSBmb3IgZm9udCBm YW1pbHkgbmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1 ZmZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCmluZGV4 IDI2ZGUxYmJmMzk1YmZhZmRjM2UxY2ZjZDk5OTYwMTAwMGI1ZGQyMTAuLjYzY2ZlNDYyNTgxZGJi YzJmZGExZmI2Mzk5Mzk0NWY4ZmUwNjAyOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hh cmVkQnVmZmVyLmNwcApAQCAtMTM1LDcgKzEzNSw3IEBAIFJlZlB0cjxBcnJheUJ1ZmZlcj4gU2hh cmVkQnVmZmVyOjp0cnlDcmVhdGVBcnJheUJ1ZmZlcigpIGNvbnN0CiB7CiAgICAgYXV0byBhcnJh eUJ1ZmZlciA9IEFycmF5QnVmZmVyOjp0cnlDcmVhdGVVbmluaXRpYWxpemVkKHN0YXRpY19jYXN0 PHVuc2lnbmVkPihzaXplKCkpLCBzaXplb2YoY2hhcikpOwogICAgIGlmICghYXJyYXlCdWZmZXIp IHsKLSAgICAgICAgV1RGTG9nQWx3YXlzKCJTaGFyZWRCdWZmZXI6OnRyeUNyZWF0ZUFycmF5QnVm ZmVyIFVuYWJsZSB0byBjcmVhdGUgYnVmZmVyLiBSZXF1ZXN0ZWQgc2l6ZSB3YXMgJXp1IHggJWx1 XG4iLCBzaXplKCksIHNpemVvZihjaGFyKSk7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiU2hhcmVk QnVmZmVyOjp0cnlDcmVhdGVBcnJheUJ1ZmZlciBVbmFibGUgdG8gY3JlYXRlIGJ1ZmZlci4gUmVx dWVzdGVkIHNpemUgd2FzICV6dVxuIiwgc2l6ZSgpKTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7 CiAgICAgfQogCg==