194959 2019-02-22 13:22:47 -0800 Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories 2019-02-27 20:11:15 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain youennf ap beidson cdumez commit-queue lforschler webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1509148 0 aakash_jain 2019-02-22 13:22:47 -0800 TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories seems flaky. In https://ews-build.webkit-uat.org/#/builders/19/builds/1115, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed. 1510729 1 363163 youennf 2019-02-27 17:24:27 -0800 Created attachment 363163 Patch 1510752 2 363163 cdumez 2019-02-27 18:11:19 -0800 Comment on attachment 363163 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363163&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1376 > + TestWebKitAPI::Util::spinRunLoop(1); 1 second seems excessive, I would suggest 0.1 1510771 3 363179 youennf 2019-02-27 19:04:51 -0800 Created attachment 363179 Patch for landing 1510772 4 youennf 2019-02-27 19:05:18 -0800 (In reply to Chris Dumez from comment #2) > Comment on attachment 363163 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=363163&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1376 > > + TestWebKitAPI::Util::spinRunLoop(1); > > 1 second seems excessive, I would suggest 0.1 Done 1510782 5 363179 commit-queue 2019-02-27 19:42:50 -0800 Comment on attachment 363179 Patch for landing Clearing flags on attachment: 363179 Committed r242188: <https://trac.webkit.org/changeset/242188> 1510783 6 commit-queue 2019-02-27 19:42:52 -0800 All reviewed patches have been landed. Closing bug. 1510789 7 webkit-bug-importer 2019-02-27 20:11:15 -0800 <rdar://problem/48461500> 363163 2019-02-27 17:24:27 -0800 2019-02-27 19:04:49 -0800 Patch bug-194959-20190227172426.patch text/plain 1714 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMTIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDUyNTFiY2Y5MjE1MDNkMzc4ZjhiODIzY2JkYmU0M2M2 MzcwMTExNC4uMzI3MmMxOTQ4NzJhODEwYWEzMzhhNWUzYzI3ZGVmODVmNjUyYzQwYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAyLTI3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAg ICAgICBGbGFreSBBUEkgVGVzdDogVGVzdFdlYktpdEFQSS5TZXJ2aWNlV29ya2Vycy5TZXJ2aWNl V29ya2VyQW5kQ2FjaGVTdG9yYWdlU3BlY2lmaWNEaXJlY3RvcmllcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0OTU5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BpbiBsb29wIHVudGlsIGdldHRpbmcg dGhlIGNvbmRpdGlvbiB0byByZW1vdmUgZmxha2luZXNzLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFzaWMubW06CisKIDIwMTktMDIt MjYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBNb3ZlIGVwaGVtZXJhbCBsb2NhbCBzdG9yYWdlIGZyb20gV2ViUHJvY2VzcyB0byBVSVByb2Nl c3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2Vy dmljZVdvcmtlckJhc2ljLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9TZXJ2aWNlV29ya2VyQmFzaWMubW0KaW5kZXggM2Q3MTViOWZlMzkyZTA2YmEwODRhOWNhYzFk MGM5NTZmOGZjMGZiOC4uMzQyMGQ1ZWFhYTM5N2I2NmFjMmM2Mjc0NWY1NmIxMGI1ODIxNGEyNCAx MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNl V29ya2VyQmFzaWMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9TZXJ2aWNlV29ya2VyQmFzaWMubW0KQEAgLTEzNzIsNyArMTM3Miw4IEBAIFRFU1QoU2Vydmlj ZVdvcmtlcnMsIFNlcnZpY2VXb3JrZXJBbmRDYWNoZVN0b3JhZ2VTcGVjaWZpY0RpcmVjdG9yaWVz KQogICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3RdOwogICAgIFRlc3RXZWJLaXRBUEk6 OlV0aWw6OnJ1bigmZG9uZSk7CiAgICAgZG9uZSA9IGZhbHNlOwotICAgIEVYUEVDVF9UUlVFKFt3 ZWJzaXRlRGF0YVN0b3JlIF9oYXNSZWdpc3RlcmVkU2VydmljZVdvcmtlcl0pOworICAgIHdoaWxl ICghW3dlYnNpdGVEYXRhU3RvcmUgX2hhc1JlZ2lzdGVyZWRTZXJ2aWNlV29ya2VyXSkKKyAgICAg ICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3AoMSk7CiAKICAgICB3ZWJWaWV3ID0g YWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAs IDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCldKTsKICAgICByZXF1 ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpA InN3Oi8vaG9zdC9yZWd1bGFyUGFnZUdyYWJiaW5nQ2FjaGVTdG9yYWdlRGlyZWN0b3J5Lmh0bWwi XV07Cg== 363179 2019-02-27 19:04:51 -0800 2019-02-27 19:42:50 -0800 Patch for landing bug-194959-20190227190450.patch text/plain 1713 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMTIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDUyNTFiY2Y5MjE1MDNkMzc4ZjhiODIzY2JkYmU0M2M2 MzcwMTExNC4uYzlhY2U4ODAzNzQyNzZkYmEwMjEzMTU2N2YyOTBkZDlmMDk1NTgyNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAyLTI3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAg ICAgICBGbGFreSBBUEkgVGVzdDogVGVzdFdlYktpdEFQSS5TZXJ2aWNlV29ya2Vycy5TZXJ2aWNl V29ya2VyQW5kQ2FjaGVTdG9yYWdlU3BlY2lmaWNEaXJlY3RvcmllcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0OTU5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgU3BpbiBsb29wIHVudGlsIGdldHRpbmcgdGhl IGNvbmRpdGlvbiB0byByZW1vdmUgZmxha2luZXNzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFzaWMubW06CisKIDIwMTktMDItMjYg IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBN b3ZlIGVwaGVtZXJhbCBsb2NhbCBzdG9yYWdlIGZyb20gV2ViUHJvY2VzcyB0byBVSVByb2Nlc3MK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2Vydmlj ZVdvcmtlckJhc2ljLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9T ZXJ2aWNlV29ya2VyQmFzaWMubW0KaW5kZXggM2Q3MTViOWZlMzkyZTA2YmEwODRhOWNhYzFkMGM5 NTZmOGZjMGZiOC4uY2UzNmExZmI3ZmJlNzQ5ZDU2ZDhmNjA5Zjc4Y2U3NmMzZTM4MmYzNyAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29y a2VyQmFzaWMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9T ZXJ2aWNlV29ya2VyQmFzaWMubW0KQEAgLTEzNzIsNyArMTM3Miw4IEBAIFRFU1QoU2VydmljZVdv cmtlcnMsIFNlcnZpY2VXb3JrZXJBbmRDYWNoZVN0b3JhZ2VTcGVjaWZpY0RpcmVjdG9yaWVzKQog ICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3RdOwogICAgIFRlc3RXZWJLaXRBUEk6OlV0 aWw6OnJ1bigmZG9uZSk7CiAgICAgZG9uZSA9IGZhbHNlOwotICAgIEVYUEVDVF9UUlVFKFt3ZWJz aXRlRGF0YVN0b3JlIF9oYXNSZWdpc3RlcmVkU2VydmljZVdvcmtlcl0pOworICAgIHdoaWxlICgh W3dlYnNpdGVEYXRhU3RvcmUgX2hhc1JlZ2lzdGVyZWRTZXJ2aWNlV29ya2VyXSkKKyAgICAgICAg VGVzdFdlYktpdEFQSTo6VXRpbDo6c3BpblJ1bkxvb3AoMC4xKTsKIAogICAgIHdlYlZpZXcgPSBh ZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwg ODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOwogICAgIHJlcXVl c3QgPSBbTlNVUkxSZXF1ZXN0IHJlcXVlc3RXaXRoVVJMOltOU1VSTCBVUkxXaXRoU3RyaW5nOkAi c3c6Ly9ob3N0L3JlZ3VsYXJQYWdlR3JhYmJpbmdDYWNoZVN0b3JhZ2VEaXJlY3RvcnkuaHRtbCJd XTsK