194929 2019-02-21 19:31:28 -0800 Web Inspector: propagate whether to show prototype information to subobject views 2019-07-02 18:57:02 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 198721 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1508834 0 hi 2019-02-21 19:31:28 -0800 `_includeProtoProperty` is only set on the top-level `WI.ObjectTreeView`, not any of the child `WI.ObjectTreeBaseTreeElement`. As a result, we see "Object prototype" for logs like `{a: {b: {c: 42}}}`. 1540995 1 371122 hi 2019-06-01 13:05:48 -0700 Created attachment 371122 Patch 1541139 2 371122 mattbaker 2019-06-02 16:03:58 -0700 Comment on attachment 371122 Patch rs=me 1541141 3 371122 commit-queue 2019-06-02 16:34:41 -0700 Comment on attachment 371122 Patch Clearing flags on attachment: 371122 Committed r246025: <https://trac.webkit.org/changeset/246025> 1541142 4 commit-queue 2019-06-02 16:34:43 -0700 All reviewed patches have been landed. Closing bug. 1541149 5 webkit-bug-importer 2019-06-02 16:35:39 -0700 <rdar://problem/51342180> 371122 2019-06-01 13:05:48 -0700 2019-06-02 16:34:41 -0700 Patch bug-194929-20190601130548.patch text/plain 5918 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUwZWE0N2M4MmE2YTVhMDkxMmI2Y2MxOWE0ZmUx YTA3MjQ4Yjg2NjkuLjcyYjAyMGYyM2Q0NGRkMDZjNDc1NWY0MDUyMWI0NWQ2ZTUyZjViMGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA2LTAxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBw cm9wYWdhdGUgd2hldGhlciB0byBzaG93IHByb3RvdHlwZSBpbmZvcm1hdGlvbiB0byBzdWJvYmpl Y3Qgdmlld3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NDkyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhIHdheSB0byBtYXJrIHRoZSBgT2JqZWN0VHJlZVZpZXdgIGFzIGhvbGRpbmcgYSBKU09O IHZhbHVlLCB3aGljaCBleHRlbmRzCisgICAgICAgIGBzaG93T25seVByb3BlcnRpZXNgIHRvIGFs c28gaGlkZSB0aGUgcHJvdG90eXBlIG9mIGFsbCBoZWxkIHZhbHVlcyAoZS5nLiBjaGlsZHJlbiku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVWaWV3LmpzOgorICAg ICAgICAoV0kuT2JqZWN0VHJlZVZpZXcucHJvdG90eXBlLnNob3dPbmx5SlNPTik6IEFkZGVkLgor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuY3NzOgorICAgICAg ICAoLm9iamVjdC10cmVlLnByb3BlcnRpZXMtb25seS5qc29uLW9ubHkgLm9iamVjdC10cmVlLXBy b3BlcnR5IC5wcm90b3R5cGUtcHJvcGVydHkpOiBBZGRlZC4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvQXVkaXRUZXN0Q2FzZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuQXVk aXRUZXN0Q2FzZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5sYXlvdXQpOgorICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChX SS5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUuX3JlZnJlc2hBc3NvY2lhdGVk RGF0YSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9KU09OUmVzb3VyY2VDb250ZW50 Vmlldy5jc3M6CisgICAgICAgICguY29udGVudC12aWV3LnJlc291cmNlLmpzb24gLm9iamVjdC10 cmVlIC5wcm90b3R5cGUtcHJvcGVydHkpOiBEZWxldGVkLgorICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvSlNPTlJlc291cmNlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5KU09OUmVz b3VyY2VDb250ZW50Vmlldy5wcm90b3R5cGUuY29udGVudEF2YWlsYWJsZSk6CisKIDIwMTktMDUt MzEgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogQ1NTIENoYW5nZXM6IG1vZGlmaWNhdGlvbnMgYXJlbid0IHNoYXJlZCBmb3Ig cnVsZXMgdGhhdCBtYXRjaCBtdWx0aXBsZSBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0Q2FzZUNvbnRlbnRWaWV3 LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0 Q2FzZUNvbnRlbnRWaWV3LmpzCmluZGV4IDk1MGUzNjRkY2FhMDdjMzQ3YmQ2YmQ2YWNiZDdhOTRl NTlmNTk0ZjAuLjQ4Njg2Y2RhY2YxMWE1OWZkZGNkZmQ3OWM5OTFlYmE3NzM1MDMxNmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVz dENhc2VDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9BdWRpdFRlc3RDYXNlQ29udGVudFZpZXcuanMKQEAgLTE2MSw3ICsxNjEsNyBA QCBXSS5BdWRpdFRlc3RDYXNlQ29udGVudFZpZXcgPSBjbGFzcyBBdWRpdFRlc3RDYXNlQ29udGVu dFZpZXcgZXh0ZW5kcyBXSS5BdWRpdFRlcwogCiAgICAgICAgICAgICAgICAgICAgIGxldCBvYmpl Y3RUcmVlID0gZWxlbWVudC5fX29iamVjdFRyZWU7CiAgICAgICAgICAgICAgICAgICAgIGlmIChv YmplY3RUcmVlKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBvYmplY3RUcmVlLnNob3dPbmx5 UHJvcGVydGllcygpOworICAgICAgICAgICAgICAgICAgICAgICAgb2JqZWN0VHJlZS5zaG93T25s eUpTT04oKTsKICAgICAgICAgICAgICAgICAgICAgICAgIG9iamVjdFRyZWUuZXhwYW5kKCk7CiAg ICAgICAgICAgICAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGVi YXJQYW5lbC5qcwppbmRleCA4OWFlYzUxMTVkNTliMjgzZWFmZjM1NWIwOThmYWE2NmRkZmE2N2Rj Li4xZWE2ZDZkZjRkYjFhMmM1NDFkYTg2NGFjYTQ3YTA3YzQzODY1NjRlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1Np ZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAtNTIxLDcgKzUyMSw3IEBAIFdJ LkRPTU5vZGVEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgRE9NTm9kZURldGFpbHNTaWRlYmFy UGFuZWwgZXh0ZW5kcyBXSS5ET01ECiAKICAgICAgICAgICAgICAgICBsZXQgb2JqZWN0VHJlZSA9 IGVsZW1lbnQuX19vYmplY3RUcmVlOwogICAgICAgICAgICAgICAgIGlmIChvYmplY3RUcmVlKSB7 Ci0gICAgICAgICAgICAgICAgICAgIG9iamVjdFRyZWUuc2hvd09ubHlQcm9wZXJ0aWVzKCk7Cisg ICAgICAgICAgICAgICAgICAgIG9iamVjdFRyZWUuc2hvd09ubHlKU09OKCk7CiAgICAgICAgICAg ICAgICAgICAgIG9iamVjdFRyZWUuZXhwYW5kKCk7CiAgICAgICAgICAgICAgICAgfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9KU09OUmVz b3VyY2VDb250ZW50Vmlldy5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9KU09OUmVzb3VyY2VDb250ZW50Vmlldy5jc3MKaW5kZXggYWY1YmJkOGJjMDYyY2Jk ZTU2NGEyZTk2ZTYyYjA2MzIzNmUwMTU5Mi4uMTg4N2IxMDk2ZWUxNzMzYWE1NTBiZmQwODhlNzI1 MjI5OGEzYWU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvSlNPTlJlc291cmNlQ29udGVudFZpZXcuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0pTT05SZXNvdXJjZUNvbnRlbnRWaWV3LmNzcwpA QCAtMjcsNyArMjcsMyBAQAogICAgIHBhZGRpbmc6IDEwcHg7CiAgICAgb3ZlcmZsb3c6IHNjcm9s bDsKIH0KLQotLmNvbnRlbnQtdmlldy5yZXNvdXJjZS5qc29uIC5vYmplY3QtdHJlZSAucHJvdG90 eXBlLXByb3BlcnR5IHsKLSAgICBkaXNwbGF5OiBub25lOwotfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSlNPTlJlc291cmNlQ29udGVudFZp ZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9KU09OUmVz b3VyY2VDb250ZW50Vmlldy5qcwppbmRleCBhNzg4NDVjNWQ3OTgwNjMyNTc4MzQ4MzVjY2NjNWIy MDQ5MmNhNWYzLi4wMDFlZTY5OGE2NDFlZjExNTcwODUxNWVkODU3NzQzMGQzN2ZkMDI5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9KU09OUmVz b3VyY2VDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9KU09OUmVzb3VyY2VDb250ZW50Vmlldy5qcwpAQCAtNjksNiArNjksNyBAQCBX SS5KU09OUmVzb3VyY2VDb250ZW50VmlldyA9IGNsYXNzIEpTT05SZXNvdXJjZUNvbnRlbnRWaWV3 IGV4dGVuZHMgV0kuUmVzb3VyY2VDbwogICAgICAgICAgICAgdGhpcy5fcmVtb3RlT2JqZWN0ID0g V0kuUmVtb3RlT2JqZWN0LmZyb21QYXlsb2FkKHJlc3VsdCwgdGhpcy5yZXNvdXJjZS50YXJnZXQp OwogCiAgICAgICAgICAgICBsZXQgb2JqZWN0VHJlZSA9IG5ldyBXSS5PYmplY3RUcmVlVmlldyh0 aGlzLl9yZW1vdGVPYmplY3QpOworICAgICAgICAgICAgb2JqZWN0VHJlZS5zaG93T25seUpTT04o KTsKICAgICAgICAgICAgIG9iamVjdFRyZWUuZXhwYW5kKCk7CiAKICAgICAgICAgICAgIHRoaXMu ZWxlbWVudC5hcHBlbmRDaGlsZChvYmplY3RUcmVlLmVsZW1lbnQpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuY3Nz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZp ZXcuY3NzCmluZGV4IDdjM2ZiMzViMDdlZDM2OWFlYzRiOGE2YmU1YjBiMTAzNjFjNWY3NGIuLmFj MGYzMDM1N2IyNjUwNWNlY2QxNmFkYTA1Mjc2NTZmZDI1MjlhNGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVWaWV3LmNzcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVl Vmlldy5jc3MKQEAgLTEwNyw2ICsxMDcsMTAgQEAgYm9keVtkaXI9cnRsXSAub2JqZWN0LXRyZWUg PiA6bWF0Y2hlcygudGl0bGUsIC5vYmplY3QtcHJldmlldyk6OmJlZm9yZSB7CiAgICAgb3BhY2l0 eTogMTsKIH0KIAorLm9iamVjdC10cmVlLnByb3BlcnRpZXMtb25seS5qc29uLW9ubHkgLm9iamVj dC10cmVlLXByb3BlcnR5IC5wcm90b3R5cGUtcHJvcGVydHkgeworICAgIGRpc3BsYXk6IG5vbmU7 Cit9CisKIC50cmVlLW91dGxpbmUub2JqZWN0IGxpIHsKICAgICB3aGl0ZS1zcGFjZTogbm93cmFw OwogICAgIHRleHQtb3ZlcmZsb3c6IGVsbGlwc2lzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmlldy5qcwppbmRl eCA1ZGIxNzMwZDJjYWRkNmEyOWU2NWMyMmE5ZjE4MzU1N2I2OTQyYzJkLi5kYTI5MzhlYjY2MTk4 NjI4ZmEzNWJkOWZmNDIxM2YyZTU2NTE1N2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmlldy5qcwpAQCAt MjIyLDYgKzIyMiwxMyBAQCBXSS5PYmplY3RUcmVlVmlldyA9IGNsYXNzIE9iamVjdFRyZWVWaWV3 IGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIHRoaXMuX2luY2x1ZGVQcm90b1Byb3BlcnR5ID0g ZmFsc2U7CiAgICAgfQogCisgICAgc2hvd09ubHlKU09OKCkKKyAgICB7CisgICAgICAgIHRoaXMu c2hvd09ubHlQcm9wZXJ0aWVzKCk7CisKKyAgICAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3Qu YWRkKCJqc29uLW9ubHkiKTsKKyAgICB9CisKICAgICBhcHBlbmRUaXRsZVN1ZmZpeChzdWZmaXhF bGVtZW50KQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX3ByZXZpZXdWaWV3KQo=