194898 2019-02-21 07:10:50 -0800 [WPE] Inline wl_array_for_each to workaround C++ compatibility issue 2019-05-02 16:23:34 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner aperez bugs-noreply cgarcia commit-queue mcatanzaro olivier.blin pagebul zan oldest_to_newest 1508502 0 cturner 2019-02-21 07:10:50 -0800 [WPE] Condition use of wl_array_for_each on GCC 1508503 1 362603 cturner 2019-02-21 07:12:53 -0800 Created attachment 362603 Patch 1508969 2 aperez 2019-02-22 03:36:45 -0800 There's an upstream bug report related to this: https://gitlab.freedesktop.org/wayland/wayland/issues/34 As discussed with Charlie in a chat, it seems a tad better to have the “for”-loop expanded by hand in this code instead of relying on the wl_arrat_for_each() macro, instead of disabling the block of code completely. 1508972 3 362715 cturner 2019-02-22 04:39:31 -0800 Created attachment 362715 Patch 1508973 4 362715 aperez 2019-02-22 05:10:21 -0800 Comment on attachment 362715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362715&action=review Informal r+ from me, with a (very) minor nit. > Tools/wpe/backends/WindowViewBackend.cpp:451 > + while (pos < end) { Minor nitpick: I would probably write this as a for-loop with empty initializer list: for (; pos < end; pos++) Though this is mainly personal preference, because I find code easier to follow when the “increment” done on each iteration is written along the header of the loop :) > Tools/wpe/backends/WindowViewBackend.cpp:452 > + uint32_t state = *pos; Alternatively, if you prefer to keep the “while”, you can do: uint32_t state = *pos++; 1508992 5 362722 cturner 2019-02-22 07:47:47 -0800 Created attachment 362722 Patch Thanks Adrian, I will go with your style and use the for-loop 1512080 7 362722 commit-queue 2019-03-04 00:32:24 -0800 Comment on attachment 362722 Patch Clearing flags on attachment: 362722 Committed r242344: <https://trac.webkit.org/changeset/242344> 1512081 8 commit-queue 2019-03-04 00:32:25 -0800 All reviewed patches have been landed. Closing bug. 1512107 9 olivier.blin 2019-03-04 02:42:18 -0800 *** Bug 194290 has been marked as a duplicate of this bug. *** 362603 2019-02-21 07:12:53 -0800 2019-02-22 04:39:27 -0800 Patch bug-194898-20190221151252.patch text/plain 1585 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTY3MDhlNzliYWQ2YTAzNWE4ZWY3MjBkYmE5YThlNjNk Mjk1YjliMS4uMWE2ZDdiNWI0NzkwMGI1MWUzNWQ1NGVlNTdhZTAxNzg0OTUyNTE2MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAyLTIxICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbV1BFXSBDb25kaXRpb24gdXNlIG9mIHdsX2FycmF5X2Zvcl9lYWNoIG9uIEdDQwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0ODk4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3cGUvYmFj a2VuZHMvV2luZG93Vmlld0JhY2tlbmQuY3BwOiB3bF9hcnJheV9mb3JfZWFjaCByZWxpZXMgb24K KyAgICAgICAgYSBHQ0MgZXh0ZW5zaW9uIHdoZXJlIGFyaXRobWV0aWMgb24gdm9pZCogcG9pbnRl cnMgaXMKKyAgICAgICAgcGVybWl0dGVkLiBXaGVuIGNvbXBpbGluZyB3aXRoIENsYW5nLCB0aGlz IGlzIG5vdCBhbGxvd2VkLgorCiAyMDE5LTAyLTIwICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8 YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV1bR1RLXSBFbmFibGUgc3VwcG9ydCBm b3IgQ09OVEVOVF9FWFRFTlNJT05TCmRpZmYgLS1naXQgYS9Ub29scy93cGUvYmFja2VuZHMvV2lu ZG93Vmlld0JhY2tlbmQuY3BwIGIvVG9vbHMvd3BlL2JhY2tlbmRzL1dpbmRvd1ZpZXdCYWNrZW5k LmNwcAppbmRleCAyMGYwM2I4MGJhYmRkMzg2NjEyYWRjM2NjZWUyMzI1NmM4Y2JmM2Q1Li5lYjI0 YmE1NDIyZTQ2YTk4NTgzMTEzMTI2NWNhODliZmFmMTY4ZWRlIDEwMDY0NAotLS0gYS9Ub29scy93 cGUvYmFja2VuZHMvV2luZG93Vmlld0JhY2tlbmQuY3BwCisrKyBiL1Rvb2xzL3dwZS9iYWNrZW5k cy9XaW5kb3dWaWV3QmFja2VuZC5jcHAKQEAgLTQzOSw3ICs0MzksNyBAQCBjb25zdCBzdHJ1Y3Qg enhkZ190b3BsZXZlbF92Nl9saXN0ZW5lciBXaW5kb3dWaWV3QmFja2VuZDo6c194ZGdUb3BsZXZl bExpc3RlbmVyCiAgICAgICAgIGF1dG8mIHdpbmRvdyA9ICpzdGF0aWNfY2FzdDxXaW5kb3dWaWV3 QmFja2VuZCo+KGRhdGEpOwogICAgICAgICB3cGVfdmlld19iYWNrZW5kX2Rpc3BhdGNoX3NldF9z aXplKHdpbmRvdy5iYWNrZW5kKCksIHdpZHRoLCBoZWlnaHQpOwogCi0jaWYgZGVmaW5lZChXUEVf QkFDS0VORF9DSEVDS19WRVJTSU9OKSAmJiBXUEVfQkFDS0VORF9DSEVDS19WRVJTSU9OKDEsIDEs IDApCisjaWYgZGVmaW5lZChXUEVfQkFDS0VORF9DSEVDS19WRVJTSU9OKSAmJiBXUEVfQkFDS0VO RF9DSEVDS19WRVJTSU9OKDEsIDEsIDApICYmIChkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5l ZChfX2NsYW5nX18pKQogICAgICAgICBib29sIGlzRm9jdXNlZCA9IGZhbHNlOwogICAgICAgICB2 b2lkKiBwOwogICAgICAgICB3bF9hcnJheV9mb3JfZWFjaChwLCBzdGF0ZXMpCg== 362715 2019-02-22 04:39:31 -0800 2019-02-22 07:47:42 -0800 Patch bug-194898-20190222123930.patch text/plain 2182 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTY3MDhlNzliYWQ2YTAzNWE4ZWY3MjBkYmE5YThlNjNk Mjk1YjliMS4uMmVmNTkxODMwZDU3ZDI5OTJlOWIxMzk5Y2E3M2RlMjZiN2IyMGRmYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAyLTIyICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbV1BFXSBJbmxpbmUgd2xfYXJyYXlfZm9yX2VhY2ggdG8gd29ya2Fyb3VuZCBDKysg Y29tcGF0aWJpbGl0eSBpc3N1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk0ODk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3cGUvYmFja2VuZHMvV2luZG93Vmlld0JhY2tlbmQuY3BwOiB3bF9hcnJh eV9mb3JfZWFjaCByZWxpZXMgb24KKyAgICAgICAgYSBHQ0MgZXh0ZW5zaW9uIHRoYXQgcGVybWl0 cyBhcml0aG1ldGljIG9uIHZvaWQqIHBvaW50ZXIuIElubGluZQorICAgICAgICB0aGUgbWFjcm8g dW50aWwgdGhpcyBpc3N1ZSBpcyBmaXhlZCB1cHN0cmVhbS4KKwogMjAxOS0wMi0yMCAgQWRyaWFu IFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW0dU S10gRW5hYmxlIHN1cHBvcnQgZm9yIENPTlRFTlRfRVhURU5TSU9OUwpkaWZmIC0tZ2l0IGEvVG9v bHMvd3BlL2JhY2tlbmRzL1dpbmRvd1ZpZXdCYWNrZW5kLmNwcCBiL1Rvb2xzL3dwZS9iYWNrZW5k cy9XaW5kb3dWaWV3QmFja2VuZC5jcHAKaW5kZXggMjBmMDNiODBiYWJkZDM4NjYxMmFkYzNjY2Vl MjMyNTZjOGNiZjNkNS4uYjdkMTBjODAxZWFmMjYwM2M4NGYwNTZjYjI5OTQ4NjE4ZDFkZGFkZSAx MDA2NDQKLS0tIGEvVG9vbHMvd3BlL2JhY2tlbmRzL1dpbmRvd1ZpZXdCYWNrZW5kLmNwcAorKysg Yi9Ub29scy93cGUvYmFja2VuZHMvV2luZG93Vmlld0JhY2tlbmQuY3BwCkBAIC00NDEsMTAgKzQ0 MSwxNSBAQCBjb25zdCBzdHJ1Y3QgenhkZ190b3BsZXZlbF92Nl9saXN0ZW5lciBXaW5kb3dWaWV3 QmFja2VuZDo6c194ZGdUb3BsZXZlbExpc3RlbmVyCiAKICNpZiBkZWZpbmVkKFdQRV9CQUNLRU5E X0NIRUNLX1ZFUlNJT04pICYmIFdQRV9CQUNLRU5EX0NIRUNLX1ZFUlNJT04oMSwgMSwgMCkKICAg ICAgICAgYm9vbCBpc0ZvY3VzZWQgPSBmYWxzZTsKLSAgICAgICAgdm9pZCogcDsKLSAgICAgICAg d2xfYXJyYXlfZm9yX2VhY2gocCwgc3RhdGVzKQotICAgICAgICB7Ci0gICAgICAgICAgICB1aW50 MzJfdCBzdGF0ZSA9ICpzdGF0aWNfY2FzdDx1aW50MzJfdCo+KHApOworICAgICAgICAvLyBGSVhN RTogSXQgd291bGQgYmUgbmljZSBpZiB0aGUgZm9sbG93aW5nIGxvb3AgY291bGQgdXNlCisgICAg ICAgIC8vIHdsX2FycmF5X2Zvcl9lYWNoLCBidXQgYXQgdGhlIHRpbWUgb2Ygd3JpdGluZyBpdCBy ZWxpZXMgb24KKyAgICAgICAgLy8gR0NDIHNwZWNpZmljIGV4dGVuc2lvbiB0byB3b3JrIHByb3Bl cmx5OgorICAgICAgICAvLyBodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvd2F5bGFuZC93 YXlsYW5kL2lzc3Vlcy8zNAorICAgICAgICB1aW50MzJfdCogcG9zID0gc3RhdGljX2Nhc3Q8dWlu dDMyX3QqPihzdGF0ZXMtPmRhdGEpOworICAgICAgICB1aW50MzJfdCogZW5kID0gc3RhdGljX2Nh c3Q8dWludDMyX3QqPihzdGF0ZXMtPmRhdGEpICsgc3RhdGVzLT5zaXplOworCisgICAgICAgIHdo aWxlIChwb3MgPCBlbmQpIHsKKyAgICAgICAgICAgIHVpbnQzMl90IHN0YXRlID0gKnBvczsKIAog ICAgICAgICAgICAgc3dpdGNoIChzdGF0ZSkgewogICAgICAgICAgICAgY2FzZSBaWERHX1RPUExF VkVMX1Y2X1NUQVRFX0FDVElWQVRFRDoKQEAgLTQ1Niw2ICs0NjEsOCBAQCBjb25zdCBzdHJ1Y3Qg enhkZ190b3BsZXZlbF92Nl9saXN0ZW5lciBXaW5kb3dWaWV3QmFja2VuZDo6c194ZGdUb3BsZXZl bExpc3RlbmVyCiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICAgICAgfQorCisgICAgICAgICAgICBwb3MrKzsKICAgICAgICAgfQogCiAgICAgICAg IGlmIChpc0ZvY3VzZWQpCg== 362722 2019-02-22 07:47:47 -0800 2019-03-04 00:32:24 -0800 Patch bug-194898-20190222154745.patch text/plain 1969 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTY3MDhlNzliYWQ2YTAzNWE4ZWY3MjBkYmE5YThlNjNk Mjk1YjliMS4uMmVmNTkxODMwZDU3ZDI5OTJlOWIxMzk5Y2E3M2RlMjZiN2IyMGRmYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAyLTIyICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbV1BFXSBJbmxpbmUgd2xfYXJyYXlfZm9yX2VhY2ggdG8gd29ya2Fyb3VuZCBDKysg Y29tcGF0aWJpbGl0eSBpc3N1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTk0ODk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3cGUvYmFja2VuZHMvV2luZG93Vmlld0JhY2tlbmQuY3BwOiB3bF9hcnJh eV9mb3JfZWFjaCByZWxpZXMgb24KKyAgICAgICAgYSBHQ0MgZXh0ZW5zaW9uIHRoYXQgcGVybWl0 cyBhcml0aG1ldGljIG9uIHZvaWQqIHBvaW50ZXIuIElubGluZQorICAgICAgICB0aGUgbWFjcm8g dW50aWwgdGhpcyBpc3N1ZSBpcyBmaXhlZCB1cHN0cmVhbS4KKwogMjAxOS0wMi0yMCAgQWRyaWFu IFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW0dU S10gRW5hYmxlIHN1cHBvcnQgZm9yIENPTlRFTlRfRVhURU5TSU9OUwpkaWZmIC0tZ2l0IGEvVG9v bHMvd3BlL2JhY2tlbmRzL1dpbmRvd1ZpZXdCYWNrZW5kLmNwcCBiL1Rvb2xzL3dwZS9iYWNrZW5k cy9XaW5kb3dWaWV3QmFja2VuZC5jcHAKaW5kZXggMjBmMDNiODBiYWJkZDM4NjYxMmFkYzNjY2Vl MjMyNTZjOGNiZjNkNS4uMDc4ODdmMWIzOTBiMmY3MjRkZDhkMTExMDc4NzE3NGMzNTgwMGZjZSAx MDA2NDQKLS0tIGEvVG9vbHMvd3BlL2JhY2tlbmRzL1dpbmRvd1ZpZXdCYWNrZW5kLmNwcAorKysg Yi9Ub29scy93cGUvYmFja2VuZHMvV2luZG93Vmlld0JhY2tlbmQuY3BwCkBAIC00NDEsMTAgKzQ0 MSwxNSBAQCBjb25zdCBzdHJ1Y3QgenhkZ190b3BsZXZlbF92Nl9saXN0ZW5lciBXaW5kb3dWaWV3 QmFja2VuZDo6c194ZGdUb3BsZXZlbExpc3RlbmVyCiAKICNpZiBkZWZpbmVkKFdQRV9CQUNLRU5E X0NIRUNLX1ZFUlNJT04pICYmIFdQRV9CQUNLRU5EX0NIRUNLX1ZFUlNJT04oMSwgMSwgMCkKICAg ICAgICAgYm9vbCBpc0ZvY3VzZWQgPSBmYWxzZTsKLSAgICAgICAgdm9pZCogcDsKLSAgICAgICAg d2xfYXJyYXlfZm9yX2VhY2gocCwgc3RhdGVzKQotICAgICAgICB7Ci0gICAgICAgICAgICB1aW50 MzJfdCBzdGF0ZSA9ICpzdGF0aWNfY2FzdDx1aW50MzJfdCo+KHApOworICAgICAgICAvLyBGSVhN RTogSXQgd291bGQgYmUgbmljZSBpZiB0aGUgZm9sbG93aW5nIGxvb3AgY291bGQgdXNlCisgICAg ICAgIC8vIHdsX2FycmF5X2Zvcl9lYWNoLCBidXQgYXQgdGhlIHRpbWUgb2Ygd3JpdGluZyBpdCBy ZWxpZXMgb24KKyAgICAgICAgLy8gR0NDIHNwZWNpZmljIGV4dGVuc2lvbiB0byB3b3JrIHByb3Bl cmx5OgorICAgICAgICAvLyBodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvd2F5bGFuZC93 YXlsYW5kL2lzc3Vlcy8zNAorICAgICAgICB1aW50MzJfdCogcG9zID0gc3RhdGljX2Nhc3Q8dWlu dDMyX3QqPihzdGF0ZXMtPmRhdGEpOworICAgICAgICB1aW50MzJfdCogZW5kID0gc3RhdGljX2Nh c3Q8dWludDMyX3QqPihzdGF0ZXMtPmRhdGEpICsgc3RhdGVzLT5zaXplOworCisgICAgICAgIGZv ciAoOyBwb3MgPCBlbmQ7IHBvcysrKSB7CisgICAgICAgICAgICB1aW50MzJfdCBzdGF0ZSA9ICpw b3M7CiAKICAgICAgICAgICAgIHN3aXRjaCAoc3RhdGUpIHsKICAgICAgICAgICAgIGNhc2UgWlhE R19UT1BMRVZFTF9WNl9TVEFURV9BQ1RJVkFURUQ6Cg==