194851 2019-02-20 01:26:21 -0800 Remove a "The " in "The The HTTP headers of the response" 2019-10-10 07:57:34 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All All RESOLVED FIXED P2 Trivial --- 1 scootergrisen aperez aperez berto bugs-noreply cgarcia clopez commit-queue ews-watchlist gustavo pnormand oldest_to_newest 1508029 0 scootergrisen 2019-02-20 01:26:21 -0800 In the translation po file for WebKitGTK+ it says: #: ../../../../WebKit/Shared/API/glib/WebKitURIResponse.cpp:173 msgid "The The HTTP headers of the response" Suggest removing one "The ". 1577990 1 380474 aperez 2019-10-08 15:53:46 -0700 Created attachment 380474 Patch 1577991 2 ews-watchlist 2019-10-08 15:54:18 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1578008 3 380474 clopez 2019-10-08 16:32:26 -0700 Comment on attachment 380474 Patch Updating all the translation po files isn't needed as well? 1578225 4 aperez 2019-10-09 07:44:28 -0700 (In reply to Carlos Alberto Lopez Perez from comment #3) > Comment on attachment 380474 [details] > Patch > > Updating all the translation po files isn't needed as well? The template (.pot) translation file is generated automatically by CMake. AFAIU translators will pick that (and possibly merge it with the existing translations) next time they update the translatable strings, and each .po file will be updated when a translator sends up an updated copy later on. 1578644 5 commit-queue 2019-10-10 07:56:42 -0700 The commit-queue encountered the following flaky tests while processing attachment 380474: imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 202799 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1578645 6 380474 commit-queue 2019-10-10 07:57:33 -0700 Comment on attachment 380474 Patch Clearing flags on attachment: 380474 Committed r250967: <https://trac.webkit.org/changeset/250967> 1578646 7 commit-queue 2019-10-10 07:57:34 -0700 All reviewed patches have been landed. Closing bug. 380474 2019-10-08 15:53:46 -0700 2019-10-10 07:57:33 -0700 Patch bug-194851-20191009015343.patch text/plain 1487 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVjNWQyM2IzOGJhNGQzMmMz OGIzZDI1ZTg5ZTQ1NmU2ODdhYzE0NzIuLmNhNTJiOTlhMjRkYTY5MmQwOWFlMmQyMGFhYmFjNDRl MjBjOTQ4YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMTAtMDggIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZW1vdmUgYSAi VGhlICIgaW4gIlRoZSBUaGUgSFRUUCBoZWFkZXJzIG9mIHRoZSByZXNwb25zZSIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDg1MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0FQSS9nbGli L1dlYktpdFVSSVJlc3BvbnNlLmNwcDoKKyAgICAgICAgKHdlYmtpdF91cmlfcmVzcG9uc2VfY2xh c3NfaW5pdCk6IEZpeCB0eXBvIGluIGRlc2NyaXB0aW9uIG9mIHRoZSBXZWJLaXRVUklSZXNwb25z ZTo6aHR0cC1oZWFkZXJzIHByb3BlcnR5LgorCiAyMDE5LTA5LTI5ICBBZHJpYW4gUGVyZXogZGUg Q2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gZGlzcGxheTpub25l IGhhcyBubyBlZmZlY3Qgb24gPG9wdGlvbj4gZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9TaGFyZWQvQVBJL2dsaWIvV2ViS2l0VVJJUmVzcG9uc2UuY3BwIGIvU291cmNlL1dlYktp dC9TaGFyZWQvQVBJL2dsaWIvV2ViS2l0VVJJUmVzcG9uc2UuY3BwCmluZGV4IGQyNDU1ODkzNmNm NDYwNzU1NTcxMmExNmM5NGZkNDYxZWMwOThhMjMuLjQ2ZTY1NDZkZDRiNzk1YmM4YmNmMGVhNmYx NTYwMDg4MDg1ZTVmMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0FQSS9nbGli L1dlYktpdFVSSVJlc3BvbnNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9BUEkvZ2xp Yi9XZWJLaXRVUklSZXNwb25zZS5jcHAKQEAgLTE3MCw3ICsxNzAsNyBAQCBzdGF0aWMgdm9pZCB3 ZWJraXRfdXJpX3Jlc3BvbnNlX2NsYXNzX2luaXQoV2ViS2l0VVJJUmVzcG9uc2VDbGFzcyogcmVz cG9uc2VDbGFzcwogICAgICAgICBnX3BhcmFtX3NwZWNfYm94ZWQoCiAgICAgICAgICAgICAiaHR0 cC1oZWFkZXJzIiwKICAgICAgICAgICAgIF8oIkhUVFAgSGVhZGVycyIpLAotICAgICAgICAgICAg XygiVGhlIFRoZSBIVFRQIGhlYWRlcnMgb2YgdGhlIHJlc3BvbnNlIiksCisgICAgICAgICAgICBf KCJUaGUgSFRUUCBoZWFkZXJzIG9mIHRoZSByZXNwb25zZSIpLAogICAgICAgICAgICAgU09VUF9U WVBFX01FU1NBR0VfSEVBREVSUywKICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkp OwogfQo=