194798 2019-02-18 15:59:14 -0800 [ Mac ] REGRESSION (r237587) Layout Test compositing/visible-rect/animated-from-none.html is flaky text diff failure 2019-04-09 10:50:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts graouts dino graouts lforschler simon.fraser thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1507510 0 sroberts 2019-02-18 15:59:14 -0800 The following layout test is flaky on Mac compositing/visible-rect/animated-from-none.html Probable cause: Test started to become flaky after R237924. Prior revision passes. reproduced locally with: run-webkit-tests compositing/visible-rect/animated-from-none.html --iterations 5000 -f --exit-after-n-failures=1 --no-retry-failures Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Fvisible-rect%2Fanimated-from-none.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/compositing/visible-rect/animated-from-none-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/compositing/visible-rect/animated-from-none-actual.txt @@ -35,6 +35,7 @@ (position -100.00 0.00) (bounds 200.00 200.00) (contentsOpaque 1) + (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 0.00 1.00]) (visible rect 100.00, 0.00 100.00 x 200.00) (coverage rect 100.00, 0.00 500.00 x 200.00) (intersects coverage rect 1) 1507511 1 webkit-bug-importer 2019-02-18 16:00:05 -0800 <rdar://problem/48181898> 1507514 2 wenson_hsieh 2019-02-18 16:04:45 -0800 (In reply to Shawn Roberts from comment #0) > The following layout test is flaky on Mac > > compositing/visible-rect/animated-from-none.html > > Probable cause: > > Test started to become flaky after R237924. Prior revision passes. I haven't investigated this to any depth yet, but it seems somewhat unlikely that <https://trac.webkit.org/r237924> would cause a layout test on macOS to become flaky. 1507515 3 wenson_hsieh 2019-02-18 16:07:12 -0800 Is it possible that another change (which might've landed around the same time as r237924) caused this? 1507524 4 sroberts 2019-02-18 16:17:26 -0800 It is definitely possible. Partnering with another bot watcher they thought perhaps the Rect it was referring to was it attempting to draw a rectangle and it was off. 237925 has a similar reference but I don't think anything had been changed in that regard. 1507525 5 sroberts 2019-02-18 16:17:44 -0800 https://trac.webkit.org/changeset/237925/webkit 1525255 6 simon.fraser 2019-04-08 10:48:15 -0700 The dumping code is: if (m_transform && !m_transform->isIdentity()) { ts << indent << "(transform "; ts << "[" << m_transform->m11() << " " << m_transform->m12() << " " << m_transform->m13() << " " << m_transform->m14() << "] "; ts << "[" << m_transform->m21() << " " << m_transform->m22() << " " << m_transform->m23() << " " << m_transform->m24() << "] "; ts << "[" << m_transform->m31() << " " << m_transform->m32() << " " << m_transform->m33() << " " << m_transform->m34() << "] "; ts << "[" << m_transform->m41() << " " << m_transform->m42() << " " << m_transform->m43() << " " << m_transform->m44() << "])\n"; } So this transform must be slightly non-identity. Figure out why! 1525612 7 graouts 2019-04-09 07:09:24 -0700 I think the reason is that the animation's progress can be a very small number larger than 0. I don't know whether that is a bug or a shortcoming of the test. 1525660 8 graouts 2019-04-09 10:09:59 -0700 I think for the Web Animations engine the right thing to use is the "ready" promise and not an "animationstart" event where the event delivery is async and progress may not be 0 at the time it's delivered. 1525661 9 367047 graouts 2019-04-09 10:12:00 -0700 Created attachment 367047 Patch 1525665 10 367047 dino 2019-04-09 10:21:12 -0700 Comment on attachment 367047 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367047&action=review > LayoutTests/ChangeLog:11 > + than 1 and yield an animated transform that isn't quite the identity matrix. Don't you mean 0? 1525676 11 graouts 2019-04-09 10:50:18 -0700 Committed r244082: <https://trac.webkit.org/changeset/244082> 367047 2019-04-09 10:12:00 -0700 2019-04-09 10:21:12 -0700 Patch bug-194798-20190409191159.patch text/plain 2317 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDY4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDEyNWI3MzY5YjdmOGIwYTIxMWVm MjY0ZGNlODVmYWU0YTY1YzUwNy4uNjAwYTU0ZjM3NTNlNGJkN2M5YjkzYzlkNjNmMDgyNTEzZjI3 ZTZlOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTA5ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgWyBNYWMgXSBSRUdSRVNTSU9OIChyMjM3NTg3 KSBMYXlvdXQgVGVzdCBjb21wb3NpdGluZy92aXNpYmxlLXJlY3QvYW5pbWF0ZWQtZnJvbS1ub25l Lmh0bWwgaXMgZmxha3kgdGV4dCBkaWZmIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDc5OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDgxODE4OTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiB1c2luZyB0aGUgV2ViIEFuaW1hdGlvbnMgZW5naW5lLCB0aGUgYmVzdCB3YXkgdG8g cnVuIGNvZGUgYXMgYW4gYW5pbWF0aW9uIHN0YXJ0IGlzIHRvIHVzZSB0aGUgInJlYWR5IiBwcm9t aXNlLCB3aGVyZWFzCisgICAgICAgIERPTSBldmVudHMgYXJlIGRpc3BhdGNoZWQgYXN5bmNocm9u b3VzbHkgYW5kLCBpbiB0aGUgY2FzZSBvZiB0aGlzIHRlc3QsIG1pZ2h0IGhhdmUgYW4gYW5pbWF0 aW9uIHByb2dyZXNzIHRoYXQgaXMgZ3JlYXRlcgorICAgICAgICB0aGFuIDEgYW5kIHlpZWxkIGFu IGFuaW1hdGVkIHRyYW5zZm9ybSB0aGF0IGlzbid0IHF1aXRlIHRoZSBpZGVudGl0eSBtYXRyaXgu CisKKyAgICAgICAgKiBjb21wb3NpdGluZy92aXNpYmxlLXJlY3QvYW5pbWF0ZWQtZnJvbS1ub25l Lmh0bWw6CisKIDIwMTktMDQtMDggIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNv bT4KIAogICAgICAgICBBWDogQXV0b21hdGljYWxseSBjb21wdXRlIGFjY2Vzc2liaWxpdHkgbGFi ZWxzIGZvciBBcHBsZSBQYXkgYnV0dG9ucwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvdmlzaWJsZS1yZWN0L2FuaW1hdGVkLWZyb20tbm9uZS5odG1sIGIvTGF5b3V0VGVzdHMv Y29tcG9zaXRpbmcvdmlzaWJsZS1yZWN0L2FuaW1hdGVkLWZyb20tbm9uZS5odG1sCmluZGV4IDQ2 NGVjMGM4ZjcxNjZlNzY2OGQ3OGNlMzUwOWNkZGZiMzVjZGJiY2UuLmY2MWUxOWM3Mjk4MTdlMWRm YTU4YzA5MjM4YzkyYTJmYzE0ZjgxY2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NvbXBvc2l0 aW5nL3Zpc2libGUtcmVjdC9hbmltYXRlZC1mcm9tLW5vbmUuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9jb21wb3NpdGluZy92aXNpYmxlLXJlY3QvYW5pbWF0ZWQtZnJvbS1ub25lLmh0bWwKQEAgLTM0 LDE2ICszNCwxNSBAQAogCiAgICAgICAgIGZ1bmN0aW9uIGRvVGVzdCgpCiAgICAgICAgIHsKLSAg ICAgICAgICAgIGxldCBhbmltYXRlZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhbmltYXRl ZCcpOwotICAgICAgICAgICAgYW5pbWF0ZWQuYWRkRXZlbnRMaXN0ZW5lcignd2Via2l0QW5pbWF0 aW9uU3RhcnQnLCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGNvbnN0IGFuaW1hdGVkID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2FuaW1hdGVkJyk7CisgICAgICAgICAgICBhbmltYXRlZC5j bGFzc0xpc3QuYWRkKCdhbmltYXRpbmcnKTsKKyAgICAgICAgICAgIGFuaW1hdGVkLmdldEFuaW1h dGlvbnMoKVswXS5yZWFkeS50aGVuKCgpID0+IHsKICAgICAgICAgICAgICAgICBpZiAod2luZG93 LmludGVybmFscykKICAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2xheWVycycpLmlubmVyVGV4dCA9IGludGVybmFscy5sYXllclRyZWVBc1RleHQoZG9jdW1lbnQs IGludGVybmFscy5MQVlFUl9UUkVFX0lOQ0xVREVTX1ZJU0lCTEVfUkVDVFMpCiAKICAgICAgICAg ICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgICAgICAgICAgICAgIHRlc3RS dW5uZXIubm90aWZ5RG9uZSgpOwotICAgICAgICAgICAgfSwgZmFsc2UpOwotICAgICAgICAgICAg Ci0gICAgICAgICAgICBhbmltYXRlZC5jbGFzc0xpc3QuYWRkKCdhbmltYXRpbmcnKTsKKyAgICAg ICAgICAgIH0pOwogICAgICAgICB9CiAgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCds b2FkJywgZG9UZXN0LCBmYWxzZSk7CiAgICAgPC9zY3JpcHQ+Cg==