194734 2019-02-15 17:54:22 -0800 https://device.login.microsoftonline.com is hanging on STP75 2019-02-18 11:15:43 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson commit-queue ggaren jiewen_tan krollin webkit-bug-importer oldest_to_newest 1506910 0 youennf 2019-02-15 17:54:22 -0800 https://device.login.microsoftonline.com is hanging on STP75 1506911 1 youennf 2019-02-15 17:54:40 -0800 <rdar://problem/47573830> 1506912 2 362195 youennf 2019-02-15 17:58:49 -0800 Created attachment 362195 Patch 1506917 3 362195 jiewen_tan 2019-02-15 18:14:49 -0800 Comment on attachment 362195 Patch LGTM. r=me. Could you verify that you can reproduce the bug in tlstestwebkit.org by not having the client certificate and clicking the mandatory client certificate link? 1506935 4 ggaren 2019-02-15 20:05:46 -0800 Jiewen, can you suggest a way to test this code path in an automated way? 1506946 5 youennf 2019-02-15 20:39:54 -0800 (In reply to Jiewen Tan from comment #3) > Comment on attachment 362195 [details] > Patch > > LGTM. r=me. Could you verify that you can reproduce the bug in > tlstestwebkit.org by not having the client certificate and clicking the > mandatory client certificate link? I cannot load tlstestwebkit.org right now and might not be able to test it soon. It would be nice if you could validate it. I'll put the patch in cq? (In reply to Geoffrey Garen from comment #4) > Jiewen, can you suggest a way to test this code path in an automated way? I wonder whether WPT server has some support for scripting connection setup. If not, it might be interesting to file an issue on GitHub. 1506984 6 jiewen_tan 2019-02-15 23:57:20 -0800 (In reply to Geoffrey Garen from comment #4) > Jiewen, can you suggest a way to test this code path in an automated way? I don't think there is any at this moment. The hardest part here is to config the server to request a client certificate. 1507022 7 ggaren 2019-02-16 09:11:57 -0800 > I don't think there is any at this moment. The hardest part here is to > config the server to request a client certificate. We have run-webkit-httpd, and it can run arbitrary cgi scripts. Can we use that mechanism to request a client certificate? 1507192 8 362195 commit-queue 2019-02-17 22:49:07 -0800 Comment on attachment 362195 Patch Clearing flags on attachment: 362195 Committed r241658: <https://trac.webkit.org/changeset/241658> 1507193 9 commit-queue 2019-02-17 22:49:09 -0800 All reviewed patches have been landed. Closing bug. 1507328 10 jiewen_tan 2019-02-18 11:15:43 -0800 (In reply to Geoffrey Garen from comment #7) > > I don't think there is any at this moment. The hardest part here is to > > config the server to request a client certificate. > > We have run-webkit-httpd, and it can run arbitrary cgi scripts. Can we use > that mechanism to request a client certificate? Thanks Geoff for your input. I will address it in <rdar://problem/35927938>. 362195 2019-02-15 17:58:49 -0800 2019-02-17 22:49:07 -0800 Patch bug-194734-20190215175848.patch text/plain 3976 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4OTlmY2Y2M2RkOTc4NzMw ZDQ2ODgzMWFlNDJmMzM3ODI5MTYzNDEuLjQ1NjQxNmYyMzhhNDBlZTViODViMDIxZTk2ODQzYTUx MWMzMDlmZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDItMTUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vZGV2aWNlLmxvZ2lu Lm1pY3Jvc29mdG9ubGluZS5jb20gaXMgaGFuZ2luZyBvbiBTVFA3NQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0NzM0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80NzU3MzgzMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBNYWtlIHN1cmUgdG8gb25seSBnbyB0aGUgWFBDIHJvdXRlIGlmIFNlY0tleVBy b3h5U3RvcmUgaGFzIGNyZWRlbnRpYWxzLgorICAgICAgICBUZXN0ZWQgbWFudWFsbHkgYnkgZ29p bmcgdG8gdGhlIGFib3ZlIHdlYnNpdGUgd2l0aCBhbmQgd2l0aG91dCB0aGUgcGF0Y2guCisgICAg ICAgIExvYWQgaGFuZ3Mgd2l0aG91dCB0aGUgcGF0Y2ggYW5kIGNvbXBsZXRlcyB3aXRoIHRoZSBw YXRjaC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdGlv bkNoYWxsZW5nZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6QXV0aGVudGljYXRpb25DaGFs bGVuZ2VQcm94eTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eSk6CisgICAgICAgICogVUlQ cm9jZXNzL0F1dGhlbnRpY2F0aW9uL2NvY29hL1NlY0tleVByb3h5U3RvcmUuaDoKKyAgICAgICAg KiBVSVByb2Nlc3MvQXV0aGVudGljYXRpb24vY29jb2EvU2VjS2V5UHJveHlTdG9yZS5tbToKKyAg ICAgICAgKFdlYktpdDo6U2VjS2V5UHJveHlTdG9yZTo6aW5pdGlhbGl6ZSk6CisKIDIwMTktMDIt MTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgc2Vy dmljZSB3b3JrZXIgcmVzcG9uc2UgdmFsaWRhdGlvbiBmcm9tIHRoZSBzZXJ2aWNlIHdvcmtlciBj bGllbnQgdG8gdGhlIHNlcnZpY2Ugd29ya2VyIGl0c2VsZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94 eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRoZW50aWNhdGlvbi9BdXRoZW50aWNh dGlvbkNoYWxsZW5nZVByb3h5LmNwcAppbmRleCA4ZjNiNTVkMGViZjE5ZGMwYTVmN2U3YzU1ZWFj Mjc5ODBiODM2ZjM3Li5kOWM0MTczM2EyODEyNTg5MjY5YzZkNWJkNDg2ODI4YWYxMmVjNzQyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRoZW50aWNhdGlvbi9BdXRoZW50 aWNhdGlvbkNoYWxsZW5nZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B dXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5LmNwcApAQCAtNDcsOCAr NDcsNyBAQCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5OjpBdXRoZW50aWNhdGlvbkNoYWxs ZW5nZVByb3h5KFdlYkNvcmU6OkF1dGhlbnRpY2F0aQogICAgIDogbV9jb3JlQXV0aGVudGljYXRp b25DaGFsbGVuZ2UoV1RGTW92ZShhdXRoZW50aWNhdGlvbkNoYWxsZW5nZSkpCiAgICAgLCBtX2xp c3RlbmVyKEF1dGhlbnRpY2F0aW9uRGVjaXNpb25MaXN0ZW5lcjo6Y3JlYXRlKFtjaGFsbGVuZ2VJ RCwgY29ubmVjdGlvbiA9IFdURk1vdmUoY29ubmVjdGlvbiksIHNlY0tleVByb3h5U3RvcmUgPSBX VEZNb3ZlKHNlY0tleVByb3h5U3RvcmUpXShBdXRoZW50aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0 aW9uIGRpc3Bvc2l0aW9uLCBjb25zdCBXZWJDb3JlOjpDcmVkZW50aWFsJiBjcmVkZW50aWFsKSB7 CiAjaWYgSEFWRShTRUNfS0VZX1BST1hZKQotICAgICAgICBpZiAoc2VjS2V5UHJveHlTdG9yZSkg ewotICAgICAgICAgICAgc2VjS2V5UHJveHlTdG9yZS0+aW5pdGlhbGl6ZShjcmVkZW50aWFsKTsK KyAgICAgICAgaWYgKHNlY0tleVByb3h5U3RvcmUgJiYgc2VjS2V5UHJveHlTdG9yZS0+aW5pdGlh bGl6ZShjcmVkZW50aWFsKSkgewogICAgICAgICAgICAgc2VuZENsaWVudENlcnRpZmljYXRlQ3Jl ZGVudGlhbE92ZXJYcGMoY29ubmVjdGlvbiwgKnNlY0tleVByb3h5U3RvcmUsIGNoYWxsZW5nZUlE LCBjcmVkZW50aWFsKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vY29jb2EvU2VjS2V5UHJv eHlTdG9yZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vY29jb2Ev U2VjS2V5UHJveHlTdG9yZS5oCmluZGV4IDI5ZDM4YTE3NWZmZTRlYzUzNTU4YmJiM2VjYWU4ZTYz Y2ZjNjUxMzUuLmJlYzc1Y2YzMDcwMWJhOGVjMmRlMTE4NmRjZTU4MmNjMzIwMzQ3ZDYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dGhlbnRpY2F0aW9uL2NvY29hL1NlY0tl eVByb3h5U3RvcmUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BdXRoZW50aWNhdGlv bi9jb2NvYS9TZWNLZXlQcm94eVN0b3JlLmgKQEAgLTQzLDcgKzQzLDcgQEAgY2xhc3MgU2VjS2V5 UHJveHlTdG9yZSA6IHB1YmxpYyBSZWZDb3VudGVkPFNlY0tleVByb3h5U3RvcmU+IHsKIHB1Ymxp YzoKICAgICBzdGF0aWMgUmVmPFNlY0tleVByb3h5U3RvcmU+IGNyZWF0ZSgpIHsgcmV0dXJuIGFk b3B0UmVmKCogbmV3IFNlY0tleVByb3h5U3RvcmUoKSk7IH0KIAotICAgIHZvaWQgaW5pdGlhbGl6 ZShjb25zdCBXZWJDb3JlOjpDcmVkZW50aWFsJik7CisgICAgYm9vbCBpbml0aWFsaXplKGNvbnN0 IFdlYkNvcmU6OkNyZWRlbnRpYWwmKTsKICAgICBib29sIGlzSW5pdGlhbGl6ZWQoKSBjb25zdCB7 IHJldHVybiAhIW1fc2VjS2V5UHJveHk7IH0KIAogICAgIGF1dG8qIGdldCgpIGNvbnN0IHsgcmV0 dXJuIG1fc2VjS2V5UHJveHkuZ2V0KCk7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0F1dGhlbnRpY2F0aW9uL2NvY29hL1NlY0tleVByb3h5U3RvcmUubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BdXRoZW50aWNhdGlvbi9jb2NvYS9TZWNLZXlQcm94eVN0b3JlLm1t CmluZGV4IDA5MGQ1MjEyYWRiMWNkYTgwMmZlMWVjMmU2NDEzMjMzNjI5NjIxZmQuLjFjNzViZDQy NWVlYjI4MjY5MzY5YmUwNDhiNTg0ZTM5ZDUzYTJmOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0F1dGhlbnRpY2F0aW9uL2NvY29hL1NlY0tleVByb3h5U3RvcmUubW0KKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vY29jb2EvU2VjS2V5UHJv eHlTdG9yZS5tbQpAQCAtMzMsMTAgKzMzLDExIEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi12 b2lkIFNlY0tleVByb3h5U3RvcmU6OmluaXRpYWxpemUoY29uc3QgV2ViQ29yZTo6Q3JlZGVudGlh bCYgY3JlZGVudGlhbCkKK2Jvb2wgU2VjS2V5UHJveHlTdG9yZTo6aW5pdGlhbGl6ZShjb25zdCBX ZWJDb3JlOjpDcmVkZW50aWFsJiBjcmVkZW50aWFsKQogewogICAgIGlmICghY3JlZGVudGlhbC5p c0VtcHR5KCkgJiYgY3JlZGVudGlhbC5uc0NyZWRlbnRpYWwoKS5pZGVudGl0eSkKICAgICAgICAg bV9zZWNLZXlQcm94eSA9IGFkb3B0TlMoW1tTZWNLZXlQcm94eSBhbGxvY10gaW5pdFdpdGhJZGVu dGl0eTpjcmVkZW50aWFsLm5zQ3JlZGVudGlhbCgpLmlkZW50aXR5XSk7CisgICAgcmV0dXJuIGlz SW5pdGlhbGl6ZWQoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==