194732 2019-02-15 16:40:44 -0800 NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics 2019-02-15 20:57:15 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194737 InRadar P2 Normal --- 1 youennf youennf achristensen beidson commit-queue ggaren webkit-bug-importer oldest_to_newest 1506863 0 youennf 2019-02-15 16:40:44 -0800 NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics <rdar://problem/47833813> 1506866 1 362182 youennf 2019-02-15 16:46:25 -0800 Created attachment 362182 Patch 1506867 2 youennf 2019-02-15 16:46:58 -0800 <rdar://problem/47833813> 1506931 3 362182 ggaren 2019-02-15 19:52:02 -0800 Comment on attachment 362182 Patch r=me Can we test this with an API test for TLS certificate check? 1506938 4 youennf 2019-02-15 20:26:43 -0800 > Can we test this with an API test for TLS certificate check? API test probably not since we would need an HTTPS server, which we do no have yet. We might be able to test it as a layout test with: - a testRunner API to not respond to the certificate validation request. - a case where network load is nullified without being cancelled. A navigation load, intercepted by fetch and leading to a fetch redirect mode=manual might do the trick. 1506940 5 youennf 2019-02-15 20:28:58 -0800 (In reply to youenn fablet from comment #4) > > Can we test this with an API test for TLS certificate check? > > API test probably not since we would need an HTTPS server, which we do no > have yet. > We might be able to test it as a layout test with: > - a testRunner API to not respond to the certificate validation request. To delay otherwise, the load will not complete. 1506942 6 youennf 2019-02-15 20:29:57 -0800 Filed https://bugs.webkit.org/show_bug.cgi?id=194737 1506952 7 362182 commit-queue 2019-02-15 20:57:14 -0800 Comment on attachment 362182 Patch Clearing flags on attachment: 362182 Committed r241641: <https://trac.webkit.org/changeset/241641> 1506953 8 commit-queue 2019-02-15 20:57:15 -0800 All reviewed patches have been landed. Closing bug. 362182 2019-02-15 16:46:25 -0800 2019-02-15 20:57:14 -0800 Patch bug-194732-20190215164624.patch text/plain 1862 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4OTlmY2Y2M2RkOTc4NzMw ZDQ2ODgzMWFlNDJmMzM3ODI5MTYzNDEuLmIyYjVmMGQ0MDdkNGQzY2VlNWI0MWQ1MGMxZjhhMWYw YmZlZWFkN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDItMTUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtEYXRhVGFzayBzaG91 bGQgY2hlY2sgaXRzIGNsaWVudCBiZWZvcmUgY2FsbGluZyBzaG91bGRDYXB0dXJlRXh0cmFOZXR3 b3JrTG9hZE1ldHJpY3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NDczMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5ldHdvcmtEYXRhVGFzayBtYXkgYmUga2VwdCBhbGl2ZSBpZiByZWZpbmcgaXQgYWZ0 ZXIgaXRzIE5ldHdvcmtMb2FkIGlzIGdvbmUuCisgICAgICAgIFRoaXMgbWlnaHQgaGFwcGVuIGZv ciBpbnN0YW5jZSBpbiBEb3dubG9hZE1hbmFnZXIgb3Igd2hlbiBjaGVja2luZyBmb3IgVExTIGNl cnRpZmljYXRlcy4KKyAgICAgICAgSW4gdGhhdCBjYXNlLCBpZiB0aGUgTmV0d29ya0xvYWQgZ2V0 cyBkZXN0cm95ZWQsIGl0IGNsZWFycyB0aGUgY2xpZW50IG9mIHRoZSBOZXR3b3JrRGF0YVRhc2su CisgICAgICAgIFRvIGVuc3VyZSB0aGF0IE5ldHdvcmtEYXRhVGFzayBkb2VzIG5vdCB0cnkgdG8g dXNlIGl0cyBjbGllbnQsIGFkZCBhIG51bGwgY2hlY2suCisKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrRGF0YVRhc2suY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRh c2s6OnNob3VsZENhcHR1cmVFeHRyYU5ldHdvcmtMb2FkTWV0cmljcyBjb25zdCk6CisKIDIwMTkt MDItMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUg c2VydmljZSB3b3JrZXIgcmVzcG9uc2UgdmFsaWRhdGlvbiBmcm9tIHRoZSBzZXJ2aWNlIHdvcmtl ciBjbGllbnQgdG8gdGhlIHNlcnZpY2Ugd29ya2VyIGl0c2VsZgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suY3BwIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suY3BwCmluZGV4IGM2OWQ2NTA0MDY0ZGIz NGI0NDVmNzQ2MTc3MTExZjBmN2VmNmVkYWMuLjNlNWFkYWYxMWI5Y2Q3N2I5NjA3ZjgzOWZmMDky MjhjY2YwZTY3OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0 d29ya0RhdGFUYXNrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdv cmtEYXRhVGFzay5jcHAKQEAgLTExNCw3ICsxMTQsNyBAQCB2b2lkIE5ldHdvcmtEYXRhVGFzazo6 ZGlkUmVjZWl2ZVJlc3BvbnNlKFJlc291cmNlUmVzcG9uc2UmJiByZXNwb25zZSwgUmVzcG9uc2VD bwogCiBib29sIE5ldHdvcmtEYXRhVGFzazo6c2hvdWxkQ2FwdHVyZUV4dHJhTmV0d29ya0xvYWRN ZXRyaWNzKCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9jbGllbnQtPnNob3VsZENhcHR1cmVFeHRy YU5ldHdvcmtMb2FkTWV0cmljcygpOworICAgIHJldHVybiBtX2NsaWVudCA/IG1fY2xpZW50LT5z aG91bGRDYXB0dXJlRXh0cmFOZXR3b3JrTG9hZE1ldHJpY3MoKSA6IGZhbHNlOwogfQogCiB2b2lk IE5ldHdvcmtEYXRhVGFzazo6ZmFpbHVyZVRpbWVyRmlyZWQoKQo=