194687 2019-02-14 18:24:30 -0800 Web Inspector: Canvas: recordings with a single frame sometimes missing TreeElement 2019-02-21 14:11:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194721 InRadar P2 Normal --- 175485 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1506453 0 hi 2019-02-14 18:24:30 -0800 # STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com/demo/WebKit/canvas.html> 2. open the Canvas tab 3. start a single-frame recording of the 2D canvas 4. click the button with "8" 5. once the recording loads, select the "Frame 1" tree element 6. start a single-frame recording of the 2D canvas 7. click the button with "9" => there is no "Frame 1" tree element, even though the visual action scrubber says there are at least 2 visual actions 1506454 1 hi 2019-02-14 18:29:11 -0800 AFAICT, it looks like the issue has to do with `Object.prototype.soon`. Here's the stream of calls: 1. `appendChild` for "Initial State" 2. `soon` `updateVirtualizedElements` for the recording actions `TreeOutline` 3. the timeout from (2) fires, which actually adds the `TreeElement` from (1) to the DOM 4. `appendChild` for "Frame 1" 5. `soon` `updateVirtualizedElements` for the recording actions `TreeOutline` => the timeout from (5) never seems to fire 1506462 2 hi 2019-02-14 18:41:02 -0800 (In reply to Devin Rousso from comment #0) > 5. once the recording loads, select the "Frame 1" tree element Interestingly, the issue only reproduces when any `TreeElement` other than the first one is selected. Additionally, the first recording (3) can be multi-frame, but the second recording (6) has to be single-frame. 1506469 3 362092 hi 2019-02-14 19:24:19 -0800 Created attachment 362092 Patch 1508592 4 362092 joepeck 2019-02-21 11:30:44 -0800 Comment on attachment 362092 Patch r=me 1508599 5 362092 commit-queue 2019-02-21 11:59:06 -0800 Comment on attachment 362092 Patch Clearing flags on attachment: 362092 Committed r241875: <https://trac.webkit.org/changeset/241875> 1508600 6 commit-queue 2019-02-21 11:59:08 -0800 All reviewed patches have been landed. Closing bug. 1508661 7 webkit-bug-importer 2019-02-21 14:11:25 -0800 <rdar://problem/48289926> 362092 2019-02-14 19:24:19 -0800 2019-02-21 11:59:06 -0800 Patch bug-194687-20190214192419.patch text/plain 3901 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI4M2IxZWMyYzJhYzRhMDZlOTE2ZjllYzQwZmRh YjI5N2M4MjZmYTguLjNkZTc1NDlkMDE2YWU2NzI1NWY1MGYzYThlZTI4ZDhmYjdiZTE0ZDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTAyLTE0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IHJlY29yZGluZ3Mgd2l0aCBhIHNpbmdsZSBmcmFtZSBzb21ldGltZXMgbWlzc2luZyBU cmVlRWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk0Njg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAg KFdJLkNhbnZhc1NpZGViYXJQYW5lbCk6CisgICAgICAgIFdhaXQgdW50aWwgdGhlIGVudGlyZSBg UmVjb3JkaW5nYCBoYXMgYmVlbiBwcm9jZXNzZWQgYmVmb3JlIHNldHRpbmcgdGhlIHNlbGVjdGVk IGFjdGlvbi4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJhclBh bmVsLmNzczoKKyAgICAgICAgKC5zaWRlYmFyID4gLnBhbmVsLm5hdmlnYXRpb24uY2FudmFzLmhh cy1yZWNvcmRpbmdzID4gLmNvbnRlbnQgPiAucmVjb3JkaW5nLWNvbnRlbnQpOgorICAgICAgICBE cml2ZS1ieTogZW5zdXJlIHRoYXQgdGhlIHJlY29yZGluZyBgVHJlZU91dGxpbmVgIGNvbnRhaW5l ciBlbGVtZW50IGhhcyB0aGUgZnVsbCBoZWlnaHQgdG8KKyAgICAgICAgdGFrZSBhZHZhbnRhZ2Ug b2YgZm9yIHZpcnR1YWxpemF0aW9uLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9S ZWNvcmRpbmdTdGF0ZURldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXSS5SZWNvcmRp bmdTdGF0ZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLnNldCByZWNvcmRpbmcpOgorICAg ICAgICBEcml2ZS1ieTogY2xlYXIgdGhlIGBEYXRhR3JpZGAgbGlzdCB3aGVuIGNoYW5naW5nIHJl Y29yZGluZ3Mgc2luY2Ugd2UgcmVtb3ZlZCBhbGwgc3Vidmlld3MuCisKIDIwMTktMDItMTQgIENv bW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIyNDE0OTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuY3NzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzU2lkZWJhclBhbmVsLmNzcwpp bmRleCBlNmMxMzc2NzM3ODlhNGI4OTJiMmNhNjZiODA4YWZiZjFlOTQyZWIzLi5lMzBkYTAzMzE4 MGVhMGQyNjRlZWMwZWRhY2YwNzY4MzVkNjBkNjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuY3NzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc1NpZGViYXJQ YW5lbC5jc3MKQEAgLTQ4LDYgKzQ4LDcgQEAKIH0KIAogLnNpZGViYXIgPiAucGFuZWwubmF2aWdh dGlvbi5jYW52YXMuaGFzLXJlY29yZGluZ3MgPiAuY29udGVudCA+IC5yZWNvcmRpbmctY29udGVu dCB7CisgICAgZmxleC1ncm93OiAxOwogICAgIG92ZXJmbG93LXk6IHNjcm9sbDsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFz U2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ2FudmFzU2lkZWJhclBhbmVsLmpzCmluZGV4IGI1Y2MzNTIyMTUxZjYzMzBhODY0YjAzNjg0 MDYyMGNhOWIxODJjZDUuLjI4YzRhMzM2NzNmNDYwYjZhODczYzM4ODE4MjE2ODM1ZDA3N2YxOTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nh bnZhc1NpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9DYW52YXNTaWRlYmFyUGFuZWwuanMKQEAgLTU3OCw4ICs1NzgsOCBAQCBXSS5D YW52YXNTaWRlYmFyUGFuZWwgPSBjbGFzcyBDYW52YXNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5O YXZpZ2F0aW9uU2lkZWJhclBhbgogICAgICAgICBjb25zb2xlLmFzc2VydChpc0luaXRpYWxTdGF0 ZUFjdGlvbiB8fCB0aGlzLl9yZWNvcmRpbmdUcmVlT3V0bGluZS5jaGlsZHJlbi5sYXN0VmFsdWUg aW5zdGFuY2VvZiBXSS5Gb2xkZXJUcmVlRWxlbWVudCwgIlRoZXJlIHNob3VsZCBiZSBhIFdJLkZv bGRlclRyZWVFbGVtZW50IGZvciB0aGUgZnJhbWUgZm9yIHRoaXMgYWN0aW9uLiIpOwogICAgICAg ICB0aGlzLl9jcmVhdGVSZWNvcmRpbmdBY3Rpb25UcmVlRWxlbWVudChhY3Rpb24sIGluZGV4LCBp c0luaXRpYWxTdGF0ZUFjdGlvbiA/IHRoaXMuX3JlY29yZGluZ1RyZWVPdXRsaW5lIDogdGhpcy5f cmVjb3JkaW5nVHJlZU91dGxpbmUuY2hpbGRyZW4ubGFzdFZhbHVlKTsKIAotICAgICAgICBpZiAo aXNJbml0aWFsU3RhdGVBY3Rpb24gJiYgIXRoaXMuX3JlY29yZGluZ1tXSS5DYW52YXNTaWRlYmFy UGFuZWwuU2VsZWN0ZWRBY3Rpb25TeW1ib2xdKQotICAgICAgICAgICAgdGhpcy5hY3Rpb24gPSBh Y3Rpb247CisgICAgICAgIGlmICh0aGlzLl9yZWNvcmRpbmcucmVhZHkgJiYgIXRoaXMuX3JlY29y ZGluZ1tXSS5DYW52YXNTaWRlYmFyUGFuZWwuU2VsZWN0ZWRBY3Rpb25TeW1ib2xdKQorICAgICAg ICAgICAgdGhpcy5hY3Rpb24gPSB0aGlzLl9yZWNvcmRpbmcuYWN0aW9uc1swXTsKIAogICAgICAg ICBpZiAoYWN0aW9uID09PSB0aGlzLl9yZWNvcmRpbmcuYWN0aW9ucy5sYXN0VmFsdWUgJiYgdGhp cy5fcmVjb3JkaW5nUHJvY2Vzc2luZ09wdGlvbnNDb250YWluZXIpIHsKICAgICAgICAgICAgIHRo aXMuX3JlY29yZGluZ1Byb2Nlc3NpbmdPcHRpb25zQ29udGFpbmVyLnJlbW92ZSgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVjb3JkaW5n U3RhdGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nU3RhdGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzCmluZGV4 IDFmNmQzNmIyYmE0MGJhODIxN2RiZjNjZjllYzVlYmUyZmYzMTM0OGMuLjg5ZGEzZThmNjJiOTY2 M2ZiMDY2ZTE3YjJmMzEwNDA3NjkyZGNmZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ1N0YXRlRGV0YWlsc1NpZGViYXJQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNv cmRpbmdTdGF0ZURldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTU4LDYgKzU4LDggQEAgV0kuUmVj b3JkaW5nU3RhdGVEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgUmVjb3JkaW5nU3RhdGVEZXRh aWxzU2lkZWJhclBhbmVsIGUKIAogICAgICAgICBmb3IgKGxldCBzdWJ2aWV3IG9mIHRoaXMuY29u dGVudFZpZXcuc3Vidmlld3MpCiAgICAgICAgICAgICB0aGlzLmNvbnRlbnRWaWV3LnJlbW92ZVN1 YnZpZXcoc3Vidmlldyk7CisKKyAgICAgICAgdGhpcy5fZGF0YUdyaWRzID0gW107CiAgICAgfQog CiAgICAgc2V0IGFjdGlvbihhY3Rpb24pCg==