194597 2019-02-13 10:43:24 -0800 [ews-app] status bubble should be hidden for certain builds 2019-03-13 04:28:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1505764 0 aakash_jain 2019-02-13 10:43:24 -0800 While generating status bubbles (in ews-app) certain build should not generate status bubble. e.g.: builds which were skipped because patch was not relevant to that queue (e.g: non-webkitpy change skipping webkitpy ews queue). 1515792 1 364484 aakash_jain 2019-03-12 17:42:43 -0700 Created attachment 364484 Proposed patch 1515907 2 364484 dewei_zhu 2019-03-13 00:10:39 -0700 Comment on attachment 364484 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=364484&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:88 > + if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string): Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think? 1515929 3 aakash_jain 2019-03-13 04:26:27 -0700 > Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think? Agree. Since these values are already referenced in multiple places in this file, making that change in a separate patch in https://bugs.webkit.org/show_bug.cgi?id=195668 1515930 4 aakash_jain 2019-03-13 04:27:54 -0700 Committed r242880: <https://trac.webkit.org/changeset/242880> 1515931 5 webkit-bug-importer 2019-03-13 04:28:19 -0700 <rdar://problem/48843642> 364484 2019-03-12 17:42:43 -0700 2019-03-13 00:10:39 -0700 Proposed patch status-bubble-hide.patch text/plain 2802 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MjgzNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTAzLTEyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gc3RhdHVzIGJ1YmJsZSBzaG91bGQgYmUgaGlkZGVuIGZv ciBjZXJ0YWluIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk0NTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJi bGUucHk6CisgICAgICAgIChTdGF0dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6CisgICAgICAgIChT dGF0dXNCdWJibGUuX3Nob3VsZF9zaG93X2J1YmJsZV9mb3JfYnVpbGQpOiBIaWRlIGJ1YmJsZSBm b3IgYnVpbGRzIHdoaWNoIHdlcmUgc2tpcHBlZAorICAgICAgICBiZWNhdXNlIHRoZSBwYXRjaCBk aWRuJ3QgaGF2ZSByZWxldmFudCBjaGFuZ2VzLgorICAgICAgICAoU3RhdHVzQnViYmxlLl9zaG91 bGRfc2hvd19idWJibGVfZm9yX3F1ZXVlKTogSGlkZSBidWJibGVzIGZvciBxdWV1ZXMgd2hpY2gg YXJlIG5vdCBkZXBsb3llZAorICAgICAgICBpbiBwcm9kdWN0aW9uIHlldC4KKwogMjAxOS0wMy0x MiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0MjgyNS4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHJl dmlzaW9uIDI0MjgzNSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3Zp ZXdzL3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMjIsNiArMjIsOCBAQAogCiBm cm9tIF9fZnV0dXJlX18gaW1wb3J0IHVuaWNvZGVfbGl0ZXJhbHMKIAoraW1wb3J0IHJlCisKIGZy b20gZGphbmdvLmh0dHAgaW1wb3J0IEh0dHBSZXNwb25zZQogZnJvbSBkamFuZ28uc2hvcnRjdXRz IGltcG9ydCByZW5kZXIKIGZyb20gZGphbmdvLnZpZXdzIGltcG9ydCBWaWV3CkBAIC00Miw2ICs0 NCw5IEBAIGNsYXNzIFN0YXR1c0J1YmJsZShWaWV3KToKICAgICAgICAgICAgICJuYW1lIjogcXVl dWUsCiAgICAgICAgIH0KICAgICAgICAgYnVpbGQgPSBzZWxmLmdldF9sYXRlc3RfYnVpbGRfZm9y X3F1ZXVlKHBhdGNoLCBxdWV1ZSkKKyAgICAgICAgaWYgbm90IHNlbGYuX3Nob3VsZF9zaG93X2J1 YmJsZV9mb3JfYnVpbGQoYnVpbGQpOgorICAgICAgICAgICAgcmV0dXJuIE5vbmUKKwogICAgICAg ICBpZiBub3QgYnVpbGQ6CiAgICAgICAgICAgICBidWJibGVbInN0YXRlIl0gPSAibm9uZSIKICAg ICAgICAgICAgIGJ1YmJsZVsiZGV0YWlsc19tZXNzYWdlIl0gPSAnV2FpdGluZyBpbiBxdWV1ZSwg cHJvY2Vzc2luZyBoYXMgbm90IHN0YXJ0ZWQgeWV0LicKQEAgLTc5LDggKzg0LDEyIEBAIGNsYXNz IFN0YXR1c0J1YmJsZShWaWV3KToKICAgICBkZWYgZ2V0X2J1aWxkc19mb3JfcXVldWUoc2VsZiwg cGF0Y2gsIHF1ZXVlKToKICAgICAgICAgcmV0dXJuIFtidWlsZCBmb3IgYnVpbGQgaW4gcGF0Y2gu YnVpbGRfc2V0LmFsbCgpIGlmIGJ1aWxkLmJ1aWxkZXJfZGlzcGxheV9uYW1lID09IHF1ZXVlXQog Ci0gICAgZGVmIF9zaG91bGRfc2hvd19idWJibGVfZm9yKHNlbGYsIHBhdGNoLCBxdWV1ZSk6Ci0g ICAgICAgICMgVE9ETzogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 NDU5NworICAgIGRlZiBfc2hvdWxkX3Nob3dfYnViYmxlX2Zvcl9idWlsZChzZWxmLCBidWlsZCk6 CisgICAgICAgIGlmIGJ1aWxkIGFuZCBidWlsZC5yZXN1bHQgPT0gMyBhbmQgcmUuc2VhcmNoKHIn UGF0Y2ggLiogZG9lc25cJ3QgaGF2ZSByZWxldmFudCBjaGFuZ2VzJywgYnVpbGQuc3RhdGVfc3Ry aW5nKToKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQorICAgICAgICByZXR1cm4gVHJ1ZQorCisg ICAgZGVmIF9zaG91bGRfc2hvd19idWJibGVfZm9yX3F1ZXVlKHNlbGYsIHF1ZXVlKToKICAgICAg ICAgcmV0dXJuIHF1ZXVlIGluIFN0YXR1c0J1YmJsZS5FTkFCTEVEX1FVRVVFUwogCiAgICAgZGVm IF9idWlsZF9idWJibGVzX2Zvcl9wYXRjaChzZWxmLCBwYXRjaCk6CkBAIC05Miw3ICsxMDEsNyBA QCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgICAgICByZXR1cm4gKE5vbmUsIHNo b3dfc3VibWl0X3RvX2V3cywgZmFpbGVkX3RvX2FwcGx5KQogCiAgICAgICAgIGZvciBxdWV1ZSBp biBTdGF0dXNCdWJibGUuQUxMX1FVRVVFUzoKLSAgICAgICAgICAgIGlmIG5vdCBzZWxmLl9zaG91 bGRfc2hvd19idWJibGVfZm9yKHBhdGNoLCBxdWV1ZSk6CisgICAgICAgICAgICBpZiBub3Qgc2Vs Zi5fc2hvdWxkX3Nob3dfYnViYmxlX2Zvcl9xdWV1ZShxdWV1ZSk6CiAgICAgICAgICAgICAgICAg Y29udGludWUKIAogICAgICAgICAgICAgYnViYmxlID0gc2VsZi5fYnVpbGRfYnViYmxlKHBhdGNo LCBxdWV1ZSkK