194587 2019-02-13 00:24:42 -0800 [GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExpectations 2019-02-20 05:50:03 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified CLOSED FIXED InRadar P2 Normal --- 194586 1 fujii fujii csaavedra lforschler webkit-bug-importer oldest_to_newest 1505642 0 fujii 2019-02-13 00:24:42 -0800 [GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExpectations This is a sub task of Bug 194586. I'd like to eliminate DumpJSConsoleLogInStdErr expectation in platform TestExpectations in order to use dumpJSConsoleLogInStdErr=true webkit-test-runner option. > <!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] --> 1505654 1 csaavedra 2019-02-13 00:45:29 -0800 I see that your patch in bug 194283 already takes care of this. What else is needed? 1505662 2 fujii 2019-02-13 01:06:33 -0800 (In reply to Claudio Saavedra from comment #1) > I see that your patch in bug 194283 already takes care of this. What else is > needed? DumpJSConsoleLogInStdErr expectation is considered a bad idea by some devs. And, we have dumpJSConsoleLogInStdErr test option now (Bug 177027). So, I'd like to remove DumpJSConsoleLogInStdErr expectation and use dumpJSConsoleLogInStdErr test option instead. (In reply to Jonathan Bedard from bug #194283 comment #3) > This bug very much confuses me. Why would we have a test expectation with > DumpJSConsoleLogInStdErr in it? That feels like an abuse of the > TestExpectations. (In reply to Alexey Proskuryakov from bug #194283 comment #2) > I think that we are hitting a design mistake with regards to > DumpJSConsoleLogInStdErr - it is not an expectation, so mixing it with > expectations causes trouble. (In reply to youenn fablet from bug #161310 comment #4) > It seems a bit odd to add that keyword to TestExpectations since it is > becoming more like a setup option. This applies also a bit to Slow keyword. 1505665 3 361904 fujii 2019-02-13 01:09:22 -0800 Created attachment 361904 Patch 1505668 4 fujii 2019-02-13 01:30:01 -0800 I confirmed this change doesn't affect the output of following commands. I believe this patch changes nothing. ./Tools/Scripts/webkit-patch print-expectations --port=wpe http/tests/appcache ./Tools/Scripts/webkit-patch print-expectations --port=gtk http/tests/appcache 1505676 5 fujii 2019-02-13 02:12:53 -0800 Committed r241430: <https://trac.webkit.org/changeset/241430> 1505677 6 webkit-bug-importer 2019-02-13 02:13:30 -0800 <rdar://problem/48032550> 361904 2019-02-13 01:09:22 -0800 2019-02-20 05:49:49 -0800 Patch bug-194587-20190213180921.patch text/plain 3058 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMzM2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzlkYmZiOWY5YmE2YjY1MDQwMjIy NjgzMDNjZTQ2M2MxNmQ5MTU0NS4uYWUzZTk5MWUyY2RkZTJiZTg4NDM1MTFiNzJjNDQ5YzY3OWVi YzVlOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTEzICBGdWppaSBIaXJvbm9yaSAg PEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gRG9uJ3QgdXNl IER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyciBleHBlY3RhdGlvbiBpbiBwbGF0Zm9ybSBUZXN0RXhw ZWN0YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQ1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOiBSZW1vdmVkIER1bXBKU0NvbnNvbGVM b2dJblN0ZEVyciBtYXJrZXJzIHdoaWNoIGFyZSBtYXJrZWQgaW4gdG9wIFRlc3RFeHBlY3RhdGlv bnMuCisgICAgICAgICogcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnM6IERpdHRvLgorCiAy MDE5LTAyLTEyICBKdXN0aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CiAKICAgICAgICAg W1dlYkdQVV0gUmVtb3ZlIFdlYkdQVUJ1ZmZlckRlc2NyaXB0b3IvVXNhZ2UgYW5kIHVzZSBHUFUg dmVyc2lvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg Yzg1MWM3NTU3YjVlZjlhNDU0Y2Q0NTJhNDIzYzJhMzAyMDI0ODI5OS4uZWIyNWZlZjVlNTZhNjg0 YmEwYzM0YTA0OWZlYWIxNzRmZTQ0Njk3YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMKQEAgLTE4NTksNyArMTg1OSw2IEBAIHdlYmtpdC5vcmcvYi8xNjAxMzMg Y3NzMy9tYXNraW5nL21hc2stc3ZnLW5vLWZyYWdtZW50SWQtdGlsZWQuaHRtbCBbIEltYWdlT25s eUZhCiAKIHdlYmtpdC5vcmcvYi8xNjAxMzUgaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2Vj dXJpdHlQb2xpY3kvdmlkZW8td2l0aC1odHRwLXVybC1hbGxvd2VkLWJ5LWNzcC1tZWRpYS1zcmMt c3Rhci5odG1sIFsgRmFpbHVyZSBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xNjAxMzYgaHR0cC90ZXN0 cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4tcGx1Z2luLXByaXZhdGUtYnJvd3NpbmctdG9nZ2xlZC1h bGxvd2VkLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQotd2Via2l0Lm9yZy9iLzE0MjQ4OCBodHRwL3Rl c3RzL2FwcGNhY2hlLzQwNC1yZXNvdXJjZS13aXRoLXNsb3ctbWFpbi1yZXNvdXJjZS5waHAgWyBE dW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgXQogd2Via2l0Lm9yZy9iLzE2MjY4NSBodHRwL3Rlc3Rz L2NhY2hlL2Rpc2stY2FjaGUvZGlzay1jYWNoZS0yMDQtc3RhdHVzLWNvZGUuaHRtbCBbIEZhaWx1 cmUgUGFzcyBdCiAKIHdlYmtpdC5vcmcvYi8xNjAxMzcgc3ZnL2N1c3RvbS9ub24tc2NhbGluZy1z dHJva2UtdXBkYXRlLnN2ZyBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGI1ZWI3MWQ3NjZkMzk0ZmM1ZjBlZTBh ODYzMDVkZWRkODdiZDQ3YzQuLjc5ZjE1MzUwMjY0ZjhjNzkwN2JkYWEzYjAzZmVlM2I5ZGQ2MjU5 ZGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zCkBAIC03OTYs MTYgKzc5Niw5IEBAIHdlYmtpdC5vcmcvYi8xNDIyOTIgZmFzdC9pbWFnZXMvYW5pbWF0ZWQtZ2lm LXdpbmRvdy1yZXNpemluZy5odG1sIFsgVGltZW91dCBdCiAjIDkuIFRFU1RTIEZBSUxJTkcKICMv Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAKLUJ1ZyhXUEUpIGh0dHAvdGVzdHMvYXBw Y2FjaGUgWyBQYXNzIF0KICMgSW1wbGVtZW50IHRlc3RSdW5uZXIuc2V0VXNlRGVmZXJyZWRGcmFt ZUxvYWRpbmcKIHdlYmtpdC5vcmcvYi85Mzk4MCBodHRwL3Rlc3RzL2FwcGNhY2hlL2xvYWQtZnJv bS1hcHBjYWNoZS1kZWZlci1yZXN1bWUtY3Jhc2guaHRtbCBbIEZhaWx1cmUgXQogCi1odHRwL3Rl c3RzL2FwcGNhY2hlL2RlZmVycmVkLWV2ZW50cy1kZWxldGUtd2hpbGUtcmFpc2luZy10aW1lci5o dG1sIFsgRHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyIF0KLWh0dHAvdGVzdHMvYXBwY2FjaGUvZGVm ZXJyZWQtZXZlbnRzLWRlbGV0ZS13aGlsZS1yYWlzaW5nLmh0bWwgWyBEdW1wSlNDb25zb2xlTG9n SW5TdGRFcnIgXQotaHR0cC90ZXN0cy9hcHBjYWNoZS9mYWlsLW9uLXVwZGF0ZS5odG1sIFsgRHVt cEpTQ29uc29sZUxvZ0luU3RkRXJyIF0KLWh0dHAvdGVzdHMvYXBwY2FjaGUvZmFpbC1vbi11cGRh dGUtMi5odG1sIFsgRHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyIF0KLWh0dHAvdGVzdHMvYXBwY2Fj aGUvNDA0LXJlc291cmNlLXdpdGgtc2xvdy1tYWluLXJlc291cmNlLnBocCBbIER1bXBKU0NvbnNv bGVMb2dJblN0ZEVyciBdCi0KIEJ1ZyhXUEUpIGh0dHAvdGVzdHMvY2FjaGUvIFsgUGFzcyBdCiB3 ZWJraXQub3JnL2IvMTE4MjIwIGh0dHAvdGVzdHMvY2FjaGUvcGFydGl0aW9uZWQtY2FjaGUuaHRt bCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzExODIyMCBodHRwL3Rlc3RzL2NhY2hlL3BhcnRp dGlvbmVkLWNhY2hlLWlmcmFtZS5odG1sIFsgRmFpbHVyZSBdCg==