194570 2019-02-12 17:02:49 -0800 Branch-Specific: Revert ability to set programmatic focus when hardware keyboard is attached 2019-02-14 08:08:45 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190017 1 bfulgham bfulgham bfulgham dbates webkit-bug-importer oldest_to_newest 1505509 0 bfulgham 2019-02-12 17:02:49 -0800 Modifying WebKit to allow programmatic focus when a hardware keyboard is attached doesn't work well enough to ship. We should turn this off in our safari-607-branch. 1505510 1 bfulgham 2019-02-12 17:04:09 -0800 <rdar://problem/47673836> 1505511 2 361870 bfulgham 2019-02-12 17:05:22 -0800 Created attachment 361870 Patch 1505567 3 361870 dbates 2019-02-12 18:24:32 -0800 Comment on attachment 361870 Patch Ensure this doesn’t cause any API test failures. I think we may have some tests. 1506151 4 bfulgham 2019-02-14 08:08:41 -0800 I ran all API tests with and without this patch and had the same results for all tests. Clearing flag because we do not intend to land this in trunk. 361870 2019-02-12 17:05:22 -0800 2019-02-14 08:08:09 -0800 Patch bug-194570-20190212170521.patch text/plain 2300 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDEzMjkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTEyICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFJldmVydCBhYmlsaXR5 IHRvIHNldCBwcm9ncmFtbWF0aWMgZm9jdXMgd2hlbiBoYXJkd2FyZSBrZXlib2FyZCBpcyBhdHRh Y2hlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 NTcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzY3MzgzNj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9lbGVtZW50RGlk Rm9jdXM6dXNlcklzSW50ZXJhY3Rpbmc6Ymx1clByZXZpb3VzTm9kZTpjaGFuZ2luZ0FjdGl2aXR5 U3RhdGU6dXNlck9iamVjdDpdKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnBsYXRmb3JtRWRpdG9yU3Rh dGUgY29uc3QpOgorCiAyMDE5LTAyLTEyICBBbGFuIENvb24gIDxhbGFuY29vbkBhcHBsZS5jb20+ CiAKICAgICAgICAgQXBwbHkgcGF0Y2guIHJkYXI6Ly9wcm9ibGVtLzQ4MDA5OTk1CkluZGV4OiBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDI0MTMyOSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ1NTIs NyArNDU1Miw2IEBAIC0gKHZvaWQpX2VsZW1lbnREaWRGb2N1czooY29uc3QgV2ViS2l0OjoKICAg ICAgICAgICAgIHx8IChfaXNDaGFuZ2luZ0ZvY3VzICYmICFbX2ZvY3VzZWRGb3JtQ29udHJvbFZp ZXcgaXNIaWRkZW5dKQogI2Vsc2UKICAgICAgICAgICAgIHx8IF9pc0NoYW5naW5nRm9jdXMKLSAg ICAgICAgICAgIHx8IFtVSUtleWJvYXJkIGlzSW5IYXJkd2FyZUtleWJvYXJkTW9kZV0KICNlbmRp ZgogI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAgICAgICAgICAgICB8fCBfZHJhZ0Ryb3BJbnRl cmFjdGlvblN0YXRlLmlzUGVyZm9ybWluZ0Ryb3AoKQpJbmRleDogU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlzaW9uIDI0MTMy OSkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0yMDAsOSArMjAwLDYgQEAgdm9pZCBXZWJQYWdlOjpwbGF0Zm9y bUVkaXRvclN0YXRlKEZyYW1lJgogICAgIC8vIGltbWVkaWF0ZWx5IHNvIHRoYXQgdGhlIFVJUHJv Y2VzcyBjYW4gdXBkYXRlIFVJLCBpbmNsdWRpbmcgdGhlIHBvc2l0aW9uIG9mIHRoZSBjYXJldC4K ICAgICBib29sIG5lZWRzTGF5b3V0ID0gIWZyYW1lLnZpZXcoKSB8fCBmcmFtZS52aWV3KCktPm5l ZWRzTGF5b3V0KCk7CiAgICAgYm9vbCByZXF1aXJlc1Bvc3RMYXlvdXREYXRhID0gZnJhbWUuZWRp dG9yKCkuaGFzQ29tcG9zaXRpb24oKTsKLSNpZiAhUExBVEZPUk0oSU9TTUFDKQotICAgIHJlcXVp cmVzUG9zdExheW91dERhdGEgfD0gW1VJS2V5Ym9hcmQgaXNJbkhhcmR3YXJlS2V5Ym9hcmRNb2Rl XTsKLSNlbmRpZgogICAgIGlmIChzaG91bGRJbmNsdWRlUG9zdExheW91dERhdGEgPT0gSW5jbHVk ZVBvc3RMYXlvdXREYXRhSGludDo6Tm8gJiYgbmVlZHNMYXlvdXQgJiYgIXJlcXVpcmVzUG9zdExh eW91dERhdGEpIHsKICAgICAgICAgcmVzdWx0LmlzTWlzc2luZ1Bvc3RMYXlvdXREYXRhID0gdHJ1 ZTsKICAgICAgICAgcmV0dXJuOwo=