194536 2019-02-12 05:32:30 -0800 SourceCode should be copied when generating bytecode for functions 2019-02-13 04:31:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1505205 0 tzagallo 2019-02-12 05:32:30 -0800 ... 1505207 1 361793 tzagallo 2019-02-12 05:43:30 -0800 Created attachment 361793 Patch 1505672 2 saam 2019-02-13 02:04:47 -0800 Please add a fix me pointing to: https://bugs.webkit.org/show_bug.cgi?id=194576 1505674 3 saam 2019-02-13 02:05:20 -0800 *** Bug 194575 has been marked as a duplicate of this bug. *** 1505675 4 saam 2019-02-13 02:07:18 -0800 It would be nice if some of our bytecode cache tests used the code path of creating all functions up front to get better test coverage 1505688 5 361908 tzagallo 2019-02-13 03:26:46 -0800 Created attachment 361908 Patch for landing 1505689 6 361908 commit-queue 2019-02-13 03:29:05 -0800 Comment on attachment 361908 Patch for landing Rejecting attachment 361908 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 361908, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11133542 1505690 7 tzagallo 2019-02-13 03:30:03 -0800 (In reply to Saam Barati from comment #4) > It would be nice if some of our bytecode cache tests used the code path of > creating all functions up front to get better test coverage Yes, I agree. I tried replacing the current bytecode-cache tests with that when I added the API, but it failed on tests that loaded other files dynamically. We should think of other way of doing that. 1505691 8 361909 tzagallo 2019-02-13 03:30:41 -0800 Created attachment 361909 Patch for landing 1505695 9 commit-queue 2019-02-13 04:20:26 -0800 The commit-queue encountered the following flaky tests while processing attachment 361909: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. 1505696 10 361909 commit-queue 2019-02-13 04:21:06 -0800 Comment on attachment 361909 Patch for landing Clearing flags on attachment: 361909 Committed r241431: <https://trac.webkit.org/changeset/241431> 1505697 11 commit-queue 2019-02-13 04:21:08 -0800 All reviewed patches have been landed. Closing bug. 1505700 12 webkit-bug-importer 2019-02-13 04:31:49 -0800 <rdar://problem/48034682> 361793 2019-02-12 05:43:30 -0800 2019-02-13 03:26:42 -0800 Patch bug-194536-20190212144259.patch text/plain 1900 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MDgyNDlmN2YyNzY5OTQ3MzdiZDc4MTdhMTA1ZjA4NTNhMGRkZTM5Li4wYjIxNjZkZWE2ODhhNWMw NTU3ZDA4Y2VmMTllYzcwM2EyOWJjYjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMi0xMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBTb3VyY2VDb2RlIHNob3VsZCBiZSBjb3BpZWQgd2hlbiBnZW5lcmF0aW5n IGJ5dGVjb2RlIGZvciBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDUzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBGdW5jdGlvbkV4ZWN1dGFibGUgbWlnaHQgYmUgY29sbGVjdGVk IHdoaWxlIGdlbmVyYXRpbmcgdGhlIGJ5dGVjb2RlCisgICAgICAgIGZvciBuZXN0ZWQgZnVuY3Rp b25zLCBpbiB3aGljaCBjYXNlIHRoZSBTb3VyY2VDb2RlIHJlZmVyZW5jZSB3b3VsZCBubworICAg ICAgICBsb25nZXIgYmUgdmFsaWQuCisKKyAgICAgICAgKiBydW50aW1lL0NvZGVDYWNoZS5jcHA6 CisgICAgICAgIChKU0M6OmdlbmVyYXRlVW5saW5rZWRDb2RlQmxvY2tGb3JGdW5jdGlvbnMpOgor CiAyMDE5LTAyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBS YW5kb21pemUgaW5zZXJ0aW9uIG9mIGRlYWxsb2NhdGVkIFN0cnVjdHVyZUlEcyBpbnRvIHRoZSBT dHJ1Y3R1cmVJRFRhYmxlJ3MgZnJlZSBsaXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvZGVDYWNoZS5jcHAKaW5kZXggYjQxZTUyNjUxZjNlN2M5ZjZlY2RlMjNmZmI5Njk5Yzg5 ZGI3ODY1Ny4uZWViMDBiZjlhNzMxZmU0MzhmNDMyMmU0ODJiOTU2ZmM1MzFmZjYxYyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCkBAIC0xNzAsNyArMTcw LDcgQEAgdm9pZCBnZW5lcmF0ZVVubGlua2VkQ29kZUJsb2NrRm9yRnVuY3Rpb25zKFZNJiB2bSwg VW5saW5rZWRDb2RlQmxvY2sqIHVubGlua2VkQ28KICAgICAgICAgICAgIHJldHVybjsKIAogICAg ICAgICBGdW5jdGlvbkV4ZWN1dGFibGUqIGV4ZWN1dGFibGUgPSB1bmxpbmtlZEV4ZWN1dGFibGUt Pmxpbmsodm0sIHBhcmVudFNvdXJjZSk7Ci0gICAgICAgIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJj ZSA9IGV4ZWN1dGFibGUtPnNvdXJjZSgpOworICAgICAgICBTb3VyY2VDb2RlIHNvdXJjZSA9IGV4 ZWN1dGFibGUtPnNvdXJjZSgpOwogICAgICAgICBVbmxpbmtlZEZ1bmN0aW9uQ29kZUJsb2NrKiB1 bmxpbmtlZEZ1bmN0aW9uQ29kZUJsb2NrID0gdW5saW5rZWRFeGVjdXRhYmxlLT51bmxpbmtlZENv ZGVCbG9ja0Zvcih2bSwgc291cmNlLCBjb25zdHJ1Y3RvcktpbmQsIGRlYnVnZ2VyTW9kZSwgZXJy b3IsIHVubGlua2VkRXhlY3V0YWJsZS0+cGFyc2VNb2RlKCkpOwogICAgICAgICBpZiAodW5saW5r ZWRGdW5jdGlvbkNvZGVCbG9jaykKICAgICAgICAgICAgIGdlbmVyYXRlVW5saW5rZWRDb2RlQmxv Y2tGb3JGdW5jdGlvbnModm0sIHVubGlua2VkRnVuY3Rpb25Db2RlQmxvY2ssIHNvdXJjZSwgZGVi dWdnZXJNb2RlLCBlcnJvcik7Cg== 361908 2019-02-13 03:26:46 -0800 2019-02-13 03:30:37 -0800 Patch for landing bug-194536-20190213122614.patch text/plain 2055 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MDgyNDlmN2YyNzY5OTQ3MzdiZDc4MTdhMTA1ZjA4NTNhMGRkZTM5Li4wYjIxNjZkZWE2ODhhNWMw NTU3ZDA4Y2VmMTllYzcwM2EyOWJjYjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMi0xMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBTb3VyY2VDb2RlIHNob3VsZCBiZSBjb3BpZWQgd2hlbiBnZW5lcmF0aW5n IGJ5dGVjb2RlIGZvciBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDUzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBGdW5jdGlvbkV4ZWN1dGFibGUgbWlnaHQgYmUgY29sbGVjdGVk IHdoaWxlIGdlbmVyYXRpbmcgdGhlIGJ5dGVjb2RlCisgICAgICAgIGZvciBuZXN0ZWQgZnVuY3Rp b25zLCBpbiB3aGljaCBjYXNlIHRoZSBTb3VyY2VDb2RlIHJlZmVyZW5jZSB3b3VsZCBubworICAg ICAgICBsb25nZXIgYmUgdmFsaWQuCisKKyAgICAgICAgKiBydW50aW1lL0NvZGVDYWNoZS5jcHA6 CisgICAgICAgIChKU0M6OmdlbmVyYXRlVW5saW5rZWRDb2RlQmxvY2tGb3JGdW5jdGlvbnMpOgor CiAyMDE5LTAyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBS YW5kb21pemUgaW5zZXJ0aW9uIG9mIGRlYWxsb2NhdGVkIFN0cnVjdHVyZUlEcyBpbnRvIHRoZSBT dHJ1Y3R1cmVJRFRhYmxlJ3MgZnJlZSBsaXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvZGVDYWNoZS5jcHAKaW5kZXggYjQxZTUyNjUxZjNlN2M5ZjZlY2RlMjNmZmI5Njk5Yzg5 ZGI3ODY1Ny4uOWI2MDcwYmU5M2Y5ODVhNGYyYjRmM2UwZGIxMzU1ZGE3YTExYTNmOCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCkBAIC0xNzAsNyArMTcw LDkgQEAgdm9pZCBnZW5lcmF0ZVVubGlua2VkQ29kZUJsb2NrRm9yRnVuY3Rpb25zKFZNJiB2bSwg VW5saW5rZWRDb2RlQmxvY2sqIHVubGlua2VkQ28KICAgICAgICAgICAgIHJldHVybjsKIAogICAg ICAgICBGdW5jdGlvbkV4ZWN1dGFibGUqIGV4ZWN1dGFibGUgPSB1bmxpbmtlZEV4ZWN1dGFibGUt Pmxpbmsodm0sIHBhcmVudFNvdXJjZSk7Ci0gICAgICAgIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJj ZSA9IGV4ZWN1dGFibGUtPnNvdXJjZSgpOworICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkbid0 IG5lZWQgdG8gY3JlYXRlIGEgRnVuY3Rpb25FeGVjdXRhYmxlIGp1c3QgdG8gZ2V0IGl0cyBzb3Vy Y2UgY29kZQorICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk0NTc2CisgICAgICAgIFNvdXJjZUNvZGUgc291cmNlID0gZXhlY3V0YWJsZS0+c291cmNl KCk7CiAgICAgICAgIFVubGlua2VkRnVuY3Rpb25Db2RlQmxvY2sqIHVubGlua2VkRnVuY3Rpb25D b2RlQmxvY2sgPSB1bmxpbmtlZEV4ZWN1dGFibGUtPnVubGlua2VkQ29kZUJsb2NrRm9yKHZtLCBz b3VyY2UsIGNvbnN0cnVjdG9yS2luZCwgZGVidWdnZXJNb2RlLCBlcnJvciwgdW5saW5rZWRFeGVj dXRhYmxlLT5wYXJzZU1vZGUoKSk7CiAgICAgICAgIGlmICh1bmxpbmtlZEZ1bmN0aW9uQ29kZUJs b2NrKQogICAgICAgICAgICAgZ2VuZXJhdGVVbmxpbmtlZENvZGVCbG9ja0ZvckZ1bmN0aW9ucyh2 bSwgdW5saW5rZWRGdW5jdGlvbkNvZGVCbG9jaywgc291cmNlLCBkZWJ1Z2dlck1vZGUsIGVycm9y KTsK 361909 2019-02-13 03:30:41 -0800 2019-02-13 04:21:06 -0800 Patch for landing bug-194536-20190213123009.patch text/plain 2052 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MDgyNDlmN2YyNzY5OTQ3MzdiZDc4MTdhMTA1ZjA4NTNhMGRkZTM5Li5mNWYzOWQ5M2JmYTBkMmEy MTU4Nzk2Y2JiNDRiOGVlOWUwOTJmMTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMi0xMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBTb3VyY2VDb2RlIHNob3VsZCBiZSBjb3BpZWQgd2hlbiBnZW5lcmF0aW5n IGJ5dGVjb2RlIGZvciBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5NDUzNgorCisgICAgICAgIFJldmlld2VkIGJ5IFNhYW0gQmFyYXRp LgorCisgICAgICAgIFRoZSBGdW5jdGlvbkV4ZWN1dGFibGUgbWlnaHQgYmUgY29sbGVjdGVkIHdo aWxlIGdlbmVyYXRpbmcgdGhlIGJ5dGVjb2RlCisgICAgICAgIGZvciBuZXN0ZWQgZnVuY3Rpb25z LCBpbiB3aGljaCBjYXNlIHRoZSBTb3VyY2VDb2RlIHJlZmVyZW5jZSB3b3VsZCBubworICAgICAg ICBsb25nZXIgYmUgdmFsaWQuCisKKyAgICAgICAgKiBydW50aW1lL0NvZGVDYWNoZS5jcHA6Cisg ICAgICAgIChKU0M6OmdlbmVyYXRlVW5saW5rZWRDb2RlQmxvY2tGb3JGdW5jdGlvbnMpOgorCiAy MDE5LTAyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSYW5k b21pemUgaW5zZXJ0aW9uIG9mIGRlYWxsb2NhdGVkIFN0cnVjdHVyZUlEcyBpbnRvIHRoZSBTdHJ1 Y3R1cmVJRFRhYmxlJ3MgZnJlZSBsaXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NvZGVDYWNoZS5jcHAKaW5kZXggYjQxZTUyNjUxZjNlN2M5ZjZlY2RlMjNmZmI5Njk5Yzg5ZGI3 ODY1Ny4uOWI2MDcwYmU5M2Y5ODVhNGYyYjRmM2UwZGIxMzU1ZGE3YTExYTNmOCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCkBAIC0xNzAsNyArMTcwLDkg QEAgdm9pZCBnZW5lcmF0ZVVubGlua2VkQ29kZUJsb2NrRm9yRnVuY3Rpb25zKFZNJiB2bSwgVW5s aW5rZWRDb2RlQmxvY2sqIHVubGlua2VkQ28KICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAg ICBGdW5jdGlvbkV4ZWN1dGFibGUqIGV4ZWN1dGFibGUgPSB1bmxpbmtlZEV4ZWN1dGFibGUtPmxp bmsodm0sIHBhcmVudFNvdXJjZSk7Ci0gICAgICAgIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSA9 IGV4ZWN1dGFibGUtPnNvdXJjZSgpOworICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkbid0IG5l ZWQgdG8gY3JlYXRlIGEgRnVuY3Rpb25FeGVjdXRhYmxlIGp1c3QgdG8gZ2V0IGl0cyBzb3VyY2Ug Y29kZQorICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk0NTc2CisgICAgICAgIFNvdXJjZUNvZGUgc291cmNlID0gZXhlY3V0YWJsZS0+c291cmNlKCk7 CiAgICAgICAgIFVubGlua2VkRnVuY3Rpb25Db2RlQmxvY2sqIHVubGlua2VkRnVuY3Rpb25Db2Rl QmxvY2sgPSB1bmxpbmtlZEV4ZWN1dGFibGUtPnVubGlua2VkQ29kZUJsb2NrRm9yKHZtLCBzb3Vy Y2UsIGNvbnN0cnVjdG9yS2luZCwgZGVidWdnZXJNb2RlLCBlcnJvciwgdW5saW5rZWRFeGVjdXRh YmxlLT5wYXJzZU1vZGUoKSk7CiAgICAgICAgIGlmICh1bmxpbmtlZEZ1bmN0aW9uQ29kZUJsb2Nr KQogICAgICAgICAgICAgZ2VuZXJhdGVVbmxpbmtlZENvZGVCbG9ja0ZvckZ1bmN0aW9ucyh2bSwg dW5saW5rZWRGdW5jdGlvbkNvZGVCbG9jaywgc291cmNlLCBkZWJ1Z2dlck1vZGUsIGVycm9yKTsK