194523 2019-02-11 17:00:56 -0800 REGRESSION: ( r240978-r240985 ) [ iOS Release ] Layout Test imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is crashing 2019-03-11 12:07:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell achristensen achristensen ap beidson commit-queue ggaren jlewis3 lforschler rniwa ryanhaddad sroberts webkit-bug-importer oldest_to_newest 1505052 0 tsavell 2019-02-11 17:00:56 -0800 The following layout test is failing on iOS Release imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm Probable cause: Test began crashing constantly on iOS release. I was able to reproduce locally but there is a gap in usable builds between r240978-r240985. the test passes on 240978 and crashes on r240985. There is no stderr for the crash. The test is already a constant failure. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fsend-redirect-post-upload.htm Crash: https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r241280%20(2553)/imported/w3c/web-platform-tests/xhr/send-redirect-post-upload-crash-log.txt 1505081 1 achristensen 2019-02-11 17:33:39 -0800 This is a CFNetwork bug. This won't be fixed by an open source change. 1506279 2 ap 2019-02-14 11:47:55 -0800 > This is a CFNetwork bug. This won't be fixed by an open source change. Alex, are you saying that this is not a regression in fact, and the bisection was wrong? Otherwise, we must have done something to start triggering this bug, so we should undo that something. 1506426 3 achristensen 2019-02-14 16:23:52 -0800 I'll look into whether this was caused by https://trac.webkit.org/changeset/240984/webkit 1506444 4 362085 achristensen 2019-02-14 17:31:49 -0800 Created attachment 362085 Patch 1506621 5 362085 ggaren 2019-02-15 10:22:45 -0800 Comment on attachment 362085 Patch > FormCreationContext* formContext = static_cast<FormCreationContext*>(context); If you use adoptRef here, you can avoid the manual delete below. auto formContext = adoptRef(...); ... callOnMainThread([formContext]) { }; 1506631 6 achristensen 2019-02-15 10:31:00 -0800 FormCreationContext is not refcounted. I could call the std::unique_ptr constructor, but that would be less symmetric than this new/delete use which mirrors another new/delete pair in this file. 1506642 7 achristensen 2019-02-15 10:51:24 -0800 http://trac.webkit.org/r241594 1506646 8 webkit-bug-importer 2019-02-15 10:52:34 -0800 <rdar://problem/48116418> 1507467 9 achristensen 2019-02-18 15:02:03 -0800 See rdar://problem/28233746 1507835 10 achristensen 2019-02-19 14:47:07 -0800 Reopening to attach new patch. 1507836 11 362434 achristensen 2019-02-19 14:47:08 -0800 Created attachment 362434 Patch 1508317 12 achristensen 2019-02-20 15:46:45 -0800 rdar://problem/48211292 1512266 13 achristensen 2019-03-04 11:54:37 -0800 http://trac.webkit.org/r242367 1513056 14 sroberts 2019-03-06 09:45:47 -0800 Test is still crashing or is a flaky failure on Peace iOS simulator Dashboard : https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fsend-redirect-post-upload.htm Reproduced with: run-webkit-tests imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm --iterations 20 -f --ios-simulator Crash Log : https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r242534%20(2989)/imported/w3c/web-platform-tests/xhr/send-redirect-post-upload-crash-log.txt Process: com.apple.WebKit.Networking.Development [21918] Path: /Volumes/VOLUME/*/WebKit.framework/XPCServices/com.apple.WebKit.Networking.xpc/com.apple.WebKit.Networking.Development Identifier: com.apple.WebKit.Networking.Development Version: 608+ (608.1.6+) Code Type: X86-64 (Native) Parent Process: launchd_sim [16059] Responsible: com.apple.WebKit.Networking.Development [21918] User ID: 501 Date/Time: 2019-03-06 04:16:11.319 -0800 OS Version: Mac OS X 10.13.6 (17G65) Report Version: 12 Anonymous UUID: 08BAA9A8-3D60-DCF9-81D2-FF44C6DAE18D Time Awake Since Boot: 650000 seconds System Integrity Protection: disabled Crashed Thread: 9 Dispatch queue: com.apple.CFNetwork.Connection Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000058 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [0] VM Regions Near 0x58: --> __TEXT 000000010b840000-000000010b841000 [ 4K] r-x/rwx SM=COW /Volumes/VOLUME/*/WebKit.framework/XPCServices/com.apple.WebKit.Networking.xpc/com.apple.WebKit.Networking.Development Application Specific Information: CoreSimulator 581.2 - Device: Managed 6 - Runtime: iOS 12.1 (16B91) - DeviceType: iPhone SE Thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x000000010f6cf20a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x000000010f6ce724 mach_msg + 60 2 com.apple.CoreFoundation 0x000000010df071b4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x000000010df017e9 __CFRunLoopRun + 1689 1514099 15 achristensen 2019-03-08 11:22:22 -0800 Reopening to attach new patch. 1514100 16 364041 achristensen 2019-03-08 11:22:23 -0800 Created attachment 364041 Patch 1514912 17 364041 commit-queue 2019-03-11 12:07:44 -0700 Comment on attachment 364041 Patch Clearing flags on attachment: 364041 Committed r242723: <https://trac.webkit.org/changeset/242723> 1514913 18 commit-queue 2019-03-11 12:07:46 -0700 All reviewed patches have been landed. Closing bug. 362085 2019-02-14 17:31:49 -0800 2019-02-19 14:47:05 -0800 Patch bug-194523-20190214173149.patch text/plain 2785 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MTU3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAyLTE0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TjogKCByMjQwOTc4LXIyNDA5ODUgKSBbIGlPUyBSZWxlYXNlIF0gTGF5b3V0IFRlc3QgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvc2VuZC1yZWRpcmVjdC1wb3N0LXVwbG9hZC5o dG0gaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NDUyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBzY29wZSBvZiB0aGUgRm9ybUNyZWF0aW9uQ29udGV4dCB3YXMgbGltaXRlZCB0 byB0aGUgc2NvcGUgb2YgY3JlYXRlSFRUUEJvZHlDRlJlYWRTdHJlYW0sCisgICAgICAgIHNvIHdo ZW4gaXQgd2FzIHVzZWQgaW4gZm9ybUNyZWF0ZSBpdCB3YXMgbHVja3kgdG8gZ2V0IHRoZSBzYW1l IGNvbnRleHQgaWYgdGhlIHN0YWNrIGhhZG4ndCBiZWVuIG92ZXJ3cml0dGVuCisgICAgICAgIGFu ZCBpZiB0aGUgRm9ybURhdGEgaGFkbid0IGJlZW4gZnJlZWQuICBJbnN0ZWFkLCBrZWVwIGl0IGFs aXZlIHdpdGggbmV3L2RlbGV0ZSBsaWtlIHdlIGRvIHRoZSBGb3JtU3RyZWFtRmllbGRzLgorICAg ICAgICBBIHlvdW5nZXIgbWUgc2hvdWxkJ3ZlIG5vdGljZWQgdGhpcyB3aGVuIHJldmlld2luZyBy MjE4NTE3LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9Gb3JtRGF0YVN0cmVhbUNG TmV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZvcm1DcmVhdGUpOgorICAgICAgICAoV2ViQ29y ZTo6Y3JlYXRlSFRUUEJvZHlDRlJlYWRTdHJlYW0pOgorCiAyMDE5LTAyLTE0ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogT2Nj YXNpb25hbCBjcmFzaCB1bmRlciBXZWJDb3JlOjpDU1NTdHlsZVNoZWV0OjppdGVtIGNhbGxlZCBm cm9tIEluc3BlY3RvcgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9G b3JtRGF0YVN0cmVhbUNGTmV0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2NmL0Zvcm1EYXRhU3RyZWFtQ0ZOZXQuY3BwCShyZXZpc2lvbiAyNDE1NzIp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0Zvcm1EYXRhU3RyZWFtQ0ZO ZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYsNiArMjE2LDEwIEBAIHN0YXRpYyB2b2lkKiBm b3JtQ3JlYXRlKENGUmVhZFN0cmVhbVJlZiAKICAgICBuZXdJbmZvLT5mb3JtU3RyZWFtID0gc3Ry ZWFtOyAvLyBEb24ndCByZXRhaW4uIFRoYXQgd291bGQgY3JlYXRlIGEgcmVmZXJlbmNlIGN5Y2xl LgogICAgIG5ld0luZm8tPnN0cmVhbUxlbmd0aCA9IGZvcm1Db250ZXh0LT5zdHJlYW1MZW5ndGg7 CiAgICAgbmV3SW5mby0+Ynl0ZXNTZW50ID0gMDsKKyAgICAKKyAgICBjYWxsT25NYWluVGhyZWFk KFtmb3JtQ29udGV4dF0geworICAgICAgICBkZWxldGUgZm9ybUNvbnRleHQ7CisgICAgfSk7CiAK ICAgICAvLyBBcHBlbmQgaW4gcmV2ZXJzZSBvcmRlciBzaW5jZSB3ZSByZW1vdmUgZWxlbWVudHMg ZnJvbSB0aGUgZW5kLgogICAgIHNpemVfdCBzaXplID0gbmV3SW5mby0+Zm9ybURhdGEtPmVsZW1l bnRzKCkuc2l6ZSgpOwpAQCAtMzgwLDkgKzM4NCw5IEBAIFJldGFpblB0cjxDRlJlYWRTdHJlYW1S ZWY+IGNyZWF0ZUhUVFBCb2QKICAgICBmb3IgKGF1dG8mIGVsZW1lbnQgOiByZXNvbHZlZEZvcm1E YXRhLT5lbGVtZW50cygpKQogICAgICAgICBsZW5ndGggKz0gZWxlbWVudC5sZW5ndGhJbkJ5dGVz KCk7CiAKLSAgICBGb3JtQ3JlYXRpb25Db250ZXh0IGZvcm1Db250ZXh0ID0geyBXVEZNb3ZlKHJl c29sdmVkRm9ybURhdGEpLCBsZW5ndGggfTsKKyAgICBGb3JtQ3JlYXRpb25Db250ZXh0KiBmb3Jt Q29udGV4dCA9IG5ldyBGb3JtQ3JlYXRpb25Db250ZXh0IHsgV1RGTW92ZShyZXNvbHZlZEZvcm1E YXRhKSwgbGVuZ3RoIH07CiAgICAgQ0ZSZWFkU3RyZWFtQ2FsbEJhY2tzVjEgY2FsbEJhY2tzID0g eyAxLCBmb3JtQ3JlYXRlLCBmb3JtRmluYWxpemUsIG51bGxwdHIsIGZvcm1PcGVuLCBudWxscHRy LCBmb3JtUmVhZCwgbnVsbHB0ciwgZm9ybUNhblJlYWQsIGZvcm1DbG9zZSwgZm9ybUNvcHlQcm9w ZXJ0eSwgbnVsbHB0ciwgbnVsbHB0ciwgZm9ybVNjaGVkdWxlLCBmb3JtVW5zY2hlZHVsZSB9Owot ICAgIHJldHVybiBhZG9wdENGKENGUmVhZFN0cmVhbUNyZWF0ZShudWxscHRyLCBzdGF0aWNfY2Fz dDxjb25zdCB2b2lkKj4oJmNhbGxCYWNrcyksICZmb3JtQ29udGV4dCkpOworICAgIHJldHVybiBh ZG9wdENGKENGUmVhZFN0cmVhbUNyZWF0ZShudWxscHRyLCBzdGF0aWNfY2FzdDxjb25zdCB2b2lk Kj4oJmNhbGxCYWNrcyksIGZvcm1Db250ZXh0KSk7CiB9CiAKIHZvaWQgc2V0SFRUUEJvZHkoQ0ZN dXRhYmxlVVJMUmVxdWVzdFJlZiByZXF1ZXN0LCBGb3JtRGF0YSogZm9ybURhdGEpCg== 362434 2019-02-19 14:47:08 -0800 2019-03-08 11:22:20 -0800 Patch bug-194523-20190219144707.patch text/plain 3589 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDE3NzYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAyLTE5ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTjog KCByMjQwOTc4LXIyNDA5ODUgKSBbIGlPUyBSZWxlYXNlIF0gTGF5b3V0IFRlc3QgaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvc2VuZC1yZWRpcmVjdC1wb3N0LXVwbG9hZC5odG0g aXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NDUyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEF0dGVtcHQgdG8gd29yayBhcm91bmQgYSBDRk5ldHdvcmsgYnVnIGluIHRoZSB0aW1pbmcg b2YgdGVhcmluZyBkb3duIHRhc2tzIHdpdGggdXBsb2FkIHN0cmVhbXMuCisgICAgICAgIFNlZSBy ZGFyOi8vcHJvYmxlbS8yODIzMzc0Ni4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29h L05ldHdvcmtEYXRhVGFza0NvY29hLmg6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2Ev TmV0d29ya0RhdGFUYXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFz a0NvY29hOjp+TmV0d29ya0RhdGFUYXNrQ29jb2EpOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW06CisgICAgICAgICgtW1dLTmV0d29ya1Nlc3Np b25EZWxlZ2F0ZSBVUkxTZXNzaW9uOnRhc2s6bmVlZE5ld0JvZHlTdHJlYW06XSk6CisKIDIwMTkt MDItMTkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XSAidG91Y2gtYWN0aW9uOiBub25lIiBzaG91bGQgbm90IHByZXZlbnQgdGV4dCBzZWxlY3Rpb24g b3IgdGFwcGluZyBvbiBhIGxpbmsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLmgJKHJldmlzaW9uIDI0 MTc1MykKKysrIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFU YXNrQ29jb2EuaAkod29ya2luZyBjb3B5KQpAQCAtODMsNiArODMsOCBAQCBwdWJsaWM6CiAKICAg ICBTdHJpbmcgZGVzY3JpcHRpb24oKSBjb25zdCBvdmVycmlkZTsKIAorICAgIHZvaWQgc2V0U2hv dWxkRXh0ZW5kVGFza0xpZmV0aW1lKGJvb2wgc2hvdWxkRXh0ZW5kVGFza0xpZmV0aW1lKSB7IG1f c2hvdWxkRXh0ZW5kVGFza0xpZmV0aW1lID0gc2hvdWxkRXh0ZW5kVGFza0xpZmV0aW1lOyB9CisK IHByaXZhdGU6CiAgICAgTmV0d29ya0RhdGFUYXNrQ29jb2EoTmV0d29ya1Nlc3Npb24mLCBOZXR3 b3JrRGF0YVRhc2tDbGllbnQmLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmLCB1aW50 NjRfdCBmcmFtZUlELCB1aW50NjRfdCBwYWdlSUQsIFdlYkNvcmU6OlN0b3JlZENyZWRlbnRpYWxz UG9saWN5LCBXZWJDb3JlOjpDb250ZW50U25pZmZpbmdQb2xpY3ksIFdlYkNvcmU6OkNvbnRlbnRF bmNvZGluZ1NuaWZmaW5nUG9saWN5LCBib29sIHNob3VsZENsZWFyUmVmZXJyZXJPbkhUVFBTVG9I VFRQUmVkaXJlY3QsIFByZWNvbm5lY3RPbmx5LCBib29sIGRhdGFUYXNrSXNGb3JNYWluRnJhbWVO YXZpZ2F0aW9uLCBPcHRpb25hbDxOZXR3b3JrQWN0aXZpdHlUcmFja2VyPik7CiAKQEAgLTEwNCw2 ICsxMDYsOSBAQCBwcml2YXRlOgogICAgIHVpbnQ2NF90IG1fZnJhbWVJRDsKICAgICB1aW50NjRf dCBtX3BhZ2VJRDsKIAorICAgIC8vIEZJWE1FOiBUaGlzIGlzIG9ubHkgbmVlZGVkIHVudGlsIHJk YXI6Ly9wcm9ibGVtLzI4MjMzNzQ2IGlzIGZpeGVkLgorICAgIGJvb2wgbV9zaG91bGRFeHRlbmRU YXNrTGlmZXRpbWUgeyBmYWxzZSB9OworCiAjaWYgRU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElT VElDUykKICAgICBib29sIG1faGFzQmVlblNldFRvVXNlU3RhdGVsZXNzQ29va2llU3RvcmFnZSB7 IGZhbHNlIH07CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29j b2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQkocmV2aXNpb24gMjQx NzUzKQorKysgU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRh c2tDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMjYxLDYgKzI2MSw5IEBAIE5ldHdvcmtEYXRh VGFza0NvY29hOjp+TmV0d29ya0RhdGFUYXNrQ28KICAgICAgICAgQVNTRVJUKGNvY29hU2Vzc2lv bi5tX2RhdGFUYXNrTWFwV2l0aG91dFN0YXRlLmdldChbbV90YXNrIHRhc2tJZGVudGlmaWVyXSkg PT0gdGhpcyk7CiAgICAgICAgIGNvY29hU2Vzc2lvbi5tX2RhdGFUYXNrTWFwV2l0aG91dFN0YXRl LnJlbW92ZShbbV90YXNrIHRhc2tJZGVudGlmaWVyXSk7CiAgICAgfQorICAgIAorICAgIGlmICht X3Nob3VsZEV4dGVuZFRhc2tMaWZldGltZSkKKyAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3Bh dGNoKFt0YXNrID0gV1RGTW92ZShtX3Rhc2spXSB7IH0pOwogfQogCiB2b2lkIE5ldHdvcmtEYXRh VGFza0NvY29hOjpyZXN0cmljdFJlcXVlc3RSZWZlcnJlclRvT3JpZ2luSWZOZWVkZWQoV2ViQ29y ZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBib29sIHNob3VsZEJsb2NrQ29va2llcykKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2Nv YS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05l dHdvcmtTZXNzaW9uQ29jb2EubW0JKHJldmlzaW9uIDI0MTc1MykKKysrIFNvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQkod29ya2luZyBjb3B5 KQpAQCAtMzgzLDYgKzM4Myw3IEBAIC0gKHZvaWQpVVJMU2Vzc2lvbjooTlNVUkxTZXNzaW9uICop c2Vzc2kKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIG5ldHdvcmtEYXRhVGFzay0+c2V0 U2hvdWxkRXh0ZW5kVGFza0xpZmV0aW1lKHRydWUpOwogICAgIGNvbXBsZXRpb25IYW5kbGVyKFdl YkNvcmU6OmNyZWF0ZUhUVFBCb2R5TlNJbnB1dFN0cmVhbSgqYm9keSkuZ2V0KCkpOwogfQogCg== 364041 2019-03-08 11:22:23 -0800 2019-03-11 12:07:44 -0700 Patch bug-194523-20190308112222.patch text/plain 3822 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDI2NDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAzLTA4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTjog KCByMjQwOTc4LXIyNDA5ODUgKSBbIGlPUyBSZWxlYXNlIF0gTGF5b3V0IFRlc3QgaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvc2VuZC1yZWRpcmVjdC1wb3N0LXVwbG9hZC5odG0g aXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NDUyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEF0dGVtcHQgYW5vdGhlciB3b3JrYXJvdW5kIHRvIHByZXZlbnQgY3Jhc2hlcy4KKworICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLmg6CisgICAg ICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW06CisgICAg ICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFza0NvY29hOjp+TmV0d29ya0RhdGFUYXNrQ29jb2Ep OgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW06 CisgICAgICAgICgtW1dLTmV0d29ya1Nlc3Npb25EZWxlZ2F0ZSBVUkxTZXNzaW9uOnRhc2s6bmVl ZE5ld0JvZHlTdHJlYW06XSk6CisKIDIwMTktMDMtMDggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBBc3NlcnRpb25TdGF0ZTo6RG93bmxvYWQuCklu ZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0Nv Y29hLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9O ZXR3b3JrRGF0YVRhc2tDb2NvYS5oCShyZXZpc2lvbiAyNDI2MDEpCisrKyBTb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLmgJKHdvcmtpbmcgY29w eSkKQEAgLTgzLDggKzgzLDYgQEAgcHVibGljOgogCiAgICAgU3RyaW5nIGRlc2NyaXB0aW9uKCkg Y29uc3Qgb3ZlcnJpZGU7CiAKLSAgICB2b2lkIHNldFNob3VsZEV4dGVuZFRhc2tMaWZldGltZShi b29sIHNob3VsZEV4dGVuZFRhc2tMaWZldGltZSkgeyBtX3Nob3VsZEV4dGVuZFRhc2tMaWZldGlt ZSA9IHNob3VsZEV4dGVuZFRhc2tMaWZldGltZTsgfQotCiBwcml2YXRlOgogICAgIE5ldHdvcmtE YXRhVGFza0NvY29hKE5ldHdvcmtTZXNzaW9uJiwgTmV0d29ya0RhdGFUYXNrQ2xpZW50JiwgY29u c3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiwgdWludDY0X3QgZnJhbWVJRCwgdWludDY0X3Qg cGFnZUlELCBXZWJDb3JlOjpTdG9yZWRDcmVkZW50aWFsc1BvbGljeSwgV2ViQ29yZTo6Q29udGVu dFNuaWZmaW5nUG9saWN5LCBXZWJDb3JlOjpDb250ZW50RW5jb2RpbmdTbmlmZmluZ1BvbGljeSwg Ym9vbCBzaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGlyZWN0LCBQcmVjb25uZWN0 T25seSwgYm9vbCBkYXRhVGFza0lzRm9yTWFpbkZyYW1lTmF2aWdhdGlvbiwgT3B0aW9uYWw8TmV0 d29ya0FjdGl2aXR5VHJhY2tlcj4pOwogCkBAIC0xMDYsOSArMTA0LDYgQEAgcHJpdmF0ZToKICAg ICB1aW50NjRfdCBtX2ZyYW1lSUQ7CiAgICAgdWludDY0X3QgbV9wYWdlSUQ7CiAKLSAgICAvLyBG SVhNRTogVGhpcyBpcyBvbmx5IG5lZWRlZCB1bnRpbCByZGFyOi8vcHJvYmxlbS8yODIzMzc0NiBp cyBmaXhlZC4KLSAgICBib29sIG1fc2hvdWxkRXh0ZW5kVGFza0xpZmV0aW1lIHsgZmFsc2UgfTsK LQogI2lmIEVOQUJMRShSRVNPVVJDRV9MT0FEX1NUQVRJU1RJQ1MpCiAgICAgYm9vbCBtX2hhc0Jl ZW5TZXRUb1VzZVN0YXRlbGVzc0Nvb2tpZVN0b3JhZ2UgeyBmYWxzZSB9OwogI2VuZGlmCkluZGV4 OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29h Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0 d29ya0RhdGFUYXNrQ29jb2EubW0JKHJldmlzaW9uIDI0MjYwMSkKKysrIFNvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0JKHdvcmtpbmcgY29w eSkKQEAgLTI2MSw5ICsyNjEsNiBAQCBOZXR3b3JrRGF0YVRhc2tDb2NvYTo6fk5ldHdvcmtEYXRh VGFza0NvCiAgICAgICAgIEFTU0VSVChjb2NvYVNlc3Npb24ubV9kYXRhVGFza01hcFdpdGhvdXRT dGF0ZS5nZXQoW21fdGFzayB0YXNrSWRlbnRpZmllcl0pID09IHRoaXMpOwogICAgICAgICBjb2Nv YVNlc3Npb24ubV9kYXRhVGFza01hcFdpdGhvdXRTdGF0ZS5yZW1vdmUoW21fdGFzayB0YXNrSWRl bnRpZmllcl0pOwogICAgIH0KLSAgICAKLSAgICBpZiAobV9zaG91bGRFeHRlbmRUYXNrTGlmZXRp bWUpCi0gICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbdGFzayA9IFdURk1vdmUobV90 YXNrKV0geyB9KTsKIH0KIAogdm9pZCBOZXR3b3JrRGF0YVRhc2tDb2NvYTo6cmVzdHJpY3RSZXF1 ZXN0UmVmZXJyZXJUb09yaWdpbklmTmVlZGVkKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVx dWVzdCwgYm9vbCBzaG91bGRCbG9ja0Nvb2tpZXMpCkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCShy ZXZpc2lvbiAyNDI2MDEpCisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05l dHdvcmtTZXNzaW9uQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTM4Myw4ICszODMsMTAgQEAg LSAodm9pZClVUkxTZXNzaW9uOihOU1VSTFNlc3Npb24gKilzZXNzaQogICAgICAgICByZXR1cm47 CiAgICAgfQogCi0gICAgbmV0d29ya0RhdGFUYXNrLT5zZXRTaG91bGRFeHRlbmRUYXNrTGlmZXRp bWUodHJ1ZSk7Ci0gICAgY29tcGxldGlvbkhhbmRsZXIoV2ViQ29yZTo6Y3JlYXRlSFRUUEJvZHlO U0lucHV0U3RyZWFtKCpib2R5KS5nZXQoKSk7CisgICAgLy8gRklYTUU6IENhbGwgdGhlIGNvbXBs ZXRpb25IYW5kbGVyIGltbWVkaWF0ZWx5IG9uY2UgcmRhcjovL3Byb2JsZW0vMjgyMzM3NDYgaXMg Zml4ZWQuCisgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtib2R5ID0gbWFrZVJlZigqYm9k eSksIGNvbXBsZXRpb25IYW5kbGVyID0gbWFrZUJsb2NrUHRyKGNvbXBsZXRpb25IYW5kbGVyKV0g eworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihXZWJDb3JlOjpjcmVhdGVIVFRQQm9keU5TSW5w dXRTdHJlYW0oYm9keS5nZXQoKSkuZ2V0KCkpOworICAgIH0pOwogfQogCiAjaWYgSEFWRShDRk5F VFdPUktfV0lUSF9JR05PUkVfSFNUUykgJiYgRU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElTVElD UykK