194519 2019-02-11 15:45:57 -0800 [Cocoa] Web Automation: client callbacks are not called if delegate does not override 2019-02-11 17:15:57 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue joepeck thorton webkit-bug-importer oldest_to_newest 1505025 0 bburg 2019-02-11 15:45:57 -0800 For some platforms that can't resize, it's not expected that setWindowFrame has any effect. However, it and other completion handler-based methods need to always call the completion handler. For example, some of those methods are called when going in/out of fullscreen. 1505026 1 webkit-bug-importer 2019-02-11 15:46:28 -0800 <rdar://problem/47981961> 1505027 2 361723 bburg 2019-02-11 15:49:21 -0800 Created attachment 361723 Patch 1505028 3 361723 joepeck 2019-02-11 15:50:26 -0800 Comment on attachment 361723 Patch r=me 1505060 4 361723 commit-queue 2019-02-11 17:15:55 -0800 Comment on attachment 361723 Patch Clearing flags on attachment: 361723 Committed r241285: <https://trac.webkit.org/changeset/241285> 1505061 5 commit-queue 2019-02-11 17:15:57 -0800 All reviewed patches have been landed. Closing bug. 361723 2019-02-11 15:49:21 -0800 2019-02-11 17:15:55 -0800 Patch bug-194519-20190211154920.patch text/plain 3871 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlhYmJlYjc2ODhmM2MyMmYz NDU5ZGJmYjk5YjEzMmVmMzNiM2Q4NTQuLjJhNDhlN2IzODgzMmQ4NTM0NDg3NDlkYjAwMmVjMzQ1 ZDgyY2E1MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDItMTEgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBXZWIgQXV0b21hdGlvbjog Y2xpZW50IGNhbGxiYWNrcyBhcmUgbm90IGNhbGxlZCBpZiBkZWxlZ2F0ZSBkb2VzIG5vdCBvdmVy cmlkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 NTE5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Nzk4MTk2MT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsIHRoZSBjb21wbGV0aW9uIGhhbmRs ZXIgZGlyZWN0bHkgaWYgdGhlIGRlbGVnYXRlIGRvZXMgbm90IGltcGxlbWVudCB0aGUgcmVsZXZh bnQgbWV0aG9kLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL0F1dG9tYXRpb25TZXNzaW9u Q2xpZW50Lm1tOgorICAgICAgICAoV2ViS2l0OjpBdXRvbWF0aW9uU2Vzc2lvbkNsaWVudDo6cmVx dWVzdE5ld1BhZ2VXaXRoT3B0aW9ucyk6CisgICAgICAgIChXZWJLaXQ6OkF1dG9tYXRpb25TZXNz aW9uQ2xpZW50OjpyZXF1ZXN0U3dpdGNoVG9QYWdlKToKKyAgICAgICAgKFdlYktpdDo6QXV0b21h dGlvblNlc3Npb25DbGllbnQ6OnJlcXVlc3RIaWRlV2luZG93T2ZQYWdlKToKKyAgICAgICAgKFdl YktpdDo6QXV0b21hdGlvblNlc3Npb25DbGllbnQ6OnJlcXVlc3RSZXN0b3JlV2luZG93T2ZQYWdl KToKKyAgICAgICAgKFdlYktpdDo6QXV0b21hdGlvblNlc3Npb25DbGllbnQ6OnJlcXVlc3RNYXhp bWl6ZVdpbmRvd09mUGFnZSk6CisKIDIwMTktMDItMTEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9o c2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgZmFzdC9mb3Jtcy9pb3MvZm9yY2UtZ3JlZ29yaWFu LWNhbGVuZGFyLWZvci1jcmVkaXQtY2FyZC1leHBpcnkuaHRtbCBkb2VzIG5vdCB3b3JrIG9uIGlQ YWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL0F1dG9tYXRpb25T ZXNzaW9uQ2xpZW50Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvQXV0b21hdGlv blNlc3Npb25DbGllbnQubW0KaW5kZXggMTI3MWJhODU5NDkwODgyODJhMTVhOWE5ZWIzNmVmNDUz OWFkMmQ5ZC4uNTVhMDQ2NzAxY2NhOWM0MDE1OTRiZjQxMDVkNzk0ZTBjNzE5M2U4MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvQXV0b21hdGlvblNlc3Npb25DbGll bnQubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvQXV0b21hdGlvblNlc3Np b25DbGllbnQubW0KQEAgLTc5LDMxICs3OSw0MCBAQCB2b2lkIEF1dG9tYXRpb25TZXNzaW9uQ2xp ZW50OjpyZXF1ZXN0TmV3UGFnZVdpdGhPcHRpb25zKFdlYkF1dG9tYXRpb25TZXNzaW9uJiBzZQog ICAgICAgICBbbV9kZWxlZ2F0ZS5nZXQoKSBfYXV0b21hdGlvblNlc3Npb246d3JhcHBlcihzZXNz aW9uKSByZXF1ZXN0TmV3V2ViVmlld1dpdGhPcHRpb25zOnRvQVBJKG9wdGlvbnMpIGNvbXBsZXRp b25IYW5kbGVyOm1ha2VCbG9ja1B0cihbY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBs ZXRpb25IYW5kbGVyKV0oV0tXZWJWaWV3ICp3ZWJWaWV3KSBtdXRhYmxlIHsKICAgICAgICAgICAg IGNvbXBsZXRpb25IYW5kbGVyKHdlYlZpZXctPl9wYWdlLmdldCgpKTsKICAgICAgICAgfSkuZ2V0 KCldOwotICAgIH0KKyAgICB9IGVsc2UKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIobnVsbHB0 cik7CiB9CiAKIHZvaWQgQXV0b21hdGlvblNlc3Npb25DbGllbnQ6OnJlcXVlc3RTd2l0Y2hUb1Bh Z2UoV2ViQXV0b21hdGlvblNlc3Npb24mIHNlc3Npb24sIFdlYlBhZ2VQcm94eSYgcGFnZSwgQ29t cGxldGlvbkhhbmRsZXI8dm9pZCgpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQogewogICAgIGlmICht X2RlbGVnYXRlTWV0aG9kcy5yZXF1ZXN0U3dpdGNoVG9XZWJWaWV3KQogICAgICAgICBbbV9kZWxl Z2F0ZS5nZXQoKSBfYXV0b21hdGlvblNlc3Npb246d3JhcHBlcihzZXNzaW9uKSByZXF1ZXN0U3dp dGNoVG9XZWJWaWV3OmZyb21XZWJQYWdlUHJveHkocGFnZSkgY29tcGxldGlvbkhhbmRsZXI6bWFr ZUJsb2NrUHRyKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKS5nZXQoKV07CisgICAgZWxzZQor ICAgICAgICBjb21wbGV0aW9uSGFuZGxlcigpOwogfQogCiB2b2lkIEF1dG9tYXRpb25TZXNzaW9u Q2xpZW50OjpyZXF1ZXN0SGlkZVdpbmRvd09mUGFnZShXZWJBdXRvbWF0aW9uU2Vzc2lvbiYgc2Vz c2lvbiwgV2ViUGFnZVByb3h5JiBwYWdlLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29t cGxldGlvbkhhbmRsZXIpCiB7CiAgICAgaWYgKG1fZGVsZWdhdGVNZXRob2RzLnJlcXVlc3RIaWRl V2luZG93T2ZXZWJWaWV3KQogICAgICAgICBbbV9kZWxlZ2F0ZS5nZXQoKSBfYXV0b21hdGlvblNl c3Npb246d3JhcHBlcihzZXNzaW9uKSByZXF1ZXN0SGlkZVdpbmRvd09mV2ViVmlldzpmcm9tV2Vi UGFnZVByb3h5KHBhZ2UpIGNvbXBsZXRpb25IYW5kbGVyOm1ha2VCbG9ja1B0cihXVEZNb3ZlKGNv bXBsZXRpb25IYW5kbGVyKSkuZ2V0KCldOworICAgIGVsc2UKKyAgICAgICAgY29tcGxldGlvbkhh bmRsZXIoKTsKIH0KIAogdm9pZCBBdXRvbWF0aW9uU2Vzc2lvbkNsaWVudDo6cmVxdWVzdFJlc3Rv cmVXaW5kb3dPZlBhZ2UoV2ViQXV0b21hdGlvblNlc3Npb24mIHNlc3Npb24sIFdlYlBhZ2VQcm94 eSYgcGFnZSwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQog ewogICAgIGlmIChtX2RlbGVnYXRlTWV0aG9kcy5yZXF1ZXN0UmVzdG9yZVdpbmRvd09mV2ViVmll dykKICAgICAgICAgW21fZGVsZWdhdGUuZ2V0KCkgX2F1dG9tYXRpb25TZXNzaW9uOndyYXBwZXIo c2Vzc2lvbikgcmVxdWVzdFJlc3RvcmVXaW5kb3dPZldlYlZpZXc6ZnJvbVdlYlBhZ2VQcm94eShw YWdlKSBjb21wbGV0aW9uSGFuZGxlcjptYWtlQmxvY2tQdHIoV1RGTW92ZShjb21wbGV0aW9uSGFu ZGxlcikpLmdldCgpXTsKKyAgICBlbHNlCisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKCk7CiB9 CiAKIHZvaWQgQXV0b21hdGlvblNlc3Npb25DbGllbnQ6OnJlcXVlc3RNYXhpbWl6ZVdpbmRvd09m UGFnZShXZWJBdXRvbWF0aW9uU2Vzc2lvbiYgc2Vzc2lvbiwgV2ViUGFnZVByb3h5JiBwYWdlLCBD b21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAgICAgaWYg KG1fZGVsZWdhdGVNZXRob2RzLnJlcXVlc3RNYXhpbWl6ZVdpbmRvd09mV2ViVmlldykKICAgICAg ICAgW21fZGVsZWdhdGUuZ2V0KCkgX2F1dG9tYXRpb25TZXNzaW9uOndyYXBwZXIoc2Vzc2lvbikg cmVxdWVzdE1heGltaXplV2luZG93T2ZXZWJWaWV3OmZyb21XZWJQYWdlUHJveHkocGFnZSkgY29t cGxldGlvbkhhbmRsZXI6bWFrZUJsb2NrUHRyKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKS5n ZXQoKV07CisgICAgZWxzZQorICAgICAgICBjb21wbGV0aW9uSGFuZGxlcigpOwogfQogCiBib29s IEF1dG9tYXRpb25TZXNzaW9uQ2xpZW50Ojppc1Nob3dpbmdKYXZhU2NyaXB0RGlhbG9nT25QYWdl KFdlYkF1dG9tYXRpb25TZXNzaW9uJiBzZXNzaW9uLCBXZWJQYWdlUHJveHkmIHBhZ2UpCg==