19438 2008-06-08 12:59:24 -0700 Transaction errors are never displayed in database query view 2008-06-08 13:58:24 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aroben aroben oldest_to_newest 82643 0 aroben 2008-06-08 12:59:24 -0700 Transaction errors are never displayed in database query view. To repro: 1. Go to http://webkit.org/misc/DatabaseExample.html 2. Go to the Databases panel and click on the NoteTest database 3. Enter the following text on the query input line: INSERT INTO WebKitStickyNotes (note) VALUES (NULL) Results: The line of text you entered disappears, and no error is shown. 82647 1 21579 aroben 2008-06-08 13:23:40 -0700 Created attachment 21579 patch + changelog 82649 2 21579 darin 2008-06-08 13:26:20 -0700 Comment on attachment 21579 patch + changelog r=me; seems fine as is But this seems a little strange to me. Why wouldn't we instead use two different error functions for the two different cases, and then share a common worker function? 82652 3 aroben 2008-06-08 13:29:13 -0700 (In reply to comment #2) > (From update of attachment 21579 [edit]) > r=me; seems fine as is > > But this seems a little strange to me. Why wouldn't we instead use two > different error functions for the two different cases, and then share a common > worker function? Yeah, that's probably a better way to go. I guess this patch is a little too quick-n-dirty. 82658 4 21580 aroben 2008-06-08 13:42:03 -0700 Created attachment 21580 patch v2 + changelog Updated to address Darin's comments. 82665 5 21580 darin 2008-06-08 13:49:32 -0700 Comment on attachment 21580 patch v2 + changelog r=me 82669 6 aroben 2008-06-08 13:58:24 -0700 Committed in r34455 21579 2008-06-08 13:23:40 -0700 2008-06-08 13:42:03 -0700 patch + changelog 0001--Fix-Bug-19438-Transaction-errors-are-never.patch text/plain 4097 aroben RnJvbSA4ZTMzZWM0MThhNmIyYjJmMjQ5ODA3MjNjZDhkNDlhOGUyMTY0NjJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBT dW4sIDggSnVuIDIwMDggMTM6MTI6NDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSAgICAgICAgIEZp eCBCdWcgMTk0Mzg6IFRyYW5zYWN0aW9uIGVycm9ycyBhcmUgbmV2ZXIgZGlzcGxheWVkIGluIGRh dGFiYXNlIHF1ZXJ5IHZpZXcKCiAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTQzOD4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgog ICAgICAgIFRlc3Q6IG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtdHJhbnNhY3Rp b24tZXJyb3IuaHRtbAoKICAgICAgICAqIG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1z cWwtdHJhbnNhY3Rpb24tZXJyb3IuaHRtbDogQWRkZWQuCiAgICAgICAgKiBwYWdlL2luc3BlY3Rv ci9EYXRhYmFzZVF1ZXJ5Vmlldy5qczoKICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFiYXNlUXVl cnlWaWV3LnByb3RvdHlwZS5fcXVlcnlFcnJvcik6IFVzZSB0aGUgcmlnaHQKICAgICAgICBwYXJh bWV0ZXIgZm9yIHRoZSBlcnJvciB3aGVuIGNhbGxlZCBhcyBhIHRyYW5zYWN0aW9uIGVycm9yIGNh bGxiYWNrLgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxNiArKysrKysrKysrKysrCiAuLi4vaW5zcGVjdG9yL2Rpc3BsYXktc3FsLXRy YW5zYWN0aW9uLWVycm9yLmh0bWwgICB8ICAgMjQgKysrKysrKysrKysrKysrKysrKysKIFdlYkNv cmUvcGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VRdWVyeVZpZXcuanMgICAgICAgIHwgICAgNSArKysr CiAzIGZpbGVzIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVh dGUgbW9kZSAxMDA2NDQgV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXktc3Fs LXRyYW5zYWN0aW9uLWVycm9yLmh0bWwKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBi L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQxZjQyMGYuLjk0MTlmN2YgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMDgtMDYtMDggIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAgIEZp eCBCdWcgMTk0Mzg6IFRyYW5zYWN0aW9uIGVycm9ycyBhcmUgbmV2ZXIgZGlzcGxheWVkIGluIGRh dGFiYXNlCisgICAgICAgIHF1ZXJ5IHZpZXcKKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDM4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxh eS1zcWwtdHJhbnNhY3Rpb24tZXJyb3IuaHRtbAorCisgICAgICAgICogbWFudWFsLXRlc3RzL2lu c3BlY3Rvci9kaXNwbGF5LXNxbC10cmFuc2FjdGlvbi1lcnJvci5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBwYWdlL2luc3BlY3Rvci9EYXRhYmFzZVF1ZXJ5Vmlldy5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5EYXRhYmFzZVF1ZXJ5Vmlldy5wcm90b3R5cGUuX3F1ZXJ5RXJyb3IpOiBVc2UgdGhl IHJpZ2h0CisgICAgICAgIHBhcmFtZXRlciBmb3IgdGhlIGVycm9yIHdoZW4gY2FsbGVkIGFzIGEg dHJhbnNhY3Rpb24gZXJyb3IgY2FsbGJhY2suCisKIDIwMDgtMDYtMDggIEVyaWMgQ2FybHNvbiAg PGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtdHJh bnNhY3Rpb24tZXJyb3IuaHRtbCBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9kaXNw bGF5LXNxbC10cmFuc2FjdGlvbi1lcnJvci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLmRhMmQzMTAKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL21hbnVhbC10ZXN0 cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtdHJhbnNhY3Rpb24tZXJyb3IuaHRtbApAQCAtMCwwICsx LDI0IEBACis8c2NyaXB0PgorICAgIHRyeSB7CisgICAgICAgIHZhciBkYiA9IG9wZW5EYXRhYmFz ZSgiSW5zcGVjdG9yVGVzdCIsICIwLjEiLCAiRGF0YWJhc2UgZm9yIEluc3BlY3RvciB0ZXN0cyIs IDIwMDAwMCk7CisgICAgICAgIGRiLnRyYW5zYWN0aW9uKGZ1bmN0aW9uKHR4KSB7CisgICAgICAg ICAgICB0eC5leGVjdXRlU3FsKCJDUkVBVEUgVEFCTEUgRGlzcGxheVNRTFRyYW5zYWN0aW9uRXJy b3IgKHRlc3QgVEVYVCkiLCBbXSk7CisgICAgICAgIH0pOworICAgIH0gY2F0Y2ggKGUpIHsKKyAg ICB9Cis8L3NjcmlwdD4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQzOCI+QnVnIDE5NDM4OiBUcmFuc2FjdGlvbiBlcnJvcnMg YXJlIG5ldmVyIGRpc3BsYXllZCBpbiBkYXRhYmFzZSBxdWVyeSB2aWV3PC9hPi48L3A+Cis8cD5U byB0ZXN0OjwvcD4KKzxvbD4KKyAgICA8bGk+T3BlbiB0aGUgSW5zcGVjdG9yPC9saT4KKyAgICA8 bGk+R28gdG8gdGhlIERhdGFiYXNlcyBwYW5lbDwvbGk+CisgICAgPGxpPkNsaWNrIG9uIHRoZSA8 Y29kZT5JbnNwZWN0b3JUZXN0PC9jb2RlPiBkYXRhYmFzZTwvbGk+CisgICAgPGxpPkVudGVyIHRo ZSBmb2xsb3dpbmcgdGV4dCBvbiB0aGUgcXVlcnkgaW5wdXQgbGluZTogPGNvZGU+SU5TRVJUIElO VE8gRGlzcGxheVNRTFRyYW5zYWN0aW9uRXJyb3IgKHRlc3QpIFZBTFVFUyAoTlVMTCk8L2NvZGU+ PC9saT4KKzwvb2w+Cis8cD5JZiB0aGUgbGluZSBvZiB0ZXh0IHlvdSBlbnRlcmVkIHJlbWFpbnMg YW5kIGFuIGVycm9yIGxpbmUgaXMgb3V0cHV0IGJlbG93CitpdCwgeW91IGhhdmUgcGFzc2VkIHRo ZSB0ZXN0LjwvcD4KKzxwPklmIHRoZSBsaW5lIG9mIHRleHQgeW91IGVudGVyZWQgZGlzYXBwZWFy cyBhbmQgbm8gZXJyb3IgbGluZSBpcyBvdXRwdXQsIHlvdQoraGF2ZSBmYWlsZWQgdGhlIHRlc3Qu PC9wPgorPHA+SWYgdGhlIGxpbmUgb2YgdGV4dCB5b3UgZW50ZXJlZCByZW1haW5zIGFuZCBubyBl cnJvciBsaW5lIGlzIG91dHB1dCwgdGhlbgordGhlIHRlc3QgaGFzIGJlY29tZSBpbnZhbGlkIGFu ZCBuZWVkcyB0byBiZSBtb2RpZmllZCB0byBjYXVzZSB0aGUgZXJyb3IKK2NhbGxiYWNrIHBhc3Nl ZCBieSB0aGUgSW5zcGVjdG9yIHRvIDxjb2RlPmRiLnRyYW5zYWN0aW9uPC9jb2RlPiB0byBiZSBj YWxsZWQuPC9wPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9EYXRhYmFzZVF1 ZXJ5Vmlldy5qcyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VRdWVyeVZpZXcuanMK aW5kZXggZGRjNjAyNi4uMWFiYzg2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rv ci9EYXRhYmFzZVF1ZXJ5Vmlldy5qcworKysgYi9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0RhdGFi YXNlUXVlcnlWaWV3LmpzCkBAIC0xNjAsNiArMTYwLDExIEBAIFdlYkluc3BlY3Rvci5EYXRhYmFz ZVF1ZXJ5Vmlldy5wcm90b3R5cGUgPSB7CiAKICAgICBfcXVlcnlFcnJvcjogZnVuY3Rpb24ocXVl cnksIHR4LCBlcnJvcikKICAgICB7CisgICAgICAgIC8vIElmIHdlJ3JlIGNhbGxlZCBmb3IgYSB0 cmFuc2FjdGlvbiBlcnJvciwgdGhlbiB0aGUgZmlyc3QgcGFyYW1ldGVyCisgICAgICAgIC8vIHdp bGwgYmUgdGhlIGVycm9yLiBJZiB3ZSdyZSBjYWxsZWQgZm9yIGFuIGV4ZWN1dGVTcWwgZXJyb3Is IHRoZW4gdGhlCisgICAgICAgIC8vIHNlY29uZCBwYXJhbWV0ZXIgd2lsbCBiZSB0aGUgZXJyb3Iu CisgICAgICAgIGVycm9yID0gZXJyb3IgfHwgdHg7CisKICAgICAgICAgaWYgKGVycm9yLmNvZGUg PT0gMSkKICAgICAgICAgICAgIHZhciBtZXNzYWdlID0gZXJyb3IubWVzc2FnZTsKICAgICAgICAg ZWxzZSBpZiAoZXJyb3IuY29kZSA9PSAyKQotLSAKMS41LjYucmMwLjQ2LmdkMmIzCgo= 21580 2008-06-08 13:42:03 -0700 2008-06-08 13:49:32 -0700 patch v2 + changelog 0001--Fix-Bug-19438-Transaction-errors-are-never.patch text/plain 5555 aroben RnJvbSBkMTY1OWJmNzY3ZTFiZTYxNmI5YWNlNDY4ZjU0MGMyYWJiZmJjZjIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBT dW4sIDggSnVuIDIwMDggMTM6NDI6MzMgLTA3MDAKU3ViamVjdDogW1BBVENIXSAgICAgICAgIEZp eCBCdWcgMTk0Mzg6IFRyYW5zYWN0aW9uIGVycm9ycyBhcmUgbmV2ZXIgZGlzcGxheWVkIGluIGRh dGFiYXNlIHF1ZXJ5IHZpZXcKCiAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTQzOD4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgog ICAgICAgIFRlc3Q6IG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtdHJhbnNhY3Rp b24tZXJyb3IuaHRtbAoKICAgICAgICAqIG1hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1z cWwtdHJhbnNhY3Rpb24tZXJyb3IuaHRtbDogQWRkZWQuCiAgICAgICAgKiBwYWdlL2luc3BlY3Rv ci9EYXRhYmFzZVF1ZXJ5Vmlldy5qczoKICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFiYXNlUXVl cnlWaWV3LnByb3RvdHlwZS5fZW50ZXJLZXlQcmVzc2VkKTogVXNlCiAgICAgICAgX2V4ZWN1dGVT cWxFcnJvciBhcyB0aGUgZXJyb3IgY2FsbGJhY2sgZm9yIGV4ZWN1dGVTcWwuCiAgICAgICAgKFdl Ykluc3BlY3Rvci5EYXRhYmFzZVF1ZXJ5Vmlldy5wcm90b3R5cGUuX3F1ZXJ5RXJyb3IpOiBDaGFu Z2VkIHRvCiAgICAgICAgb25seSB0YWtlIHR3byBwYXJhbWV0ZXJzLiBUaGlzIG1hdGNoZXMgd2hh dCB3ZSdsbCBiZSBwYXNzZWQgaWYKICAgICAgICBkYi50cmFuc2FjdGlvbiBmYWlscy4KICAgICAg ICAoV2ViSW5zcGVjdG9yLkRhdGFiYXNlUXVlcnlWaWV3LnByb3RvdHlwZS5fZXhlY3V0ZVNxbEVy cm9yKTogQWRkZWQuCiAgICAgICAgQ2FsbHMgdGhyb3VnaCB0byBfcXVlcnlFcnJvci4KLS0tCiBX ZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjEg KysrKysrKysrKysrKysrKysKIC4uLi9pbnNwZWN0b3IvZGlzcGxheS1zcWwtdHJhbnNhY3Rpb24t ZXJyb3IuaHRtbCAgIHwgICAyNCArKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL2lu c3BlY3Rvci9EYXRhYmFzZVF1ZXJ5Vmlldy5qcyAgICAgICAgfCAgICA5ICsrKysrLQogMyBmaWxl cyBjaGFuZ2VkLCA1MiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUg MTAwNjQ0IFdlYkNvcmUvbWFudWFsLXRlc3RzL2luc3BlY3Rvci9kaXNwbGF5LXNxbC10cmFuc2Fj dGlvbi1lcnJvci5odG1sCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCBkMWY0MjBmLi42NzBmNWFjIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDA4LTA2 LTA4ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQnVnIDE5 NDM4OiBUcmFuc2FjdGlvbiBlcnJvcnMgYXJlIG5ldmVyIGRpc3BsYXllZCBpbiBkYXRhYmFzZQor ICAgICAgICBxdWVyeSB2aWV3CisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTQzOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0OiBtYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXktc3FsLXRy YW5zYWN0aW9uLWVycm9yLmh0bWwKKworICAgICAgICAqIG1hbnVhbC10ZXN0cy9pbnNwZWN0b3Iv ZGlzcGxheS1zcWwtdHJhbnNhY3Rpb24tZXJyb3IuaHRtbDogQWRkZWQuCisgICAgICAgICogcGFn ZS9pbnNwZWN0b3IvRGF0YWJhc2VRdWVyeVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RGF0YWJhc2VRdWVyeVZpZXcucHJvdG90eXBlLl9lbnRlcktleVByZXNzZWQpOiBVc2UKKyAgICAg ICAgX2V4ZWN1dGVTcWxFcnJvciBhcyB0aGUgZXJyb3IgY2FsbGJhY2sgZm9yIGV4ZWN1dGVTcWwu CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YWJhc2VRdWVyeVZpZXcucHJvdG90eXBlLl9xdWVy eUVycm9yKTogQ2hhbmdlZCB0bworICAgICAgICBvbmx5IHRha2UgdHdvIHBhcmFtZXRlcnMuIFRo aXMgbWF0Y2hlcyB3aGF0IHdlJ2xsIGJlIHBhc3NlZCBpZgorICAgICAgICBkYi50cmFuc2FjdGlv biBmYWlscy4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhYmFzZVF1ZXJ5Vmlldy5wcm90b3R5 cGUuX2V4ZWN1dGVTcWxFcnJvcik6IEFkZGVkLgorICAgICAgICBDYWxscyB0aHJvdWdoIHRvIF9x dWVyeUVycm9yLgorCiAyMDA4LTA2LTA4ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRpLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3BsYXktc3FsLXRyYW5zYWN0aW9uLWVycm9yLmh0 bWwgYi9XZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNwZWN0b3IvZGlzcGxheS1zcWwtdHJhbnNhY3Rp b24tZXJyb3IuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5kYTJkMzEw Ci0tLSAvZGV2L251bGwKKysrIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Rpc3Bs YXktc3FsLXRyYW5zYWN0aW9uLWVycm9yLmh0bWwKQEAgLTAsMCArMSwyNCBAQAorPHNjcmlwdD4K KyAgICB0cnkgeworICAgICAgICB2YXIgZGIgPSBvcGVuRGF0YWJhc2UoIkluc3BlY3RvclRlc3Qi LCAiMC4xIiwgIkRhdGFiYXNlIGZvciBJbnNwZWN0b3IgdGVzdHMiLCAyMDAwMDApOworICAgICAg ICBkYi50cmFuc2FjdGlvbihmdW5jdGlvbih0eCkgeworICAgICAgICAgICAgdHguZXhlY3V0ZVNx bCgiQ1JFQVRFIFRBQkxFIERpc3BsYXlTUUxUcmFuc2FjdGlvbkVycm9yICh0ZXN0IFRFWFQpIiwg W10pOworICAgICAgICB9KTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgfQorPC9zY3JpcHQ+Cis8 cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk0MzgiPkJ1ZyAxOTQzODogVHJhbnNhY3Rpb24gZXJyb3JzIGFyZSBuZXZlciBkaXNwbGF5 ZWQgaW4gZGF0YWJhc2UgcXVlcnkgdmlldzwvYT4uPC9wPgorPHA+VG8gdGVzdDo8L3A+Cis8b2w+ CisgICAgPGxpPk9wZW4gdGhlIEluc3BlY3RvcjwvbGk+CisgICAgPGxpPkdvIHRvIHRoZSBEYXRh YmFzZXMgcGFuZWw8L2xpPgorICAgIDxsaT5DbGljayBvbiB0aGUgPGNvZGU+SW5zcGVjdG9yVGVz dDwvY29kZT4gZGF0YWJhc2U8L2xpPgorICAgIDxsaT5FbnRlciB0aGUgZm9sbG93aW5nIHRleHQg b24gdGhlIHF1ZXJ5IGlucHV0IGxpbmU6IDxjb2RlPklOU0VSVCBJTlRPIERpc3BsYXlTUUxUcmFu c2FjdGlvbkVycm9yICh0ZXN0KSBWQUxVRVMgKE5VTEwpPC9jb2RlPjwvbGk+Cis8L29sPgorPHA+ SWYgdGhlIGxpbmUgb2YgdGV4dCB5b3UgZW50ZXJlZCByZW1haW5zIGFuZCBhbiBlcnJvciBsaW5l IGlzIG91dHB1dCBiZWxvdworaXQsIHlvdSBoYXZlIHBhc3NlZCB0aGUgdGVzdC48L3A+Cis8cD5J ZiB0aGUgbGluZSBvZiB0ZXh0IHlvdSBlbnRlcmVkIGRpc2FwcGVhcnMgYW5kIG5vIGVycm9yIGxp bmUgaXMgb3V0cHV0LCB5b3UKK2hhdmUgZmFpbGVkIHRoZSB0ZXN0LjwvcD4KKzxwPklmIHRoZSBs aW5lIG9mIHRleHQgeW91IGVudGVyZWQgcmVtYWlucyBhbmQgbm8gZXJyb3IgbGluZSBpcyBvdXRw dXQsIHRoZW4KK3RoZSB0ZXN0IGhhcyBiZWNvbWUgaW52YWxpZCBhbmQgbmVlZHMgdG8gYmUgbW9k aWZpZWQgdG8gY2F1c2UgdGhlIGVycm9yCitjYWxsYmFjayBwYXNzZWQgYnkgdGhlIEluc3BlY3Rv ciB0byA8Y29kZT5kYi50cmFuc2FjdGlvbjwvY29kZT4gdG8gYmUgY2FsbGVkLjwvcD4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VRdWVyeVZpZXcuanMgYi9XZWJD b3JlL3BhZ2UvaW5zcGVjdG9yL0RhdGFiYXNlUXVlcnlWaWV3LmpzCmluZGV4IGRkYzYwMjYuLmFj MzAwYjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvRGF0YWJhc2VRdWVyeVZp ZXcuanMKKysrIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9EYXRhYmFzZVF1ZXJ5Vmlldy5qcwpA QCAtMTQyLDcgKzE0Miw3IEBAIFdlYkluc3BlY3Rvci5EYXRhYmFzZVF1ZXJ5Vmlldy5wcm90b3R5 cGUgPSB7CiAKICAgICAgICAgZnVuY3Rpb24gcXVlcnlUcmFuc2FjdGlvbih0eCkKICAgICAgICAg ewotICAgICAgICAgICAgdHguZXhlY3V0ZVNxbChxdWVyeSwgbnVsbCwgSW5zcGVjdG9yQ29udHJv bGxlci53cmFwQ2FsbGJhY2sodGhpcy5fcXVlcnlGaW5pc2hlZC5iaW5kKHRoaXMsIHF1ZXJ5KSks IEluc3BlY3RvckNvbnRyb2xsZXIud3JhcENhbGxiYWNrKHRoaXMuX3F1ZXJ5RXJyb3IuYmluZCh0 aGlzLCBxdWVyeSkpKTsKKyAgICAgICAgICAgIHR4LmV4ZWN1dGVTcWwocXVlcnksIG51bGwsIElu c3BlY3RvckNvbnRyb2xsZXIud3JhcENhbGxiYWNrKHRoaXMuX3F1ZXJ5RmluaXNoZWQuYmluZCh0 aGlzLCBxdWVyeSkpLCBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBDYWxsYmFjayh0aGlzLl9leGVj dXRlU3FsRXJyb3IuYmluZCh0aGlzLCBxdWVyeSkpKTsKICAgICAgICAgfQogCiAgICAgICAgIHRo aXMuZGF0YWJhc2UuZGF0YWJhc2UudHJhbnNhY3Rpb24oSW5zcGVjdG9yQ29udHJvbGxlci53cmFw Q2FsbGJhY2socXVlcnlUcmFuc2FjdGlvbi5iaW5kKHRoaXMpKSwgSW5zcGVjdG9yQ29udHJvbGxl ci53cmFwQ2FsbGJhY2sodGhpcy5fcXVlcnlFcnJvci5iaW5kKHRoaXMsIHF1ZXJ5KSkpOwpAQCAt MTU4LDcgKzE1OCw3IEBAIFdlYkluc3BlY3Rvci5EYXRhYmFzZVF1ZXJ5Vmlldy5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLmRhdGFiYXNlcy51cGRhdGVEYXRh YmFzZVRhYmxlcyh0aGlzLmRhdGFiYXNlKTsKICAgICB9LAogCi0gICAgX3F1ZXJ5RXJyb3I6IGZ1 bmN0aW9uKHF1ZXJ5LCB0eCwgZXJyb3IpCisgICAgX3F1ZXJ5RXJyb3I6IGZ1bmN0aW9uKHF1ZXJ5 LCBlcnJvcikKICAgICB7CiAgICAgICAgIGlmIChlcnJvci5jb2RlID09IDEpCiAgICAgICAgICAg ICB2YXIgbWVzc2FnZSA9IGVycm9yLm1lc3NhZ2U7CkBAIC0xNzAsNiArMTcwLDExIEBAIFdlYklu c3BlY3Rvci5EYXRhYmFzZVF1ZXJ5Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2Fw cGVuZFF1ZXJ5UmVzdWx0KHF1ZXJ5LCBtZXNzYWdlLCAiZXJyb3IiKTsKICAgICB9LAogCisgICAg X2V4ZWN1dGVTcWxFcnJvcjogZnVuY3Rpb24ocXVlcnksIHR4LCBlcnJvcikKKyAgICB7CisgICAg ICAgIHRoaXMuX3F1ZXJ5RXJyb3IocXVlcnksIGVycm9yKTsKKyAgICB9LAorCiAgICAgX2FwcGVu ZFF1ZXJ5UmVzdWx0OiBmdW5jdGlvbihxdWVyeSwgcmVzdWx0LCByZXN1bHRDbGFzc05hbWUpCiAg ICAgewogICAgICAgICB2YXIgZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIp OwotLSAKMS41LjYucmMwLjQ2LmdkMmIzCgo=