194283 2019-02-05 00:10:37 -0800 webkit-patch print-expectations fails to format TestExpectationLine with DumpJSConsoleLogInStdErr 2019-12-12 17:52:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii aakash_jain ap don.olmstead eric.carlson ews-watchlist glenn jbedard lforschler rniwa ross.kirsling webkit-bug-importer youennf oldest_to_newest 1502290 0 fujii 2019-02-05 00:10:37 -0800 webkit-patch print-expectations fails to format TestExpectationLine with DumpJSConsoleLogInStdErr > $ ./Tools/Scripts/webkit-patch print-expectations --port=wincairo imported/w3c/web-platform-tests/fetch/ > --lint-test-files warnings: > LayoutTests/platform/gtk/TestExpectations:3782 Path does not exist. imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time.html > > Traceback (most recent call last): > File "./Tools/Scripts/webkit-patch", line 84, in <module> > main() > File "./Tools/Scripts/webkit-patch", line 79, in main > WebKitPatch(os.path.abspath(__file__)).main() > File "/mnt/c/webkit/ga/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main > result = command.check_arguments_and_execute(options, args, self) > File "/mnt/c/webkit/ga/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute > return self.execute(options, args, tool) or 0 > File "/mnt/c/webkit/ga/Tools/Scripts/webkitpy/tool/commands/queries.py", line 501, in execute > print('\n'.join(self._format_lines(options, port_name, lines))) > File "/mnt/c/webkit/ga/Tools/Scripts/webkitpy/tool/commands/queries.py", line 525, in _format_lines > output.append("%s" % line.to_string(None, include_modifiers, include_expectations, include_comment=False)) > File "/mnt/c/webkit/ga/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 460, in to_string > include_modifiers, include_expectations, include_comment) > File "/mnt/c/webkit/ga/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 510, in _format_line > result += ' [ %s ]' % ' '.join(sorted(set(new_expectations))) > TypeError: sequence item 0: expected string, NoneType found 1502307 1 361173 fujii 2019-02-05 01:06:12 -0800 Created attachment 361173 Patch 1502422 2 361173 ap 2019-02-05 10:44:06 -0800 Comment on attachment 361173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361173&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:244 > + 'DumpJSConsoleLogInStdErr': 'DUMPJSCONSOLELOGINSTDERR', Would we need changes in the flakiness dashboard to support this value? I think that we are hitting a design mistake with regards to DumpJSConsoleLogInStdErr - it is not an expectation, so mixing it with expectations causes trouble. 1502482 3 jbedard 2019-02-05 13:08:49 -0800 This bug very much confuses me. Why would we have a test expectation with DumpJSConsoleLogInStdErr in it? That feels like an abuse of the TestExpectations. 1502660 4 youennf 2019-02-05 19:21:13 -0800 > Would we need changes in the flakiness dashboard to support this value? No > I think that we are hitting a design mistake with regards to > DumpJSConsoleLogInStdErr - it is not an expectation, so mixing it with > expectations causes trouble. It is not really a test expectation, it is closer to 'Slow' in the sense it is changing the way the test is run. It was put there and not in some other file for convenience following the 'one place is better than two'. 1503595 5 fujii 2019-02-06 19:33:07 -0800 DumpJSConsoleLogInStdErr has been introduced in Bug 161310. webkit-test-runner magic comments or window.testRunner or window.internals can be the alternatives. Some imported tests have been modifed to have a webkit-test-runner magic comment. E.g. https://trac.webkit.org/browser/webkit/trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logical-box-border-color.html?rev=241112#L1 internals.setConsoleMessageListener() doesn't prevent console log. Settings::logsPageMessagesToSystemConsoleEnabled doesn't prevent console log. 1503599 6 youennf 2019-02-06 19:55:43 -0800 (In reply to Fujii Hironori from comment #5) > DumpJSConsoleLogInStdErr has been introduced in Bug 161310. > > webkit-test-runner magic comments or window.testRunner or window.internals > can be the alternatives. DumpJSConsoleLogInStdErr is mostly useful for imported tests that we do not want to modify. For tests that we can modify, there are usually ways, though not always, to not rely on it. > Some imported tests have been modifed to have a webkit-test-runner magic > comment. > E.g. > https://trac.webkit.org/browser/webkit/trunk/LayoutTests/imported/w3c/web- > platform-tests/css/css-logical/logical-box-border-color.html?rev=241112#L1 When reimporting these files, these comments will be lost by the importer and one will need to add them again. I hope these changes are expected to be temporary until we can activate the feature globally. The test importer could try to preserve these comments. In some cases, this is not possible though. Tests like like imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html are templates generated by the WPT server. The only way would be to modify the WPT server and we would certainly not be able to upstream these changes. An alternative is to apply DumpJSConsoleLogInStdErr to all WPT tests but we decided not to do that as it sometimes catches regressions. Another alternative would be to have some ways to grab the test options outside of the test content itself, either a central file or a file close to each test. I don't think we reached consensus there. 1503656 7 fujii 2019-02-07 00:23:14 -0800 (In reply to youenn fablet from comment #6) > Another alternative would be to have some ways to grab the test options > outside of the test content itself, either a central file or a file close to > each test. I don't think we reached consensus there. This seems the best. How about the idea reusing tests-options.json for such purpose? https://trac.webkit.org/browser/webkit/trunk/LayoutTests/tests-options.json?rev=241112 tests-options.json has been introduced in Bug 161601. 1503657 8 fujii 2019-02-07 00:26:01 -0800 I realize a tiny problem of DumpJSConsoleLogInStdErr that it outputs into stderr even though it is not a error message. Windows port has "EDITING DELEGATE:" filter in do_text_results_differ. https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/port/win.py?rev=241112#L108 We can have "CONSOLE:" filter for the purpose without modifying DRT and WTR. This approach wouldn't pollute the content of -stderr.txt. 1503683 9 fujii 2019-02-07 02:20:44 -0800 (In reply to Fujii Hironori from comment #7) > How about the idea reusing tests-options.json for such purpose? This is not easy because magic comments are retrieved by DRT and WTR, not by webkit-test-runner. DRT and WTR need to be changed to parse tests-options.json. It is easier to use a option file for each test, which is placed close to the test. 1503711 10 fujii 2019-02-07 06:07:14 -0800 (In reply to Fujii Hironori from comment #8) > I realize a tiny problem of DumpJSConsoleLogInStdErr that it outputs into > stderr even though it is not a error message. Darin mentioned this in Bug 161310 Comment 15. I didn't read the lengthy discussion. I should have read it first. 1505632 11 fujii 2019-02-12 23:29:17 -0800 Bug 177027 has introduced dumpJSConsoleLogInStdErr test option. > webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] I think we should use this for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations. 1505646 12 361901 fujii 2019-02-13 00:32:30 -0800 Created attachment 361901 Patch 1505657 13 361901 fujii 2019-02-13 00:56:53 -0800 Comment on attachment 361901 Patch Oops, wrong patch. 1505682 14 fujii 2019-02-13 02:39:29 -0800 (In reply to Fujii Hironori from comment #11) > I think we should use this for non-imported tests instead of using > DumpJSConsoleLogInStdErr expectation in TestExpectations. Filed Bug 194586. 1506163 15 youennf 2019-02-14 08:52:38 -0800 > Tests like like imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html are templates generated by the WPT server. If we decide to continue with these templated .any.html, we could actually modify them to include <!-- webkit-test-runner --> comments, as I guess the test runner is reading the file and not the HTTP resource. We would then need to instruct the importer to preserve any of these comments. 1506523 16 fujii 2019-02-15 01:40:38 -0800 a previous discussion: [webkit-dev] WPT tests and runtime-enabled features https://lists.webkit.org/pipermail/webkit-dev/2017-June/029165.html 1507191 17 fujii 2019-02-17 22:27:54 -0800 (In reply to youenn fablet from comment #15) > > Tests like like imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html are templates generated by the WPT server. > > If we decide to continue with these templated .any.html, we could actually > modify them to include <!-- webkit-test-runner --> comments, as I guess the > test runner is reading the file and not the HTTP resource. > We would then need to instruct the importer to preserve any of these > comments. youenn, do you prefer this approach? I think it is easier to use a option file for each test, which is placed close to the test, as you mentionsed in comment 6. E.g. imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any-option.txt 1597465 18 fujii 2019-12-10 18:03:05 -0800 As Youenn mentioned in Bug 204793 Comment 5, there is no consensus on removing all DumpJSConsoleLogInStdErr expectation at the moment yet. I'm going to fix the original issue of formatting DumpJSConsoleLogInStdErr (comment 0). 1597468 19 385333 fujii 2019-12-10 18:07:46 -0800 Created attachment 385333 Patch 1597899 20 fujii 2019-12-11 17:56:35 -0800 Youenn, can I ask you review? 1597958 21 fujii 2019-12-12 00:57:24 -0800 Thank you! I will land it unless anyone objects. 1598218 22 385333 fujii 2019-12-12 17:51:39 -0800 Comment on attachment 385333 Patch Clearing flags on attachment: 385333 Committed r253459: <https://trac.webkit.org/changeset/253459> 1598219 23 fujii 2019-12-12 17:51:43 -0800 All reviewed patches have been landed. Closing bug. 1598220 24 webkit-bug-importer 2019-12-12 17:52:30 -0800 <rdar://problem/57898667> 361173 2019-02-05 01:06:12 -0800 2019-02-13 00:32:11 -0800 Patch bug-194283-20190205180611.patch text/plain 3141 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGNlZWU3YjkwM2U5MjZlN2ZlMGUxOWY2ZWFlN2I0Nzk1 ODQxZWEyYy4uMjExNGJhZjRkZGY4NmFlZTM1YmZkYzQ5MTdlMTBiN2MzMGVhYjQ0ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTAyLTA1ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBwcmludC1leHBlY3RhdGlvbnMgZmFpbHMgdG8gZm9y bWF0IFRlc3RFeHBlY3RhdGlvbkxpbmUgd2l0aCBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDI4MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5OgorICAgICAg ICAoVGVzdEV4cGVjdGF0aW9uUGFyc2VyKTogQWRkIER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyciB0 byBUZXN0RXhwZWN0YXRpb25QYXJzZXIuX2V4cGVjdGF0aW9uX3Rva2Vucy4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5p dHRlc3QucHk6CisgICAgICAgIEFkZGVkIGEgdG9rZW5pemUgdGVzdCBhbmQgcm91bmQgdGlwIHRl c3QgZm9yIER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyci4KKwogMjAxOS0wMi0wNCAgSm9uYXRoYW4g QmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2Via2l0cHk6IFByZWNlZGVu Y2Ugb2YgYm9vdGVkIGRldmljZXMgc2hvdWxkIG1hdGNoIHByZWNlZGVuY2UgaW4gREVGQVVMVF9E RVZJQ0VfVFlQRVMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQppbmRleCA3YmU2ZDQ4NDdl NTBjMzY2NzRhZGVjZmNkYTZjZjk3NTZmMjM1NTMyLi42ODEwZDcxYTMzZjBlOWM5MjhiNzlmYWQx NmFjZWI0YmM0OGRkZDVjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CkBAIC0yNDEs NiArMjQxLDcgQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9uUGFyc2VyKG9iamVjdCk6CiAgICAgIyBG SVhNRTogVXBkYXRlIHRoZSBvcmlnaW5hbCBtb2RpZmllcnMgbGlzdCBhbmQgcmVtb3ZlIHRoaXMg b25jZSB0aGUgb2xkIHN5bnRheCBpcyBnb25lLgogICAgIF9leHBlY3RhdGlvbl90b2tlbnMgPSB7 CiAgICAgICAgICdDcmFzaCc6ICdDUkFTSCcsCisgICAgICAgICdEdW1wSlNDb25zb2xlTG9nSW5T dGRFcnInOiAnRFVNUEpTQ09OU09MRUxPR0lOU1RERVJSJywKICAgICAgICAgJ0ZhaWx1cmUnOiAn RkFJTCcsCiAgICAgICAgICdJbWFnZU9ubHlGYWlsdXJlJzogJ0lNQUdFJywKICAgICAgICAgJ0xl YWsnOiAnTEVBSycsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3Qu cHkKaW5kZXggMjA0NjQ0NjYzZTc3MGVkYTQxYTc2ZDQ5YWFiNGIxYjlmNDIwZjQ1ZS4uZDhhZjU4 YTdhN2RmNmQyZTg1MWFiY2E1ZWJhMWFlZGJmZDhmNzcwMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0 ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90 ZXN0X2V4cGVjdGF0aW9uc191bml0dGVzdC5weQpAQCAtNDAxLDYgKzQwMSw5IEBAIGNsYXNzIEV4 cGVjdGF0aW9uU3ludGF4VGVzdHMoQmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X3Rva2VuaXpl X2V4cCgnZm9vLmh0bWwgWyBXb250Rml4IEltYWdlT25seUZhaWx1cmUgXScsIG1vZGlmaWVycz1b J1dPTlRGSVgnXSwgZXhwZWN0YXRpb25zPVsnSU1BR0UnXSkKICAgICAgICAgc2VsZi5hc3NlcnRf dG9rZW5pemVfZXhwKCdmb28uaHRtbCBbIFdvbnRGaXggUGFzcyBGYWlsdXJlIF0nLCBtb2RpZmll cnM9WydXT05URklYJ10sIGV4cGVjdGF0aW9ucz1bJ1BBU1MnLCAnRkFJTCddKQogCisgICAgZGVm IHRlc3RfZHVtcF9qc19jb25zb2xlX2xvZ19pbl9zdGRlcnIoc2VsZik6CisgICAgICAgIHNlbGYu YXNzZXJ0X3Rva2VuaXplX2V4cCgnZm9vLmh0bWwgWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIg XScsIG1vZGlmaWVycz1bJ0RVTVBKU0NPTlNPTEVMT0dJTlNUREVSUiddLCBleHBlY3RhdGlvbnM9 WydQQVNTJ10pCisKICAgICBkZWYgdGVzdF9ibGFua19saW5lKHNlbGYpOgogICAgICAgICBzZWxm LmFzc2VydF90b2tlbml6ZV9leHAoJycsIG5hbWU9Tm9uZSkKIApAQCAtNzEwLDYgKzcxMyw4IEBA IGNsYXNzIFRlc3RFeHBlY3RhdGlvblNlcmlhbGl6YXRpb25UZXN0cyh1bml0dGVzdC5UZXN0Q2Fz ZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X3JvdW5kX3RyaXAoJyMgRm9vJykKICAgICAgICAgc2Vs Zi5hc3NlcnRfcm91bmRfdHJpcCgnIyBGb28gOicpCiAgICAgICAgIHNlbGYuYXNzZXJ0X3JvdW5k X3RyaXAoJyMgRm9vIDogPScpCisgICAgICAgIHNlbGYuYXNzZXJ0X3JvdW5kX3RyaXAoJ2ZvbyBb IENyYXNoIFNraXAgV29udEZpeCBdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfcm91bmRfdHJpcCgn Zm9vIFsgRHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyIEltYWdlIF0nKQogCiAgICAgZGVmIHRlc3Rf bGlzdF9yb3VuZHRyaXAoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpc3Rfcm91bmRfdHJp cCgnJykK 361901 2019-02-13 00:32:30 -0800 2019-02-13 00:56:53 -0800 Patch bug-194283-20190213173229.patch text/plain 3069 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxMzM2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzlkYmZiOWY5YmE2YjY1MDQwMjIy NjgzMDNjZTQ2M2MxNmQ5MTU0NS4uN2Y3YjcxMTM1ZmRlM2IyNjNlYTNiNGQ2ZTJlNWM4MzhhYTRh ZDBmZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAyLTEzICBGdWppaSBIaXJvbm9yaSAg PEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBwcmludC1l eHBlY3RhdGlvbnMgZmFpbHMgdG8gZm9ybWF0IFRlc3RFeHBlY3RhdGlvbkxpbmUgd2l0aCBEdW1w SlNDb25zb2xlTG9nSW5TdGRFcnIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NDI4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgRHVt cEpTQ29uc29sZUxvZ0luU3RkRXJyIG1hcmtlcnMgd2hpY2ggYXJlIG1hcmtlZCBpbiB0b3AgVGVz dEV4cGVjdGF0aW9ucy4KKyAgICAgICAgKiBwbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9uczog RGl0dG8uCisKIDIwMTktMDItMTIgIEp1c3RpbiBGYW4gIDxqdXN0aW5fZmFuQGFwcGxlLmNvbT4K IAogICAgICAgICBbV2ViR1BVXSBSZW1vdmUgV2ViR1BVQnVmZmVyRGVzY3JpcHRvci9Vc2FnZSBh bmQgdXNlIEdQVSB2ZXJzaW9ucwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCBjODUxYzc1NTdiNWVmOWE0NTRjZDQ1MmE0MjNjMmEzMDIwMjQ4Mjk5Li5lYjI1 ZmVmNWU1NmE2ODRiYTBjMzRhMDQ5ZmVhYjE3NGZlNDQ2OTdjIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTg1OSw3ICsxODU5LDYgQEAgd2Via2l0Lm9y Zy9iLzE2MDEzMyBjc3MzL21hc2tpbmcvbWFzay1zdmctbm8tZnJhZ21lbnRJZC10aWxlZC5odG1s IFsgSW1hZ2VPbmx5RmEKIAogd2Via2l0Lm9yZy9iLzE2MDEzNSBodHRwL3Rlc3RzL3NlY3VyaXR5 L2NvbnRlbnRTZWN1cml0eVBvbGljeS92aWRlby13aXRoLWh0dHAtdXJsLWFsbG93ZWQtYnktY3Nw LW1lZGlhLXNyYy1zdGFyLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzE2MDEz NiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLW9yaWdpbi1wbHVnaW4tcHJpdmF0ZS1icm93c2lu Zy10b2dnbGVkLWFsbG93ZWQuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCi13ZWJraXQub3JnL2IvMTQy NDg4IGh0dHAvdGVzdHMvYXBwY2FjaGUvNDA0LXJlc291cmNlLXdpdGgtc2xvdy1tYWluLXJlc291 cmNlLnBocCBbIER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyciBdCiB3ZWJraXQub3JnL2IvMTYyNjg1 IGh0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNoZS9kaXNrLWNhY2hlLTIwNC1zdGF0dXMtY29kZS5o dG1sIFsgRmFpbHVyZSBQYXNzIF0KIAogd2Via2l0Lm9yZy9iLzE2MDEzNyBzdmcvY3VzdG9tL25v bi1zY2FsaW5nLXN0cm9rZS11cGRhdGUuc3ZnIFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYjVlYjcxZDc2NmQz OTRmYzVmMGVlMGE4NjMwNWRlZGQ4N2JkNDdjNC4uNzlmMTUzNTAyNjRmOGM3OTA3YmRhYTNiMDNm ZWUzYjlkZDYyNTlkYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTc5NiwxNiArNzk2LDkgQEAgd2Via2l0Lm9yZy9iLzE0MjI5MiBmYXN0L2ltYWdlcy9h bmltYXRlZC1naWYtd2luZG93LXJlc2l6aW5nLmh0bWwgWyBUaW1lb3V0IF0KICMgOS4gVEVTVFMg RkFJTElORwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KIAotQnVnKFdQRSkgaHR0 cC90ZXN0cy9hcHBjYWNoZSBbIFBhc3MgXQogIyBJbXBsZW1lbnQgdGVzdFJ1bm5lci5zZXRVc2VE ZWZlcnJlZEZyYW1lTG9hZGluZwogd2Via2l0Lm9yZy9iLzkzOTgwIGh0dHAvdGVzdHMvYXBwY2Fj aGUvbG9hZC1mcm9tLWFwcGNhY2hlLWRlZmVyLXJlc3VtZS1jcmFzaC5odG1sIFsgRmFpbHVyZSBd CiAKLWh0dHAvdGVzdHMvYXBwY2FjaGUvZGVmZXJyZWQtZXZlbnRzLWRlbGV0ZS13aGlsZS1yYWlz aW5nLXRpbWVyLmh0bWwgWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgXQotaHR0cC90ZXN0cy9h cHBjYWNoZS9kZWZlcnJlZC1ldmVudHMtZGVsZXRlLXdoaWxlLXJhaXNpbmcuaHRtbCBbIER1bXBK U0NvbnNvbGVMb2dJblN0ZEVyciBdCi1odHRwL3Rlc3RzL2FwcGNhY2hlL2ZhaWwtb24tdXBkYXRl Lmh0bWwgWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgXQotaHR0cC90ZXN0cy9hcHBjYWNoZS9m YWlsLW9uLXVwZGF0ZS0yLmh0bWwgWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgXQotaHR0cC90 ZXN0cy9hcHBjYWNoZS80MDQtcmVzb3VyY2Utd2l0aC1zbG93LW1haW4tcmVzb3VyY2UucGhwIFsg RHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyIF0KLQogQnVnKFdQRSkgaHR0cC90ZXN0cy9jYWNoZS8g WyBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xMTgyMjAgaHR0cC90ZXN0cy9jYWNoZS9wYXJ0aXRpb25l ZC1jYWNoZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTE4MjIwIGh0dHAvdGVzdHMv Y2FjaGUvcGFydGl0aW9uZWQtY2FjaGUtaWZyYW1lLmh0bWwgWyBGYWlsdXJlIF0K 385333 2019-12-10 18:07:46 -0800 2019-12-12 17:51:39 -0800 Patch bug-194283-20191211110745.patch text/plain 3089 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMzU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDBkYWJlNzNmNDhjM2NlZTM0MTdkM2E4Njc1ZjQwZjk4 Mzg0ODFkMi4uOWQ2MGE5MTEzYzc5ZTBkMjQ5MzkzMTJkNjk3M2YyMzM1MzNhOTY2MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTEyLTEwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBwcmludC1leHBlY3RhdGlvbnMgZmFpbHMgdG8gZm9y bWF0IFRlc3RFeHBlY3RhdGlvbkxpbmUgd2l0aCBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDI4MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5OgorICAgICAg ICAoVGVzdEV4cGVjdGF0aW9uUGFyc2VyKTogQWRkIER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyciB0 byBUZXN0RXhwZWN0YXRpb25QYXJzZXIuX2V4cGVjdGF0aW9uX3Rva2Vucy4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5p dHRlc3QucHk6CisgICAgICAgIEFkZGVkIGEgdG9rZW5pemUgdGVzdCBhbmQgcm91bmQgdGlwIHRl c3QgZm9yIER1bXBKU0NvbnNvbGVMb2dJblN0ZEVyci4KKwogMjAxOS0xMi0xMCAgUGVyIEFybmUg Vm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IEFQSSB0ZXN0IGZhaWx1 cmUgYWZ0ZXIgcjI1MzM1MQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CmluZGV4IDlmYmY1 M2ViY2FiNjdmZDc2M2IyY2Q4ZTVjZTYyMGI5NjU5ZmMyOGEuLmFiYzMyZTcyYmUwYzQ0NmNhY2U2 NjFjY2M3ZDNlZWNiMmUyODdmMzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKQEAg LTI0Miw2ICsyNDIsNyBAQCBjbGFzcyBUZXN0RXhwZWN0YXRpb25QYXJzZXIob2JqZWN0KToKICAg ICAjIEZJWE1FOiBVcGRhdGUgdGhlIG9yaWdpbmFsIG1vZGlmaWVycyBsaXN0IGFuZCByZW1vdmUg dGhpcyBvbmNlIHRoZSBvbGQgc3ludGF4IGlzIGdvbmUuCiAgICAgX2V4cGVjdGF0aW9uX3Rva2Vu cyA9IHsKICAgICAgICAgJ0NyYXNoJzogJ0NSQVNIJywKKyAgICAgICAgJ0R1bXBKU0NvbnNvbGVM b2dJblN0ZEVycic6ICdEVU1QSlNDT05TT0xFTE9HSU5TVERFUlInLAogICAgICAgICAnRmFpbHVy ZSc6ICdGQUlMJywKICAgICAgICAgJ0ltYWdlT25seUZhaWx1cmUnOiAnSU1BR0UnLAogICAgICAg ICAnTGVhayc6ICdMRUFLJywKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191bml0dGVzdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191bml0 dGVzdC5weQppbmRleCA4YTlhZTc0MjIyYjQyMTc5YzM4NzJiODJlZWE0M2EwYzk5M2FlYmZhLi5j OTcxMjA0YzUyM2JhODllZGZkNTM2OWVmZjgyMjlhN2RmZTYwZjI2IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNf dW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9k ZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5CkBAIC00MDEsNiArNDAxLDkgQEAgY2xh c3MgRXhwZWN0YXRpb25TeW50YXhUZXN0cyhCYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRfdG9r ZW5pemVfZXhwKCdmb28uaHRtbCBbIFdvbnRGaXggSW1hZ2VPbmx5RmFpbHVyZSBdJywgbW9kaWZp ZXJzPVsnV09OVEZJWCddLCBleHBlY3RhdGlvbnM9WydJTUFHRSddKQogICAgICAgICBzZWxmLmFz c2VydF90b2tlbml6ZV9leHAoJ2Zvby5odG1sIFsgV29udEZpeCBQYXNzIEZhaWx1cmUgXScsIG1v ZGlmaWVycz1bJ1dPTlRGSVgnXSwgZXhwZWN0YXRpb25zPVsnUEFTUycsICdGQUlMJ10pCiAKKyAg ICBkZWYgdGVzdF9kdW1wX2pzX2NvbnNvbGVfbG9nX2luX3N0ZGVycihzZWxmKToKKyAgICAgICAg c2VsZi5hc3NlcnRfdG9rZW5pemVfZXhwKCdmb28uaHRtbCBbIER1bXBKU0NvbnNvbGVMb2dJblN0 ZEVyciBdJywgbW9kaWZpZXJzPVsnRFVNUEpTQ09OU09MRUxPR0lOU1RERVJSJ10sIGV4cGVjdGF0 aW9ucz1bJ1BBU1MnXSkKKwogICAgIGRlZiB0ZXN0X2JsYW5rX2xpbmUoc2VsZik6CiAgICAgICAg IHNlbGYuYXNzZXJ0X3Rva2VuaXplX2V4cCgnJywgbmFtZT1Ob25lKQogCkBAIC03MTAsNiArNzEz LDggQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9uU2VyaWFsaXphdGlvblRlc3RzKHVuaXR0ZXN0LlRl c3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRfcm91bmRfdHJpcCgnIyBGb28nKQogICAgICAg ICBzZWxmLmFzc2VydF9yb3VuZF90cmlwKCcjIEZvbyA6JykKICAgICAgICAgc2VsZi5hc3NlcnRf cm91bmRfdHJpcCgnIyBGb28gOiA9JykKKyAgICAgICAgc2VsZi5hc3NlcnRfcm91bmRfdHJpcCgn Zm9vIFsgQ3Jhc2ggU2tpcCBXb250Rml4IF0nKQorICAgICAgICBzZWxmLmFzc2VydF9yb3VuZF90 cmlwKCdmb28gWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgSW1hZ2UgXScpCiAKICAgICBkZWYg dGVzdF9saXN0X3JvdW5kdHJpcChzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGlzdF9yb3Vu ZF90cmlwKCcnKQo=