194274 2019-02-04 20:47:53 -0800 [WPE][GTK] Defer sandboxing APIs to 2.26 2019-02-15 09:15:06 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194553 P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro pgriffis oldest_to_newest 1502239 0 mcatanzaro 2019-02-04 20:47:53 -0800 The web process sandbox has not been widely-tested yet, so we should defer the new APIs to 2.26. This is the patch for trunk. I can provide another patch for 2.24 later if desired. Besides removing the APIs, we should also remove the bubblewrap dependency on that branch. 1502240 1 361154 mcatanzaro 2019-02-04 20:48:53 -0800 Created attachment 361154 Patch 1502241 2 ews-watchlist 2019-02-04 20:51:51 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1506586 3 361154 commit-queue 2019-02-15 09:15:05 -0800 Comment on attachment 361154 Patch Clearing flags on attachment: 361154 Committed r241589: <https://trac.webkit.org/changeset/241589> 1506587 4 commit-queue 2019-02-15 09:15:06 -0800 All reviewed patches have been landed. Closing bug. 361154 2019-02-04 20:48:53 -0800 2019-02-15 09:15:05 -0800 Patch bug-194274-20190204224852.patch text/plain 2023 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwOTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkzNzc2M2E4MWEyYmU1YzRh MTA5YTg3NmIyZDg1ODEyNDVlOGFhMDQuLmJmMjA2Nzg2NmQ5ZGJlMDcxNjNlNGM4MWM2NDk0OWUx YjI1Yzk5ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDItMDQgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10g RGVmZXIgc2FuZGJveGluZyBBUElzIHRvIDIuMjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDI3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSB3ZWIgcHJvY2VzcyBzYW5kYm94IGhhcyBub3QgYmVl biB3aWRlbHktdGVzdGVkIHlldCwgc28gd2Ugc2hvdWxkIGRlZmVyIHRoZSBuZXcgQVBJcyB0bwor ICAgICAgICAyLjI2LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNv bnRleHQuY3BwOgorCiAyMDE5LTAyLTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIE1vdmUgc29tZSBtYWNPUy9pT1Mgc2Nyb2xsaW5nIGNvZGUgaW50 byB0aGUgc2Nyb2xsaW5nL2NvY29hIGRpcmVjdG9yeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcAppbmRleCA3MjRjNWZiZjVl ODQ3Y2VkMWYzMGZiMDhjZmQ1OGQ4ZDFmNTY5ZjBiLi4xZWNiZjM4MDNlNWU0MDVkNTE3NmY5MzUx ZDkyM2U4Y2QxNzM0MzI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Z2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcApAQCAtMTE1OSw3ICsxMTU5LDcgQEAgdm9pZCB3 ZWJraXRfd2ViX2NvbnRleHRfcmVnaXN0ZXJfdXJpX3NjaGVtZShXZWJLaXRXZWJDb250ZXh0KiBj b250ZXh0LCBjb25zdCBjaGEKICAqCiAgKiBUaGlzIGlzIG9ubHkgaW1wbGVtZW50ZWQgb24gTGlu dXggYW5kIGlzIGEgbm8tb3Agb3RoZXJ3aXNlLgogICoKLSAqIFNpbmNlOiAyLjI0CisgKiBTaW5j ZTogMi4yNgogICovCiB2b2lkIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfc2FuZGJveF9lbmFibGVk KFdlYktpdFdlYkNvbnRleHQqIGNvbnRleHQsIGdib29sZWFuIGVuYWJsZWQpCiB7CkBAIC0xMTgz LDcgKzExODMsNyBAQCB2b2lkIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfc2FuZGJveF9lbmFibGVk KFdlYktpdFdlYkNvbnRleHQqIGNvbnRleHQsIGdib29sZWFuCiAgKgogICogU2VlIGFsc28gd2Vi a2l0X3dlYl9jb250ZXh0X3NldF9zYW5kYm94X2VuYWJsZWQoKQogICoKLSAqIFNpbmNlOiAyLjI0 CisgKiBTaW5jZTogMi4yNgogICovCiB2b2lkIHdlYmtpdF93ZWJfY29udGV4dF9hZGRfcGF0aF90 b19zYW5kYm94KFdlYktpdFdlYkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IGNoYXIqIHBhdGgsIGdi b29sZWFuIHJlYWRPbmx5KQogewpAQCAtMTIwNSw3ICsxMjA1LDcgQEAgdm9pZCB3ZWJraXRfd2Vi X2NvbnRleHRfYWRkX3BhdGhfdG9fc2FuZGJveChXZWJLaXRXZWJDb250ZXh0KiBjb250ZXh0LCBj b25zdCBjaGEKICAqCiAgKiBSZXR1cm5zOiAlVFJVRSBpZiBzYW5kYm94aW5nIGlzIGVuYWJsZWQs IG9yICVGQUxTRSBvdGhlcndpc2UuCiAgKgotICogU2luY2U6IDIuMjQKKyAqIFNpbmNlOiAyLjI2 CiAgKi8KIGdib29sZWFuIHdlYmtpdF93ZWJfY29udGV4dF9nZXRfc2FuZGJveF9lbmFibGVkKFdl YktpdFdlYkNvbnRleHQqIGNvbnRleHQpCiB7Cg==