194268 2019-02-04 18:40:39 -0800 Safari does not free ArrayBuffers being transferred from webworker to main thread 2020-01-08 12:17:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore Safari 12 iPhone / iPad iOS 12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=172790 https://bugs.webkit.org/show_bug.cgi?id=203990 InRadar P2 Critical --- 1 hypertree webkit-unassigned cdumez dino keith_miller lee mike rniwa saam simon.fraser webkit-bug-importer ysuzuki zac.spitzer oldest_to_newest 1502200 0 hypertree 2019-02-04 18:40:39 -0800 Safari frequently runs out of memory running webapps using WebGL libraries such as Mapbox GL-JS and Tangram that transfer large number of araybuffers from webworker to main thread. This was previously reviewed here and mistakenly marked as RESOLVED/WORKSFORME: https://bugs.webkit.org/show_bug.cgi?id=172790#c10 Mapbox engineer has provided a small example that clearly shows Safari memory usage growing indefinitely as Safari never garbage collects ArrayBuffrs allocated in the webworker and transferred to foreground thread. Example can be found here (plain simple few lines of JavaScript, no WebGL): https://measuredweighed.github.io/mapboxgl-js-mem-usage/arraybuffer-test.html This example also crashes Firefox but rcent version of Chrome is able to garbage collect and keep memory usage down to 1 GB. Apparently such transfer of arraybuffers is core to WbeGL applications and expected to work. Safari users of my app have suffered for years and it impossible to release our App for iOS without this issue being fixed. It seems end is in sight since core issue has been identified. 1502408 1 webkit-bug-importer 2019-02-05 10:02:26 -0800 <rdar://problem/47821447> 1521586 2 mike 2019-03-26 18:52:52 -0700 Any timelines on this bug fix? 1523513 3 dino 2019-04-02 16:35:12 -0700 Taking a look at this now. 1524104 4 dino 2019-04-03 19:02:40 -0700 I spent a fair bit of time on this and think the issue is fixed, at least on tip-of-tree. Attached two test cases I made (modifications to the one linked above). They allocate some ArrayBuffers in the worker, and then transfer them to the main thread via postMessage. The main thread only keeps references to a small number of buffers. The allocation timeline in the Web Inspector shows garbage collection triggering, and only a fixed number of ArrayBuffers being retained (the ones I'm keeping a reference to). I also tried with Instruments and the Allocations widget. It also showed that while a large number of ArrayBuffers were created, they were all reclaimed over time. Lastly I put printf statements in JavaScriptCore for ArrayBuffer's constructor and destructor. Each of the large ArrayBuffers allocated in the Worker was eventually reclaimed (and very soon after the references were dropped, because they were taking up a lot of memory). [Side note: I was not sure if it should be "each... was" or "each were". Most resources say "was" (s), but many say "were" (pl) is acceptable too.] 1524105 5 366692 dino 2019-04-03 19:03:05 -0700 Created attachment 366692 tests 1524107 6 dino 2019-04-03 19:05:16 -0700 I also tried the original test with my printf statements and confirmed that the ArrayBuffers are being deallocated. 1524192 7 hypertree 2019-04-04 04:38:07 -0700 It seems fix was included in ios 12.2 because when I tested a few weeks back my Web App was no longer crashing even if I left it running for extended time. Earlier it would crash in 5-10 minutes on low memory devices. This is great news and great relief to all of us WebGL users and Mapbox users - we can think of iOS now as a viable platform for Web Apps thanks to this fix. Thank you Apple/Webkit team ! 1524406 8 rniwa 2019-04-04 13:41:09 -0700 (In reply to Sanjay Kumar from comment #7) > It seems fix was included in ios 12.2 because when I tested a few weeks back > my Web App was no longer crashing even if I left it running for extended > time. Earlier it would crash in 5-10 minutes on low memory devices. That's great! > This is great news and great relief to all of us WebGL users and Mapbox > users - we can think of iOS now as a viable platform for Web Apps thanks to > this fix. Thank you Apple/Webkit team ! Thank YOU for reporting the issue you saw. We always appreciate good bug reports on our products :) 1537470 9 hypertree 2019-05-19 02:40:57 -0700 I am sorry but the problem is back in iOS 12.3. test is still available @: https://measuredweighed.github.io/mapboxgl-js-mem-usage/arraybuffer-test.html If you run the test for a few minutes on an IPAD 5 with 2 GB RAM and iOS 12.3 the page crashes in seconds. memory usage grows quickly and iOS Safari kills the web page almost immediately. Test does not crash on my iPhone 8 plus w/ iOS version 12.2. It also does not crash on Safari Technology Preview 81 or version 82 on High Sierra. So something went wrong in iOS 12.3. Please fix. Thanks. 1558289 10 hypertree 2019-08-03 09:22:31 -0700 I checked further. It seems crash I am seeing does not have to do this with specific bug which indeed seems fixed. It seems Safari has some general limit of overall memory use and we are running into that due to memory bloat. So I am marking this bug as fixed and opening a new bug for Mapbox. Since I am seeing crashes only on iOS Safari so it may still have to do with webkit but probably its not this bug. 1558438 11 rniwa 2019-08-05 00:40:00 -0700 Thanks for the follow up! 366692 2019-04-03 19:03:05 -0700 2019-04-03 19:03:05 -0700 tests arraybuffer-worker.zip application/zip 2174 dino UEsDBAoAAAAAAKpmhE4AAAAAAAAAAAAAAAATABwAYXJyYXlidWZmZXItd29ya2VyL1VUCQADj2Ol XJBjpVx1eAsAAQT1AQAABBQAAABQSwMEFAAAAAgAoV6ETkK95E9JAQAAegIAABwAHABhcnJheWJ1 ZmZlci13b3JrZXIvd29ya2VyLmpzVVQJAANtVaVcbVWlXHV4CwABBPUBAAAEFAAAAHVQsWrDMBDd /RWHJ6dOTVI6hLgpdMjUlhRD2yFkkO2zIypLQZITQvC/9xTbRVByg2S/u3d67xVKGgt5W1Wo31DW dg8rmM8eHu+uxyINCm/CfKB+R2NYjTRGzUCghaLVGqX9YqJ18JxgJZu/saqVheVKRjiBSwBUbqUS mAhVR+H3JntdZ0vQWCA/YgkDcwkhxIBJySxLGlNP0iv3yPQohnZvdz1aKQ2R08IJnKV0Pf2XTHAc jxpcOUJOBIkn+OTSLl60ZufIT2N41VW+ne1o2Hcbx167fy45tGYf5Un/O9C727YNypLLenQNVkHD uAwHpkFRJQdl7OAhulAUFM0ehVBQadXASekf1OHU7bekbDlK6abjFy0LfI0U15oVJBNWz14evAKn /GxxMO/1bhpYZ9kmg/thN5S8BKksWM2kISD0Euxj6Ajp0uAXUEsDBBQAAAAIAHVkhE4WiGI7ewIA AOIFAAAiABwAYXJyYXlidWZmZXItd29ya2VyL21haW4tbG9vcHMuaHRtbFVUCQADbV+lXG1fpVx1 eAsAAQT1AQAABBQAAACFVG1r2zAQ/u5fcQ2FOLRzMtiHkjqGbutgH7qOtaOMUqhqn2OttmQkuSGE /PedLDlx3WwzBsv38ujuuUeKjz5ff7r99f0SClOVSRB3H2RZEgA9cYWGQVowpdEsxo3J352NYeqd hpsSkwul2Ppjk+eooMJKqjU0mi0RDGoTT11QEE8davwks3USBLcF11DbMF2zldCQy0bBnVTPqHQE dwUKMAV5DVMGnhpjpACbolBrzE5bZ8W4jVKEHD+pJFjxsvQZNRdLegFZWnhYwBek4jSmUhAAE5kF WUObpbAu7dIUwIDZlkDmLWjJlG1GMaGpRYUZVWOb1XNqxtUlRVry9HkxavcOJ6Pkxi7iqfMnhwJl 7eJk3QvTqeK1cfRSldqAaCpPCizgw3nrKdF0NXxRsvPvfatdwv3D3qoaISwjC8hZqdE5cqkgtF5O 9tk5feLelvR/cjKBTRv6Gp3CBa48s+HYGaPfejw530V7I88omL8xS1HRKK0CqKJGpIZLEXpTf8+O C1liVMpl+Hh18fXbHH5givyFptGh5ESFx74/3uz23j7M4Xjjg6KMGRZVerl97NVpn7d8UlmvsqgG g8L8Ly0iSi9JdKFzwSIZ9NLx2HBhztrD47n8uTP43EGJQyJGjogbpKPiNxvBSQ/3fvYwgNj2/reD geiobnQRuh8ftw2cSvx4wOu719FeVUY1uEe35y/8K4oV/0GQnjSHWQ6xl8VzCI986lAwCk2jxL+a 7cbUyXk4pgOSu0GR2TI7xRl5UG9DaXlXLbW5cpnhhiQ4h1GBZSmdcO1VNno1nt6aLt9bXqFsTGhZ OIX3s9lsR2487a4NWrrrlW7b9ir/A1BLAwQUAAAACAAIZYRO9BP/hsoBAACQAwAAHAAcAGFycmF5 YnVmZmVyLXdvcmtlci9tYWluLmh0bWxVVAkAA39gpVx/YKVcdXgLAAEE9QEAAAQUAAAAfVNta9sw EP7uX3EzgzjQ2ftYMtvQbRnsQ7eyF0oZgyr2OdYqS0Y6J4SQ/96zJa8po9MXHff2PPeclL/6+PXD j7ubNbTUqTLK5wtFXUbAJ++QBFStsA6pWAzUvLlcQBaCJElheWWtOLwfmgYtdNgZe4DBiS0CoaM8 80lRnvmu+cbUhzKK1jvkRJId57XSwWYgMhrY6i06h/UF+xE6ITUblmvzjS2jvVQKeqm3U/TW2Ae0 F7BvZdXCFLPYqwOb1IIAMVID00ylStiRlBXaMVWLNWOOpN0KmJWHN7pSsnoo4hEiWcblzQjlYfLM J/EMrrKyJ6+CQpobfbKm87nu3RTbCQv7yQEFaNyHTsnCO9M/brH0mcFhdMfDj+IV0Ay6Iml0ElxL OE6p46mMdkZhqsw2ub+++vxlBd+wQrnjqeYODbMJfVfw+hjcaS1IpJ3bnu4D9Hj+HYAJPKtgREJN /ytJG2PXomoTH4KiPGM8SzVITZfTkwmS/PzrCHVntF4Y9TuiDvg82FPHX29/P5vqFOxTNF2zoOCX +4Kc8Yyh63H3s5pkgpbxGUDYWm8cXfu85MjSriBuUSnjVzA+4fiJSp7Nr4dN/xn4b0wf7xFQSwEC HgMKAAAAAACqZoROAAAAAAAAAAAAAAAAEwAYAAAAAAAAABAA7UEAAAAAYXJyYXlidWZmZXItd29y a2VyL1VUBQADj2OlXHV4CwABBPUBAAAEFAAAAFBLAQIeAxQAAAAIAKFehE5CveRPSQEAAHoCAAAc ABgAAAAAAAEAAACkgU0AAABhcnJheWJ1ZmZlci13b3JrZXIvd29ya2VyLmpzVVQFAANtVaVcdXgL AAEE9QEAAAQUAAAAUEsBAh4DFAAAAAgAdWSEThaIYjt7AgAA4gUAACIAGAAAAAAAAQAAAKSB7AEA AGFycmF5YnVmZmVyLXdvcmtlci9tYWluLWxvb3BzLmh0bWxVVAUAA21fpVx1eAsAAQT1AQAABBQA AABQSwECHgMUAAAACAAIZYRO9BP/hsoBAACQAwAAHAAYAAAAAAABAAAApIHDBAAAYXJyYXlidWZm ZXItd29ya2VyL21haW4uaHRtbFVUBQADf2ClXHV4CwABBPUBAAAEFAAAAFBLBQYAAAAABAAEAIUB AADjBgAAAAA=