19426 2008-06-06 21:22:46 -0700 LOW_BANDWIDTH_DISPLAY build broken 2008-06-22 18:03:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 david.krause webkit-unassigned hyatt oldest_to_newest 82508 0 david.krause 2008-06-06 21:22:46 -0700 Using a recent nightly (r34342), it seems that the build will not finish if USE(LOW_BANDWIDTH_DISPLAY) is set. WebCore/loader/FrameLoader.cpp fails to compile because of 3 lines of code that look like: cache->ref(this); or: (*it)->deref(this); Looking back, it appears that the changes on changeset 31834 may have introduced this breakage. The build at least completes if I change ref to addClient and deref to removeClient. Can an expert confirm this? If so, I'll submit a patch changing this. 82701 1 21587 david.krause 2008-06-08 20:04:11 -0700 Created attachment 21587 Proposed patch Proposed patch uploaded that changes the three references causing the build to break. 82702 2 21587 darin 2008-06-08 20:07:18 -0700 Comment on attachment 21587 Proposed patch r=me 84094 3 mrowe 2008-06-22 18:03:11 -0700 Landed in r34733. 21587 2008-06-08 20:04:11 -0700 2008-06-08 20:07:18 -0700 Proposed patch patch text/plain 2169 david.krause SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDQ1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDYtMDggIERhdmlkIEtyYXVzZSAgPGRhdmlkLmtyYXVzZUBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2hhbmdlIHJlZiB0byBhZGRDbGllbnQgYW5kIGRlcmVmIHRvIHJlbW92ZUNsaWVudCBpbiBj b2RlIHdyYXBwZWQKKyAgICAgICAgYnkgVVNFKExPV19CQU5EV0lEVEhfRElTUExBWSkgdG8gbWF0 Y2ggY2hhbmdlcyBvbiBjaGFuZ2VzZXQgMzE4MzQKKworICAgICAgICAqIGxvYWRlci9GcmFtZUxv YWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6YWRkTG93QmFuZHdpZHRo RGlzcGxheVJlcXVlc3QpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnJlbW92ZUFs bExvd0JhbmR3aWR0aERpc3BsYXlSZXF1ZXN0cyk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxv YWRlcjo6bm90aWZ5RmluaXNoZWQpOgorCiAyMDA4LTA2LTA4ICBEYW4gQmVybnN0ZWluICA8bWl0 ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBX ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiAzNDQ1OCkKKysrIFdlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDkzNyw3ICs0OTM3LDcgQEAgYm9vbCBG cmFtZUxvYWRlcjo6YWRkTG93QmFuZHdpZHRoRGlzcGxheQogICAgICAgICBjYXNlIENhY2hlZFJl c291cmNlOjpTY3JpcHQ6CiAgICAgICAgICAgICBtX25lZWRUb1N3aXRjaE91dExvd0JhbmR3aWR0 aERpc3BsYXkgPSB0cnVlOwogICAgICAgICAgICAgbV9leHRlcm5hbFJlcXVlc3RzSW5Mb3dCYW5k d2lkdGhEaXNwbGF5LmFkZChjYWNoZSk7Ci0gICAgICAgICAgICBjYWNoZS0+cmVmKHRoaXMpOwor ICAgICAgICAgICAgY2FjaGUtPmFkZENsaWVudCh0aGlzKTsKICAgICAgICAgICAgIHJldHVybiB0 cnVlOwogICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpJbWFnZVJlc291cmNlOgogICAgICAg ICBjYXNlIENhY2hlZFJlc291cmNlOjpGb250UmVzb3VyY2U6CkBAIC00OTU4LDcgKzQ5NTgsNyBA QCB2b2lkIEZyYW1lTG9hZGVyOjpyZW1vdmVBbGxMb3dCYW5kd2lkdGhECiB7CiAgICAgSGFzaFNl dDxDYWNoZWRSZXNvdXJjZSo+OjppdGVyYXRvciBlbmQgPSBtX2V4dGVybmFsUmVxdWVzdHNJbkxv d0JhbmR3aWR0aERpc3BsYXkuZW5kKCk7CiAgICAgZm9yIChIYXNoU2V0PENhY2hlZFJlc291cmNl Kj46Oml0ZXJhdG9yIGl0ID0gbV9leHRlcm5hbFJlcXVlc3RzSW5Mb3dCYW5kd2lkdGhEaXNwbGF5 LmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkKLSAgICAgICAgKCppdCktPmRlcmVmKHRoaXMpOwor ICAgICAgICAoKml0KS0+cmVtb3ZlQ2xpZW50KHRoaXMpOwogICAgIG1fZXh0ZXJuYWxSZXF1ZXN0 c0luTG93QmFuZHdpZHRoRGlzcGxheS5jbGVhcigpOwogfQogICAgIApAQCAtNDk2Niw3ICs0OTY2 LDcgQEAgdm9pZCBGcmFtZUxvYWRlcjo6bm90aWZ5RmluaXNoZWQoQ2FjaGVkUgogewogICAgIEhh c2hTZXQ8Q2FjaGVkUmVzb3VyY2UqPjo6aXRlcmF0b3IgaXQgPSBtX2V4dGVybmFsUmVxdWVzdHNJ bkxvd0JhbmR3aWR0aERpc3BsYXkuZmluZChzY3JpcHQpOwogICAgIGlmIChpdCAhPSBtX2V4dGVy bmFsUmVxdWVzdHNJbkxvd0JhbmR3aWR0aERpc3BsYXkuZW5kKCkpIHsKLSAgICAgICAgKCppdCkt PmRlcmVmKHRoaXMpOworICAgICAgICAoKml0KS0+cmVtb3ZlQ2xpZW50KHRoaXMpOwogICAgICAg ICBtX2V4dGVybmFsUmVxdWVzdHNJbkxvd0JhbmR3aWR0aERpc3BsYXkucmVtb3ZlKGl0KTsKICAg ICAgICAgc3dpdGNoT3V0TG93QmFuZHdpZHRoRGlzcGxheUlmUmVhZHkoKTsgICAgICAgIAogICAg IH0K